| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/403020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
given the current design and triggers a crash. I'm also effectively
disabling DockInfo for ChromeOS as that triggers a crash. I don't
believe we'll hit the code after my first change, but I'm going for
completeness.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22210 (this is not a partial mitigation, not a fix)
Review URL: http://codereview.chromium.org/399043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Change your password after logging into bookmark sync, then restart your browser. There should be a warning button on the bookmark bar now.
Review URL: http://codereview.chromium.org/387054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run chrome with --enable-sync. While bookmark sync is disabled, click on Wrench Menu->Sync My Bookmarks
Review URL: http://codereview.chromium.org/402059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
return an undefined value.chrome.experimental.extension.getPopupView() may return undefined if no pop-up is currently displayed.chrome.experimental.popup.getParentWindow() may return undefined if called from a non-popup view.BUG=28045TEST=extension_popup_apitest.cc
Review URL: http://codereview.chromium.org/400023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
GYP changes to allow test_shell be buildable on ARM so we can
use it as a minimal browser for testing purpopse.
Review URL: http://codereview.chromium.org/399077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that, per Apple's HIG, the context menu alternates between Pin/Unpin Tab instead of toggling a checkmark.
Changes to TabView.xib:
- add Pin Tab item (to match Windows)
Still to do:
- dragging/dropping tabs needs visual feedback to indicate how pinned state will change (need input from UI team)
- on Windows, you can pin a tab by dragging it slightly to the right of the rightmost pinned tab; this needs to be done
BUG=25481
TEST=not yet
Review URL: http://codereview.chromium.org/375010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=browser_tess --gtest_filter=BrowserActionTest* should pass on linux/view build.
Review URL: http://codereview.chromium.org/404021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The fix is to add --ignored=" --type=renderer " to the command line of
non-renderer, non-plugin subprocesses, tricking GD into not injecting its DLL.
BUG=25580
Review URL: http://codereview.chromium.org/400026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux/views.
see http://crbug/28098 for more details about the root cause of the issue.
BUG=28098
TEST=brower_tests passes with this hack, but we need real solution.
Review URL: http://codereview.chromium.org/397037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test will allow us to know when the tests fail because the http server failed to start and not due to a NaCl problem
This CL depends on http://codereview.chromium.org/394016/show
TEST=this CL
BUG=none
Review URL: http://codereview.chromium.org/385113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the two-state purge/reset code (no longer necessary), and the hooks to the power monitor (not ready to turn those on without more work and testing).
BUG=23400
TEST=Run Chrome with --purge-memory-button, use it for awhile, open the Task Manager, and click "Purge Memory". You should still be able to use the program normally, and hopefully we dumped some memory out too (varies by usage).
Review URL: http://codereview.chromium.org/399028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/407004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=abarth
BUG=25133
TEST=none. A cosmetic change.
Review URL: http://codereview.chromium.org/403011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/404030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/406003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/406004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
renable some disabled tests.
BUG=24732
TEST=none
Review URL: http://codereview.chromium.org/402055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and draw the icon, title, message and add new "Learn more" link; the old implementation used skia to do simple drawing, but couldn't be used for link, hence the rewrite.
BUG=27211
TEST=Verify that "Aw Snap" page is displayed correctly, and new "Learn more" link shows up centralized beneath the message, and when window is resized bi-directionally, especially smaller to force wrapping of message.
Review URL: http://codereview.chromium.org/385145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in Destroy when the widget was a native (external) pop-up menu.
This change depends on WebKit r51102
(https://bugs.webkit.org/show_bug.cgi?id=31609).
BUG=27723, 26876
TEST=1. Following the steps in bug 27723 comment 5 should not result in a sad
tab:
a. Open Google Calendar
b. Bring up a recurring event
c. Click the "Edit" link on the "Repeat" line beneath "When"
d. Change the value of the "Repeat Every" drop-down menu
2. Also, web content pop-up menus should work more generally.
3. After using a web content pop-up menu and then closing all windows,
there should not be any renderer processes running.
Review URL: http://codereview.chromium.org/397039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and Windows versions, except that it uses a gtk dialog and TabContentsContainerGtk to create the window.
BUG=25260
TEST=Call ShowHTMLDialog() with a working dialog, such as the login dialog for Bookmark sync.
Review URL: http://codereview.chromium.org/394011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default.
BUG=27403
TEST=As described in the bug above.
Review URL: http://codereview.chromium.org/408004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If set_normal_color was called while native_markup == normal_markup, then the string could be double freed. To fix this problem and prevent similar future mistakes, I made native_markup stdup normal_markup instead of just copying the pointer (the optimization wasn't worth the trickiness). Also, I cleaned up destruction logic.
BUG=27855
TEST=tried every flavor of chrome link button:
- classic theme
- non classic theme
- gtk theme
- gtk theme system theme that has non-default link text color property
Review URL: http://codereview.chromium.org/400009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/399076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/408007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/380010/diff/1/2.
BUG=27149
TEST=Style
Review URL: http://codereview.chromium.org/405019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/404029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them to sandboxed_extension_unpacker.
Added unittest files for unpacker and sandboxed unpacker.
TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail.
BUG=27362
Review URL: http://codereview.chromium.org/390019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27795
TEST=Start with a fresh Chrome or else remove all bookmarks. Bring up the Bookmarks menu. Observe that there is a single separator above the Other Bookmarks menu item. Add a bookmark to the bar. Bring up the Bookmarks menu. Observe that there is now a new bookmark item followed by a new separator. Remove the new bookmark and repeat the observation noting that both the bookmark and the separator have been removed.
Review URL: http://codereview.chromium.org/403013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes to MainMenu.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS_MAC", tag: IDC_MANAGE_EXTENSIONS, sends: -commandDispatch: to First Responder) to Main Menu -> Window, immediately below Downloads.
Changes to Toolbar.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS", others as above) to Wrench Menu, immediately below Downloads.
Enable Extensions menu item when no browser window is open.
BUG=25423
TEST=Make sure Extensions menu items in Main Menu -> Window and in the Wrench Menu work. Also make sure the former works when no browser window is open.
Review URL: http://codereview.chromium.org/399072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Does not include DnD to/from menus.
No animations of drop destination yet.
BUG=http://crbug.com/17608
TEST=Do some draggin and droppin.
Confirm click still works on the marks and folders.
Confirm "other bookmarks" canNOT be moved.
Confirm NTP / detached bar also works for DnD.
Review URL: http://codereview.chromium.org/395031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/407002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/355029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- when opening a browser action popup, it gets the focus.
- tab traversal now works in the popup
- pressing esc closes the popup (if the keyboard event is not processed by the page)
BUG=22654, 28087, 28086
TEST=Create an extension with a browser extension that shows a popup. Make the popup
so that it has a textfield (that gets focused when the popup show) and a button.
Install the extension. Open the popup, the textfield should have focus. Press
tab, the focus should go to the button. Press Esc, the popup should be closed.
Review URL: http://codereview.chromium.org/402036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to children nodes (sets TVS_LINESATROOT). Set this to false by default
(maintaining existing behaviour by default), except for cookies_view where
we set it to true.
BUG=27657
TEST=open cookies dialog, make sure the origins have a + box next to them,
and that expanding these also expands the cookies folder beneath them.
Review URL: http://codereview.chromium.org/399030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/401015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/402049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lazily).
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144
Review URL: http://codereview.chromium.org/405007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28115
TBR=dank
Review URL: http://codereview.chromium.org/405015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If chrome-sandbox is mode 4755 but not owned by root, Chrome doesn't start up. We should abort instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/372008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/404002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If instance variables holding pointers to Histograms, it would cause
crash bug when the instance is torn down and the metrics services use
and recording of their contents.
The current "standard" patten for using Histograms includes making sure
that the Histogram instances are not destroyed prematurely, held in
static variables.
BUG=28096
TEST=none
Review URL: http://codereview.chromium.org/404022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change retrieves the number of slots available for custom JumpList items to calculate the items for "Most Visited" items and for "Recently Closed" items.
As written in the MSDN doc, Windows 7 changes the number of JumpList slots at run time and it truncates the items from the bottom (i.e. "Recently Closed" items) if we add more items than available ones.
To fix this issue, this change assigned 60% of available JumpList slots to the "Most Visited" category and 40% to the "Recently Closed" category, respectively. (If there are not so many "Recently Closed" Items, this change increases the number of "Most Visited" items.)
Also, this change sets the AppID since <http://codereview.chromium.org/385120> changes it.
BUG=18994
TEST=Open a JumpList and see there are two or more "Recently Closed" items in it.
Review URL: http://codereview.chromium.org/399031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26471
TEST=Load news example extension, see resizing goodness.
Review URL: http://codereview.chromium.org/400028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Test was failing because the key events were sent even after
the window has been destroyed.
* Make sure browser window is closed before the end of test.
Test fails in BookmarkBarView without this. I think this requires
a fix on browser side. Filed a bug 28046.
BUG=None
Test=run browser_tests --gtest_filter=*Bookmark*
Review URL: http://codereview.chromium.org/397034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32286 0039d316-1c4b-4281-b951-d872f2087c98
|