| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
that ResourceMessageFilter doesn't have to know about them and vice versa. A bunch of small cleanup in the process. I've added new message files for classes that want their messages dispatched on threads other than the IO.
Review URL: http://codereview.chromium.org/5698008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.
This primarily covers files in chrome os and other directories, missed in the previous CL.
In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase.
BUG=65298
TEST=all existing tests should pass.
Review URL: http://codereview.chromium.org/5734002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
position_util to properly handle 'fixed' positioned elements.
BUG=62747
TEST=See bug.
Review URL: http://codereview.chromium.org/5445002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
be used by the TTS extension API. Moved some locale utility functions from
extension_l10n_util to l10n_util.
BUG=none
TEST=Adds new unit test
Review URL: http://codereview.chromium.org/5643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
missing.
Removed previous stubs and enforce security.
BUG=chromium-os:9818
TEST=Manual
Review URL: http://codereview.chromium.org/5692007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
views::ViewStorage::GetSharedInstance didn't get renamed to GetInstance in a
previous CL.
BUG=chrome doesn't compile with touchui=1
TEST=see bug
Review URL: http://codereview.chromium.org/5807001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass a MasterPreferences into BrowserDistribution et al. to allow for preferences-based behaviour.
Add a GetComDllList() method that returns the set of registerable components for that distribution.
Change GetKeyFile() on BrowserDistribution to GetKeyFiles().
Refactor GetMasterPreferencesForCurrentProcess into a static method on MasterPreferences.
BUG=61609
TEST=None
Review URL: http://codereview.chromium.org/5558006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10163
TEST=Manual.
Review URL: http://codereview.chromium.org/5760003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See the screenshot in the issue tracker.
BUG=chromium-os:9740
TEST=Follow the procedure in the bug description and check if the translation fit in the dialog.
Review URL: http://codereview.chromium.org/5675006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.
I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case.
BUG=65298
TEST=all existing tests should pass.
Review URL: http://codereview.chromium.org/5685007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add user metrics for the following login actions:
1. login success
2. login failure
3. off the record login success (guest mode).
Update chromeactions.txt by:
% cd chrome/tools
% PYTHONPATH=../../tools/python python extract_actions.py --hash
TEST=login screen worked as before.
BUG=chromium-os:8382
Review URL: http://codereview.chromium.org/5287003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
candidate window is changed
BUG=chromium-os:9950
TEST=manual
Review URL: http://codereview.chromium.org/5582004
Patch from Peng Huang <penghuang@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'crx-less' web apps to extensions.
BUG=66127
TEST=
Review URL: http://codereview.chromium.org/5709004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66608
TEST=none
TBR=kbr,vangelis
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a version of AdjustStringForLocaleDirection() that handles the quirks of GTK/OSX label autodirectionality.
Comment from the CL:
// On OS X & GTK the directionality of a label is determined by the first
// strongly directional character.
// However, we want to make sure that in an LTR-language UI all strings are
// left aligned and vice versa.
// A problem can arise if we display a string which starts with user input.
// User input may be the opposite directionality and so the whole string will
// be displayed in the opposite directionality, e.g. if we want to display in
// an LTR UI [such as US English]:
//
// EMAN_NOISNETXE is now installed.
//
// Since EXTENSION_NAME begins with a strong RTL char, the label's
// directionality will be set to RTL and the string will be displayed visually
// as:
//
// .is now installed EMAN_NOISNETXE
//
// In order to solve this issue, we prepend an LRM to the string which is a
// strongly directional LTR char.
// We also append an LRM at the end which ensures that we're in an LTR
// context.
// Unlike Windows, Linux and OS X can correctly display RTL glyphs out of the
// box so there is no issue with displaying zero-width bidi control characters
// on any system. Thus no need for the !IsRTL() check here.
BUG=63303
TEST=1. Try scenario described in bug. 2. Make sure there areno regressions displaying RTL strings in LTR UI and vice versa on OS X.
Review URL: http://codereview.chromium.org/5291009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=trybots
Review URL: http://codereview.chromium.org/5755004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=trybots
Review URL: http://codereview.chromium.org/5797003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reporting option, the alert is obsolete.
BUG=none
TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds.
Review URL: http://codereview.chromium.org/4778002
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/5752004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(os, device, driver) configuration is on the blacklist.
BUG=58182
TEST=unittest
Review URL: http://codereview.chromium.org/5612002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=66539
TEST=browser_tests
Review URL: http://codereview.chromium.org/5743006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=67300
The change has been approved conditionally,
i.e. if the outstanding review comments are handled
in a follow-up as the top priority.
Two weeks have passed, and I have not seen the follow-up.
It is risky to keep this change in the tree, as it is already
non-trivial to revert.
Conflicts:
chrome/browser/automation/automation_provider.cc
chrome/test/ui/named_interface_uitest.cc
ipc/ipc_channel_posix.cc
TBR=nirnimesh
BUG=chromium-os:8512
TEST=none
Review URL: http://codereview.chromium.org/5707006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=self
Review URL: http://codereview.chromium.org/5687002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness.
As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file.
There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5682008
TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/5721005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/5607004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness.
As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file.
There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5682008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When there is no application installed on chrome we are showing two separators instead of one
in the menu.
BUG=65648
TEST=see bug
Review URL: http://codereview.chromium.org/5513008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can be changed.
BUG=62875
TEST=none
Review URL: http://codereview.chromium.org/5799001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Seems to have cured itself.
BUG=59208
Review URL: http://codereview.chromium.org/5713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to the log, the flakiness may be caused by http://crbug.com/65375. But I can't reproduce it manually on my local Windows 7 workstation. This CL just uses the same test flow as Mac port to try to avoid flakiness. The FLAKY label is not removed in case the test will still be flaky.
BUG=65847
TEST=The test should not flaky on Windows.
Review URL: http://codereview.chromium.org/5746002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
option, the alert is obsolete.
BUG=none
TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds.
Review URL: http://codereview.chromium.org/4778002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move the sync settings into the Personal Stuff page.
* Fix disabling input elements from JS.
* Fix handling of boolean prefs in select controls.
BUG=59279
TEST=none
Review URL: http://codereview.chromium.org/5779001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Marks PlatformThread::Join() as blocking IO using ThreadRestrictions.
Whitelists existing spots where we join on the UI/IO threads.
Also noteworthy is I allow blocking IO on shutdown.
BUG=65530,66077,66082
TEST=none
Review URL: http://codereview.chromium.org/5693003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63830
TEST=none
Review URL: http://codereview.chromium.org/5721003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added tests
1. testRemovePasswords
2. testFetchAnotherUser
3. testNeverSavePasswords
Added a method for constructing password dictionary
Modified testSavePassword in passwords.py
MOdified GoogleAccountsLogin and VerifyGoogleAccountCredsFilled in test_utils.py to take window index and tab index
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5379007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5784001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5770002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25232
TEST=1, Input text to show popup with autofill. 2. Once autofill pops up drag the browser with mouse. 4, Confirm the popup window is closes.
Review URL: http://codereview.chromium.org/5544011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66448
Review URL: http://codereview.chromium.org/5697004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
( Note: Data file related to the same test is submitted in a different CL)
Verify prefs to enabled/disables omnibox suggestions
Review URL: http://codereview.chromium.org/5556010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5748001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Marks PlatformThread::Join() as blocking IO using ThreadRestrictions.
Whitelists existing spots where we join on the UI/IO threads.
Also noteworthy is I allow blocking IO on shutdown.
BUG=65530,66077,66082
TEST=none
Review URL: http://codereview.chromium.org/5693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
since different environments may require users to have certain external policy extensions installed. This patch also fixes a crash when --disable-extensions is used with external extensions installed.
BUG=66070
TEST=ExtensionsServiceTest.ExternalUninstall
Review URL: http://codereview.chromium.org/5695004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added unit tests for ServerNotifierThread.
Put DISABLE_RUNNABLE_METHOD_REFCOUNT() call for MediatorThreadImpl in the right place.
BUG=57898
TEST=New unittests
Review URL: http://codereview.chromium.org/5722002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixes bug where Instant is on even when checkbox in prefs is cleared.
BUG=66089
Review URL: http://codereview.chromium.org/5745004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
translate the page"
TEST=47250
Review URL: http://codereview.chromium.org/5557005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=None
Bug=None
1. Verify content on https page - https://www.google.com. Verify in regular,
incognito window
2. Verify that chrome works with some top websites. Browse a list of urls, each
time verify some key strings. This test will verify that chrome is not getting
blocked by user-agent test by those websites.
Review URL: http://codereview.chromium.org/5726001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68886 0039d316-1c4b-4281-b951-d872f2087c98
|