| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
I added additional information to the regular load commit notification so all
interested parties can listen for that instead.
I removed the old navigation type enum, and replaced it with the enum from
the NavigationController, so it's now public.
Review URL: http://codereview.chromium.org/3112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
comes back in ISO-8859-1.
Change the encoding for voila to ISO-8859-1. The front page of Voila.fr is in UTF-8 but the search result pages are
in ISO-8859-1 and voila.fr expects a query to be in ISO-8859-1.
BUG=2722
TEST=Set your default search engine to voila (in French Chrome) and type a keyword with accented letters. It should come back correctly in the search result page.
Review URL: http://codereview.chromium.org/4068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Webcore has no custom build step so it can be bypassed.
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln glue
Glue
KJSBindings_prebuild
KJSConfig
localized_strings
WebCore
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln port
Port
KJSBindings_prebuild
KJSConfig
WebCore
To
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln glue
Glue
KJSBindings_prebuild
KJSConfig
libxml_config
libxslt_config
localized_strings
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln port
Port
KJSBindings_prebuild
KJSConfig
Review URL: http://codereview.chromium.org/4252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=2742
TBR=nsylvain
Review URL: http://codereview.chromium.org/4256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHelper gets angry. This change allows the PaintMsgProxy to be
deleted without being Run.
This change is to support deleting all tasks that have made it into a
MessageLoop without being Run. Currently, we leak those tasks, but I'd like to
change that to allow us to avoid some hacks that exist to help Purify.
R=brettw
BUG=2734
Review URL: http://codereview.chromium.org/4251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some more info:
SSL UI Tests:
Added new tests for redirects and frames.
Also improved the mixed-content test to exercise the "block mixed-contents" preference and the show info-bar.
Automation:
For the new UI tests, added methods to tab_proxy and browser_proxy. The ones of most interest are GetLastNavigatinTime and WaitForNavigation that ensures we wait for a navigation to occur or have occured when taking actions that asynchronously trigger navigations.
Resource loading:
Added a flag to the response we get when loading a resource that indicates whether that resource was filtered (blocked or altered) by the security peer. We use this flag to notify back the browser when we report a load has been committed.
This is so the SSL manager knows a frame has been filtered (in which case we have no cert info but should not consider that as unsafe).
BUG=2004
Review URL: http://codereview.chromium.org/3165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has no custom build step so it can be bypassed.
Glue
localized_strings
V8Bindings_prebuild
V8Config
WebCore
WebCore
libxml_config
libxslt_config
V8Bindings_prebuild
V8Config
To
Glue
libxml_config
libxslt_config
localized_strings
V8Bindings_prebuild
V8Config
WebCore
libxml_config
libxslt_config
V8Bindings_prebuild
V8Config
Review URL: http://codereview.chromium.org/4067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test for this case. I also checked the other navigation cases to see if we
were relying on state from the renderer (which might be malicious) and the
controller being in sync, and I didn't see any others in this area. I clarified
some comments so it should be more clearly correct.
BUG=1279570
Review URL: http://codereview.chromium.org/4250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SP3 or Vista.
This won't submit the crash dump but it's still better than nothing.
Fix broken alignment on test_shell_main.cc.
Review URL: http://codereview.chromium.org/3105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=petersont
Review URL: http://codereview.chromium.org/4242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
because the browser window does not have a focus manager.
I am not sure how this could happen, this CL just bullet-proofs the code.
BUG=1384044
Review URL: http://codereview.chromium.org/4054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to fix a crash in renderer/chrome_plugin_host.cc.
Review URL: http://codereview.chromium.org/4050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- it was causing trouble in the distributed tests
- now does not try to load the dll in headless configs
Review URL: http://codereview.chromium.org/4233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We were comparing the creation date of the favorite with the profile dir creation date, and ignoring the favorite if they were created around the same time (in an effort to get rid of IE defaults favorites).
This was causing problems as some users seem to import their profile and have profile dir and favorites created at the same time.
Review URL: http://codereview.chromium.org/4207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
For the frame case, the SSL info had to be added to the show menu message (as the navigation entry contains the top frame SSL info).
BUG=2467
TEST=Open a page over HTTPS with multiple frames. Right-click and select shot page info.
Review URL: http://codereview.chromium.org/4034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mal
Review URL: http://codereview.chromium.org/4228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle WM_NCPAINT and handle it (do nothing) instead of
passing it down to DefWindowProc.
B=2577
TEST=resizing window using botom right corner and watch
for any odd GUI effects.
Review URL: http://codereview.chromium.org/3192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enter triggers a focus change.
BUG=2554
TEST=see bug
Review URL: http://codereview.chromium.org/4014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
on GCC.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Patch from Pawel Hajdan Jr.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
our combined-build icuuc.lib to icu.lib.
Change solution file references accordingly.
Also change libxml patch and Makefile references
Review URL: http://codereview.chromium.org/4027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're already working toward 0.3 as the next Beta update,
I bumped the minor to 0.3.
R= nsylvain@chromium.org
Review URL: http://codereview.chromium.org/4204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the distributed test at this location:
chrome_23e0000!v8::internal::Builtins::Setup+0x2bb
Revert this change because it seems to be the culprit.
Review URL: http://codereview.chromium.org/4206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up solution files for webkit and net
Add one line keyword change to help linux build
r=hunanr,openvcdiff,nsylvain
Review URL: http://codereview.chromium.org/4026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- And have a way to set the initial events even if chrome
was shut down before it was able to initialize and
thus we have an empty rlz.
Apparently a sizeable % of our users have an empty
rlz string and it looks like this can be the cause.
BUG= 1372961
Review URL: http://codereview.chromium.org/3200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
--magic_browzR command line switch.
R= ben@chromium.org
Review URL: http://codereview.chromium.org/4031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/4202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
performance when there are multiple plugins, or when scrolling.
Review URL: http://codereview.chromium.org/3133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reviewed earlier.
Fixes mnemonic bug in chrome menus. After this change you can indicate
whether menus have mnemonics. Mnemonics are shown if the menus have
mnemonics, and the OS says we should show them.
BUG=1355952
TEST=add a bookmark and change the title to &foo. Move the bookmark to
a folder, click on the folder and make sure the title shows the &.
Review URL: http://codereview.chromium.org/4021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
locked.
Review URL: http://codereview.chromium.org/3194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also need to augment sln dependencies
tbr
Review URL: http://codereview.chromium.org/3188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command line option "sdch-enable" enables support of sdch
and automtic lazy download of dictionaries. Optionally it
can select a singular domain to work from.
By default, all domains are enabled when the flag is used.
"-sdch-enable=".google.com" Enables it only for Google.
When the switch is not set on the command line, all this
code is completely disabled.
Still TBD:
a) Finish implementation of security details (much of it is in place)
b) Add tests for security details.
r=huanr,ajenjo,kmixter
Review URL: http://codereview.chromium.org/461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether menus have mnemonics. Mnemonics are shown if the menus have
mnemonics, and the OS says we should show them.
BUG=1355952
TEST=add a bookmark and change the title to &foo. Move the bookmark to
a folder, click on the folder and make sure the title shows the &.
Review URL: http://codereview.chromium.org/4002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the loading of dlls that cause renderer crashes.
- Remove the old FreeLibrary() method
Review URL: http://codereview.chromium.org/2458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
correct path. Lack of EOL on bloom_filter.h had broken the Linux build, this is a fatal warning with GCC.
Review URL: http://codereview.chromium.org/4007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
facilitate alternate implementations.
The current SafeBrowsingDatabase code is moved to *_impl files.
Adding a new implementation can be done via command line flags
in the SafeBrowsingDatabase::Create factory method.
Review URL: http://codereview.chromium.org/3162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stack crashing is this one:
chrome_2650000!xmlTextWriterStartElement+0x23
chrome_2650000!MetricsLog::StartElement+0xb5
chrome_2650000!MetricsLog::ScopedElement::ScopedElement+0x67
chrome_2650000!MetricsLog::RecordHistogramDelta+0xd8
chrome_2650000!MetricsService::RecordHistogram+0x122
chrome_2650000!MetricsService::RecordCurrentHistograms+0xc3
chrome_2650000!MetricsService::StopRecording+0x94
chrome_2650000!MetricsService::PushPendingLogsToUnsentLists+0xbf
chrome_2650000!MetricsService::SetRecording+0x36f
chrome_2650000!MetricsService::Stop+0x11
chrome_2650000!BrowserMain+0xefa
chrome_2650000!ChromeMain+0x862
It looks like writer_ is null on invalid.
It also look like there is debugging code that was left
in.
Review URL: http://codereview.chromium.org/4005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.http://code.google.com/p/chromium/issues/detail?id=292
This was a painting issue in the XStandard plugin. The bug
occurs in a windowed instance of the plugin. We handle
window repositions in the plugin process until the window
becomes visible. We set the SWP_NOREDRAW flag in the
SetWindowPos call. This turns off client/non-client
paints. After the SetWindowPos call we invalidate the
client area. The plugin only receives WM_PAINT as a
result. The plugin relies on the WM_NCPAINT message
being received as well. In any case the SWP_NOREDRAW flag
does not buy us much as we invalidate immediately after.
The fix is to take out this flag.
2.http://code.google.com/p/chromium/issues/detail?id=2556
The plugin invoked the NPN_GetValue function to retreive
the window script object. This call fails in this case
probably because the plugin instance in the renderer
process is in the process of shutting down. We return a
failure from the call.
The plugin fails to check the return code and ends up
invoking NPN_GetProperty on a NULL NPObject which causes a
crash in chrome when we try to create a proxy for the
same.
The fix is to add NULL NPObject checks in the
NPObjectProxy members and return early.
Bug=292,2556
R=jam
Review URL: http://codereview.chromium.org/3176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main goal of this is to be a first step towards divorcing the popup and the edit from each other.
To do this, I changed the behavior of manual selections. They now do not persist once the user types more characters, hits esc, etc. Our old behavior, which Brett and I designed long ago, turns out to have been a mistake; users who arrowed to an item and then typed more weren't expecting "stickiness" on their previous choice, and it led to user mistakes.
This also required changing how we do the "keyword UI" persistence in the case where the user switches into keyword UI, but then deletes all his text. Previously, we used manually_selected_match_ with a provider affinity to the keyword provider in order to accomplish this. Now we stick another flag on the AutocompleteInput, which, when set, biases the keyword provider to return the best results. The user-visible effect of this is that when in keyword UI mode with no query string, the selected entry in the popup will be the first, rather than third, entry. This is a small win.
While here I fixed the bug where editing a string and transforming it into a keyword search would avoid switching into keyword UI (as expected), but also delete the keyword off the visible string (oops). I also made us lock the popup once the user changes the manually_selected_match_, in order to give a little more stability to it.
I'm sorry this makes so many behavioral changes at once. All this code is tangled together and untangling it is hard :(
The keyword-related variables in the AutocompleteEditModel seem a mess. They are probably worse now than before this change; I think I need a followup change at some point to make them all more sane. It seems like we have three variables and complex conditionals where two, and simpler ones, would do.
BUG=997976,1201974,1204173
Review URL: http://codereview.chromium.org/3172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
) together with the disabling of a test called MetricsServiceTest.CloseRenderersNormally which the change makes obsolete (see bug 2522.)
Review URL: http://codereview.chromium.org/2995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=abarth
Review URL: http://codereview.chromium.org/2996
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
thread.
Review URL: http://codereview.chromium.org/2969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reference the same url. Clicking the star button edits the most
recently added bookmark for the URL. Dragging a button/star always
does a move, otherwise drops on the bookmark bar create a new
bookmark.
Also changed the add page context menu for the bookmark bar to
remember where you invoked it from.
BUG=1173228 1678
Review URL: http://codereview.chromium.org/3203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The waterfall (build.chromium.org) has been complaining about this test for a while now. Nicolas and I looked at this, but we don't see anything wrong. We theorized this is because we issue Find right after the navigation and maybe the tab isn't ready. We'll see what happens with this change.
Review URL: http://codereview.chromium.org/2978
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
looks funny.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2410 0039d316-1c4b-4281-b951-d872f2087c98
|