summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix build for mac botsmhm@chromium.org2009-09-042-4/+4
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/201016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25446 0039d316-1c4b-4281-b951-d872f2087c98
* Implement PrintPageAsJPEG feature for Print Preview.In order to show the tab ↵mhm@chromium.org2009-09-045-1/+93
| | | | | | | | contents to the print tab, the renderer should print the page as a JPEG image so it could be rendered in the DOMUI. A unit test case has been created to make sure the image contains something from deciding whether its not 100% white.MockPrinter has been altered to remove the const parameter, since its useful to retrieve the DefaultSettings not via IPC.BUG=173 (http://crbug.com/173)TEST=created a unit test and ran it. Review URL: http://codereview.chromium.org/196021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25445 0039d316-1c4b-4281-b951-d872f2087c98
* Add some logging in convert_dict.mhm@chromium.org2009-09-041-8/+17
| | | | | | | | | | Currently, there is no way to tell what is failing, it is returning silently. This will output some information regarding what error occurred. BUG=20754 (http://crbug.com/20754) TEST=Compile and run convert_dict with korean dictionary (1 error will spit out which will help the converter whats wrong) Review URL: http://codereview.chromium.org/177051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25444 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23702.hbono@chromium.org2009-09-041-12/+0
| | | | | | Review URL: http://codereview.chromium.org/173343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25442 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: enable scripts panel sanity test.yurys@google.com2009-09-041-1/+1
| | | | | | | BUG=19858 Review URL: http://codereview.chromium.org/201014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25440 0039d316-1c4b-4281-b951-d872f2087c98
* This changelist fixes some issues with the NPAPI WMP plugin work in Chrome. ↵jam@chromium.org2009-09-0414-148/+136
| | | | | | | | | | | | The first is that we need to disable windowless mode since it doesn't work in the NPAPI plugin (Safari does this as well, and sites don't use windowless for Firefox). The second is to make UpdateGeometry message synchronous for WMP. The problem I saw was that while handling that message, the plugin might disaptch a NPObject Invoke method to play a video, which WMP doesn't expect and it leads to the video never playing. While touching these files, I made some small cleanup by reverting the change that made WebPluginProxy not have a WebPluginDelegateImpl pointer, which added a bunch of unnecessary methods to WebPluginDelegate. BUG=20259 TEST=use --no-activex and try playing the videos on http://www.nana10.co.il/Section/?SectionID=10847&sid=235 Review URL: http://codereview.chromium.org/196012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25433 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebEditingClient.darin@chromium.org2009-09-043-66/+137
| | | | | | | | | | | | | | | | | | | | Moves the WebViewDelegate parameter back to WebView::Create and adds a second parameter for WebEditingClient. I had hoped to make the WebEditingClient NULL for RenderView on Windows and Mac, but that turned out to not be an option. I need a few methods on all platforms. The Describe* functions from EditorClientImpl are moved into the TestWebViewDelegate since they are only applicable to layout tests. R=dglazkov BUG= TEST=none Review URL: http://codereview.chromium.org/195008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25432 0039d316-1c4b-4281-b951-d872f2087c98
* Re-disable ExtensionApiTest.Tabs (flakey)rafaelw@chromium.org2009-09-041-1/+1
| | | | | | | | TBR=asargent,phajdan.jr Review URL: http://codereview.chromium.org/200016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25430 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix issue with pinning the pre-populated thumbnails.arv@google.com2009-09-042-55/+74
| | | | | | | | | | | | BUG=20801 TEST=Create a new profile and open the new tab page. Pin and reorder the pre-populated thumbnails. The thumbnails and favicons should continue to work. Review URL: http://codereview.chromium.org/195010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25422 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Doc Changes (no building or testable changes) - Get build.py ↵rafaelw@chromium.org2009-09-041-15/+16
| | | | | | | | | | working on linux (and hopefully mac) TBR=aa Review URL: http://codereview.chromium.org/194020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25415 0039d316-1c4b-4281-b951-d872f2087c98
* Delete some empty files.viettrungluu@chromium.org2009-09-044-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25414 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make external protocol dialog non-modal.mdm@chromium.org2009-09-042-10/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/198017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25413 0039d316-1c4b-4281-b951-d872f2087c98
* Fix OS_WINDOWS -> OS_WIN.mdm@chromium.org2009-09-041-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/194019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25412 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary scaffolding cleanup.thestig@chromium.org2009-09-032-30/+18
| | | | | | Review URL: http://codereview.chromium.org/182048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25405 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to fix bug 20968, this time not breaking browseraa@chromium.org2009-09-033-8/+17
| | | | | | | | | | | tests. This is kinda a janky hack to get the browser test to keep working but I couldn't think of anything better. Review URL: http://codereview.chromium.org/196015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix loading bubble not disappearing with corrupt theme image.mirandac@chromium.org2009-09-031-0/+7
| | | | | | | | | BUG= http://crbug.com/21044 TEST= try installing a theme with a corrupt image. note that loading bubble disappears. Review URL: http://codereview.chromium.org/196016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25401 0039d316-1c4b-4281-b951-d872f2087c98
* Add some DCHECKS and asserts to debug why ExtensionApiTest.Tabs is flakey ↵rafaelw@chromium.org2009-09-033-1/+4
| | | | | | | | | | and Reenable. BUG=20828 Review URL: http://codereview.chromium.org/193013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25394 0039d316-1c4b-4281-b951-d872f2087c98
* Sleep and poll (yuck!) in DownloadTest while verifying Internet ZoneIdentifier.phajdan.jr@chromium.org2009-09-031-21/+41
| | | | | | | | | | | | | There seems to be no other reliable way to do that due to Windows file semantics. This should decrease the flakiness. TEST=Covered by ui_tests. http://crbug.com/20809 Review URL: http://codereview.chromium.org/192010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25390 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing focus in location bar and accelerators on Linux toolkit views.jcampan@chromium.org2009-09-0311-2/+62
| | | | | | | | | | | | | | | BUG=None TEST=Focus the location bar, deactive/reactivate the browser window with Alt-Tab, the focus should still be on the location bar. Click few links on a page to have a history navigation. Focus the location bar, use backspace to delete some text. Focus a text area in a web page, make sure backspace works as expected (deletes text). Now click on a non text area, press backspace. You should trigger a navigate back. Review URL: http://codereview.chromium.org/185014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25389 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing purify suppressions for bug 20703.asargent@chromium.org2009-09-031-9/+133
| | | | | | | | | | (I had them incorrectly formatted before) BUG=http://crbug.com/20703 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25388 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r25382: blame Windowsagl@chromium.org2009-09-035-150/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25386 0039d316-1c4b-4281-b951-d872f2087c98
* Add "loading..." message to theme install to counter jank.mirandac@chromium.org2009-09-037-0/+259
| | | | | | | | | BUG= http://crbug.com/17696 TEST= Install a theme. Note that a "loading" message appears to notify you that a theme is loading. Review URL: http://codereview.chromium.org/191011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25383 0039d316-1c4b-4281-b951-d872f2087c98
* ForceTLS: persist to diskagl@chromium.org2009-09-035-6/+150
| | | | | | | | | | | | | | | With this patch, we'll persist ForceTLS state to disk. It's saved as a JSON file (ForceTLSState) in the user data directory for the moment. You still need the --force-https flag in order to trigger any ForceTLS behaviour, however. For the moment, this state isn't cleared when the rest of the browser state it. That's ok because it's still behind a flag. http://codereview.chromium.org/186014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25382 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust color spaces so that Mac Chrome renders colors properly.amanda@chromium.org2009-09-033-14/+13
| | | | | | | | | | | BUG=19951,20552 TEST=compare pages rendered in Chromium and Safari. They should appear the same. mark: review jrg/brettw: FYI Review URL: http://codereview.chromium.org/194013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views linux build.estade@chromium.org2009-09-031-2/+2
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/198012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25379 0039d316-1c4b-4281-b951-d872f2087c98
* GTK file picker: Use mime type filters instead of shell-style glob filters.estade@chromium.org2009-09-031-12/+9
| | | | | | | | BUG=12347 Review URL: http://codereview.chromium.org/192011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25377 0039d316-1c4b-4281-b951-d872f2087c98
* Add external protocol dialog for Linux.estade@chromium.org2009-09-037-80/+182
| | | | | | | | | | This exposes a bug where \n in a string resource is rendered literally when it is displayed. I don't know at what point on Windows the '\' + 'n' is translated to a line return, I have filed crbug.com/20943 BUG=20731 Review URL: http://codereview.chromium.org/194002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25373 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing headers for Release.finnur@chromium.org2009-09-031-0/+2
| | | | | | | | | TBR=jcampan BUG=None TEST=Release build should work now. Review URL: http://codereview.chromium.org/196008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25369 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-0373-120/+175
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Make the Page/Wrench buttons place their menu in the right place.viettrungluu@chromium.org2009-09-039-761/+403
| | | | | | | | | | | | | | | | | | | | | | Also makes the buttons drag-able -- you can drag or click and wait to open their menu. Lucky for me, I wrote reusable code. To do (not now): The "off-the-end" button on the bookmark bar needs the same fix. Bug (not to be fixed now): The menu doesn't do the right thing when the window is moved off the left edge to the screen -- it doesn't open to the right in the correct fashion. Nor does it do the proper thing when you move the window off the bottom edge of the screen -- it doesn't open upwards entirely correctly. <shrug> BUG=18572 TEST=Click on the Page and Wrench menu buttons and observe. Also test \ dragging to open. Review URL: http://codereview.chromium.org/174556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25362 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme cache corruption.mirandac@chromium.org2009-09-032-34/+42
| | | | | | | | | BUG= http://crbug.com/20957 TEST= Install many themes quickly, with many windows open. Close browser and reopen. Theme should not be corrupted. Review URL: http://codereview.chromium.org/197010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25359 0039d316-1c4b-4281-b951-d872f2087c98
* Add "other bookmarks" to bookmark menu.jrg@chromium.org2009-09-033-31/+93
| | | | | | | | | | | | | | | | | BUG=http://crbug.com/18734 TEST=Launch Chrome. Add some bookmarks then open the bookmark menu. You should see all "bookmark bar" bookmarks, followed by a separator line, followed by an "Other bookmarks" submenu at the end. Go to a bookmark then click on STAR. Change folder to "other bookmarks". Now open bookmark menu; see item moved from "main page" to the "other bookmarks" folder at the end. Undo that change by clicking on STAR, changing parent. Make sure back to normal. Review URL: http://codereview.chromium.org/195001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25357 0039d316-1c4b-4281-b951-d872f2087c98
* Properly show/hide "off the side" button/menu (chevron) on bookmark bar as ↵jrg@chromium.org2009-09-033-17/+12
| | | | | | | | | | | | | | | | | | | needed. BUG=http://crbug.com/17852 TEST=delete all bookmarks. No chevron. Add one bookmark to bookmark bar. No chevron. Make window real wide. Add some more bookmarks (but not enough that it spills over). No chevron. Make window thinner. Chevron appears! Widen window until chevron hides. Add more bookmarks until it appears again. Review URL: http://codereview.chromium.org/201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25356 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Disable Omnibox editing in popup windows.shess@chromium.org2009-09-031-2/+2
| | | | | | | | | | | http://crbug.com/20243 TEST=Go to www.popuptest.com. Select test #2, allow one of the popups through. Try to edit in the omnibox. Should be able to select and copy, but not enter text. Review URL: http://codereview.chromium.org/183043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25351 0039d316-1c4b-4281-b951-d872f2087c98
* Drop new strings (copied over all existing files, so what you see in this CL ↵laforge@chromium.org2009-09-0351-27/+843
| | | | | | | | is what has changed). Review URL: http://codereview.chromium.org/196005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25347 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make I-beam cursor match editing area.shess@chromium.org2009-09-033-2/+22
| | | | | | | | | | | | Due to our tweaking of the text area, the I-beam cursor was sometimes janky. http://crbug.com/20238 TEST=I don't even know how to really test this. Review URL: http://codereview.chromium.org/181011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25346 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Initialize the focus ring color preference values. This fixes an UMR ↵jhawkins@chromium.org2009-09-031-0/+3
| | | | | | | | | | when running the RenderView unit tests. The tests create a RenderView object using the default constructor of RendererPreferences. The uninitialized values are then passed through to WebKit to set the focus ring color. BUG=20964 TEST=Covered by valgrinding unit tests. Review URL: http://codereview.chromium.org/194009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25343 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete comment about a test being disabled.asargent@chromium.org2009-09-031-1/+0
| | | | | | | | | BUG=16106 TEST=none Review URL: http://codereview.chromium.org/176016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25341 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks for bug 20703asargent@chromium.org2009-09-031-0/+11
| | | | | | | | BUG=http://crbug.com/20703 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25337 0039d316-1c4b-4281-b951-d872f2087c98
* Make the omnibox 2 hover code a tiny bit less goofy by removing a now-unused ↵pkasting@chromium.org2009-09-037-37/+20
| | | | | | | | | | | | function (although it may have to come back eventually) and using the Model's conception of hover state instead of direct hot-tracking in the view. Unfortunately, there are still problems, including bogus mousemove events for the same point and no WM_MOUSELEAVE events, all of which the old code handled. I think fixing this is going to require implementing a TODO in the code to hoist mouse handling to the main dropdown view, at which point I can probably address issue 13703 as well. BUG=13279 TEST=none Review URL: http://codereview.chromium.org/187002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25336 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-0317-93/+236
| | | | | | | | | | | | privileges to the new"" Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed. BUG=17636 Review URL: http://codereview.chromium.org/172120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25329 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes a SSL related message non Window specific.jcampan@chromium.org2009-09-031-1/+1
| | | | | | | | BUG=http://crbug.com/20938 TEST=Visit https://alioth.debian.org/ A warning page is shown. Click the 'Help me understand' link. The text shown should not mention Windows. Review URL: http://codereview.chromium.org/192002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25328 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Workaround Skia and Pango measuring font heights differently by ↵evan@chromium.org2009-09-031-1/+1
| | | | | | | | | asking Pango" This reverts commit r25131. It seems to have regressed Linux startup; will track perf builder after committing this to be sure. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25325 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't have a blank line in bookmark folder tooltips.erg@google.com2009-09-031-1/+4
| | | | | | Review URL: http://codereview.chromium.org/198006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25322 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix link and link underline colorsarv@google.com2009-09-037-34/+125
| | | | | | | | | | | | | The fall back color for the link underline is the link color with the alpha channel set to 1/3 of the link color. BUG=20697 TEST=All links on the NTP should have different underline color. Also, try with different themes. Review URL: http://codereview.chromium.org/194004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25318 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Add basic unit tests for gtk themes.erg@google.com2009-09-036-13/+180
| | | | | | Review URL: http://codereview.chromium.org/186019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25317 0039d316-1c4b-4281-b951-d872f2087c98
* The iterator used to walk through the set of throbbers might become invalidmark@chromium.org2009-09-031-4/+11
| | | | | | | | | | | if a throbber decides it's done animating during the walk. This might happen for toast throbbers, like the sad tab icon. TEST=none, really BUG=20907 Review URL: http://codereview.chromium.org/185016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25316 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky ExtensionApi tests. #1 source of flakiness.phajdan.jr@chromium.org2009-09-032-2/+4
| | | | | | | | | TEST=none http://crbug.com/19866, http://crbug.com/20828 Review URL: http://codereview.chromium.org/195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25314 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme setup a little faster by not blurring images for tab backgrounds.mirandac@chromium.org2009-09-031-5/+5
| | | | | | | | | BUG= http://crbug.com/20956 TEST= Install themes, note that tab backgrounds look good. Review URL: http://codereview.chromium.org/198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25312 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 25302 since ExtensionBrowserTest.ParseFeed in browser_tests has ↵yusukes@google.com2009-09-031-1/+1
| | | | | | | | started to fail. Review URL: http://codereview.chromium.org/197009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25306 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 16:19:36 +0000