summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Change Mac fullscreen mode to be a stack, not a flag. This fixes crashes andamanda@chromium.org2009-10-114-19/+30
| | | | | | | | | | | | | misbehavior of fullscreen browser windows and plugins, especially when they interact. BUG=23571,24216 TEST=open up multiple browser windows, make them fullscreen, and go to pages (such as video players) that can invoke full screen plugins. The menu bar should hide when the first window becomes fullscreen, show again after the last window stops being fullscreen, and not crash at any of those transitions. Review URL: http://codereview.chromium.org/269022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28690 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency on i18n/icu_string_conversions from base/string_util.h.brettw@chromium.org2009-10-105-24/+31
| | | | | | | | | | | | Fix up all files requireing this header to include it directly. Split out the ICU-dependent string util unit tests into a new file base/i18n/icu_string_util_unittest.cc TEST=none BUG=none Review URL: http://codereview.chromium.org/269034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28674 0039d316-1c4b-4281-b951-d872f2087c98
* Change back from using NSRectFillWithOperation to plain NSRectFilldmaclach@chromium.org2009-10-101-1/+1
| | | | | | | | | | | | | | because according to shark we were spending a lot of time doing the alpha blending that we didn't need. In fact we didn't even want it because it was leaving us artifacts in the corners of our windows. BUG=24490,24500 TEST=none Review URL: http://codereview.chromium.org/273015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28673 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28558 because this is clearly responsible fornsylvain@chromium.org2009-10-101-1/+267
| | | | | | | | | | | | | | | | | | | | breaking the interactive ui tests. It just needs a clobber. It looks like 2 parts of the code don't agree on the number of buttons on the bookmark bar. Maybe because part of the code is compiled with CHROME_PERSONALIZATION = 1 while the test is compiled with CHROME_PERSONALIZATION = 0. Maybe this new gyp change broke the define propagation. This is really easy to replicate, and should also be easy to debug. Original Log: Relanding the interactive UI tests GYP factor out, as it turns out it is not responsible for breaking the interactive ui tests. Review URL: http://codereview.chromium.org/271046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28668 0039d316-1c4b-4281-b951-d872f2087c98
* Don't draw the red line when the security level is SECURE.yusukes@google.com2009-10-101-7/+7
| | | | | | | | | | Review URL: http://codereview.chromium.org/273016/show BUG=24510 TEST=see the bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28667 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the empty line that got added at the end of this file.nsylvain@chromium.org2009-10-101-1/+0
| | | | | | | This seems to confuse archive_build.py Review URL: http://codereview.chromium.org/264031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28665 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.3 to 222.4laforge@chromium.org2009-10-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28661 0039d316-1c4b-4281-b951-d872f2087c98
* Accessibility information from the renderer was not being returned to tools ↵ananta@chromium.org2009-10-101-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | like screen readers, etc. This was because the object implementing the root IAccessible interface did not know how to navigate a native render view. To work around this, we now check if the underlying view is a native view in our root IAccessible::get_accChild function and if yes we send the WM_GETOBJECT message to the corresponding RenderWidgetHostViewWin class, which returns an IAccessible interface which then can expose information from the renderer. The other changes in the accessibility code are for some crashes I observed while testing the screen readers like nvda, the Windows screen reader which send a flurry of WM_GETOBJECT messages leading to some race conditions. We also ensure that the accessibility information for a view is torn down when the view is destroyed. Fixes portions of http://code.google.com/p/chromium/issues/detail?id=13291 Bug=13291 Review URL: http://codereview.chromium.org/261044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28645 - "Render sync code inactive..."tim@chromium.org2009-10-103-0/+20
| | | | | | | | Vive le sync! Review URL: http://codereview.chromium.org/269044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28649 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another race condition on worker process shutdown that results in ↵jam@chromium.org2009-10-105-0/+9
| | | | | | | | | | use-after-free. Like 23018, this is happening because valgrind is slowing the worker thread shutdown enough that the backup terminate process code executes. BUG=24346 TEST=covered by valgrind Review URL: http://codereview.chromium.org/266036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28646 0039d316-1c4b-4281-b951-d872f2087c98
* Render sync code inactive without any way to enable.tim@chromium.org2009-10-103-20/+0
| | | | | | | | | | | | **** I WILL REVERT THIS PATCH IMMEDIATELY. It is a kill switch that may need to be merged in later. *** Patching this CL is a quick shut-off mechanism in the event sync needs to de disabled prior to a release build. TEST=No sync UI visible. about:sync shows 'SYNC_DISABLED', no 'Sync Data' folder created when run. Review URL: http://codereview.chromium.org/270049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28645 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pthreads from build and installer files.tim@chromium.org2009-10-1012-1232/+1
| | | | | | | | | | | We can yank it from deps/ following this. BUG=19895 TEST=sync_unit_tests Review URL: http://codereview.chromium.org/261042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28642 0039d316-1c4b-4281-b951-d872f2087c98
* Browser actions: limit minimum size of omnibox. When decreasing the width of ↵sidchat@chromium.org2009-10-093-1/+51
| | | | | | | | | | the omnibox, the Browser actions start falling off one by one till there are two left. After that, the omnibox itself starts shrinking, as it normally does. Note that if there is only one browser action, then it remains sticky to the toolbar. BUG=23962 TEST=none Review URL: http://codereview.chromium.org/262008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28628 0039d316-1c4b-4281-b951-d872f2087c98
* Add EV certificate text to the Mac location barhawk@chromium.org2009-10-095-17/+132
| | | | | | | | BUG=10910 TEST=EV sites (e.g., http://www.paypal.com and most bank sites) get a green text description next to the lock icon in the location bar, non-EV (and non-SSL) sites do not Review URL: http://codereview.chromium.org/216031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28627 0039d316-1c4b-4281-b951-d872f2087c98
* Force linux_symbols target to run when building all (even though nothingmmoss@chromium.org2009-10-091-1/+2
| | | | | | | | | depends on it). Review URL: http://codereview.chromium.org/270053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory_test's temporary user data directory path, the base namesgk@chromium.org2009-10-091-5/+8
| | | | | | | | | of which is copied into the containing temporary directory. BUG=none TEST=Useful mem test stats in the perf graph. Review URL: http://codereview.chromium.org/266047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28625 0039d316-1c4b-4281-b951-d872f2087c98
* test conversion from toolstrips to actionserikkay@chromium.org2009-10-097-10/+271
| | | | | | Review URL: http://codereview.chromium.org/264019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28624 0039d316-1c4b-4281-b951-d872f2087c98
* Change text for extension download UI.sidchat@chromium.org2009-10-094-12/+25
| | | | | | | | BUG=23105 TEST=none Review URL: http://codereview.chromium.org/261026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28621 0039d316-1c4b-4281-b951-d872f2087c98
* Fix use-after-free in the worker process. The object was shutting down the ↵jam@chromium.org2009-10-093-23/+14
| | | | | | | | | | process so it was a race condition that the process was still running when the task executed. BUG=23018 TEST=covered by valgrind on mac Review URL: http://codereview.chromium.org/267035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28620 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix early font free during printing.estade@chromium.org2009-10-091-1/+0
| | | | | | | | | | The ownership model for this stuff (fonts, cairo canvas, etc.) is a bit brittle. Don't know how to improve it though. BUG=23372 Review URL: http://codereview.chromium.org/270048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28619 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: use NtpBackgroundUtil to draw detached bookmark bar.estade@chromium.org2009-10-093-172/+21
| | | | | | | | BUG=23836 Review URL: http://codereview.chromium.org/268027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28618 0039d316-1c4b-4281-b951-d872f2087c98
* A couple fixes for network cros librarychocobo@google.com2009-10-092-57/+42
| | | | | | | | | | - no need to send updates after connecting to wifi. the cros api will handle this. - clear state before parsing ServiceStatus in case the network no longer exists. BUG=23923 TEST=none Review URL: http://codereview.chromium.org/271038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28617 0039d316-1c4b-4281-b951-d872f2087c98
* Several theming fixes for the Mac. Sorry for the extensive change, but theythakis@chromium.org2009-10-0926-345/+838
| | | | | | | | | | | | | | | | | | were all sort of intertwined. Fixes up patterns in general so that they are all in phase. Moves the window widget buttons down by two pixels. Draws overlays correctly. Fixes up some accessibility issues with the default window widgets. Gets rid of some out of date files (tab_cell). BUG=18438, 18547, 19851, 20295, 22213, 23651, 24338 TEST=Launch Chrome. Switch to "dots" theme from the Google themes. Create a couple of tabs. Check to make sure that the background pattern line up with the tabs. Move the tabs around. Check that the hightlight colors and text colors look correct for all of the tabs. Make sure the patterns stay lined up. Resize the window, make sure none of the patterns move around. Create new windows by dragging the tabs out of the windows and make sure a new window is created with the correct pattern. Show the "find" bar. Make sure its pattern lines up correctly with the tabbar. Switch to default theme. Make sure it looks correct and draws properly. Switch to Zen theme and make sure that the overlay at the top draws correctly. Create a new window. make sure that the rollovers in the window widgets work correctly in both the active and inactive window. Mouse down on the zoom button in the inactive window and notice that the window context changes. Move off of the zoom button and mouse up. Mouse down on the miniaturize button on the inactive window and notice that the window context does not change. Move off of the miniaturize button and mouse up. Do the same thing you did for the miniaturize button for the close button. Start up Accessibility Inspector from the developer tools. Make sure that the window widgets report their accessibility information correctly. Review URL: http://codereview.chromium.org/260009 Patch from dmaclach@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28613 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a interactive testjcampan@chromium.org2009-10-091-1/+2
| | | | | | | | | | | | | Disabling the last browser focus interactive UI tests. It mysteriously crashing, as with the rest of them that were disabled yesterday (this one was left out, probably unintentionaly). BUG=http://crbug.com/24400 TBR=estade Review URL: http://codereview.chromium.org/272016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28606 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix some omnibox breakage for small windows.shess@chromium.org2009-10-093-10/+149
| | | | | | | | | | | | Change the code to decorate the contents string normally, then elide the marked-up string if it doesn't fit. http://crbug.com/23279 TEST=See bug. Review URL: http://codereview.chromium.org/264012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28603 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error messages when a manifest is not readable or not valid JSON.aa@chromium.org2009-10-097-5/+67
| | | | | | Review URL: http://codereview.chromium.org/251003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that files cannot be dropped on the input widget on the Mac.jianli@chromium.org2009-10-091-1/+16
| | | | | | | | | BUG=19529 TEST=none Review URL: http://codereview.chromium.org/270026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28600 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spacing that was supposed to go in a previous checkin and somehow pkasting@chromium.org2009-10-091-1/+1
| | | | | | | missed it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28597 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove deprecated AbsolutePath function."evan@chromium.org2009-10-091-8/+5
| | | | | | This reverts commit r28593. Random guess at build breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28596 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Rename ThemePreviewInfobarDelegate toaa@chromium.org2009-10-098-66/+66
| | | | | | | | | | ThemeInstalledInfoBarDelegate Contributed by Thiago Farina <tfarina@gmail.com> TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28595 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated AbsolutePath function.evan@chromium.org2009-10-091-5/+8
| | | | | | Review URL: http://codereview.chromium.org/271037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28593 0039d316-1c4b-4281-b951-d872f2087c98
* linux/mac: use "First Run", not "First Run Dev"evan@chromium.org2009-10-091-8/+7
| | | | | | | | | | | | This should've been done back when we finished the First Run dialogs, but better late than never. BUG=24397 TEST=Run Chrome on an old profile; you should not get a first run dialog if you've already clicked through and your user data dir should now contain a "First Run" file and no "First Run Dev" file. Run Chrome on a new profile; First Run should still work as before. Review URL: http://codereview.chromium.org/273009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28592 0039d316-1c4b-4281-b951-d872f2087c98
* Build 64-bit RPMs.thestig@chromium.org2009-10-091-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28589 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pthreads from event_sys_unittest.tim@chromium.org2009-10-091-48/+42
| | | | | | | | | BUG=19895 TEST=EventSys Review URL: http://codereview.chromium.org/273007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28587 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Valgrind UMR errors by initializing thumbnail pixels.huanr@chromium.org2009-10-091-0/+1
| | | | | | | | | | | Original code review: http://codereview.chromium.org/270040 BUG=17067 TEST=none Review URL: http://codereview.chromium.org/264024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28586 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an include.brettw@chromium.org2009-10-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28585 0039d316-1c4b-4281-b951-d872f2087c98
* Fix header.brettw@chromium.org2009-10-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28584 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include.brettw@chromium.org2009-10-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28583 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some mroe includes.brettw@chromium.org2009-10-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28581 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a broken include in the mini installer testsbrettw@chromium.org2009-10-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28579 0039d316-1c4b-4281-b951-d872f2087c98
* Really fix the changed include to fix the ChromeOS build this time.brettw@chromium.org2009-10-091-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28577 0039d316-1c4b-4281-b951-d872f2087c98
* Fix wrong include to fix the CromeOS build.brettw@chromium.org2009-10-091-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a missed include rename to fix the build.brettw@chromium.org2009-10-091-1/+1
| | | | | | | BUG=none TET=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28572 0039d316-1c4b-4281-b951-d872f2087c98
* Move more ICU-dependent stuff from base into base/i18n. Some test stuff alsobrettw@chromium.org2009-10-0924-27/+27
| | | | | | | | | | | | depended on this, so to make the DEPS work out, I made a new base/test directory where I moved the testing-related files into a new directory base/test. TEST=none BUG=none Review URL: http://codereview.chromium.org/266038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
* Moving ShowContextMenu out of WebView_delegate and into WebViewClientyaar@chromium.org2009-10-097-168/+106
| | | | | | | | (Part of the Webkit API refactoring effort). Review URL: http://codereview.chromium.org/265011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28567 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.extension.connectExternal and fix various API inconsistencies.mpcomplete@chromium.org2009-10-0920-94/+376
| | | | | | | | | | BUG=23583 BUG=17910 TEST=no Review URL: http://codereview.chromium.org/262016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28565 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the NTP to be bookmarked.pkasting@chromium.org2009-10-094-42/+16
| | | | | | | | BUG=none TEST=Try to bookmark the NTP. Review URL: http://codereview.chromium.org/269028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28564 0039d316-1c4b-4281-b951-d872f2087c98
* Update cros network library code to work with the latest cros API that sends ↵chocobo@google.com2009-10-092-3/+4
| | | | | | | | | | network updates with ServiceStatus. This fixes the issue where if we are connected to ethernet, we won't get wifi network updates. BUG=23923 TEST=none Review URL: http://codereview.chromium.org/269029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28562 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Theme the bookmark bar on the new tab page.erg@chromium.org2009-10-0910-50/+299
| | | | | | | | | | | | | | | | | - XIB change: The controller has a connection to buttonView_. - BrowserThemeProviderMac: Fix a bug where we weren't returning default colors; we returned nil instead. - The majority of the implementation is actually the cross platform NtpBackgroundUtil::PaintBackgroundDetachedMode. We do platform specific drawing on top of the background, though. TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithNoImage TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithBgImage BUG=http://crbug.com/17625 Review URL: http://codereview.chromium.org/266027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28560 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Start the database query for the new tab page results as soon""tony@chromium.org2009-10-092-39/+93
| | | | | | | | | | | | | | This re-applies r28549 with a NULL pointer check for the HistoryService, which can be NULL during unit tests. It also means that if the user does a view-source on the new tab page, we make a wasted query to the history service, but I guess that's not a big deal. TBR=arv Review URL: http://codereview.chromium.org/267039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28559 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 11:01:31 +0000