summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Adds support for the gtest_also_run_disabled_tests flag in the browser tests.jcampan@chromium.org2009-07-073-3/+12
| | | | | | | | BUG=None TEST=Run the browser tests with the --gtest_also_run_disabled_tests flag. Disabled tests should be run. Review URL: http://codereview.chromium.org/155112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20060 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra delegate method to mac unit test.ben@chromium.org2009-07-071-0/+4
| | | | | | TBR=pinkerton git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20058 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - add headerben@chromium.org2009-07-072-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20056 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release bustage. ALLOW_THIS_IN_INITIALIZER_LISTben@chromium.org2009-07-072-3/+3
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/149267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20055 0039d316-1c4b-4281-b951-d872f2087c98
* Basics of a new TabStrip.It's very, very rough, but I wanted to check it in ↵ben@chromium.org2009-07-0719-26/+1231
| | | | | | | | so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout! Review URL: http://codereview.chromium.org/42490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the prefs for the optional home buttons and page/wrench buttons. ↵pinkerton@chromium.org2009-07-0712-44/+3531
| | | | | | | | | | Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked. BUG=13151 TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar. Review URL: http://codereview.chromium.org/155151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20052 0039d316-1c4b-4281-b951-d872f2087c98
* Beginning of code coverage on Windows.jrg@chromium.org2009-07-071-3/+6
| | | | | | Review URL: http://codereview.chromium.org/155123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20045 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the ability to close or minimize the hung renderer dialogrohitrao@chromium.org2009-07-073-14/+11
| | | | | | | | | | | | on Mac. I'm leaving the window resizable for now, because I dislike non-resizable windows. This is easy enough to change later. BUG=None TEST=After bringing up the dialog, verify that the only way to dismiss it is by pressing either the wait button or the kill button. Review URL: http://codereview.chromium.org/151009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20044 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Status bubble obeys GTK colors now.erg@google.com2009-07-073-8/+49
| | | | | | | | http://crbug.com/13967 Review URL: http://codereview.chromium.org/149259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20043 0039d316-1c4b-4281-b951-d872f2087c98
* Change the use of typedef Language in Spell Check files back to std::string. ↵sidchat@google.com2009-07-0710-50/+46
| | | | | | | | | | It is unnecessary, and is conflicting with enum Language definition for compact language detection library. BUG=none TEST=none Review URL: http://codereview.chromium.org/150139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20042 0039d316-1c4b-4281-b951-d872f2087c98
* linux: OOP windowed pluginsevan@chromium.org2009-07-0717-35/+173
| | | | | | | | | | | | | | There are still a few issues, but that's a start. - only windowed plugins - we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID). - the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC. - some code is duplicated between chrome and test_shell. We should probably refactor it, but I'm not sure where the common part should live. Patch from Antoine Labour <piman@google.com>, with some touchups by me. Review URL: http://codereview.chromium.org/146078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20041 0039d316-1c4b-4281-b951-d872f2087c98
* Crashers from the field indicate the navigation entry can be NULL. This is ↵jcampan@chromium.org2009-07-071-0/+13
| | | | | | | | | | | | | | | not expected and not clear how this happen. Working-around the crasher. BUG=http://crbug.com/15605 TEST=None Review URL: http://codereview.chromium.org/150185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20037 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo. TextDirection is the name of the enum, while GetTextDirection ↵jhawkins@chromium.org2009-07-071-2/+4
| | | | | | | | | | | returns the current text direction. Also fixes a few lint nits. CID=4539 BUG=none TEST=none Review URL: http://codereview.chromium.org/149257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20035 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the GC of workers. When Worker object is GC'ed in the renderer, we need ↵dimich@google.com2009-07-072-5/+16
| | | | | | | | | | to terminate the worker process. BUG=15647, 15759 TEST=new ui_test is part of this CL Review URL: http://codereview.chromium.org/151125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20034 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionBrowserTest.Incognito because it fails too often.nsylvain@chromium.org2009-07-071-0/+3
| | | | | | | | BUG:16106 Review URL: http://codereview.chromium.org/155147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20029 0039d316-1c4b-4281-b951-d872f2087c98
* Theme window control buttons.mirandac@chromium.org2009-07-0711-19/+71
| | | | | | | | | | | BUG= http://crbug.com/14579 TEST= Install a theme with themed window control buttons. Observe that WCB's are themed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19758 Review URL: http://codereview.chromium.org/150041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20028 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a couple of keybindings.sky@chromium.org2009-07-074-0/+26
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: store devtools split offset only when devtools is being hidden.pfeldman@chromium.org2009-07-071-3/+6
| | | | | | | | Otherwise any browser window closed afterwards will overwrite settings with the original ones. Review URL: http://codereview.chromium.org/155140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20026 0039d316-1c4b-4281-b951-d872f2087c98
* Use native Cocoa tooltips instead of Mozilla's ToolTip class.pinkerton@chromium.org2009-07-073-38/+201
| | | | | | | | This makes tooltips behave more normally, and fixes some of the bugs. Patch by Jens Alfke (snej@google.com) BUG=15655 TEST=tooltips should feel more like native tooltips git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20019 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add global eval sanity test.pfeldman@chromium.org2009-07-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20018 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add more sanity tests.pfeldman@chromium.org2009-07-072-3/+39
| | | | | | Review URL: http://codereview.chromium.org/149246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20017 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Preserve devtools window contents on dock/undock.pfeldman@chromium.org2009-07-073-209/+179
| | | | | | Review URL: http://codereview.chromium.org/149199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20016 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: first cut at web contents as drag destination.estade@chromium.org2009-07-072-2/+205
| | | | | | | | | TEST=drag plain text into the web page in some place that will accept it, e.g. a text entry box. Also, no crashes when dragging from various places (tab strip, bookmark bar, desktop icons, omnibox, etc.) BUG=http://crbug.com/15429 Review URL: http://codereview.chromium.org/150198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20010 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up contents creation in BrowserViewben@chromium.org2009-07-071-3/+1
| | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/155029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue once and for all where distributor logo overlays window controls. ↵ben@chromium.org2009-07-072-0/+19
| | | | | | | | | | Need to force a layout and schedule a paint when a window is made visible. http://crbug.com/15520 TEST=see bug. Review URL: http://codereview.chromium.org/155111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20006 0039d316-1c4b-4281-b951-d872f2087c98
* Popup changesdavemoore@chromium.org2009-07-077-11/+400
| | | | | | Review URL: http://codereview.chromium.org/155075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20001 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Set the text color of bookmark buttons to theme color.erg@google.com2009-07-078-55/+103
| | | | | | | | http://crbug.com/13967 Review URL: http://codereview.chromium.org/155108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20000 0039d316-1c4b-4281-b951-d872f2087c98
* Have the ApplyEdit* bookmark utilities return the BookmarkNode pointertim@chromium.org2009-07-072-37/+42
| | | | | | | | | so that callers know whether or not the original BookmarkNode* passed in is still valid or not. Review URL: http://codereview.chromium.org/149140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19999 0039d316-1c4b-4281-b951-d872f2087c98
* Only force-abort popup render views on mousedown.estade@chromium.org2009-07-071-6/+6
| | | | | | | | | BUG= http://crbug.com/15976 TEST=see bug Review URL: http://codereview.chromium.org/149209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19998 0039d316-1c4b-4281-b951-d872f2087c98
* Make default extension for downloading html "html" rather than "htm" on ↵estade@chromium.org2009-07-073-15/+39
| | | | | | | | | | | non-windows platforms. BUG= http://crbug.com/15999 TEST=un-disable and run save page uitest on linux (it's only disabled because it's flaky, for some unrelated reason) Review URL: http://codereview.chromium.org/155095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19997 0039d316-1c4b-4281-b951-d872f2087c98
* The default ping delay should be 90 seconds.kuchhal@chromium.org2009-07-071-0/+3
| | | | | | | | BUG=1953127 Review URL: http://codereview.chromium.org/149220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19995 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: OOP windowed plugins"evan@chromium.org2009-07-0617-173/+35
| | | | | | This reverts r19983. Test failures on Mac and Windows. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19988 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a crash in RenderViewGone.finnur@chromium.org2009-07-061-4/+7
| | | | | | | | | | | | | | | | | | | | | | If I start Chrome and shut it down quickly RenderViewHost receives an IPC ViewHostMsg_RenderViewGone. We respond in ExtensionHost::RenderViewGone by putting up an info bar on the selected tab contents saying that an extension crashed. Only problem is that ExtensionHost::GetBrowser() can return NULL during startup and shutdown, as documented in the function and so we should not try to put up the Infobar if the browser is going away. BUG=None TEST=Open Chrome with extensions enabled and an extension loaded and shut Chrome down as soon as it launches. It should not crash. Might take a few trys to repro. Review URL: http://codereview.chromium.org/149205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19986 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the no-match red background to take up more spacefinnur@chromium.org2009-07-061-10/+23
| | | | | | | | | | | (basically leaving only one pixel margin around the edges). BUG=htt://crbug.com/15874 TEST=None, Find box should work as before. Review URL: http://codereview.chromium.org/155061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19985 0039d316-1c4b-4281-b951-d872f2087c98
* linux: OOP windowed pluginsevan@chromium.org2009-07-0617-35/+173
| | | | | | | | | | | | There are still a few issues, but that's a start. - only windowed plugins - we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID). - the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC. - some code is duplicated between chrome and test_shell. We should probably factor it, but I'm not sure where the common part should live. Review URL: http://codereview.chromium.org/146078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19983 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-0640-279/+363
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Activate the currently selected process when the user double clicks the task ↵jhawkins@chromium.org2009-07-062-1/+30
| | | | | | | | | | manager treeview. BUG=11392 TEST=Open the task manager and double click different processes. Those tabs should be activated. Review URL: http://codereview.chromium.org/155098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19980 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for extended tooltips.arv@google.com2009-07-062-3/+18
| | | | | | | | | | | | | | As the user moves the mouse around. Check if the element has an xtitle property. If it does, compare the scrollWidth and the clientWidth and set the real title property as needed. BUG=15769 TEST=Hover over items on the NNTP. Only items with ellipsis should show tooltips. Review URL: http://codereview.chromium.org/149166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19979 0039d316-1c4b-4281-b951-d872f2087c98
* Add a ping delay time master preference.kuchhal@chromium.org2009-07-065-21/+69
| | | | | | | | BUG=1953127 Review URL: http://codereview.chromium.org/149135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19978 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the current remaining Views-GTK compile and linker errors.brettw@chromium.org2009-07-067-8/+78
| | | | | | | | Chrome still doesn't run. Review URL: http://codereview.chromium.org/155026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19977 0039d316-1c4b-4281-b951-d872f2087c98
* Make default browser path check case insensitive.kuchhal@chromium.org2009-07-062-3/+9
| | | | | | | | BUG=15449 Review URL: http://codereview.chromium.org/149136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19976 0039d316-1c4b-4281-b951-d872f2087c98
* Don't install the RWHVMac into the view hierarchy until everything has been ↵pinkerton@chromium.org2009-07-063-3/+18
| | | | | | | | | | properly sized. This avoids sending spurrious resize message with incorrect sizes to the renderer. BUG=15717 TEST=pages should always be the correct size when loaded in bg or foreground. No more flashing a small size then redrawing. Review URL: http://codereview.chromium.org/155099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19973 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 192.0 to 193.0laforge@chromium.org2009-07-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19970 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of CHECKs to RenderViewHost trying to track down a crash.mpcomplete@chromium.org2009-07-062-1/+40
| | | | | | | | | BUG=15607 TEST=CHECKs should not fire, unless we're about to crash anyway, in which case I want the crash report. Review URL: http://codereview.chromium.org/149142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19967 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Give the aboot dialog a facelift.estade@chromium.org2009-07-063-63/+140
| | | | | | | | | BUG=http://crbug.com/15897 TEST=get Glen to look at it Review URL: http://codereview.chromium.org/155040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19966 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Improve look of find in page failure label.estade@chromium.org2009-07-061-1/+7
| | | | | | | | | BUG=http://crbug.com/15874 TEST=looks good Review URL: http://codereview.chromium.org/155041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19965 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exact search method to the Keychain adapter, and modify unit tests to ↵stuartmorgan@chromium.org2009-07-063-243/+230
| | | | | | | | | | | | | us that instead of the raw keychain version. Overhaul the single-item-search test to be shorter, clearer, and more complete. Convert more namespaced methods that now have no public callers to private helpers of the Keychain adapter, and refactor the helpers. BUG=none TEST=none; no behavioral changes Review URL: http://codereview.chromium.org/149160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19964 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r19950. Turns out it wasn't at fault for breaking the vista tests.willchan@chromium.org2009-07-062-0/+18
| | | | | | | | | | | This reverts commit 6c6d8665c114217a14fea346cca97006e4c3daa7. BUG=none TEST=none TBR=nsylvain Review URL: http://codereview.chromium.org/155097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19961 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r19950 since it broke vista tests.willchan@chromium.org2009-07-062-18/+0
| | | | | | | | | | Revert "Add checks to track down crashes in URLRequestChromeJob." BUG=none TEST=none Review URL: http://codereview.chromium.org/155092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19957 0039d316-1c4b-4281-b951-d872f2087c98
* Add a context menu to the gtk task manager.jhawkins@chromium.org2009-07-062-0/+133
| | | | | | | | BUG=11392 TEST=none Review URL: http://codereview.chromium.org/155027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19956 0039d316-1c4b-4281-b951-d872f2087c98