| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
already running would end up creating an extra tab.
BUG=11594
TEST=open chrome with a single tabbed browser, turn on session
restore, navigate to a page with a popup, close the tabbed browser,
create a new window ala control-n (or double click on the desktop),
and make the restored window doesn't end upw
Review URL: http://codereview.chromium.org/1371002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Scott's insight in comment 18 on the bug report was correct; fixed by relinquishing control on call to UpdatePageActions, so that we don't try to look at the private variables of a dying this ptr.
BUG= 35864
TEST= no crash.
Review URL: http://codereview.chromium.org/1397001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GeolocationPermissionContext to persist settings.
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1141004
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/1394005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
persist settings.
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1141004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, an in-progress version of the bubble/omnibox icon. The bubble shows up, but doesn't do much yet. The two buttons are disabled because they both don't do anything yet. Since this is behind a flag, I think checking in work-in-progress UI is fine.
Parts of this CL were merged in from http://codereview.chromium.org/1369002 . Ignore the files from that CL.
http://imgur.com/tWJhg
BUG=11246
TEST=Start chrome with --enable-geolocation, go to http://maxheapsize.com/static/html5geolocationdemo.html , click allow or deny, observe that an icon appears. Click icon, a bubble appears.
Review URL: http://codereview.chromium.org/1345005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1361004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33071
TEST=drags to omnibox in popup should be denied. drags to omnibox in normal window should be allowed and load the url.
Review URL: http://codereview.chromium.org/1225007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39147
TEST=Existing tests in extensions_service_unittest.cc
Review URL: http://codereview.chromium.org/1278003
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:2036
TEST=Run out/Debug/browser_tests --gtest_filter=LoginManagerViewTest.TestBasic
Review URL: http://codereview.chromium.org/1256004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/1369002
BUG=11246
TEST=--enable-geolocation and open http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html
Review URL: http://codereview.chromium.org/1348002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We did the original abuse because we were past the 4.1 string freeze and needed
to add new features, but we can fix this for chrome 5.
TEST=The labels should be things like "Key:" instead of "Name:" and so on.
BUG=34669
Review URL: http://codereview.chromium.org/1317004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180
TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)
BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.
Review URL: http://codereview.chromium.org/1369002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
failure multiple times.
BUG=39214
TEST=included new fancy unit test
Review URL: http://codereview.chromium.org/1294002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I plan to further rearrange the files after landing this CL
so that the names make sense again.
TEST=browser tests and live sync tests
BUG=none
Review URL: http://codereview.chromium.org/1310003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/1108002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See: http://codereview.chromium.org/858003
TBR=tommi
BUG=22846
TEST=On IE 8, clear the cache entirely, watch GCF launch (via task manager)
Review URL: http://codereview.chromium.org/1343004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1368001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=36229
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/1338007
TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/1360003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds label scraping to AutoFill. Infers labels from surrounding context of
input fields in the WebKit DOM. Specific cases added are:
- Text element immediately preceeding INPUT element.
Eg. First name:<INPUT type="text" id="firstname" value="John"/>
- Paragraph element containing text immediately preceeding INPUT element.
Eg. <P>First name:</P><INPUT type="text" id="firstname" value="John"/>
BUG=33031
TEST=FormManagerTest.LabelsFromInferredParagraph,
FormManagerTest.LabelsFromInferredText,
FormStructureTest.HeuristicsLabelsOnly
Review URL: http://codereview.chromium.org/1380002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=36229
TEST=none
TBR=bradnelson
Review URL: http://codereview.chromium.org/1338007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The gunit ASSERT_DEBUG_DEATH check is causing long timeouts on Mac. Removing.
BUG=NONE
TEST=AutoFill unit tests.
Review URL: http://codereview.chromium.org/1400001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Bug=39356
TBR=robertshield
Review URL: http://codereview.chromium.org/1336005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deprecating 'he' in favor of 'iw'.
Review URL: http://codereview.chromium.org/1332001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionUpdater. This is needed for theme syncing.
Basically a pending extension is an (id, update_url) pair. This change
makes it so that one can pass pending extensions to the extension service
and they will be installed if necessary on the next auto-update cycle.
BUG=32414
TEST=unittests, trybots, in-progress theme syncing change
Review URL: http://codereview.chromium.org/1232003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the UI thread
BUG=34206
TEST=none
Review URL: http://codereview.chromium.org/1361002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39401
TEST=ui_test --gtest_filter BookmarksUITest.*
TBR=dhollowa
Review URL: http://codereview.chromium.org/1365003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34514
TEST=none
Review URL: http://codereview.chromium.org/1353003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return).
BUG=38964
TEST=crash an extension while the context menu for it is showing.
Review URL: http://codereview.chromium.org/1237004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win64 are not enabled yet, but should run in the sandbox once they are.
Mac problem was hopefully fixed with bug 37707
BUG=http://code.google.com/p/nativeclient/issues/detail?id=342
TEST=nacl_ui_tests
Review URL: http://codereview.chromium.org/1342002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39404
TEST=none
TBR=avayvod
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a followup to an earlier change (r38266) which did most of the
warning-related cleanup. This one just flips the flag, and fixes some
new warnings that crept in during the window while the flag was off.
Second try, now with some libpng fixes.
BUG=34160
Review URL: http://codereview.chromium.org/1320011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding to valgrind exception list while we determine source of failure. Note, same test does not fail
under other platforms, nor does it fail under non-valgrind Mac bots.
BUG=39401
TEST=none
Review URL: http://codereview.chromium.org/1342003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reload the correct tab, not the full browser.
BUG=chromium-os:2057
Review URL: http://codereview.chromium.org/1238006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=power_menu_button_browsertest
Review URL: http://codereview.chromium.org/1338003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.
Review URL: http://codereview.chromium.org/1207005
TBR=neb@chromium.org
Review URL: http://codereview.chromium.org/1344003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42684 - Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF directory for nonpriv mode users on IE < 8.
Implementation notes:
Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change:
"Delete Browsing History":
IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual.
IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8.
"InPrivate Filtering":
IE 8 (only): more testing required.
"InPrivate Browsing":
IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected.
BUG=22846
TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming)
Review URL: http://codereview.chromium.org/858003
TBR=slightlyoff@chromium.org
Review URL: http://codereview.chromium.org/1353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Compiled locally and on trybots but failed on builder?!
This reverts commit r42688.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a followup to an earlier change (r38266) which did most of the
warning-related cleanup. This one just flips the flag, and fixes some
new warnings that crept in during the window while the flag was off.
BUG=34160
Review URL: http://codereview.chromium.org/597023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
strings are generated from checked in .grds from revision 42543.
BUG=24305
Review URL: http://codereview.chromium.org/1361001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory for non-priv mode users on IE < 8.
Implementation notes:
Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change:
"Delete Browsing History":
IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual.
IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8.
"InPrivate Filtering":
IE 8 (only): more testing required.
"InPrivate Browsing":
IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected.
BUG=22846
TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming)
Review URL: http://codereview.chromium.org/858003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it appears that some rely on these numbers, like the help center, sigh
BUG=38927
TEST=none
TBR=mal
Review URL: http://codereview.chromium.org/1323002
TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/1362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added ability for renderer processes to render to a real window (Windows only so far).
- Added ability to create offscreen frame buffer objects that can be resized later.
- OpenGL context can have a "parent" context that can access its last swapped back buffer through a texture ID.
- Moved code to establish GPU channel from RenderWidget to RenderThread.
- Changed way service size command buffer object lifetimes are managed.
TEST=trybot and visual verification that OpenGL can clear the browser window to magenta.
BUG=none
Review URL: http://codereview.chromium.org/1136006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all FDs.
BUG=35229
TEST=Let Chrome idle with a flakey net connection, and check that the number of open FDs is not increasing.
Review URL: http://codereview.chromium.org/1336004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the known crashes list.
Bug=39356
Review URL: http://codereview.chromium.org/1340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1320002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bring up FileBrowseUI.
<http://crosbugs.com/2056>
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1315003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
linux/views yet.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27905
TEST=Verify fix for 27095.
Review URL: http://codereview.chromium.org/1351001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180
TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)
BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.
Review URL: http://codereview.chromium.org/1344002
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/1367002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42668 0039d316-1c4b-4281-b951-d872f2087c98
|