summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix port disconnect so that it's refcounted. This fixes a bug where a channelmpcomplete@chromium.org2009-07-275-6/+122
| | | | | | | | | | | would close if any one listener on the channel called "disconnect()". BUG=16644 TEST=no Review URL: http://codereview.chromium.org/155476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21678 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid calls to gtk_widget_get_pointer during mouse move iftc@google.com2009-07-271-7/+15
| | | | | | | | | | | | | not necessary. This is to work around janky scrolling behavior that brad was seeing. I can't repro, so he'll have to tell me if this works for him BUG=16786 Review URL: http://codereview.chromium.org/160179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21675 0039d316-1c4b-4281-b951-d872f2087c98
* Make downloads not prevent tabs from closing.brettw@chromium.org2009-07-279-40/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21673 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutomationProxyTest.NavigateToURLWithTimeout* tests not-flaky.phajdan.jr@chromium.org2009-07-277-18/+148
| | | | | | | | | | | I used a mock url request job which is guaranteed to finish after the timeout the test uses. TEST=none http://crbug.com/16462 Review URL: http://codereview.chromium.org/155941 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21668 0039d316-1c4b-4281-b951-d872f2087c98
* Implement delete key for the Remove action in the bookmark manager.estade@chromium.org2009-07-272-9/+36
| | | | | | | | | | | | Although we will also need to implement certain other hotkeys such as Ctrl+C and so forth, I see no point in adding an accelerator group as we do not want the accelerators to work when the tree views don't have focus. Also we don't want the menu to show the accelerators. Also, fix a bug where the organize menu could be stale. mdm pointed out that ctrl+clicking the selection could lead to an empty selection. BUG=17393 Review URL: http://codereview.chromium.org/160137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21664 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: gtk_window_present when an already-showing browser window is showing ↵estade@chromium.org2009-07-271-1/+2
| | | | | | | | | | | | and we want to show it again. I think this will be very WM-specific on whether it works. It seems that a lot of WMs don't want to allow windows from groups that don't have focus to do this. For example: http://blogs.gnome.org/metacity/2007/12/24/stacking/ BUG=17767 Review URL: http://codereview.chromium.org/160149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21657 0039d316-1c4b-4281-b951-d872f2087c98
* Give crashed tabs the crashed tab icon on the Mac.avi@chromium.org2009-07-279-124/+266
| | | | | | | | | BUG=none TEST=crash a page and see if the icon shows up (animated) Review URL: http://codereview.chromium.org/160113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21648 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Mac history menu.rohitrao@chromium.org2009-07-2712-9/+842
| | | | | | | | | | | | | | | | * The menu has two sections: most visited and recently closed. * Creates a HistoryMenuBridge that observes different data sources and stores results for use in the menu. * Creates a HistoryMenuController to respond to Cocoa IBActions from the menu. BUG=14933 TEST=History menu in mac should populate with most visited and recently closed sites. RELEASE_NOTES=Add initial implementation of the Mac history menu. Patch by Robert Sesek. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21639 0039d316-1c4b-4281-b951-d872f2087c98
* reenable a disabled part of a unit testerikkay@chromium.org2009-07-272-6/+4
| | | | | | | | | BUG=15363 TEST=ExtensionsService.LoadAllExtensionsFromDirectorySuccess Review URL: http://codereview.chromium.org/159388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21638 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: split console evaluation into two steps: actual evaluation and resultyurys@google.com2009-07-271-0/+5
| | | | | | | | | | | wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21635 Review URL: http://codereview.chromium.org/159395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21637 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21635.yurys@google.com2009-07-271-5/+0
| | | | | | Review URL: http://codereview.chromium.org/159399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21636 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: split console evaluation into two steps: actual evaluation and resultyurys@google.com2009-07-271-0/+5
| | | | | | | | | wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Review URL: http://codereview.chromium.org/159395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix location bar display.thakis@chromium.org2009-07-271-1/+1
| | | | | | | | | BUG=17667 TEST=see bug Review URL: http://codereview.chromium.org/160142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21634 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Change the lower right section to say "What will we put here?"arv@google.com2009-07-272-5/+4
| | | | | | | | | | | | TBR=glen@chromium.org BUG=None Test=None Review URL: http://codereview.chromium.org/159393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21633 0039d316-1c4b-4281-b951-d872f2087c98
* add test to verify mole data being readerikkay@chromium.org2009-07-261-0/+3
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/160148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21632 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the concept of threading from ProxyService, and move it into the ↵ericroman@google.com2009-07-261-9/+29
| | | | | | | | | | | | | | | | | | | | | | | | ProxyResolver dependency. ProxyResolver may now complete requests asynchronously, and is defined to handle multiple requests. The code from ProxyService that queued requests onto the single PAC thread has moved into SingleThreadedProxyResolver. This refactor lays the groundwork for: (1) http://crbug.com/11746 -- Run PAC proxy resolving out of process. (Can inject an IPC bridge implementation of ProxyResolver) (2) http://crbug.com/11079 -- Run PAC proxy resolving on multiple threads. (Can implement a MultithreadedProxyResolver type class; still complications around v8 threadsafety though). BUG=http://crbug.com/11746, http://crbug.com/11079 TEST=existing unit-tests. Review URL: http://codereview.chromium.org/149525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix exception in DownloadManager if the download has no extension.aa@chromium.org2009-07-261-1/+2
| | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/159392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21628 0039d316-1c4b-4281-b951-d872f2087c98
* Modify detection of Chrome extensions in download manager. Itaa@chromium.org2009-07-261-3/+17
| | | | | | | | | | | | | | turns out many servers send the no-sniff option, including the one we use for our sample extensions. So we can't rely on mime types to detect Chrome extensions, at least until we have some place to put our samples that doesn't have this problem. TBR=erikkay Review URL: http://codereview.chromium.org/159391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21627 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r21622: Add infobar preview for themes,aa@chromium.org2009-07-269-40/+174
| | | | | | | | remove --enable-extension requirement. Review URL: http://codereview.chromium.org/159390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21626 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 21622-21624.aa@chromium.org2009-07-269-186/+48
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21625 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken tree.aa@chromium.org2009-07-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21624 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken tree on mac/linux.aa@chromium.org2009-07-263-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21623 0039d316-1c4b-4281-b951-d872f2087c98
* Add infobar preview for themes, remove --enable-extensionaa@chromium.org2009-07-269-48/+186
| | | | | | | requirement. Review URL: http://codereview.chromium.org/160141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21622 0039d316-1c4b-4281-b951-d872f2087c98
* add mole info to toolstrip definition and enable moleserikkay@chromium.org2009-07-2617-98/+242
| | | | | | Review URL: http://codereview.chromium.org/159202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21621 0039d316-1c4b-4281-b951-d872f2087c98
* Make the download manager display a scary file warning if anaa@chromium.org2009-07-253-29/+51
| | | | | | | extensions is not from the gallery. Review URL: http://codereview.chromium.org/159379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21620 0039d316-1c4b-4281-b951-d872f2087c98
* * notify theme loading with --load-extensionerikkay@chromium.org2009-07-251-11/+22
| | | | | | | | * fix crasher in theme parsing with no images Review URL: http://codereview.chromium.org/160124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21619 0039d316-1c4b-4281-b951-d872f2087c98
* Adds strings for possible future web clips on the new tab pagearv@google.com2009-07-251-0/+170
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/160135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21618 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the tips service by default.arv@google.com2009-07-259-17/+38
| | | | | | | | | | | | | Update the UI to not say tips or recommendations. BUG=None TEST=Starting chrome should not show any tips byt default Review URL: http://codereview.chromium.org/160138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21615 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r21548 and r21559 due to crash spike.huanr@chromium.org2009-07-255-18/+22
| | | | | | Review URL: http://codereview.chromium.org/159383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21614 0039d316-1c4b-4281-b951-d872f2087c98
* Implement mimetype sniffing for extensions.aa@chromium.org2009-07-256-6/+47
| | | | | | | | | | | abarth: can you review the changes to mime_sniffer.cc? paul: everything else? BUG=13296 TEST=Added unit tests Review URL: http://codereview.chromium.org/159345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21612 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress crash for Ananta.paul@chromium.org2009-07-251-0/+3
| | | | | | | | | | TEST=None. BUG=17710 (http://crbug.com/17710) Review URL: http://codereview.chromium.org/160136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21609 0039d316-1c4b-4281-b951-d872f2087c98
* , INNTP: Adds 2 hard coded thumbnails.arv@google.com2009-07-255-7/+99
| | | | | | | | | | | | | This code needs to be rewritten after beta to handle localized content. BUG=15079 TEST=Start chrome with a new profile. There should be 2 thumbnails on the new tab page. Review URL: http://codereview.chromium.org/160126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21608 0039d316-1c4b-4281-b951-d872f2087c98
* Add strings for SSL3.0 and TLS1.0 config options for Linux.mattm@chromium.org2009-07-251-0/+6
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/160133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21605 0039d316-1c4b-4281-b951-d872f2087c98
* Stop drawing the status bubble text highlight because it sucks for themes.glen@chromium.org2009-07-251-23/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21604 0039d316-1c4b-4281-b951-d872f2087c98
* Use referrer_url instead of download url to decide whether aaa@chromium.org2009-07-256-18/+53
| | | | | | | theme installation can happens sans-prompt. Review URL: http://codereview.chromium.org/160087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21603 0039d316-1c4b-4281-b951-d872f2087c98
* Make some default file dialog titles for linux.estade@chromium.org2009-07-253-8/+29
| | | | | | | | | | | Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar. BUG=16890 TEST=should be obvious Review URL: http://codereview.chromium.org/159326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21600 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Window modality in TOOLKIT_VIEWS, and allow windows to be centered ↵ben@chromium.org2009-07-251-1/+1
| | | | | | | | | | over their modal parent or the screen if there is no modal parent. This means child windows don't open at 0,0 anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/159335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21599 0039d316-1c4b-4281-b951-d872f2087c98
* Add in UMA logging for context menu playback controls.ajwong@chromium.org2009-07-251-0/+11
| | | | | | | | | BUG=15686 TEST=none Review URL: http://codereview.chromium.org/159371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21598 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21588 to make Linux toolkit dbg happy.mhm@chromium.org2009-07-252-13/+12
| | | | | | | TBR: thiago Review URL: http://codereview.chromium.org/159378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21597 0039d316-1c4b-4281-b951-d872f2087c98
* Partial fix to 7028 - Pinning in Win7.A complete fix will require Gears to ↵brg@chromium.com2009-07-251-0/+6
| | | | | | | | | | set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group. Bug=7028 Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly) Review URL: http://codereview.chromium.org/159336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21593.mhm@chromium.org2009-07-251-3/+2
| | | | | | | TBR=thiago Review URL: http://codereview.chromium.org/159377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21594 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux Toolkit dbg bustage.mhm@chromium.org2009-07-251-2/+3
| | | | | | | | | BUG=None TEST=None TBR=nsylvain Review URL: http://codereview.chromium.org/159375 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21593 0039d316-1c4b-4281-b951-d872f2087c98
* Images for the pre populated thumbnails on the NNTParv@google.com2009-07-244-0/+0
| | | | | | | | | | | | TBR=glen@chromium.org BUG=15079 TEST=none Review URL: http://codereview.chromium.org/160130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21592 0039d316-1c4b-4281-b951-d872f2087c98
* Porting POINT to gfx::Point for automation providermhm@chromium.org2009-07-242-12/+13
| | | | | | | | | | | BUG=None TEST=None Patch by tfarina Original Review: http://codereview.chromium.org/155888 Review URL: http://codereview.chromium.org/160088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21588 0039d316-1c4b-4281-b951-d872f2087c98
* Adding mention of allowing third-party cookies as a way to fix redirect loops.jcampan@chromium.org2009-07-241-1/+1
| | | | | | | | BUG=http://crbug.com/12969 TEST=Open a page with a redirect loop. The error page should mention allowing third-party cookies as a way to fix the problem. Review URL: http://codereview.chromium.org/159145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21587 0039d316-1c4b-4281-b951-d872f2087c98
* Move setlocale() to zygote_main_linux to make sure that it's calledjshin@chromium.org2009-07-242-3/+8
| | | | | | | | | | | | | | before the sandbox is triggered. BUG=16860 (http://crbug.com/16860 ) TEST=Run Chrome with LC_ALL=en_US.UTF-8. 1. Make sure that you don't see any warning about 'setlocale failing'. 2. Upload a file whose name contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The filename field in a form should be populated with the name (rather than empty). Review URL: http://codereview.chromium.org/160112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21586 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 2136 - move image_diff to tools/imagediff, add deps to test_shelldpranke@google.com2009-07-242-376/+0
| | | | | | | | | | | | | | | | | moving image_diff from chrome/tools/test/image_diff to tools/imagediff (not moving to tools/image_diff to avoid some svn unpleasantness with that directory having been created in CL 21366). Also change test_shell.gyp to depend on everything needed to run the layout tests. R=darin@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/159361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21584 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 bugs in extensions autoupdate request parameters.asargent@chromium.org2009-07-242-17/+116
| | | | | | | | | | | | | -Separator that should be between id and version parameters was at the end of version -Missing the "uc" parameter which the gallery server code was expecting as indication of an update check BUG=http://crbug.com/17469 TEST=extensions auto-update should work Review URL: http://codereview.chromium.org/159224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21582 0039d316-1c4b-4281-b951-d872f2087c98
* Implement feature where tabs don't resize when using the close box until the ↵pinkerton@chromium.org2009-07-242-8/+95
| | | | | | | | | | mouse leaves the tab strip. Also turn off zordering fix from before, it regressed things. BUG=14912 TEST=creating a bunch of tabs and making sure that after you close them and mouse away, they return to the correct sizes. Creating new tabs after that should all be the correct size as well. Review URL: http://codereview.chromium.org/160116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21581 0039d316-1c4b-4281-b951-d872f2087c98
* fix toolkit_views compile due to AutocompleteEditViewGtk change.tc@google.com2009-07-241-0/+1
| | | | | | | | | TBR=estade Review URL: http://codereview.chromium.org/159367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21579 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 11:35:30 +0000