summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Re-enable SQL lite preloadjar@chromium.org2009-09-301-3/+1
| | | | | | | | | | | We previously disabled it it to see if it was involved with the double free... but the cause has been shown to be a thread-unsafe reference count (not a party to this change). r=brettw Review URL: http://codereview.chromium.org/246036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27612 0039d316-1c4b-4281-b951-d872f2087c98
* Address review comments.thakis@chromium.org2009-09-303-9/+12
| | | | | | | | | | | Belongs to http://codereview.chromium.org/254002 BUG=none TEST=none Review URL: http://codereview.chromium.org/244044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27609 0039d316-1c4b-4281-b951-d872f2087c98
* BrowsingDataRemover* should not be scoped.kuchhal@chromium.org2009-09-303-9/+14
| | | | | | | | | | | BrowsingDataRemover deletes itself (see browsing_data_remover.cc: MessageLoop::current()->DeleteSoon(FROM_HERE, this)). BUG=22068 Review URL: http://codereview.chromium.org/218001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27607 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where dragging a window that's been closed by JS back into another ↵pinkerton@chromium.org2009-09-305-8/+37
| | | | | | | | | | window would crash. Be more specific about when the window will be closed/deleted during dragging in hopes of making future crashes a little more clear. BUG=none TEST=dragging tabs between windows should work. tabs closed via window.close() on a timer should work. Review URL: http://codereview.chromium.org/246035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27606 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: temorarily disable TestStepOut as it fails on Linuxyurys@google.com2009-09-301-1/+1
| | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/256009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27603 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 220.0 to 220.1laforge@chromium.org2009-09-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27602 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add tests for step over/out/inyurys@google.com2009-09-303-0/+58
| | | | | | Review URL: http://codereview.chromium.org/248040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27600 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate browser actions with the wrench menu. Browseraa@chromium.org2009-09-3019-30/+258
| | | | | | | | | | | | actions always show up in a submenu of the wrench menu, and if they have an icon, they also show up in the toolbar area. BUG=23380,22883 TEST=Added new automated tests for the command handling, but we need to test that the menu items show up manually. To do that, run with no extension installed, you should see "extensions" in the wrench menu. Add an extension that adds a browser action, you should now see an "extensions" submenu with "manage extensions" and the browser action(s) in the submenu. Review URL: http://codereview.chromium.org/246037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27599 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix AutocompleteEditViewTest failures on buildbot (issue 23213).suzhe@chromium.org2009-09-301-14/+15
| | | | | | | | | | | The failures must be caused by timing issue. This CL tries to fix the issue by initializing all necessary components before running tests. BUG=23213 AutocompleteEditViewTest tests are failing TEST=none Review URL: http://codereview.chromium.org/242047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27597 0039d316-1c4b-4281-b951-d872f2087c98
* Update text to more clearly explain our cookie setting. As requested by ↵abarth@chromium.org2009-09-302-3/+3
| | | | | | | | Fiona Chong. Review URL: http://codereview.chromium.org/243041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27596 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:mbelshe@google.com2009-09-302-0/+14
| | | | | | | | | | | | | | | Implement a readsize throttle within the TCP socket. Add a fieldgroup trial for testing it. BUG=none TEST=none Original Review URL: http://codereview.chromium.org/173259 Review URL: http://codereview.chromium.org/243038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27595 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27389.darin@chromium.org2009-09-3018-87/+48
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize all member variables in the constructor.jhawkins@chromium.org2009-09-301-1/+6
| | | | | | | | | CID=4839 BUG=none TEST=none Review URL: http://codereview.chromium.org/242064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27593 0039d316-1c4b-4281-b951-d872f2087c98
* Add bug 23411 to known crash list.huanr@chromium.org2009-09-301-0/+4
| | | | | | | | | BUG=23411 TEST=None Review URL: http://codereview.chromium.org/246045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27592 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r27589 that broke the treehclam@chromium.org2009-09-302-5/+0
| | | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/246043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27590 0039d316-1c4b-4281-b951-d872f2087c98
* <video> use cache if --enable-byte-range-support is presenthclam@chromium.org2009-09-302-0/+5
| | | | | | | | | | | BUG=16013 TEST=Playing a video should still work with the flag in incognito mode or not. Allow <video> to use cache if running with experimental byte range support. Review URL: http://codereview.chromium.org/253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27589 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WorkerTest.WorkerFastLayoutTests.huanr@chromium.org2009-09-301-1/+3
| | | | | | | | | BUG=23391 TEST=None Review URL: http://codereview.chromium.org/255014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27579 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make InfoBubble use an override-redirect (popup) window.derat@chromium.org2009-09-308-98/+162
| | | | | | | | | | | | | This makes it work correctly in ion3 and other window managers that don't expect clients to try to move top-level windows themselves. This implementation grabs the pointer and keyboard. By doing this and using an override-redirect window, we should be able to avoid worrying about interactions with different window managers. The only downside (alluded to in the previous code) is that window manager keybindings don't make it through until the user dismisses the bubble by clicking outside of it or hitting Enter or Escape. I don't think this will be a problem; it's no different from what happens when you open a context menu in an app. BUG=20523 TEST=tested first-run and bookmark bubbles in Metacity, ion3, Fluxbox, KDE4, and the WM that I'm working on Review URL: http://codereview.chromium.org/198016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27578 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the syncapi stub.nick@chromium.org2009-09-302-341/+15
| | | | | | | | | | This was only needed so that we could compile the sync glue code without access to a syncapi binary. Now that syncapi can be built from source, it's obsolete. Review URL: http://codereview.chromium.org/242060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27577 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 219.9 to 220.0laforge@chromium.org2009-09-301-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27573 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use a calculated border color in chrome theme mode instead of blue.erg@google.com2009-09-295-42/+26
| | | | | | Review URL: http://codereview.chromium.org/255012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27565 0039d316-1c4b-4281-b951-d872f2087c98
* WebView::DownloadImage refactoredyaar@chromium.org2009-09-292-10/+51
| | | | | | | | | The implementation was dependent on webkit_glue::image_resource_fetcher and had to be removed if we want to upstream WebView. DownloadImage has been moved into RenderView::DownloadImage. WebViewImpl's set of ImageResourceFetchers has been ripped off and moved into RenderView. Review URL: http://codereview.chromium.org/255006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27564 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). jcampan@chromium.org2009-09-2910-25/+24
| | | | | | | | | | | | | | | Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. See original review: http://codereview.chromium.org/235011/show BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. TBR=ben Review URL: http://codereview.chromium.org/246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
* The RSS extension now renders the RSS HTML preview inside an IFRAME.finnur@chromium.org2009-09-295-85/+148
| | | | | | | | | BUG=None TEST=See browser tests. Review URL: http://codereview.chromium.org/242055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27562 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize stats_table_ in the constructor.jhawkins@chromium.org2009-09-291-3/+5
| | | | | | | | | CID=1648 BUG=none TEST=none Review URL: http://codereview.chromium.org/251037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27561 0039d316-1c4b-4281-b951-d872f2087c98
* Use a helper to facilitate reading a file on a background thread.darin@chromium.org2009-09-296-38/+190
| | | | | | | | | | | | | | | | This fixes a thread-safety bug in ExecuteCodeInTabFunction caused by using RefCounted instead of RefCountedThreadSafe. Instead of changing ExecuteCodeInTabFunction to be RefCountedThreadSafe, I thought it would be better to fork off a helper class. R=aa BUG=none TEST=file_reader_unittest.cc and existing browser_tests (once my other patch lands which adds thread-safety assertions to NewRunnableMethod) Review URL: http://codereview.chromium.org/243033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27559 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize has_indexed_affixes_ in the constructor.jhawkins@chromium.org2009-09-291-1/+2
| | | | | | | | | CID=1635 BUG=none TEST=none Review URL: http://codereview.chromium.org/249036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27557 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some code in the render_view_host_manager unittest.brg@chromium.com2009-09-291-4/+3
| | | | | | | | | | The initialization of the ProfileSyncService was being called twice in one test. Test=RenderViewHostManagerTest in unittests Bug=none Review URL: http://codereview.chromium.org/248036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27556 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the os_event struct members to 0 in the constructor.jhawkins@chromium.org2009-09-291-0/+1
| | | | | | | | | CID=1642 BUG=none TEST=none Review URL: http://codereview.chromium.org/255013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27554 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when using about:ipc with only NTP on Windows.jrg@chromium.org2009-09-291-2/+3
| | | | | | | | Must check iterator's Done() before dereferencing (list may be empty). Review URL: http://codereview.chromium.org/243040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27552 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.8 to 219.9laforge@chromium.org2009-09-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27551 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix a bookmark dragging crasher by initing a member var.estade@chromium.org2009-09-291-0/+1
| | | | | | | | | | | Not sure when this regressed. Looking at the svn history I can't even find a revision where it would have worked. We probably made some other change that revealed this long-standing bug. BUG=23233 TEST=drag a bookmark out of a bookmark bar folder Review URL: http://codereview.chromium.org/255011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27550 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove an unused variable.jhawkins@chromium.org2009-09-291-2/+1
| | | | | | | | | CID=1650 BUG=none TEST=none Review URL: http://codereview.chromium.org/251036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27549 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize type_ in the constructor.jhawkins@chromium.org2009-09-291-1/+2
| | | | | | | | | CID=2287 BUG=none TEST=none Review URL: http://codereview.chromium.org/242065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27548 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Add the typedef keyword to the ProfileType enum so we're not ↵jhawkins@chromium.org2009-09-291-1/+1
| | | | | | | | | | | creating an instance of the enum. CID=5718 BUG=none TEST=none Review URL: http://codereview.chromium.org/249035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27547 0039d316-1c4b-4281-b951-d872f2087c98
* These classes need to use thread safe reference counting.darin@chromium.org2009-09-291-2/+2
| | | | | | | | | | | | | Detected using this CL: http://codereview.chromium.org/251012 R=jcampan BUG=none TEST=covered by browser tests once my assertion to NewRunnableMethod lands. Review URL: http://codereview.chromium.org/251033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27544 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakpad unused variable warning.thestig@chromium.org2009-09-291-9/+7
| | | | | | | | | BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/251035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27541 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27520.mirandac@chromium.org2009-09-292-121/+61
| | | | | | Review URL: http://codereview.chromium.org/256003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27540 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize test_funcs_.test_make_request in the constructor.jhawkins@chromium.org2009-09-291-0/+1
| | | | | | | | | CID=5447 BUG=none TEST=none Review URL: http://codereview.chromium.org/243037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27538 0039d316-1c4b-4281-b951-d872f2087c98
* Update known crash signature.huanr@chromium.org2009-09-291-0/+1
| | | | | | Review URL: http://codereview.chromium.org/256002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27536 0039d316-1c4b-4281-b951-d872f2087c98
* Use a separate Breakpad product name for ChromeOS.thestig@chromium.org2009-09-291-0/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/251032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27535 0039d316-1c4b-4281-b951-d872f2087c98
* Use Mac fonts in Mac Chrome.mark@chromium.org2009-09-292-52/+113
| | | | | | | | | | | | | | | Use Helvetica, Times, Courier, Apple Chancery, and Papyrus for sans-serif, serif, monospace, cursive, and fantasy, respectively. These are the fonts used by Safari and Firefox on the Mac, and the fonts that we run layout tests with on the Mac. BUG=19135 21458 TEST=http://www.w3.org/Style/Examples/007/fonts Check the fonts for sans-serif, serif, monospace, cursive, fantasy Note that the font used for "Helvetica, sans-serif" is actually Verdana Review URL: http://codereview.chromium.org/244039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27533 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Raise window after click on titlebar or border.derat@chromium.org2009-09-291-0/+5
| | | | | | | | | BUG=23318 TEST=checked that it matches native window behavior in metacity and kwin Review URL: http://codereview.chromium.org/246029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27531 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: tickle the render sandbox early so it forks at the right time"evan@chromium.org2009-09-291-4/+0
| | | | | | This reverts the previous commit (compile failure). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27530 0039d316-1c4b-4281-b951-d872f2087c98
* linux: tickle the render sandbox early so it forks at the right timeevan@chromium.org2009-09-291-0/+4
| | | | | | | | | Otherwise, the first time the singleton is touched we've already started loading a page! We surely have a bunch of threads going at that point. Review URL: http://codereview.chromium.org/245039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27528 0039d316-1c4b-4281-b951-d872f2087c98
* Import dialog fixup:thomasvl@chromium.org2009-09-292-68/+158
| | | | | | | | | | | | | | | - use one call string convert - load the nib from the main bundle - make the cancel button autosize to it's string - make the cancel button tweak it's position based on the string (not dialog position, but keep the right edge as is) - fix up some field overlaps, and position, dialog still isn't pretty, but this is how Cole said to leave it rather then reopen the discussion now. - use the WithFixup helpers to deal with ellipses TEST=button fits text, fields don't overlap any strings. BUG=20534 Review URL: http://codereview.chromium.org/235055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27526 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize got_thumbnail_callback_, query_url_success_, and ↵jhawkins@chromium.org2009-09-291-2/+7
| | | | | | | | | | | redirect_query_success_ in the constructor. CID=1653 BUG=none TEST=none Review URL: http://codereview.chromium.org/251031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27525 0039d316-1c4b-4281-b951-d872f2087c98
* This CL cleans-up the FindBarHost and fixes an assert that happens on the ↵jcampan@chromium.org2009-09-294-63/+11
| | | | | | | | | | | | | | | focus manager when closing Chrome (linux toolkit views). See original review at: http://codereview.chromium.org/220036/show BUG=None TEST=Make sure find works as expected on Chrome Linux toolkit views. TBR=ben Review URL: http://codereview.chromium.org/243035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27524 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix memleak in GetNodeDictionary again.mattm@chromium.org2009-09-291-3/+2
| | | | | | | | | | CID=4804 BUG=none TEST=none Review URL: http://codereview.chromium.org/246025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27523 0039d316-1c4b-4281-b951-d872f2087c98
* Unflakify SyncerThreadWithSyncerTest.Polling by using TimeTicks instead of ↵tim@chromium.org2009-09-291-15/+7
| | | | | | | | | | | system time. Should have done that first, but I had started writing the test before writing the code and learning how to use TimeTicks. TEST=SyncerThreadWithSyncerTest.Polling BUG=23336 Review URL: http://codereview.chromium.org/248034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27522 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 22:38:00 +0000