summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Changes closed windows on the new tab page to show the Chromium/Chromesky@chromium.org2009-04-235-10/+37
| | | | | | | | | | | | | | icon and the text to show the number of closed windows. BUG=9022 TEST=With more than one window open close a window. Go to the new tab page and make sure you see an entry for the closed window. The entry should have the chrome/chromium logo and instead of 'Window' it should say the number of tabs in the window. Review URL: http://codereview.chromium.org/92022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14309 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor index value capture outside of DCHECK to fix build failure in release.rafaelw@chromium.org2009-04-231-2/+2
| | | | | | Review URL: http://codereview.chromium.org/93060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14305 0039d316-1c4b-4281-b951-d872f2087c98
* Allow appkit-driven animations in unit tests to work correctly.pinkerton@chromium.org2009-04-232-4/+5
| | | | | | Review URL: http://codereview.chromium.org/95003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14301 0039d316-1c4b-4281-b951-d872f2087c98
* Merge: chromium side [42671:42725]levin@chromium.org2009-04-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Rebaselines: http://trac.webkit.org/changeset/42722 resulted in LayoutTests/editing/inserting/insert-3907422-fix.html LayoutTests/editing/pasteboard/paste-text-015.html LayoutTests/editing/style/font-family-with-space.html http://trac.webkit.org/changeset/42723 resulted in LayoutTests/editing/selection/select-all-iframe.html LayoutTests/svg/custom/pointer-events-path.svg http://trac.webkit.org/changeset/42716 resulted in LayoutTests/fast/dom/HTMLSelectElement/named-options.html http://trac.webkit.org/changeset/42725 Broke the close event behavior and resulted in disabling these ui tests: * BrowserCloseBeforeUnloadOK and * BrowserCloseBeforeUnloadCancel Review URL: http://codereview.chromium.org/92051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14291 0039d316-1c4b-4281-b951-d872f2087c98
* In the new tab page, when in edit move, right-clicking on a thumbnail should ↵jcampan@chromium.org2009-04-231-2/+4
| | | | | | | | | | not trigger its deletion. BUG=10527 TEST=Open the New Tab Page. Click the "Remove thumbnails" link to enter edit mode. Right-click on a thumbnail. The context menu should be displayed and the thumbnail should not be removed. Review URL: http://codereview.chromium.org/92018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14290 0039d316-1c4b-4281-b951-d872f2087c98
* Browser Crash when opening urls with NEW_BACKGROUND_TAB dispositionhbono@chromium.org2009-04-231-3/+3
| | | | | | | | | | | | | | | | | | | When that disposition is used and no "normal" window is opened, it crashes. "normal" means non POPUP, non APPLICATION window type. This happens because background disposition doens't focus or activate the window unless selected. A crash happens because GetSelectedTabContents() is null since nothing initially there. This fix might have stopped it crash, but would be best to see if its a "good" approach. I fixed some lints such as, header file already exists, extra white space, etc) BUG=10591 ( http://crbug.com/10591 ) Original patch by Mohamed Mansour (see http://codereview.chromium.org/67205/show), r=me,pkasting Review URL: http://codereview.chromium.org/93058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14288 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a keyboard-event test into RenderViewTest.hbono@chromium.org2009-04-232-0/+181
| | | | | | | | | | | | | | This change adds a new test "RenderViewTest.OnHandleKeyboardEvent" to verify we can receive proper DOM events when we send platform-specific keyboard events. This test is mainly for verifying our WebKit-glue code can convert platform-specific keyboard events to keyboard events of WebKit without any problems, which is hard to implement with LayoutTests. To emulate non-US layouts, this test loads the following keyboard-layout drivers: * Arabic (qwerty); * United States (qwerty); * French (azerty); * Hebrew, and; * Canadian French (qwerty). Review URL: http://codereview.chromium.org/75034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14287 0039d316-1c4b-4281-b951-d872f2087c98
* Move the positioner code into autocompletepopupview.h so that linux can use ↵ben@chromium.org2009-04-232-11/+13
| | | | | | | | it too. Review URL: http://codereview.chromium.org/87007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14284 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with bookmark bar introduced by window sharing; prefjrg@chromium.org2009-04-2318-179/+258
| | | | | | | | | | | | change needs to change all open windows with the same preferences, not just the current one). Improve unit testing. Limit bookmark menu size width (1st pass). Cleanup/delete of code which no longer does much. Review URL: http://codereview.chromium.org/79068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14282 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of http://codereview.chromium.org/87058 which appears to hang the XP ↵robertshield@google.com2009-04-232-27/+15
| | | | | | | | | | | | | Tests. Log of hanging tests: http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/1246/steps/unit_tests/logs/stdio TBR=http://codereview.chromium.org/92055 Review URL: http://codereview.chromium.org/92055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14281 0039d316-1c4b-4281-b951-d872f2087c98
* Some random cleanups in the HTML files.arv@chromium.org2009-04-2313-376/+351
| | | | | | | | | | | | | | | Use HTML5 placeholder instead of js code for the text input place holders. Use HTML5 doctype in all html files. Skip optional type in script and style tags. Some small optimizations in LocalStrings. Review URL: http://codereview.chromium.org/88072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14278 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the width and the height of options dialog (Tamil) and jungshik@google.com2009-04-234-17/+17
| | | | | | | | | | | | first-run dialog (ta,kn,te,ml) BUG=10687 Review URL: http://codereview.chromium.org/88017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14277 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow the browser window to be resized so small that layout starts ↵pkasting@chromium.org2009-04-2312-68/+201
| | | | | | | | breaking horribly. When it _is_ small, draw the frame correctly.This is an incomplete fix; only non-Aero main/popup/app windows are handled so far, but this was becoming hairy enough I wanted to checkpoint it.BUG=9885 Review URL: http://codereview.chromium.org/88069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14276 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send resize messages until the renderer has been initialized.evan@chromium.org2009-04-2213-43/+22
| | | | | | | | | | | | | | | | [Retry of 14260 with fixed unit test.] 1) Moves renderer_initialized_ from RenderWidgetView into RenderWidgetHost (its parent). Should be identical semantics to before. 2) Test renderer_initialized_ in RWH::WasResized(). This also reverts r13725, which was another attempt at fixing this problem. BUG=9830,10659 TEST=From the Linux start page, click a link then click back -- should not get a gray page. From Google reader, click a link (which spawns a new tab within the same process) -- should not get a gray page. Review URL: http://codereview.chromium.org/93038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14273 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in interactive ui tests that appears to only happen onsky@chromium.org2009-04-222-6/+10
| | | | | | | | | | | | | | vista. I believe the bug happens because we're in a nested loop with a Dispatcher, so that even though we're posting two quits, they both end up quitting the same loop. Posting a WM_USER event between these two tickles exitting out of the nested loop, then quitting the outer loop. BUG=none TEST=none Review URL: http://codereview.chromium.org/93049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14272 0039d316-1c4b-4281-b951-d872f2087c98
* Hide the exit bubble when the main window is inactivated, and don't re-show ↵pkasting@chromium.org2009-04-221-2/+7
| | | | | | | | | until it's reactivated. BUG=8945 Review URL: http://codereview.chromium.org/93048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14270 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Don't send resize messages until the renderer has been initialized."evan@chromium.org2009-04-2212-21/+43
| | | | | | This reverts commit r14260. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14267 0039d316-1c4b-4281-b951-d872f2087c98
* Fix focus rects for checkboxes and radio buttons:ben@chromium.org2009-04-2211-47/+89
| | | | | | | | | | | | | | | | | | | | | | | - add concept of default insets to view which get added to any other insets provided by the user. used by label to provide room for a focus border. - provide the ability for the label to paint its focus border even if it isn't focused. needed because the outer container (the checkbox) gets focus but the inner label does not, however the label knows best the location of its text around which the focus border must be drawn. please note: - also make it easier to click checkboxes by not resetting mouse_pressed_handler_ in RootView when a view decides it doesn't want to handle a drag. this is so we can still receive mousereleased notifications when the mouse is released... it's "difficult" to click checkboxes and radio buttons when you accidentally drag a little on their label. (this is the root view change). - fix slight alignment issue on the general page of options. Also fix a slight error in my last radio checkbox - clicking on a checked radio button should still focus it. http://crbug.com/10834 TEST=visit options, Minor Tweaks. click the "always ask before downloading" checkbox and observe that the focus rect tightly surrounds the text label instead of stretching to the right side of the dialog. Visit options, click an already-checked radio button. observe that it takes focus. Visit options, click on any checkbox or radio button, drag slightly then release (still within the bounds of the item). note the item is now toggled or selected. click down then drag out and release, note that it is not toggled or selected. Review URL: http://codereview.chromium.org/92004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14265 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ExtensionView to properly set the size of the RenderWidgetHostView. ↵erikkay@google.com2009-04-222-15/+27
| | | | | | | | Without this, GetClientRect would return a size of 0,0 for the view, which would prevent the tooltip machinery from working properly. Review URL: http://codereview.chromium.org/87058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14264 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send resize messages until the renderer has been initialized.evan@chromium.org2009-04-2212-43/+21
| | | | | | | | | | | | | | | | 1) Moves renderer_initialized_ from RenderWidgetView into RenderWidgetHost (its parent). Should be identical semantics to before. 2) Test renderer_initialized_ in RWH::WasResized(). This also reverts r13725, which was another attempt at fixing this problem. BUG=9830,10659 TEST=From the Linux start page, click a link then click back -- should not get a gray page. From Google reader, click a link (which spawns a new tab within the same process) -- should not get a gray page. Review URL: http://codereview.chromium.org/93038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14260 0039d316-1c4b-4281-b951-d872f2087c98
* Add pref_service_unittest.cc on Mac.shess@chromium.org2009-04-222-5/+0
| | | | | | | | | Needed to remove the anonymous namespace because Mac's gcc complains about friend trying to poke through anonymous namespaces. Review URL: http://codereview.chromium.org/93043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14259 0039d316-1c4b-4281-b951-d872f2087c98
* Always enable copy-link-address in context menu.brettw@chromium.org2009-04-224-2/+9
| | | | | | | | | | | | | | Added a new field into ContextMenuParam only for this purpose. The new field won't be validated in frontend processes. In this way, even if renderer processes are going to mad, the frontend would be OK if the frontend uses this new field only for copying into the clipboard. Fix checked in for Shinichiro Hamaji Original code review: http://codereview.chromium.org/91002 BUG=2725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14256 0039d316-1c4b-4281-b951-d872f2087c98
* implement remaining tab events (except for onTabUpdated).rafaelw@chromium.org2009-04-225-15/+187
| | | | | | Review URL: http://codereview.chromium.org/88053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14255 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delete the DOM UI property for the callback when the DOM UI is torn down.brettw@chromium.org2009-04-221-2/+8
| | | | | | | | | | With my ownership changes, the TabContents owns the RVHManager which owns the DOMUI. This means that the DOM UI is deleted from ~TabContents and it will crash during destruction if we access the TabContents to delete the property. Review URL: http://codereview.chromium.org/92042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14253 0039d316-1c4b-4281-b951-d872f2087c98
* Run user_script_master_unittest.cc on Mac.shess@chromium.org2009-04-222-5/+8
| | | | | | | | | | | | | | | | Removed anonymous namespace, Mac's gcc won't allow friend to reach into anonymous namespaces. Noticed that UserScriptMasterTest.NoScripts hanged it DirectoryWatcher was not implemented. Added a timeout event so that now it fails slowly. Then I disabled that test for non-Windows. Other tests pass, lets get those in the system! Review URL: http://codereview.chromium.org/88075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14252 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest gardening.shess@chromium.org2009-04-221-2/+1
| | | | | | | | | | | | Enable extension_messages_unittest.cc for Mac and Linux. Had been added for Windows, but not to chrome.gyp. Drop extension_content_script_inject_unittest.cc because it no longer exists. Review URL: http://codereview.chromium.org/87070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14251 0039d316-1c4b-4281-b951-d872f2087c98
* Last chunk of OS X Breakpad integration:jeremy@chromium.org2009-04-225-74/+119
| | | | | | | | | | * Link agasint Breakpad from public svn repo. * Bump DEPS to new svn rev of Breakpad with fixes for 10.5 compilation. * Fill in code to differentiate between processes types in crash report. Review URL: http://codereview.chromium.org/88043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14245 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an assert caused by trying to add duplicate observers for multiple workers.jianli@chromium.org2009-04-221-11/+5
| | | | | | Review URL: http://codereview.chromium.org/87072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14243 0039d316-1c4b-4281-b951-d872f2087c98
* Weaken is_active check more, since it appears that Chromium can switch to andpam@chromium.org2009-04-221-19/+8
| | | | | | | | | | | | | | from being the frontmost app during the course of a ui_tests run. This way errors will show up in more carefully controlled local tests, but won't turn the bots red. BUG=5278 TEST=make sure TabRestoreUiTest.* don't fail due to is_active being false Review URL: http://codereview.chromium.org/92038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14242 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak build.estade@chromium.org2009-04-221-1/+3
| | | | | | | | TBR=pinkerton Review URL: http://codereview.chromium.org/93037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14241 0039d316-1c4b-4281-b951-d872f2087c98
* Enable more tests, change a NOTREACHED to a bug since it's not fatal in the ↵pinkerton@chromium.org2009-04-226-15/+13
| | | | | | | | download code. Get other tests compiling even if disabled. Mark why tests are failing in gyp file. Review URL: http://codereview.chromium.org/92033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14239 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid DCHECK in nine box during download shelf animation.estade@chromium.org2009-04-222-4/+9
| | | | | | | | | That DCHECK might be a little overzealous, but is probably useful for most situations, so I'm leaving it. TBR=tony Review URL: http://codereview.chromium.org/92036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14237 0039d316-1c4b-4281-b951-d872f2087c98
* Restore closed tabs into new windows when necessary, and track the windows theypam@chromium.org2009-04-227-128/+306
| | | | | | | | | | | | | | | | | | | came from so they're restored together (into the same new window) when appropriate. Fix safety check on tab index when restoring: make it check the correct browser. Change some ASSERTs to EXPECTs in the unit test for greater coverage. BUG=5278 TEST=Open a window with two tabs, close both (closing the window), then restore both. Make sure both restored tabs are in the same window. Open a window with multiple tabs, close a tab, then close the window using its close box. Restore both and make sure the tab goes back into the window. Review URL: http://codereview.chromium.org/92001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14234 0039d316-1c4b-4281-b951-d872f2087c98
* Move all data members from WebContents to TabContents in preparation forbrettw@chromium.org2009-04-224-232/+287
| | | | | | | | | | | | | | | merging the two. This is extremely straightforward except for the GearsCreateShortcutCallbackFunctor which I had to move to the header (with a TODO and its associated function OnGearsCreateShortcutDone) and some of the constructors for the members which took a WebContents that I had to cast. I tried to reorganize the data to have some kind of groupings. I made the member initializers all explicit for TabContents because the extreme number of them makes them difficult to keep track of. Review URL: http://codereview.chromium.org/88021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14230 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused implementation of TabContentsDelegate in HtmlDialogView.stoyan@chromium.org2009-04-223-108/+3
| | | | | | Review URL: http://codereview.chromium.org/87031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14227 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 176.0 to 177.0laforge@chromium.org2009-04-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14225 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a debugging change that was accidentally added to r14123.jhawkins@chromium.org2009-04-221-1/+0
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/88045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14222 0039d316-1c4b-4281-b951-d872f2087c98
* Enable some ui tests that were already ported, but weren't enabled at the ↵estade@chromium.org2009-04-221-2/+2
| | | | | | | | time because they didn't pass. Review URL: http://codereview.chromium.org/88056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14221 0039d316-1c4b-4281-b951-d872f2087c98
* Add new item animation to download shelf.estade@chromium.org2009-04-226-15/+60
| | | | | | | | Also, fix duration and tween type for download shelf open animation. Review URL: http://codereview.chromium.org/88064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14220 0039d316-1c4b-4281-b951-d872f2087c98
* The test_worker.vsprops file had wrong link to another vsprop file. dimich@google.com2009-04-229-583/+1
| | | | | | Review URL: http://codereview.chromium.org/93028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14214 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DIR_SOURCE_ROOT to work in bundles like Chromium.app. Add more ui tests. ↵pinkerton@chromium.org2009-04-2211-15/+74
| | | | | | | | Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel). Review URL: http://codereview.chromium.org/93025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14212 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak the RenderProcessHost when running site instance unit tests bybrettw@chromium.org2009-04-221-0/+4
| | | | | | | | | flusing the message queue (containing the delete message). BUG=10782 Review URL: http://codereview.chromium.org/92023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14208 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move X operations from the IO to UI2 thread.agl@chromium.org2009-04-2213-93/+305
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (r14075 take two) Currently we perform several X operations on the IO thread including geometry and clipboard work. This is causing races inside Xlib and crashing the browser. These are the result of synchronous calls from the renderer, so we cannot route these requests to the UI thread without risking deadlock. Thus we introduce the UI2 thread. This thread has a second connection to the X server and can perform X operations safely the without UI thread. Work remains to be done: Since we still have the hack where we pass GtkWidget pointers into the renderer and back, we still have to access these structures from the IO and UI2 threads. This still needs to be fixed, but this is not the patch for it. Also, not all the X calls from the IO thread have been moved over in this patch; just a few small ones. http://codereview.chromium.org/67145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14206 0039d316-1c4b-4281-b951-d872f2087c98
* Add Australian English spell check support.sidchat@google.com2009-04-224-1/+46838
| | | | | | | Issue=8934 Review URL: http://codereview.chromium.org/89006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14204 0039d316-1c4b-4281-b951-d872f2087c98
* Properly construct shell filters (forgetting the asterisk means it works but ↵avi@chromium.org2009-04-223-4/+4
| | | | | | | | | | doesn't show existing files). BUG=10734 Review URL: http://codereview.chromium.org/93019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14202 0039d316-1c4b-4281-b951-d872f2087c98
* Add tcalloc-related crashes to known crashers list.dglazkov@google.com2009-04-221-0/+4
| | | | | | | | BUG=10843 TBR=mbelshe git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14200 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "try enabling installer tests again."kuchhal@chromium.org2009-04-222-3/+3
| | | | | | | | | This reverts commit 8269e3cc8929f8348d0ed1ec13cb69f90cc928f6. Review URL: http://codereview.chromium.org/93020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14190 0039d316-1c4b-4281-b951-d872f2087c98
* try enabling installer tests again.kuchhal@chromium.org2009-04-222-3/+3
| | | | | | | Review URL: http://codereview.chromium.org/92016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14189 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/87034apavlov@chromium.org2009-04-2212-79/+89
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14187 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Run nested message loop instead of whitelisting the messages.pfeldman@chromium.org2009-04-227-103/+42
| | | | | | Review URL: http://codereview.chromium.org/90007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14183 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 11:09:13 +0000