| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/3061034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ahendrickson
TEST=compile?
BUG=48913
Review URL: http://codereview.chromium.org/3027035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix favicons in task manager.
BUG=32148
TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block.
Review URL: http://codereview.chromium.org/3029041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate all interactions with HistoryService out of DownloadManager
to new class DownloadHistory owned by the DownloadManager.
The goal is to create more smaller classes with clearly defined
responsibilities.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3071005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unrelated file.
BUG=none
TEST=Test passes
Review URL: http://codereview.chromium.org/3029038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to net/test/test_server.h
No code changes, just a move.
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/3034038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4485
TEST=unit tests
Review URL: http://codereview.chromium.org/3058021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it still compiles
BUG=none
Review URL: http://codereview.chromium.org/3020027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Toolbar.xib changes:
- buttons from 31x27 to 29x29 so that the visual is 27x27.
- shift things left to take up opened space.
- omnibox to 29 pixels tall.
- wrench also to 29x29.
- all of that raised a single pixel to recenter.
- swap positions of home and reload.
Modify home-button-adjustment code to reflect rearranged
home/reload positions.
Increase Omnibox font size by one point to match increased field
height (and Windows Omnibox). Revise various font clients to
recognize this. Shift Omnibox baseline and other measurements to
account for increased height.
Shift globe/search icon in by one pixel so icons on both sides of
Omnibox are 4px from border. Matching shift in popup.
Fix EV-bubble to use appropriate green for text, rather than black.
Push out bubble to have a single-pixel space WRT Omnibox border.
Tighten corners to tuck into Omnibox corners. Handle different
lhs padding versus location icon (image should end up in same
spot, even though the bubble draws outside the image).
BUG=50575
TEST=none
Review URL: http://codereview.chromium.org/3046029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are calculated. Handle edge case where the top scroll arrow is not showing. Proposed window height was not taking into account the one additional vertical separation.
BUG=46101
TEST=Setup: Create a bookmark folder on the bookmark bar with plenty of bookmarks, more than enough to fill the screen, and so that it is scrollable. 1) Bring up the bookmark folder menu but do not cause it to scroll. 2) Using the contextual menu delete a bookmark midway in the menu. 3) Verify that the top of the menu window and contents do not move relative to the bookmark bar folder button. 4) Bring up the bookmark folder menu again. 5) Cause the menu to scroll up to fill the screen and then scroll it down so that the top scroll arrow is not showing. 6) Using the contextual menu delete a bookmark midway in the menu. 7) Verify that the top of the menu window and contents have not moved in relation to the screen top. 8) Bring up the bookmark folder menu and cause it to scroll such that both the top and bottom scroll arrows are showing. 9) Using the contextual menu, delete a bookmark midway in the menu. 10) Verify that the top scroll arrow, the top-most item showing in the menu, and the menu window have not changed position relative to the top of the window. Note that the contents of the folder menu below the bookmark item being delete should adjust upward to fill the slot originally occupied by the deleted bookmark.
Review URL: http://codereview.chromium.org/3050021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50573
TEST=none
Review URL: http://codereview.chromium.org/2868082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50378
TEST=none
Review URL: http://codereview.chromium.org/3018026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=DOMUI Under the Hood options still display correctly.
Review URL: http://codereview.chromium.org/3017039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50669
TEST=none
Review URL: http://codereview.chromium.org/3013043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a leak in test Init reported by valgrind. The problem was that the test called a rogue init, which didn't cause the window to be shown, and hence -close didn't send a -windowWillClose: notification. Also restore -windowWillClose:, it accidentally got deleted in http://codereview.chromium.org/536086
BUG=32148,30398
TEST=Click a column in the task manager. Should sort.
Review URL: http://codereview.chromium.org/2873075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In short, this:
* Eliminates the divider on the right (the new chevron has a built-in divider)
* Changes the padding between items (see updated comments in header for precise layout details)
* Updates the imagery for the new theme
* Makes the chevron respond to theme changes
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3057016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
leak on the build bots when PulseAudio was initialized on a separate worker thread. This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread. For some reason, the init finishes cleanly on one thread, but not the other.
BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141)
TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures.
Review URL: http://codereview.chromium.org/3026028
TBR=davej@chromium.org
Review URL: http://codereview.chromium.org/3013042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
is not being built on the buildbots. Adding osmesa target dependency may fix it.
BUG=46662
Review URL: http://codereview.chromium.org/3031028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=this is it
BUG=none
Review URL: http://codereview.chromium.org/3079006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3020041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Verifies the multiple downloads infobar.
Implemented by Venkat, who figured out how to reliably trigger the multiple
downloads infobar.
Review URL: http://codereview.chromium.org/3066017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise.
Review URL: http://codereview.chromium.org/3032038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
branded builds).
BUG=50471
TEST=PreferencesWindowController.SwitchToPage should not crash in official builds.
Review URL: http://codereview.chromium.org/2836073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2873074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data.
BUG=http://crbug.com/50081
TEST=as in bug
Review URL: http://codereview.chromium.org/3031030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
labels.
Changes suggestions for forms with billing information to show derived labels based on contents of suggestions, not the labels stored in the matched profiles. Also, the suggestion logic has been updated to properly take account of the billing "relation" in the credit card info. Credit card only suggestions now use derived labels as well.
BUG=50261
TEST=AutoFillManagerTest.GetBillingSuggestionsAddress1, AutoFillManagerTest.GetCreditCardSuggestions*
Review URL: http://codereview.chromium.org/3067016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=estade
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3056030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
They don't work locally for me, and on the bots only Mac_Sandbox_Intentional_Leak3 is getting used, which is overly wide.
Review URL: http://codereview.chromium.org/2808079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Directly include base/string_util.h, which was removed in r53969 from the indirectly included base/command_line.h
BUG=none
TEST=Mac official builder goes green.
Review URL: http://codereview.chromium.org/3032037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50648
TEST=none
Review URL: http://codereview.chromium.org/3073009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux/Windows.
- Omit Network and SSL sections for ChromeOS.
BUG=49038
TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/2847061
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/2884047
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/3023026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Omit Network and SSL sections for ChromeOS.
BUG=49038
TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/2847061
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/2884047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=xiyuan
Review URL: http://codereview.chromium.org/3077011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5028
TEST=Verify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only.
Review URL: http://codereview.chromium.org/2868067
TBR=xiyuan@chromium.org
Review URL: http://codereview.chromium.org/3074010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes breakage on the ARM buildbot, introduced by r54113.
nacl::Close() is not available when DISABLE_NACL is set.
The error was:
nacl_process_host.cc: error: undefined reference to 'nacl::Close(int)'
BUG=none
TEST=none (no trybot for the ARM build)
Review URL: http://codereview.chromium.org/3023025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
BUG=42921
Review URL: http://codereview.chromium.org/3060027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the "channel number" parameter from messages, since this is now
fixed in the NaCl plugin code in sel_main_chrome.c.
Replace pair_ and descriptor_ with sockets_for_renderer_ and
sockets_for_sel_ldr_.
NaClProcessMsg_Start: Pass an array of FDs instead of one FD.
ViewHostMsg_LaunchNaCl:
* Add socket count.
* Return an array of FDs instead of one FD.
Expose this functionality to the NaCl plugin via a new function,
"launch_nacl_process_multi_fd".
BUG=50626
TEST=nacl_ui_tests
Review URL: http://codereview.chromium.org/2832093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46408
TEST=Title for detached devtools window doesn't overlap with "x" button for long URLs.
Review URL: http://codereview.chromium.org/2868075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Bots go green.
TBR=erg
Review URL: http://codereview.chromium.org/3038035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3040016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made ChromeUrlRequestContext handle multiple extension unloaded
notifications gracefully.
BUG=50567
TEST=manual (see repro in bug)
Review URL: http://codereview.chromium.org/2819072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move InitializeSSL() into platform-specific files and eliminate #ifdef.
2. Add some instructions on how to add code to BrowserMain().
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/3073008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supplied URLs.
BUG=none
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/3061026
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3012031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3015026
TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/3046031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PhishingDOMFeatureExtractor iterates over the page elements and computes a
number of features. To avoid blocking the renderer for too long, the extractor
may run in several chunks of works, posting a task to continue processing if
necessary.
This CL only includes the feature extraction itself. I will add the logic to
cap the time per iteration in a follow-up CL.
BUG=none
TEST=PhishingDOMFeatureExtractorTest
Review URL: http://codereview.chromium.org/2878046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3015026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/3061026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54073 0039d316-1c4b-4281-b951-d872f2087c98
|