summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix build on ChromiumOS by ASSERTing TRUE in a UI test.phajdan.jr@chromium.org2010-07-291-1/+1
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/3061034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54210 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively fix ChromiumOS build.phajdan.jr@chromium.org2010-07-291-7/+3
| | | | | | | | | | | TBR=ahendrickson TEST=compile? BUG=48913 Review URL: http://codereview.chromium.org/3027035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54209 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Keep groups when sorting task manager, like windows does.thakis@chromium.org2010-07-291-3/+13
| | | | | | | | | | | Also fix favicons in task manager. BUG=32148 TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block. Review URL: http://codereview.chromium.org/3029041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54206 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup patch of death:phajdan.jr@chromium.org2010-07-2915-372/+347
| | | | | | | | | | | | | | | Separate all interactions with HistoryService out of DownloadManager to new class DownloadHistory owned by the DownloadManager. The goal is to create more smaller classes with clearly defined responsibilities. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3071005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54205 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a test lost in r37819, because it had been at the bottom of an ↵pkasting@chromium.org2010-07-291-2/+36
| | | | | | | | | | unrelated file. BUG=none TEST=Test passes Review URL: http://codereview.chromium.org/3029038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54204 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-2957-276/+396
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* OwnerManager, allows use of OwnerKeyUtils to take ownership of a devicecmasone@google.com2010-07-296-0/+727
| | | | | | | | | BUG=chromium-os:4485 TEST=unit tests Review URL: http://codereview.chromium.org/3058021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54199 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused IPC message.brettw@chromium.org2010-07-291-6/+0
| | | | | | | | TEST=it still compiles BUG=none Review URL: http://codereview.chromium.org/3020027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54190 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First pass at final sizing of toolbar items.shess@chromium.org2010-07-2911-978/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Toolbar.xib changes: - buttons from 31x27 to 29x29 so that the visual is 27x27. - shift things left to take up opened space. - omnibox to 29 pixels tall. - wrench also to 29x29. - all of that raised a single pixel to recenter. - swap positions of home and reload. Modify home-button-adjustment code to reflect rearranged home/reload positions. Increase Omnibox font size by one point to match increased field height (and Windows Omnibox). Revise various font clients to recognize this. Shift Omnibox baseline and other measurements to account for increased height. Shift globe/search icon in by one pixel so icons on both sides of Omnibox are 4px from border. Matching shift in popup. Fix EV-bubble to use appropriate green for text, rather than black. Push out bubble to have a single-pixel space WRT Omnibox border. Tighten corners to tuck into Omnibox corners. Handle different lhs padding versus location icon (image should end up in same spot, even though the bubble draws outside the image). BUG=50575 TEST=none Review URL: http://codereview.chromium.org/3046029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54188 0039d316-1c4b-4281-b951-d872f2087c98
* Rework somewhat how the folder menu window and main view sizes and positions ↵mrossetti@chromium.org2010-07-292-41/+111
| | | | | | | | | | | are calculated. Handle edge case where the top scroll arrow is not showing. Proposed window height was not taking into account the one additional vertical separation. BUG=46101 TEST=Setup: Create a bookmark folder on the bookmark bar with plenty of bookmarks, more than enough to fill the screen, and so that it is scrollable. 1) Bring up the bookmark folder menu but do not cause it to scroll. 2) Using the contextual menu delete a bookmark midway in the menu. 3) Verify that the top of the menu window and contents do not move relative to the bookmark bar folder button. 4) Bring up the bookmark folder menu again. 5) Cause the menu to scroll up to fill the screen and then scroll it down so that the top scroll arrow is not showing. 6) Using the contextual menu delete a bookmark midway in the menu. 7) Verify that the top of the menu window and contents have not moved in relation to the screen top. 8) Bring up the bookmark folder menu and cause it to scroll such that both the top and bottom scroll arrows are showing. 9) Using the contextual menu, delete a bookmark midway in the menu. 10) Verify that the top scroll arrow, the top-most item showing in the menu, and the menu window have not changed position relative to the top of the window. Note that the contents of the folder menu below the bookmark item being delete should adjust upward to fill the slot originally occupied by the deleted bookmark. Review URL: http://codereview.chromium.org/3050021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54187 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Collect UMA stats for AutoFill CC InfoBar.jhawkins@chromium.org2010-07-291-0/+3
| | | | | | | | | BUG=50573 TEST=none Review URL: http://codereview.chromium.org/2868082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54185 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Capitalize "Options" in the AutoFill dialog title.jhawkins@chromium.org2010-07-294-5/+11
| | | | | | | | | BUG=50378 TEST=none Review URL: http://codereview.chromium.org/3018026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54183 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI prefs: Remove use of tables for layout on the Under the Hood pane.stuartmorgan@chromium.org2010-07-293-130/+93
| | | | | | | | | BUG=none TEST=DOMUI Under the Hood options still display correctly. Review URL: http://codereview.chromium.org/3017039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54178 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Remove a static string16.jhawkins@chromium.org2010-07-292-8/+12
| | | | | | | | | BUG=50669 TEST=none Review URL: http://codereview.chromium.org/3013043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54176 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add sort support for task manager.thakis@chromium.org2010-07-294-26/+150
| | | | | | | | | | | Also fix a leak in test Init reported by valgrind. The problem was that the test called a rogue init, which didn't cause the window to be shown, and hence -close didn't send a -windowWillClose: notification. Also restore -windowWillClose:, it accidentally got deleted in http://codereview.chromium.org/536086 BUG=32148,30398 TEST=Click a column in the task manager. Should sort. Review URL: http://codereview.chromium.org/2873075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54175 0039d316-1c4b-4281-b951-d872f2087c98
* Browser actions container layout changes for M6 theme.pkasting@chromium.org2010-07-293-277/+278
| | | | | | | | | | | | | | In short, this: * Eliminates the divider on the right (the new chevron has a built-in divider) * Changes the padding between items (see updated comments in header for precise layout details) * Updates the imagery for the new theme * Makes the chevron respond to theme changes BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3057016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54174 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53992 - An earlier check-in (r51786, Issue 2769008) caused a memory ↵brettw@chromium.org2010-07-292-9/+10
| | | | | | | | | | | | | | leak on the build bots when PulseAudio was initialized on a separate worker thread. This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread. For some reason, the init finishes cleanly on one thread, but not the other. BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141) TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures. Review URL: http://codereview.chromium.org/3026028 TBR=davej@chromium.org Review URL: http://codereview.chromium.org/3013042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54170 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper3D test passes on trybots but fails on buildbots. I am guessing osmesa ↵alokp@chromium.org2010-07-291-0/+1
| | | | | | | | | is not being built on the buildbots. Adding osmesa target dependency may fix it. BUG=46662 Review URL: http://codereview.chromium.org/3031028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54167 0039d316-1c4b-4281-b951-d872f2087c98
* Enable more PPAPI tests.brettw@chromium.org2010-07-291-10/+0
| | | | | | | | TEST=this is it BUG=none Review URL: http://codereview.chromium.org/3079006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54166 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded browser.h include from RVHDelegateHelper.brettw@chromium.org2010-07-291-1/+1
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3020041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54165 0039d316-1c4b-4281-b951-d872f2087c98
* Test to verify the 'multiple downloads' infobarnirnimesh@chromium.org2010-07-293-0/+47
| | | | | | | | | | | Verifies the multiple downloads infobar. Implemented by Venkat, who figured out how to reliably trigger the multiple downloads infobar. Review URL: http://codereview.chromium.org/3066017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54163 0039d316-1c4b-4281-b951-d872f2087c98
* The button menu items on GTK menus honor the enabled state of the command.sanjeevr@chromium.org2010-07-291-19/+20
| | | | | | | | | BUG=None TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise. Review URL: http://codereview.chromium.org/3032038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54162 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a crashing PreferencesWindowController unit test (only crashes in ↵rohitrao@chromium.org2010-07-291-2/+10
| | | | | | | | | | branded builds). BUG=50471 TEST=PreferencesWindowController.SwitchToPage should not crash in official builds. Review URL: http://codereview.chromium.org/2836073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54160 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch to control accelerated 2d canvasjamesr@chromium.org2010-07-294-0/+8
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/2873074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54159 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Don't offer profiles for billing addresses that have no address avi@chromium.org2010-07-291-1/+15
| | | | | | | | | | | data. BUG=http://crbug.com/50081 TEST=as in bug Review URL: http://codereview.chromium.org/3031030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54149 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill suggestions for billing and credit card fields should show derived ↵dhollowa@chromium.org2010-07-292-73/+130
| | | | | | | | | | | | | labels. Changes suggestions for forms with billing information to show derived labels based on contents of suggestions, not the labels stored in the matched profiles. Also, the suggestion logic has been updated to properly take account of the billing "relation" in the credit card info. Credit card only suggestions now use derived labels as well. BUG=50261 TEST=AutoFillManagerTest.GetBillingSuggestionsAddress1, AutoFillManagerTest.GetCreditCardSuggestions* Review URL: http://codereview.chromium.org/3067016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54147 0039d316-1c4b-4281-b951-d872f2087c98
* Update omnibox_c.png to remove garbage in middle.pkasting@chromium.org2010-07-291-0/+0
| | | | | | | | | TBR=estade BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3056030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54145 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix broken valgrind suppressions.thakis@chromium.org2010-07-292-7/+5
| | | | | | | | They don't work locally for me, and on the bots only Mac_Sandbox_Intentional_Leak3 is getting used, which is overly wide. Review URL: http://codereview.chromium.org/2808079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54141 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] fix official buildmnissler@chromium.org2010-07-291-2/+2
| | | | | | | | | | | Directly include base/string_util.h, which was removed in r53969 from the indirectly included base/command_line.h BUG=none TEST=Mac official builder goes green. Review URL: http://codereview.chromium.org/3032037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54140 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SessionHistoryTest.JavascriptHistory as flaky.brettw@chromium.org2010-07-291-1/+4
| | | | | | | | BUG=50648 TEST=none Review URL: http://codereview.chromium.org/3073009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54139 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54137 - Revert 53990 - - Implement proxy settings dialog for ↵glider@chromium.org2010-07-299-106/+329
| | | | | | | | | | | | | | | | | | Linux/Windows. - Omit Network and SSL sections for ChromeOS. BUG=49038 TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options). Review URL: http://codereview.chromium.org/2847061 TBR=csilv@chromium.org Review URL: http://codereview.chromium.org/2884047 TBR=glider@chromium.org Review URL: http://codereview.chromium.org/3023026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54138 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53990 - - Implement proxy settings dialog for Linux/Windows.glider@chromium.org2010-07-299-329/+106
| | | | | | | | | | | | | - Omit Network and SSL sections for ChromeOS. BUG=49038 TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options). Review URL: http://codereview.chromium.org/2847061 TBR=csilv@chromium.org Review URL: http://codereview.chromium.org/2884047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54137 0039d316-1c4b-4281-b951-d872f2087c98
* Returned chromeos_accounts_user_name_edit.js deleted at r54128glider@chromium.org2010-07-291-0/+121
| | | | | | | | TBR=xiyuan Review URL: http://codereview.chromium.org/3077011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54134 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53989 - Implement new mock for user options page per chromium-os:5028glider@chromium.org2010-07-2911-336/+72
| | | | | | | | | | | | BUG=chromium-os:5028 TEST=Verify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only. Review URL: http://codereview.chromium.org/2868067 TBR=xiyuan@chromium.org Review URL: http://codereview.chromium.org/3074010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54128 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl: Fix link time error when DISABLE_NACL is setmseaborn@chromium.org2010-07-291-0/+5
| | | | | | | | | | | | | | | This fixes breakage on the ARM buildbot, introduced by r54113. nacl::Close() is not available when DISABLE_NACL is set. The error was: nacl_process_host.cc: error: undefined reference to 'nacl::Close(int)' BUG=none TEST=none (no trybot for the ARM build) Review URL: http://codereview.chromium.org/3023025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54123 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude NewTabUITest.NTPHasThumbnails from Valgrind run - 4GB is not enoughtimurrrr@chromium.org2010-07-291-1/+2
| | | | | | | | TBR=glider BUG=42921 Review URL: http://codereview.chromium.org/3060027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54120 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl: Allow setting up multiple sockets for subprocess instead of just onemseaborn@chromium.org2010-07-297-63/+146
| | | | | | | | | | | | | | | | | | | | | | | | Remove the "channel number" parameter from messages, since this is now fixed in the NaCl plugin code in sel_main_chrome.c. Replace pair_ and descriptor_ with sockets_for_renderer_ and sockets_for_sel_ldr_. NaClProcessMsg_Start: Pass an array of FDs instead of one FD. ViewHostMsg_LaunchNaCl: * Add socket count. * Return an array of FDs instead of one FD. Expose this functionality to the NaCl plugin via a new function, "launch_nacl_process_multi_fd". BUG=50626 TEST=nacl_ui_tests Review URL: http://codereview.chromium.org/2832093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54113 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 479.0 to 480.0chrome-release@google.com2010-07-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54110 0039d316-1c4b-4281-b951-d872f2087c98
* Fix wrong line ending.markusheintz@chromium.org2010-07-291-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54107 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome OS: Prevent overlapping of title and "x" button for devtools windowdpolukhin@chromium.org2010-07-291-15/+19
| | | | | | | | | BUG=46408 TEST=Title for detached devtools window doesn't overlap with "x" button for long URLs. Review URL: http://codereview.chromium.org/2868075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build - forgot to check in a file.thestig@chromium.org2010-07-291-0/+1
| | | | | | | | | BUG=none TEST=Bots go green. TBR=erg Review URL: http://codereview.chromium.org/3038035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54103 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-2981-101/+19
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* Net: Convert username and password to string16.thestig@chromium.org2010-07-291-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3040016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54101 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed extension sync-related crash in ChromeUrlRequestContextakalin@chromium.org2010-07-291-2/+9
| | | | | | | | | | | | Made ChromeUrlRequestContext handle multiple extension unloaded notifications gracefully. BUG=50567 TEST=manual (see repro in bug) Review URL: http://codereview.chromium.org/2819072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54100 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserMain() refactoring, part 2.1.viettrungluu@chromium.org2010-07-295-35/+73
| | | | | | | | | | | | 1. Move InitializeSSL() into platform-specific files and eliminate #ifdef. 2. Add some instructions on how to add code to BrowserMain(). BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/3073008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54098 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54073 - Fix --kiosk to work regardless of the startup pref setting or ↵rohitrao@chromium.org2010-07-291-8/+10
| | | | | | | | | | | | | supplied URLs. BUG=none TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble). Review URL: http://codereview.chromium.org/3061026 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/3012031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54095 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs).rohitrao@chromium.org2010-07-295-183/+0
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/3046031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54093 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extractor for DOM features to be used for client side phishing detection.bryner@chromium.org2010-07-298-1/+1063
| | | | | | | | | | | | | | | | | PhishingDOMFeatureExtractor iterates over the page elements and computes a number of features. To avoid blocking the renderer for too long, the extractor may run in several chunks of works, posting a task to continue processing if necessary. This CL only includes the feature extraction itself. I will add the logic to cap the time per iteration in a follow-up CL. BUG=none TEST=PhishingDOMFeatureExtractorTest Review URL: http://codereview.chromium.org/2878046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54082 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial tests for keyboard access (tabbing in some dialogs).dtseng@chromium.org2010-07-285-0/+183
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix --kiosk to work regardless of the startup pref setting or supplied URLs.pkasting@chromium.org2010-07-281-10/+8
| | | | | | | | BUG=none TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble). Review URL: http://codereview.chromium.org/3061026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54073 0039d316-1c4b-4281-b951-d872f2087c98