summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Reverting 16569.ben@chromium.org2009-05-213-3/+0
| | | | | | Review URL: http://codereview.chromium.org/113689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16574 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16570.ben@chromium.org2009-05-211-1/+0
| | | | | | Review URL: http://codereview.chromium.org/115621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16573 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16571.ben@chromium.org2009-05-211-1/+0
| | | | | | Review URL: http://codereview.chromium.org/113688 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16572 0039d316-1c4b-4281-b951-d872f2087c98
* unittests depend on app resources tooben@chromium.org2009-05-211-0/+1
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/113687 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16571 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure browser depends on app resources in GYP too.ben@chromium.org2009-05-211-0/+1
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/113686 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release build by adding intermediate dir to release build include dirs too.ben@chromium.org2009-05-213-0/+3
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/115620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16569 0039d316-1c4b-4281-b951-d872f2087c98
* views/ should use resources from app/resources. Move dependent images to ↵ben@chromium.org2009-05-2191-73/+39
| | | | | | | | | this location. http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16567 0039d316-1c4b-4281-b951-d872f2087c98
* Don't get stuck in an allocate loop on closing the download shelf.estade@chromium.org2009-05-212-8/+16
| | | | | | Review URL: http://codereview.chromium.org/113674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16565 0039d316-1c4b-4281-b951-d872f2087c98
* Catch up:sgk@google.com2009-05-211-2/+7
| | | | | | | | | * Add browser/views/browser_bubble{,_win}.{cc,h} * Rename of browser/views/tabs/native_view_photobooth{,_win}.{cc,h} * Old omitted browser/views/frame/browser_frame.h Review URL: http://codereview.chromium.org/115614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16563 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC serialization for DictionaryValue and ListValue, with unit tests.mpcomplete@google.com2009-05-213-1/+300
| | | | | | Review URL: http://codereview.chromium.org/115491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16562 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to handle notification observing.pkasting@chromium.org2009-05-214-16/+10
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16560 0039d316-1c4b-4281-b951-d872f2087c98
* Use NotificationRegistrar to handle notification observing.pkasting@chromium.org2009-05-216-37/+20
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16559 0039d316-1c4b-4281-b951-d872f2087c98
* Send the V8 histograms to UMAdavemoore@chromium.org2009-05-211-1/+5
| | | | | | Review URL: http://codereview.chromium.org/115183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16558 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2124-792/+515
| | | | | | | | This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811. Review URL: http://codereview.chromium.org/113680 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16557 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in bookmark editor. We crash when we don't have a selected folder, ↵erg@google.com2009-05-211-5/+11
| | | | | | | | | | but we don't select a folder by default when we're adding a new bookmark. Review URL: http://codereview.chromium.org/115598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16556 0039d316-1c4b-4281-b951-d872f2087c98
* Make the NotificationRegistrar safe for use in Singletons, which may outlive ↵pkasting@chromium.org2009-05-213-5/+26
| | | | | | | | | | | the NotificationService instances, by checking whether the service exists before calling RemoveObserver() on it. Also add comments in NotificationService telling people to use NotificationRegistrar. BUG=2381 Review URL: http://codereview.chromium.org/115601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16554 0039d316-1c4b-4281-b951-d872f2087c98
* Need to disable two print test temporarily to green the tree.levin@chromium.org2009-05-212-2/+2
| | | | | | | | | | TBR=dimich BUG=12363 TEST=none, just disabling some unit test temporarily. Review URL: http://codereview.chromium.org/115610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16552 0039d316-1c4b-4281-b951-d872f2087c98
* Remove widget_win.h dependency from fullscreen_exit_bubble.h. It is unused inbrettw@chromium.org2009-05-202-1/+1
| | | | | | | the header so I moved it to the .cc. Review URL: http://codereview.chromium.org/115578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16548 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2024-515/+792
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16547 0039d316-1c4b-4281-b951-d872f2087c98
* About box development.jrg@chromium.org2009-05-208-15/+950
| | | | | | | | | | | BUG=http://codereview.chromium.org/112044 Note pieces of chrome.gyp come from a different CL (keystone_glue work associated with this). Review URL: http://codereview.chromium.org/113614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16545 0039d316-1c4b-4281-b951-d872f2087c98
* Development of keystone glue.jrg@chromium.org2009-05-204-37/+375
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=http://codereview.chromium.org/112044 chrome.gyp caught in a different CL but here is the relevant part of the diff: --- chrome.gyp (revision 16158) +++ chrome.gyp (working copy) @@ -2679,6 +2682,11 @@ ], 'sources': [ 'app/breakpad_mac_stubs.mm', + # *NO* files in chrome/app have unit tests (except keystone_glue)!!! + # It seems a waste to have an app_unittests target, so for now + # I add keystone_glue.m explicitly to this target. + 'app/keystone_glue.m', + 'app/keystone_glue_unittest.mm', # All unittests in browser, common, and renderer. 'browser/autocomplete/autocomplete_unittest.cc', 'browser/autocomplete/autocomplete_popup_view_mac_unittest.mm', Review URL: http://codereview.chromium.org/113613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16540 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent setting the checkbox value in menus from activating the menu item.erg@google.com2009-05-201-0/+21
| | | | | | | | http://crbug.com/11942 Review URL: http://codereview.chromium.org/115589 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16539 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2023-792/+515
| | | | | | | | This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a. Review URL: http://codereview.chromium.org/113664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16538 0039d316-1c4b-4281-b951-d872f2087c98
* Add HKLM + HKCU lookup for COM history indexercpu@google.com2009-05-201-16/+43
| | | | | | | | | | | | - slight refactor TEST= there are no tests BUG= http://b/issue?id=1860803 Review URL: http://codereview.chromium.org/113605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16534 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reject empty file filters for file chooser dialogs.estade@chromium.org2009-05-201-3/+10
| | | | | | | | | | Note that this is temporary in that, in the long run, we should be using mime type filters rather than shell-style globs. TEST=right click/save as on a link. There should be no "*." filter. Review URL: http://codereview.chromium.org/113660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16533 0039d316-1c4b-4281-b951-d872f2087c98
* Restoring cygwin project and dependencies that seem to have been clobbered ↵bradnelson@google.com2009-05-201-0/+36
| | | | | | | | at some point. Review URL: http://codereview.chromium.org/115590 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16531 0039d316-1c4b-4281-b951-d872f2087c98
* mac_util::SetOverrideAppBundle() are handled in class ChromeTestSuite.jrg@chromium.org2009-05-201-10/+0
| | | | | | | | | They should not be modified here (and especially should not be undone in TearDown since it breaks things for following unit tests). Review URL: http://codereview.chromium.org/115554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16530 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2023-515/+792
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16529 0039d316-1c4b-4281-b951-d872f2087c98
* Implement process singleton on linux so if the user tries totc@google.com2009-05-203-16/+281
| | | | | | | | | | | | | | open multiple chrome processes, the first one just opens a new window. This is based on http://codereview.chromium.org/88067 by Nikita Ofitserov (himikof). BUG=8073 Review URL: http://codereview.chromium.org/115572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16528 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most of the Find UI tests to InProcBrowser tests. I might be able to ↵finnur@chromium.org2009-05-203-194/+235
| | | | | | | | | | | | | convert the remaining ones, but this is enough for a first pass. I also added a new disabled test, which will soon be enabled. BUG=None TEST=This whole changelist is about tests. :) Review URL: http://codereview.chromium.org/113646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16527 0039d316-1c4b-4281-b951-d872f2087c98
* Enable IDC_CLOSE_WINDOW on linux.estade@chromium.org2009-05-203-5/+5
| | | | | | | | I filed http://crbug.com/12334 to fix the ifdefed-out block in ui_test.cc. Review URL: http://codereview.chromium.org/113655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16526 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add background image theming to bookmark bar.estade@chromium.org2009-05-203-25/+57
| | | | | | | | | | I got rid of the border padding in an attempt to more closely match windows, where the bookmark bar is very compact. BUG=http://crbug.com/12216 Review URL: http://codereview.chromium.org/115551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16524 0039d316-1c4b-4281-b951-d872f2087c98
* Don't die on glib/gtk/gdk errors in release mode.estade@chromium.org2009-05-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/113654 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16523 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to make the Gmail checker more robust in the face of errors.aa@chromium.org2009-05-201-47/+91
| | | | | | | | | | | | | The heart of this is that I wrapped up the request to the feed in a timeout and a bunch more error handling and abstracted all that into one function so I could be sure all the errors were getting handled the same way. Also general cleaning while I was in there. BUG=11969 TEST=Install Gmail Checker, go offline, go back online. It should start showing message counts again when you go back online. Review URL: http://codereview.chromium.org/115584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16522 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetPixbufNamed to ThemeProvider. GetPixbufNamed converts a loaded theme ↵jhawkins@chromium.org2009-05-206-25/+74
| | | | | | | | bitmap to a GdkPixbuf and caches the image so ThemeProvider users don't need to release them ala ResourceBundle::GetPixbufNamed. Review URL: http://codereview.chromium.org/113626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16520 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in bookmark bar where we had conflicting ids.erg@google.com2009-05-203-11/+42
| | | | | | | | http://crbug.com/12304 Review URL: http://codereview.chromium.org/115581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16519 0039d316-1c4b-4281-b951-d872f2087c98
* Change RenderWidgetHostViewGtk::Destroy() to call gtk_widget_destroy().willchan@chromium.org2009-05-201-0/+8
| | | | | | | | | BUG=http://www.crbug.com/11847. TEST=Navigate to an interstitial page. Click on Proceed. It should not crash. Review URL: http://codereview.chromium.org/115549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16518 0039d316-1c4b-4281-b951-d872f2087c98
* Make views/ use strings from app_strings.ben@chromium.org2009-05-201-1/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16512 0039d316-1c4b-4281-b951-d872f2087c98
* Added a script to remove headers from the target.thomasvl@chromium.org2009-05-201-4/+15
| | | | | | | | Added a default in common.gypi to remove headers from all mac applications that are bundles. Added a var to control the inclusion of keystone to chrome.gyp defaulted on branding and then honor it for the shipping work. Review URL: http://codereview.chromium.org/113652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16510 0039d316-1c4b-4281-b951-d872f2087c98
* revert this change, svn seems to have committed it with my property-edit.ben@chromium.org2009-05-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16509 0039d316-1c4b-4281-b951-d872f2087c98
* Support multi-touch gestures for back&forward.pinkerton@chromium.org2009-05-201-0/+21
| | | | | | Review URL: http://codereview.chromium.org/115579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16505 0039d316-1c4b-4281-b951-d872f2087c98
* Copy first_run.cc to first_run_win.cc for history preservation.evan@chromium.org2009-05-201-0/+667
| | | | | | | | A subsequent change will modify these files. (Retrying previous change.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16504 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r16502.evan@chromium.org2009-05-201-667/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16503 0039d316-1c4b-4281-b951-d872f2087c98
* Copy first_run.cc to first_run_win.cc for history preservation.evan@chromium.org2009-05-201-0/+667
| | | | | | A subsequent change will modify these files. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16502 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary function overload in FontDisplayView.yutak@chromium.org2009-05-201-20/+0
| | | | | | | | | FontDisplayView::SetFontType is overloaded and has two function signatures, but one of them became obsolete (its implementation is not synchronized with the other) and is no longer used. TEST=none Review URL: http://codereview.chromium.org/113610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16501 0039d316-1c4b-4281-b951-d872f2087c98
* Alert dialogs only get one button.avi@chromium.org2009-05-201-4/+6
| | | | | | Review URL: http://codereview.chromium.org/113638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16500 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent an extra copy of data types that get passed into IPC messages whenmpcomplete@google.com2009-05-206-75/+78
| | | | | | | | | | sending them. This makes it so that types sendable via IPC no longer need copy constructors. BUG=12296 Review URL: http://codereview.chromium.org/112042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16497 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't display empty tooltips on folders in the bookmark bar.erg@google.com2009-05-201-1/+3
| | | | | | Review URL: http://codereview.chromium.org/115576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16496 0039d316-1c4b-4281-b951-d872f2087c98
* Translate the canvas used to render gtk tabs by the tab bounds in order to ↵jhawkins@chromium.org2009-05-202-21/+28
| | | | | | | | | render at (0,0) to match windows metrics. This helps eliminate differences between the two tab rendering implementations. TEST=Open multiple tabs. Make sure the tabs are rendered correctly (close button, elided title text, favicon, sad tab crash animation). Review URL: http://codereview.chromium.org/113623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16495 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disabling throbber to see if startup tests bot goes back to normal.pinkerton@chromium.org2009-05-201-0/+4
| | | | | | Review URL: http://codereview.chromium.org/113648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16494 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 22:57:16 +0000