summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add a UI test for downloading in incognito mode.paul@chromium.org2009-06-161-1/+43
| | | | | | | | | | | | | This test opens an incognito window and verifies that downloads work and that closing the incognito window does not crash (see bug http://crbug.com/13983). TEST=Test should run and not crash. BUG=none Review URL: http://codereview.chromium.org/126181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18534 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a chromebot crash since I can't reproduce itpaul@chromium.org2009-06-162-0/+5
| | | | | | | | | | | | | | | | | | locally. When shutting down the browser with a download shelf, we first release the shelf (see BUG=13681 for details) but we are still part of the view hierarchy. A little later in the shutdown, the shelf's parent (BrowserView) will dereference the already deleted shelf through its View base class, which I believe is the source of the Chromebot crash. BUG=14171 (http://crbug.com/14171) TEST=Chromebot should not crash Review URL: http://codereview.chromium.org/126228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18532 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup Personal Stuff options tab pagemhm@chromium.org2009-06-161-5/+0
| | | | | | | | | | | The popup variable declarations are not needed anymore since they were removed . BUG=none TEST=page functions correctly Review URL: http://codereview.chromium.org/126102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18530 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing headers to gyp files.jam@chromium.org2009-06-161-0/+2
| | | | | | Review URL: http://codereview.chromium.org/125204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18526 0039d316-1c4b-4281-b951-d872f2087c98
* Initial stub for the support library, gyp file and targets. Chrome.exe and ↵slightlyoff@chromium.org2009-06-161-0/+4
| | | | | | | | chrome.dll will depend on them. Review URL: http://codereview.chromium.org/125155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18525 0039d316-1c4b-4281-b951-d872f2087c98
* Improved tab overview animations with better animation and wiring tosky@chromium.org2009-06-1615-56/+375
| | | | | | | | | | | message loop. BUG=none TEST=none Review URL: http://codereview.chromium.org/126185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18523 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18512 - Revert 18373 Consider a redirect following user gesture as ↵laforge@chromium.org2009-06-1618-33/+317
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | userinitiated in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 TBR=laforge@chromium.org Review URL: http://codereview.chromium.org/126221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18522 0039d316-1c4b-4281-b951-d872f2087c98
* Remove type from page action manifest, since we are ignoring that value ↵finnur@chromium.org2009-06-161-2/+1
| | | | | | | | | | | | anyway at the moment. TBR=aa BUG=None TEST=None (RSS page action should work as before) Review URL: http://codereview.chromium.org/126214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18521 0039d316-1c4b-4281-b951-d872f2087c98
* * Add an OnCancelResolution() notifier to HostResolver::Observer, so ↵ericroman@google.com2009-06-161-5/+21
| | | | | | | | | | | | | | | observers can tell when a request has been cancelled. * Use OnCancelResolution() in DNS prefetcher observer, to avoid leaking entries in the |resolution| table when requests are cancelled. (BUG=14138) * Fix a bug where completion notification wasn't being sent when the response was cached. (BUG=14188) BUG=14138,14188 TEST=HostResolverTest.CancellationObserver, HostResolverTest.Observer Review URL: http://codereview.chromium.org/125171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18520 0039d316-1c4b-4281-b951-d872f2087c98
* Move TableModel out of views/ and into app/.estade@chromium.org2009-06-1620-142/+112
| | | | | | | | | Remove stub implementation in temp_scaffolding_stubs.h Use l10n_util collator helper function in TableModel::Compare Review URL: http://codereview.chromium.org/126184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18518 0039d316-1c4b-4281-b951-d872f2087c98
* Add file icons to chrome://downloads/ on the Mac. Add Skia helpermark@chromium.org2009-06-163-7/+23
| | | | | | | | | | CGImageToSkBitmap(). Patch by Robert Sesek <rsesek@bluestatic.org> Review URL: http://codereview.chromium.org/118488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that could happen at shutdown or window close due to a double-free.mpcomplete@google.com2009-06-164-26/+7
| | | | | | | | | | | | This is erikkay's patch. I'm landing it while he's away. TBR=erikkay BUG=none TEST=install an extension with a toolstrip and close chrome. It shouldn't crash. Review URL: http://codereview.chromium.org/126219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18516 0039d316-1c4b-4281-b951-d872f2087c98
* Extract load times from WebDataSource. Move them to NavigationState.darin@chromium.org2009-06-1650-193/+320
| | | | | | | | | | | | Move PasswordForm into the webkit_glue namespace. TEST=none BUG=10041 R=brettw Review URL: http://codereview.chromium.org/126190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18515 0039d316-1c4b-4281-b951-d872f2087c98
* Access RenderThread::current() only on render threadhclam@chromium.org2009-06-163-47/+80
| | | | | | | | | | Since the renfer to RenderThread is now stored in the thread local storage, we can only access RenderThread::current() from render thread. Change BufferedDataSource accordingly. Review URL: http://codereview.chromium.org/126183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18513 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18373 - Consider a redirect following user gesture as userinitiated ↵laforge@chromium.org2009-06-1618-317/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18512 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate new Linux deb packaging file.mmoss@chromium.org2009-06-161-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/125199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18482, gyp conversion of chrome.exe; first run issues.sgk@google.com2009-06-161-0/+1
| | | | | | | | BUG=14179 TEST=none Review URL: http://codereview.chromium.org/126215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18508 0039d316-1c4b-4281-b951-d872f2087c98
* Restore .pdb file names to chrome_{dll,exe}.pdb (as expected by thesgk@google.com2009-06-161-2/+16
| | | | | | | | | symbol infrastructure), not {product_name}.pdb. BUG=none TEST=none Review URL: http://codereview.chromium.org/125198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18507 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show tooltips if the window isn't main.pinkerton@chromium.org2009-06-161-1/+4
| | | | | | | | BUG=none TEST=tooltips shouldn't show if the window isn't the frontmost. Review URL: http://codereview.chromium.org/125194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18505 0039d316-1c4b-4281-b951-d872f2087c98
* Hack to enable video on mac by creating a blank PlatformContextMac to draw on.ajwong@chromium.org2009-06-161-3/+0
| | | | | | | | This isn't a great solution, but it kinda works. Video renders, and the speed is acceptable even though we're doing an extra copy for each frame. The image shows up upside-down though. :( Review URL: http://codereview.chromium.org/126087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows release compile by adding missing build_config.h include.phajdan.jr@chromium.org2009-06-161-0/+2
| | | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/126211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18502 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing problem where ml, hi, pt-PT and bg first run bubbles were truncated or tojshin@chromium.org2009-06-164-6/+6
| | | | | | | | | | | | | | | | narrow to hold all of text. Increased width of bubble by 4+ chars, and for bg increased the height of bubble by 1. BUG=12208 (http://crbug.com/12208) TEST=Run Chrome with --lang=ml, --lang=hi, --lang=pt-PT, --lang=bg. In 'First Run UI', press button 'Start Google Chrome' and see if there's any truncated string in the FirstRun Bubble. Everytime you run Chrome with different language options, please make sure to delete 'First Run' file in Chrome application folder. Patch by nciric (cira) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18501 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in chrome/browser/phajdan.jr@chromium.org2009-06-1649-71/+93
| | | | | | | | In my scan of headers I got up to browser/gtk/ Review URL: http://codereview.chromium.org/126131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
* Removes entirely dead code paths related to ConstrainedWindows.erg@chromium.org2009-06-1615-332/+36
| | | | | | | | | | - Removes parts of the interface that probably made sense at some time, but now only have a DLOG(INFO) as their implementation. Also remove their callers. - Remove all usage of the ConstrainedWindowProxy interface in the automation system. It was *never* used. - Rename constrianed_window_impl_interactive_uitests.cc to blocked_popup_container_interactive_uitest.cc. The test case hasn't tested code in constrained_window_impl.cc since the rewrite of the blocked popup system back last autumn. Review URL: http://codereview.chromium.org/125160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18498 0039d316-1c4b-4281-b951-d872f2087c98
* Adding ap key inclusion to uninstall metrics.robertshield@google.com2009-06-161-0/+9
| | | | | | | | BUG=http://crbug.com/14007 TEST=Uninstall a build with this patch and verify that the uninstall survey window has ap=XXXX in the URL. Review URL: http://codereview.chromium.org/126154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18495 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up the sprintf to properly mark the string as a wide string.thomasvl@chromium.org2009-06-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/125191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18493 0039d316-1c4b-4281-b951-d872f2087c98
* Use a pdf instead of a png for incognito badge.pinkerton@chromium.org2009-06-163-2/+255
| | | | | | | | BUG=none TEST=incognito badge should display correctly in incognito windows. Review URL: http://codereview.chromium.org/126204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18491 0039d316-1c4b-4281-b951-d872f2087c98
* Make tooltip loading lazy.pinkerton@chromium.org2009-06-161-2/+3
| | | | | | | | BUG=none TEST=normal tooltip tests Review URL: http://codereview.chromium.org/126203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18490 0039d316-1c4b-4281-b951-d872f2087c98
* Bring url_fetch_test into compiling shape on mac/linux.thomasvl@chromium.org2009-06-162-35/+42
| | | | | | Review URL: http://codereview.chromium.org/126072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18488 0039d316-1c4b-4281-b951-d872f2087c98
* Solve a strict-aliasing issue in metrics_log.cc to appease gcc 4.4 on Linux.craig.schlenter@chromium.org2009-06-161-5/+9
| | | | | | Review URL: http://codereview.chromium.org/126104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18487 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.exe to gyp.sgk@google.com2009-06-161-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18482 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.dll to gyp generation.sgk@google.com2009-06-161-1/+1
| | | | | | | | | Adds dependency on ffmpeg to pull in av*.dll files. BUG=none TEST=succesfull build Review URL: http://codereview.chromium.org/126187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18481 0039d316-1c4b-4281-b951-d872f2087c98
* Whoops. Actually print out the private key in the unit test,aa@chromium.org2009-06-161-1/+1
| | | | | | | | instead of the crx file. Review URL: http://codereview.chromium.org/125172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18480 0039d316-1c4b-4281-b951-d872f2087c98
* Removed mixed content options. Turns out extremely few users changed the ↵abarth@chromium.org2009-06-163-165/+2
| | | | | | | | | | | | default. R=beng BUG=None TEST=Go to options dialog and notice that the mixed content option is gone. Review URL: http://codereview.chromium.org/126106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18479 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary static_cast in the ctor of TabContents and AsWC helperbrettw@chromium.org2009-06-161-32/+20
| | | | | | | | | | | function. These were leftover from Brett's refactoring of Tab/WebContents. Original review: http://codereview.chromium.org/125040 Patch by tyoshino@google.com Review URL: http://codereview.chromium.org/125138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18478 0039d316-1c4b-4281-b951-d872f2087c98
* Trying to debug a purify problem, the flags are not set to output LOG(INFO), ↵aa@chromium.org2009-06-161-1/+1
| | | | | | | | so I am changing to something I know will work. Review URL: http://codereview.chromium.org/125167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18476 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bug number to a TODO comment.ericroman@google.com2009-06-161-0/+1
| | | | | | | | | TBR=jar BUG=14138 Review URL: http://codereview.chromium.org/126167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18471 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where ExtensionHost and ExtensionView weren't getting closed ↵erikkay@google.com2009-06-162-1/+25
| | | | | | | | | | | | properly when a browser window was closed. BUG=13975 TEST=see bug for repro steps Review URL: http://codereview.chromium.org/125164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18470 0039d316-1c4b-4281-b951-d872f2087c98
* Set magic string in registry to enable fallback to full installer in case of ↵kuchhal@chromium.org2009-06-162-2/+39
| | | | | | | | | | 3 stage updates. BUG=12832 Review URL: http://codereview.chromium.org/126157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18468 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments on magic number 0xbb. They are VK_OEM_PLUS. I guess the ↵hamaji@chromium.org2009-06-161-1/+4
| | | | | | | | original author of this code considered the case where VK_OEM_PLUS isn't defined. For example, it seems that 0xbb is VK_EQUAL for embeded environments and VK_OEM_PLUS is never defined. Review URL: http://codereview.chromium.org/119154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18467 0039d316-1c4b-4281-b951-d872f2087c98
* Close all browsers during InProcessBrowserTest cleanup, not just the main one.erikkay@google.com2009-06-163-40/+6
| | | | | | | | | | BUG=none TEST=ExtensionViewTest.Incognito Review URL: http://codereview.chromium.org/126175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18466 0039d316-1c4b-4281-b951-d872f2087c98
* Make XHR work in Workers. Creates a 'shadow page' in a worker process to ↵dimich@google.com2009-06-162-5/+5
| | | | | | | | | | proxy the loading requests through. BUG=4361 TEST=none Review URL: http://codereview.chromium.org/126070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18465 0039d316-1c4b-4281-b951-d872f2087c98
* Limit the size of popup menus on linux.estade@chromium.org2009-06-161-1/+6
| | | | | | | | | | This fixes <http://crbug.com/13805>. I've filed http://crbug.com/14142 for a more graceful solution. Review URL: http://codereview.chromium.org/126171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18464 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark dragging cleanup.estade@chromium.org2009-06-163-26/+33
| | | | | | | | | | | | | | | | | bookmark bar: - re-show on buttons when done dragging - match g_object_ref in drag-begin with g_object_unref in drag-end bookmark manager: - get rid of default tree view drag handling (we override it all anyway, and it was causing problems) - fix index out of bounds crash - when you drag onto a folder, add it at the end of the folder rather than the beginning. TEST=single bookmark dragging should be fully functional, non crashing BUG=14019 Review URL: http://codereview.chromium.org/126163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18463 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily break the purify bot again so that I can get logaa@chromium.org2009-06-162-3/+4
| | | | | | | | entries needed to permanently fix. Review URL: http://codereview.chromium.org/125162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18462 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the tests after sgk reverted CL18441.anantha@chromium.org2009-06-161-2/+2
| | | | | | Review URL: http://codereview.chromium.org/125165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18461 0039d316-1c4b-4281-b951-d872f2087c98
* Move automated_ui_test_test to ui_tests from a library so it actually gets run.dkegel@google.com2009-06-163-7/+18
| | | | | | | | | | | Trivial tweaks to get most of it to build on Linux. BUG=none TEST=run ui_tests --gtest_filter=AutomatedUITestBase, verify that six to eight are enabled and all pass Review URL: http://codereview.chromium.org/125142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18460 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when closing an incognito window with a downloadpaul@chromium.org2009-06-162-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | shelf visible. We explicitly remove the download shelf view from the browser view hierarchy during a window close operation. This avoids calling back into the partially deleted view hierarchy with download deleted observer notifications. Explicitly removing the shelf allows the observer notifications to run first while the views are still valid. To reproduce: 1. Launch Chrome 2. Open an incognito window 3. Download something in the incognito window 4. The download shelf should become visible with one entry 5. Close the incognito window 6. Crash BUG=13681 (http://crbug.com/13681) Review URL: http://codereview.chromium.org/126082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18458 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage caused by last change. enumeration changed name and got rid of ↵ben@chromium.org2009-06-161-2/+2
| | | | | | | | | | | _DELEGATE. BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/126176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18456 0039d316-1c4b-4281-b951-d872f2087c98
* Upgrade BackForwardMenuModelViews to use new menu API. Also adds accelerator ↵ben@chromium.org2009-06-157-98/+151
| | | | | | | | | | | | to the "Show Full History" item. This requires bringing the owner-draw system for native menus over from the old code. I haven't really changed anything in it other than the format of dwItemData. This code could be improved/simplified by using gfx::Canvas more, but don't want to do it here. BUG=none TEST=make sure BackForwardMenuModel tests still pass, test the menu functionality in the toolbar. Review URL: http://codereview.chromium.org/126092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18454 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 19:19:41 +0000