summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix signature of onConnect.addListener in content scripts doc.asargent@chromium.org2009-10-092-4/+4
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/265057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28516 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate WebView::GetDelegate and replace RenderViewSet with a map fromdarin@chromium.org2009-10-098-75/+145
| | | | | | | | | | | | WebView to RenderView. R=mpcomplete BUG=10033 TEST=none Review URL: http://codereview.chromium.org/265044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28515 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Remove pthreads from syncapi. Convert AddressWatchThread from pthreads ↵tim@chromium.org2009-10-091-51/+57
| | | | | | | | | | to chrome threads. BUG=19895 Review URL: http://codereview.chromium.org/265054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28514 0039d316-1c4b-4281-b951-d872f2087c98
* Spellchecker:estade@chromium.org2009-10-093-115/+231
| | | | | | | | | | | | | Move file accesses during initialization to file thread. Also fix a rare (and harmless) memory leak. Also introduce a rare (and harmless) memory leak. TEST=added dchecks, ran spellcheck unit tests, clicked around, changed dictionaries, added words BUG=22984 BUG=21924 BUG=1123096 Review URL: http://codereview.chromium.org/269020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28512 0039d316-1c4b-4281-b951-d872f2087c98
* Make on-demand download directory creation safe.estade@chromium.org2009-10-094-20/+39
| | | | | | | | | | | If the SavePackage or SaveFileManager went down at the wrong time (most likely during shutdown), we potentially could have crashed. Avoid this race by using a specialized Task instaed of SaveFileManager, and by making the SavePackage callback task scoped. BUG=none TEST=downloads still work, whether or not the downloads dir exists. Review URL: http://codereview.chromium.org/262019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28511 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Draw a strikethrough over bad https.estade@chromium.org2009-10-092-6/+85
| | | | | | | | | TEST=https://metafilter.com BUG=23339 Review URL: http://codereview.chromium.org/261033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28510 0039d316-1c4b-4281-b951-d872f2087c98
* Protect the user against whitelisted external protocol bombardment as well ↵estade@chromium.org2009-10-091-1/+2
| | | | | | | | | | as greylisted. BUG=3628 Review URL: http://codereview.chromium.org/270006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28509 0039d316-1c4b-4281-b951-d872f2087c98
* Disable all browser focus tests on windows. They are hanging or crashing on ↵estade@chromium.org2009-10-091-9/+12
| | | | | | | | | | | the buildbot. BUG=24400 TBR=thakis Review URL: http://codereview.chromium.org/271030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28508 0039d316-1c4b-4281-b951-d872f2087c98
* Support cmd-left/right for history.thakis@chromium.org2009-10-096-19/+145
| | | | | | | | | | | | | | | | | | | | | | Since cmd-left/right should not do history if the omnibox is focussed, but cmd-1-9 should work if the omnibox is focussed, we have to differentiate between window- and browser-level shortcuts. (Because performKeyEquivalent bubbles up from the window -- and if we let it bubble up to the omnibox, then the omnibox handles cmd-left/right just fine, but it swallows cmd-1 and doesn't give us a chance to intercept this. That means cmd-left doesn't work if you hit cmd-l tab, which focusses something that's neither omnibox nor tab contents. This behavior is consistent with safari and camino, and I think it's the best we can do without rewriting event dispatching. Camino does this here: http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWindow.mm#128 http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWrapper.mm#1031 ) BUG=12557 TEST=Focus text box on a web page. cmd-left/right should go to start/end of text. Focus webpage background. cmd-left/right \ should go history back/forward. When the omnibox is focussed, cmd-left/right should move the caret, but cmd-1-9 should still switch tabs. Note that shortcuts still don't work if a subwindow (e.g. find bar, bookmark bubble) has focus. Review URL: http://codereview.chromium.org/251069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28505 0039d316-1c4b-4281-b951-d872f2087c98
* Set size before realizing window in chrome os.davemoore@chromium.org2009-10-091-0/+4
| | | | | | | | Change to avoid race condition over size of popup windows in Chrome OS Review URL: http://codereview.chromium.org/261025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28504 0039d316-1c4b-4281-b951-d872f2087c98
* Replace pthreads locks with chrome locks in syncable.cc.chron@chromium.org2009-10-094-211/+234
| | | | | | | | | | | Replace pthreads with chrome platform thread in syncable unittest. TEST=unit tests included BUG=19895 Review URL: http://codereview.chromium.org/265033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28503 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fix: MetricsService::RecordPluginChanges should handle only pluginsgregoryd@google.com2009-10-092-5/+28
| | | | | | Review URL: http://codereview.chromium.org/264020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28502 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent first-run bubble from getting clipped on high-DPI displays.derat@chromium.org2009-10-093-5/+13
| | | | | | | | | | | | | | | | | | Avoids setting the width of the contents vbox (so it can grow if the combined width of the two buttons exceeds the estimated width of the bubble's text) and fixes an issue where we were getting even-more-bogus estimates due to using an unrealized widget. Also adds a DCHECK() to catch future code that passes unrealized widgets to gtk_util::GetWidgetSizeFromResources() (I checked the existing calls to it and they all look fine). BUG=23367 TEST=tested first-run bubble on displays with various DPIs (75, 120, 200, etc.) Review URL: http://codereview.chromium.org/265023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28500 0039d316-1c4b-4281-b951-d872f2087c98
* Update the SSLClientAuthHandler to use the thread safe reference counter.mbelshe@google.com2009-10-091-1/+2
| | | | | | | | | | | It does get invoked both on the ui and io threads. BUG=none TEST=none Review URL: http://codereview.chromium.org/267028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28498 0039d316-1c4b-4281-b951-d872f2087c98
* Implement animation using ThrobAnimation.chocobo@google.com2009-10-093-72/+46
| | | | | | | | | Fix so that we show ethernet icon if connected even if wifi is connected. BUG=23923 TEST=none Review URL: http://codereview.chromium.org/262031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28496 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28489 as it broke the linux build.aa@chromium.org2009-10-094-40/+16
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28495 0039d316-1c4b-4281-b951-d872f2087c98
* Make some minor improvements to browser action samples:aa@chromium.org2009-10-098-33/+29
| | | | | | | | | | | | | | | | | Gmail checker: a) fix the name an description b) add an icon to the install dialog c) make the icons in the toolbar a little nicer d) put a question mark in a grey badge when not logged in e) get rid of the blinking Test browser action a) Make it continuously animate since that is really the point of this sample. Review URL: http://codereview.chromium.org/270037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28494 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28404, it seems to break the interactive ui tests in mysterious ways.jcampan@chromium.org2009-10-092-151/+267
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/268024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28492 0039d316-1c4b-4281-b951-d872f2087c98
* Make the max size for ImageTrackingLoader configurable. This makes it so ↵aa@chromium.org2009-10-094-16/+40
| | | | | | | | | | that icons larger than 16px can be used in browser actions. This is not that useful until we fix the inset issue in the browser action buttons though, so I will not be checking it in. Review URL: http://codereview.chromium.org/271029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28489 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the missing memory information functions that memory_test uses.vandebo@chromium.org2009-10-081-4/+57
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28486 0039d316-1c4b-4281-b951-d872f2087c98
* Hide "Undocumented." items in the API reference doc. People found themkathyw@google.com2009-10-081-3/+3
| | | | | | | | | | confusing, and we can easily unhide them while we're working on the doc by editing the top rule in this .css file. TBR=rafaelw Review URL: http://codereview.chromium.org/266032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28485 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ctrl-shift-d to bookmark all tabs.pkasting@chromium.org2009-10-0820-51/+81
| | | | | | | | | | | * Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything. * Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious. BUG=2935 TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs Review URL: http://codereview.chromium.org/266029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
* Move ffmpeg binaries into the Framework package so it can be accssed by ↵ajwong@chromium.org2009-10-082-23/+45
| | | | | | | | | | | Chrome Helper. BUG=24219 TEST=none Review URL: http://codereview.chromium.org/269018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28478 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check file_util::ReadFileToString return.mattm@chromium.org2009-10-081-1/+1
| | | | | | | | | | CID=6217 TEST=none BUG=none Review URL: http://codereview.chromium.org/257039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28476 0039d316-1c4b-4281-b951-d872f2087c98
* Remove comments and const_cast that is no longer necessary with the latest Skia.brettw@chromium.org2009-10-082-8/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/262017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28470 0039d316-1c4b-4281-b951-d872f2087c98
* Add a ticks counter that tells you how idle is a render processcpu@chromium.org2009-10-084-0/+36
| | | | | | | | | | | | | | | It gives you a timedelta since the last time it was known that the renderer was active - so far receiving a message from the renderer seems a simple heuristic. - The goal is to use it to prioritize the use of hot renderers or do something to cold ones. BUG=none TEST=test included Review URL: http://codereview.chromium.org/267018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28469 0039d316-1c4b-4281-b951-d872f2087c98
* Measure the sync wizard dialog in appropriate units:nick@chromium.org2009-10-0852-103/+113
| | | | | | | | | | | | | | | | | | | | | | | | | specifically, units proportional to the fonts used inside of it. We approximate the font chosen by the wizard's CSS. In actuality, the CSS chooses a font-face "arial", "sans-serif". We just use the default sans serif font; arial is the default value for that property. This fixes an issue where changing to the "Windows Classic" theme on Vista would cause the dialog to be resized, clipping its contents, which are unaffected by the UI font size. Update the default GRIT sizes to closely match the old ones. Old vs new: http://www.corp.google.com/~ncarter/wizard-size-screenshots.png BUG=21828 TEST=verified old size against new size in Aero Theme with default settings; verified size stays the same under Classic theme. Review URL: http://codereview.chromium.org/261017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28465 0039d316-1c4b-4281-b951-d872f2087c98
* Make the signature for 23780 more generic.huanr@chromium.org2009-10-081-1/+1
| | | | | | | | | TEST=none BUG=23780 Review URL: http://codereview.chromium.org/266030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28464 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to unload the HistoryBackend.pkasting@chromium.org2009-10-0813-70/+147
| | | | | | | | | | A small number of places used accessors like in_memory_url_database() or backend_loaded() with the expectation that if they weren't already functional, the history system was in the process of making them so. I elected to make both of these functions that triggered lazy backend initialization. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/267019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28461 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass file parameter by reference.jhawkins@chromium.org2009-10-082-2/+4
| | | | | | | | | CID=6423 BUG=none TEST=none Review URL: http://codereview.chromium.org/265046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28458 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls WebDragDest out of TabContentsViewGtk so that it can be used bysky@chromium.org2009-10-087-236/+301
| | | | | | | | | | | both views and gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/265041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28457 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASSERT_TRUE, not ASSERT_NE.jhawkins@chromium.org2009-10-081-1/+1
| | | | | | | | | TBR=mpcomplete BUG=none TEST=none Review URL: http://codereview.chromium.org/270033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28455 0039d316-1c4b-4281-b951-d872f2087c98
* Hung Renderer dialog should dismiss with "Wait" for Enter or Escmark@chromium.org2009-10-086-135/+148
| | | | | | | | | | | | HungRendererDialog.xib: made the "Wait" button's use Return as its normal key equivalent; changed the "Wait" button's class to MultiKeyEquivalentButton. BUG=21074 TEST=about:hang. Return, Enter, Esc, and Command-. (period) should all dismiss the Hung Renderer dialog with "Wait". Review URL: http://codereview.chromium.org/266026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28454 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enable "Edit Search Engines" in Omnibox context menu.shess@chromium.org2009-10-088-23/+201
| | | | | | | | | | | | | | Side effect of making the editor a singleton. http://crbug.com/22512 http://crbug.com/22648 TEST=Right-click in Omnibox, "Edit Search Engines" should bring up the editor. TEST=Right-click in a popu's Omnibox, no such option on menu. TEST=Open prefs, select Basic/Manage, close prefs. Repeat, should not get a second window. Review URL: http://codereview.chromium.org/220040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28453 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Assert that GetMutableDictionary returns a non-NULL dictionary.jhawkins@chromium.org2009-10-081-2/+3
| | | | | | | | | CID=6421 BUG=none TEST=none Review URL: http://codereview.chromium.org/270030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28452 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: DCHECK that we got a valid dictionary.jhawkins@chromium.org2009-10-081-0/+1
| | | | | | | | | CID=6420 BUG=none TEST=none Review URL: http://codereview.chromium.org/262029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28451 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Resize status bubble when window is resized.viettrungluu@chromium.org2009-10-086-9/+86
| | | | | | | | | BUG=22956 TEST=Load a (slow-loading) web site so that a status bubble will appear and be visible for a while. While the status bubble is visible, resize the window. The status bubble should move and/or resize appropriately. Review URL: http://codereview.chromium.org/266018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28448 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserFocusTest.BrowsersRememberFocus as it is crashing thezork@google.com2009-10-081-1/+7
| | | | | | | | | | interactive UI tests in win. BUG=none TEST=none Review URL: http://codereview.chromium.org/270029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28447 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to create a bookmark folder populated with a bookmarksky@chromium.org2009-10-0814-97/+290
| | | | | | | | | | | | | | | for each open tab. I've currently wired this up on windows, will wire up rest of platforms in a separate cl. BUG=2935 TEST=on Windows open multiple tabs, right click on a tab and choose 'Bookmark all tabs'. You should then get the bookmark editor with no url field. Accepting the dialog should result in creating a new folder with a bookmark for each of the open tabs. Review URL: http://codereview.chromium.org/270021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28446 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: fix possible leak in VisitSegmentDatabase.mattm@chromium.org2009-10-081-2/+2
| | | | | | | | | | | | If we get a non-zero segment_id, a zero segment_id, and another non-zero segment_id, the pud for the zero segment_id will be leaked. A non-zero segment_id shouldn't happen since it refers to a primary-key in the segments table, but this changes it to check directly whether a pud has been created, and thus makes it more error-proof. This should be safe, as pud is only stored into the list in two places, in the first it is immediately replaced with a new pud, in the second it is storing the final pud (if any.) CID=6379 TEST=none BUG=none Review URL: http://codereview.chromium.org/265027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28445 0039d316-1c4b-4281-b951-d872f2087c98
* Move MostVisitedHandler into a separate file because it's big.tony@chromium.org2009-10-085-811/+862
| | | | | | | | | I'm going to be modifying this file a lot and the single big file was hard to work with. Review URL: http://codereview.chromium.org/265040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28435 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of mac_app_names.h. Replace it with real constants frommark@chromium.org2009-10-088-45/+26
| | | | | | | | | | | | | | | | | chrome_constants.h. As a side effect of this change, tests will use the framework in the build directory as their main bundle override for the purposes of resource loading, instead of looking into the framework inside the application bundle. This should be more than sufficient, and is done for simplicity, because a future change will make it more difficult to locate the correct framework inside the application bundle unless the product version number is known. BUG=24220 TEST=product still works and all tests still pass Review URL: http://codereview.chromium.org/266023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28431 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserFocusTest.ClickingMovesFocus as it is crashing the ↵jhawkins@chromium.org2009-10-081-1/+10
| | | | | | | | | | | interactive UI tests in win. TBR=zork BUG=none TEST=none Review URL: http://codereview.chromium.org/265043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28430 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Remove pthreads from ServerConnectionManager and notifier.tim@chromium.org2009-10-086-74/+38
| | | | | | | | BUG=19895 Review URL: http://codereview.chromium.org/266011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28429 0039d316-1c4b-4281-b951-d872f2087c98
* Add about:memory link to task manager.thakis@chromium.org2009-10-087-77/+120
| | | | | | | | | | | | | Since about:memory DCHECK()s atm, the link is not completely hooked up. In the xib, I've added a square button with height 14 and the new HyperlinkCell, contained in a GTMWidthBasedResizer or how it's called. I made sure the baseline of link on the left and button on the right is at the same height. BUG=17989,13156 TEST=Open MainMenu.xib, click "Enable" for view->dev->taskman. Build&run chrome. Task manager should contain link. Review URL: http://codereview.chromium.org/255018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28426 0039d316-1c4b-4281-b951-d872f2087c98
* cleanup: Change AddTabWithNavigationController to simply AddTab.evan@chromium.org2009-10-082-12/+8
| | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/243013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28420 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the plugin HWND doesn't disappear before the plugin gets ↵jam@chromium.org2009-10-0811-70/+25
| | | | | | | | | | NPP_SetWindow with a null HWND. BUG=23694 TEST=tried really hard to write an automated test but couldn't since it's a race condition that repros this (i.e. IO thread is busy and windows message gets dispatched on the UI thread first) Review URL: http://codereview.chromium.org/268012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28418 0039d316-1c4b-4281-b951-d872f2087c98
* Remove auto-open files from the download shelf on auto-open. This is the Gtk ↵thakis@chromium.org2009-10-081-0/+4
| | | | | | | | | | | version of r20787 / r28391. BUG=None, see http://codereview.chromium.org/268008 . TEST=download a theme, make sure that it doesn't stay in the download shelf. Review URL: http://codereview.chromium.org/262022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28417 0039d316-1c4b-4281-b951-d872f2087c98
* Add functionality to the renderer thread to purge memory. Not yet called.pkasting@chromium.org2009-10-083-0/+39
| | | | | | | | BUG=23400 TEST=none Review URL: http://codereview.chromium.org/267021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28415 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of making sync work on Mac:munjal@chromium.org2009-10-0815-41/+152
| | | | | | | | | | | | | | | | | | | | - Add high res timer class for mac (we might eventually replace all timer classes with Chrome ones) - Define POSIX for OS==mac where needed - Add new liens at the end of some files since otherwise they produce errors on Mac - Rearrange initializer list of constructors to match declaration order in header; these become warning as error. - Some chrome.gyp magic At this point the code compiles but doesn't link due to some missing code on Mac like SSL stuff. But I thought this was a good check point. Note that chrome.gyp magic might change in future. BUG=none TEST=none Review URL: http://codereview.chromium.org/255053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28414 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 22:26:48 +0000