summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Change a bunch of string types.estade@chromium.org2010-06-29136-885/+886
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* Stretch the roster to fill its window and enable scrollingseh@chromium.org2010-06-292-2/+3
| | | | | | | if it exceeds its window's height. Review URL: http://codereview.chromium.org/2834029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51156 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmarks: Fix Cmd+A on Macarv@chromium.org2010-06-291-2/+10
| | | | | | | | | BUG=47241 TEST=Navigate between a few folders and then click on the right pane. Now hit Cmd+A. Review URL: http://codereview.chromium.org/2832034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51155 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new type of button cell for bookmark bar buttons that don't darken ↵pinkerton@chromium.org2010-06-294-2/+9
| | | | | | | | | | when pressed, leaving "standard" buttons (like used on the toolbar) to darken as expected. BUG=44574 TEST=test bookmark buttons and toolbar buttons with different themes, make sure the appearance isn't crappy Review URL: http://codereview.chromium.org/2866031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51154 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a known crash in HTML5DocumentParser::write() which has been fixedtonyg@chromium.org2010-06-291-4/+0
| | | | | | | | | | | upstream. This is guaranteed to work as the HTML5DocumentParser class has since been renamed to HTMLDocumentParser. BUG=47080 TEST=None Review URL: http://codereview.chromium.org/2807030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51152 0039d316-1c4b-4281-b951-d872f2087c98
* Disable all UnloadTest tests using LoadUrlAndQuitBrowser on Linuxstuartmorgan@chromium.org2010-06-291-18/+11
| | | | | | | | | | | TBR=erikkay BUG=47575 TEST=Greener bot Review URL: http://codereview.chromium.org/2822037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51151 0039d316-1c4b-4281-b951-d872f2087c98
* Translate infobar always/never translate buttonsjcivelli@chromium.org2010-06-2911-10/+241
| | | | | | | | | | | | | | | Adding extra buttons on the translate infobar to let user easily set the "never/always translate this language" property when they declined/accepted translation for a language more than 3 times. Original review: http://codereview.chromium.org/2825015/show BUG=NONE TEST=Visit a page in a foreign language, translate the page. Repeat 4 times. On the fourth time, the "before translate" infobar should show a button that says "always translate". Similarly when declining translations 4 times. Review URL: http://codereview.chromium.org/2835025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51148 0039d316-1c4b-4281-b951-d872f2087c98
* Remove download check for web store apps (temporarily).rafaelw@chromium.org2010-06-291-10/+0
| | | | | | | | | | There's still discussion about the design for this, so to minimize breakage on the dev channel, I'm backing the check out temporarily. BUG=47675,45542 Review URL: http://codereview.chromium.org/2815035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51146 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Display the correct number of restorable tabs in the History menu.rsesek@chromium.org2010-06-291-9/+15
| | | | | | | | | BUG=47797 TEST=Open a new window, create 4 NTP tabs and 1 navigated tab. Close the window. The History menu has a "1 Tab" submenu with the navigated page. Review URL: http://codereview.chromium.org/2800032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51145 0039d316-1c4b-4281-b951-d872f2087c98
* Follow-up on http://codereview.chromium.org/2861019 to address Powel's comments.jrg@chromium.org2010-06-292-18/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2821018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51144 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar facelift. Main buttons larger and more spread out, only get borders ↵pinkerton@chromium.org2010-06-297-27/+46
| | | | | | | | | | | when mouse is inside. Fix to gradient button to not show border on mouseover when disabled. Adjust "overlap" between the toolbar and bookmark bar to allow for larger buttons w/out clipping. Nib change: All buttons changed to not bordered, button cell tags are 0. Buttons are 31x31 and spread out a bit more. BUG=44574 TEST=toolbar and bookmark bar appearance, hidden, always showing, and detached on NTP. Review URL: http://codereview.chromium.org/2806041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51143 0039d316-1c4b-4281-b951-d872f2087c98
* Use InvalidationClient::Create() instead of creating an Impl directly.akalin@chromium.org2010-06-293-10/+7
| | | | | | | | | BUG=34647 TEST=none Review URL: http://codereview.chromium.org/2836032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51140 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for allowing a parent GGL context to be destroyed before all ↵apatrick@chromium.org2010-06-291-6/+7
| | | | | | | | | | | | of its children. I made the parent_ pointer a WeakPtr. It is correct to not free the offscreen texture ID if the parent is destroyed first. It is freed as part of the parent's destruction. TEST=trybot BUG=47594 Review URL: http://codereview.chromium.org/2882004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51139 0039d316-1c4b-4281-b951-d872f2087c98
* Removes control-alt-b accelerator. Turns out control-alt acceleratorssky@chromium.org2010-06-293-4/+0
| | | | | | | | | | | are bad. BUG=44797 TEST=make sure control-alt-b doesn't work. Review URL: http://codereview.chromium.org/2885003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51138 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to animate the balloon before it's been shown, it will cause a crash.johnnyg@chromium.org2010-06-291-1/+1
| | | | | | | | | BUG=47809 TEST=notifications on windows Review URL: http://codereview.chromium.org/2861035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51137 0039d316-1c4b-4281-b951-d872f2087c98
* Disable another crashing unload test on Linuxstuartmorgan@chromium.org2010-06-291-1/+5
| | | | | | | | | | | TBR=erikkay BUG=47575 TEST=Greener bots Review URL: http://codereview.chromium.org/2887001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51136 0039d316-1c4b-4281-b951-d872f2087c98
* Don't re-store deleted passwords on form submit on the Macstuartmorgan@chromium.org2010-06-294-31/+224
| | | | | | | | | | | | Adds test coverage for the various update cases to make sure they are all handled correctly. Also fixes a regression during the recent PasswordStore refactoring that caused the Mac implementation to run queries on the wrong thread (found by the new unit tests). BUG=35603 TEST=See bug; other password update cases should continue to work as before. Review URL: http://codereview.chromium.org/2818035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51135 0039d316-1c4b-4281-b951-d872f2087c98
* Stop tracking a drag after the user drops the dragged item.mrossetti@chromium.org2010-06-291-1/+1
| | | | | | | | | BUG=44407 TEST=Perform the steps outlined in the bug and verify that after step #5 the folders are no longer still active. Review URL: http://codereview.chromium.org/2849026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher with the translate infobar.jcivelli@google.com2010-06-293-53/+55
| | | | | | | | | | | | | | | | | Turns out calling Close() from an infobar class to close it is a bad idea as it only removes its associated view so it is not displayed, but the tab contents still belives it is showing. RemoveInfoBar() should be called instead. I made the InfobarContainer methods private and made InfobarContainer a friend to prevent other people from running into the same problem. BUG=47669 TEST=Open a www.google.de In the translate infobar, click Nope. Navigate away from the page, it should not crash. Review URL: http://codereview.chromium.org/2873029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51131 0039d316-1c4b-4281-b951-d872f2087c98
* Show tooltips only for users with identical display names.avayvod@chromium.org2010-06-292-13/+29
| | | | | | | | | | | Tooltip text is changed from email to "<display name> (<domain>)". BUG=cros:2318 TEST=Verify that tooltips are shown only for users with equal display names. Tooltips show display name and domain. Review URL: http://codereview.chromium.org/2877002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51129 0039d316-1c4b-4281-b951-d872f2087c98
* Removes debugging code added in hopes of finding crasher. The crashsky@chromium.org2010-06-292-27/+3
| | | | | | | | | | | doesn't appear in latest logs, so no point in keeping the code around. BUG=44642 TEST=none Review URL: http://codereview.chromium.org/2824036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51128 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserCloseUnload on Linuxstuartmorgan@chromium.org2010-06-291-1/+3
| | | | | | | | | | | TBR=sky BUG=47575 TEST=Green dbg-shlib Linux bot Review URL: http://codereview.chromium.org/2827035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51127 0039d316-1c4b-4281-b951-d872f2087c98
* Grd strings for password changed dialog.nkostylev@google.com2010-06-291-0/+15
| | | | | | | | | BUG= http://crosbug.com/323 TEST=none Review URL: http://codereview.chromium.org/2870033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51126 0039d316-1c4b-4281-b951-d872f2087c98
* Adding stack trace to known crashes list.mnaganov@chromium.org2010-06-291-0/+4
| | | | | | | | | BUG=47846 TBR=dglazkov,patrick,huanr Review URL: http://codereview.chromium.org/2847034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51125 0039d316-1c4b-4281-b951-d872f2087c98
* Make the location bar generate accessibility extension API events on ↵dmazzoni@chromium.org2010-06-2910-20/+112
| | | | | | | | | | | linux/views. BUG=none TEST=none Review URL: http://codereview.chromium.org/2811023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51124 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run ExtensionsServiceTest.ReloadExtensions under ThreadSanitizertimurrrr@chromium.org2010-06-291-0/+3
| | | | | | | | BUG=47843 TBR=glider Review URL: http://codereview.chromium.org/2827034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51122 0039d316-1c4b-4281-b951-d872f2087c98
* Adding stack trace to known crashes list.mnaganov@chromium.org2010-06-291-1/+5
| | | | | | | | | BUG=47839 TBR=patrick,dglazkov Review URL: http://codereview.chromium.org/2855028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51120 0039d316-1c4b-4281-b951-d872f2087c98
* Expand print-related IPCs so we can implement CSS3 paged media.hamaji@chromium.org2010-06-292-4/+37
| | | | | | | | | | | | | | | | | | | | The members added into ViewMsg_Print_Params will be used to tell printers' setting to renderer process. Maybe ViewMsg_Print_Params::printable_size should be printable_area, but I've just added margin_top and margin_left for now because printable_size is used from several code so I wanted to avoid a big change. The members added into ViewHostMsg_DidPrintPage_Params will be used to tell web authors' page setting to browser process. BUG=47277 TEST=none Review URL: http://codereview.chromium.org/2805045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51117 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 451.0 to 452.0chrome-release@google.com2010-06-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51112 0039d316-1c4b-4281-b951-d872f2087c98
* Group plugins in about:plugins and show update link for out-of-date ones.bauerb@chromium.org2010-06-2910-255/+979
| | | | | | | | | | | | | | | | Tracking patch by mavrommatis, original review here: <http://codereview.chromium.org/1991005> Original description follows: (1) Group plugins with the same name together. (2) Show a download link for plugin versions with known security problems in about:plugins. BUG=3910 TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Review URL: http://codereview.chromium.org/2835018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51110 0039d316-1c4b-4281-b951-d872f2087c98
* Provide more descriptive logging for OOBE update.nkostylev@google.com2010-06-291-1/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2886001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51107 0039d316-1c4b-4281-b951-d872f2087c98
* Implement limited paged media support for linux.hamaji@chromium.org2010-06-291-13/+101
| | | | | | | | | BUG=47277 TEST=none Review URL: http://codereview.chromium.org/2847025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51104 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple UI test for --app mode.scherkus@chromium.org2010-06-291-1/+28
| | | | | | | | | | | The --app browser launch code path was previously untested, which resulted in us shipping a release where it was broken. BUG=47544 TEST=ui_tests Review URL: http://codereview.chromium.org/2847032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51100 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: delete the unencrypted login database file after a successful ↵mdm@chromium.org2010-06-295-77/+81
| | | | | | | | | | password store migration, since otherwise fragments of password data may be left in it. BUG=25404 TEST=the "Login Data" file should get deleted and recreated from scratch after migration Review URL: http://codereview.chromium.org/2866023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51094 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Gray out uneditable search URLs.tfarina@chromium.org2010-06-291-1/+26
| | | | | | | | | | | | Change the appearence of the url entry to be like disable, so the user doesn't begin confused. BUG=34476 TEST=see bug Review URL: http://codereview.chromium.org/2823030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51093 0039d316-1c4b-4281-b951-d872f2087c98
* [chromeos]Fix input method switching shortcut keys.suzhe@chromium.org2010-06-291-7/+2
| | | | | | | | | BUG=http://crosbug.com/3892 TEST=manually Review URL: http://codereview.chromium.org/2835023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51092 0039d316-1c4b-4281-b951-d872f2087c98
* Added ModelType <-> server sync type mappings and used them.akalin@chromium.org2010-06-294-25/+108
| | | | | | | | | BUG=34645 TEST=manual Review URL: http://codereview.chromium.org/2856019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51089 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken delegate reference in IB file.johnnyg@chromium.org2010-06-291-1/+9
| | | | | | | | | BUG=34627 TEST=none Review URL: http://codereview.chromium.org/2803026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51088 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of an obsolete test for page options prefnirnimesh@chromium.org2010-06-291-6/+0
| | | | | | | | Page options button pref has been removed. Remove the test. Review URL: http://codereview.chromium.org/2810036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51080 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionInfobarGtk now take up available width.rafaelw@chromium.org2010-06-287-27/+76
| | | | | | | | | | | | | This patch allows ExtensionInfoBarGtk to use the actual width of the infobar for display of the content. This involves factoring out of ExtensionViewGtk a similar pattern that exists on Views -- namely a Container interface that allows containers to decide how to react to PreferredWidthChanged notifications BUG=39916 TEST=none Review URL: http://codereview.chromium.org/2877003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo.michaeln@chromium.org2010-06-281-1/+1
| | | | | | | | | BUG=none TEST=none TBR=jianli git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51069 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed app name used for server-issued notifications.akalin@chromium.org2010-06-281-5/+5
| | | | | | | | | BUG=34647 TEST=none Review URL: http://codereview.chromium.org/2876014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51067 0039d316-1c4b-4281-b951-d872f2087c98
* No actual code change. Just added more logging information to helpgene@chromium.org2010-06-282-5/+44
| | | | | | | | | | | debugging cloud print proxy in the production environment. BUG=none TEST=Run cloud print proxy with --log-filter-prefix="CP_PROXY" and verify new information get logged. Review URL: http://codereview.chromium.org/2801019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51066 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent hitting DCHECK when multiple slashes are specified in ↵eroman@chromium.org2010-06-281-0/+7
| | | | | | | | | chrome://devtools///. BUG=47699 Review URL: http://codereview.chromium.org/2829028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51065 0039d316-1c4b-4281-b951-d872f2087c98
* Push change for stevenjb:chocobo@chromium.org2010-06-285-38/+115
| | | | | | | | | | | | Issue 2848016: Store wifi network in network_menu_button.cc as a path instead of as a struct. Store wifi network in network_menu_button.cc as a path instead of as a struct. This should address a potential edge case where wifi network information gets updated after the menu is opened and before a network is selected. BUG=None TEST=None Review URL: http://codereview.chromium.org/2817036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51064 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a build failure caused by the patch of ↵suzhe@chromium.org2010-06-281-1/+0
| | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=41244 BUG=none TEST=none Review URL: http://codereview.chromium.org/2860033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51063 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA logging of search engine selection position when the search engine ↵mirandac@google.com2010-06-284-10/+58
| | | | | | | | | | | logo positions have been randomized. BUG=46604 TEST=none Review URL: http://codereview.chromium.org/2846038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51061 0039d316-1c4b-4281-b951-d872f2087c98
* Run appcache layout tests in chrome using the ui test harness. michaeln@chromium.org2010-06-284-4/+91
| | | | | | | | | BUG=39365 TEST=yes Review URL: http://codereview.chromium.org/2879003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51059 0039d316-1c4b-4281-b951-d872f2087c98
* Remove #define cruft around ExtensionApiTest.TabOnRemoved.skerner@chromium.org2010-06-281-8/+1
| | | | | | | | | | | ExtensionApiTest.TabOnRemoved was disabled on Chrome OS. I fixed the issue a while ago, but did not remove some #defines. BUG=43440 TEST=ExtensionApiTest.TabOnRemoved Review URL: http://codereview.chromium.org/2872018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51057 0039d316-1c4b-4281-b951-d872f2087c98
* PyAuto: Collect branding info as a part of GetBrowserInfo()nirnimesh@chromium.org2010-06-282-5/+11
| | | | | | | | | Also, use command_line_string() from base/command_line.h which is cross-platform now. Review URL: http://codereview.chromium.org/2800029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51055 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 11:11:34 +0000