| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr@chromium.org,
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3149026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
TBR=brettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
worked correctly.
I think there might still be a place for this, but it is in
Browser::AdjustWindowOpenDispositionForTab(), which is a much more
constrained use case, and also isn't working correctly, because
it lacks knowledge of apps.
BUG=52442
Review URL: http://codereview.chromium.org/3199004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It turns out to be reasonably common not to have a host for some URLs, such
as data: URLs, and the extra logging actually slows down feature extraction
significantly.
Review URL: http://codereview.chromium.org/3198003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I
couldn't remove ViewHostMsg_DocumentLoadedInFrame/
NavigationController::DocumentLoadedInFrame since it accumulated other usages
since then.
(second attempt of r56693, this time with updated unit tests)
BUG=40395
TEST=manual testing with hp.com and keyboard shortcut search experiment,
history_uitest
Review URL: http://codereview.chromium.org/3124035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to (but not limited to) allow system update notification to have "restart" button.
* BalloonHost::EnableDOMUI() to enable DOMUI in notification page.
* chromeos::BalloonCollectionImpl::AddDOMUIMessageCallback to add
a callback for given DOMUI message.
* Added two tests cases (see below)
BUG=chromium-os:5810
TEST=TestAddDOMUIMessageCallback and TestDOMUIMessagCallback are added to notification_browsertest
Review URL: http://codereview.chromium.org/3186016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jmikhail@google.com
BUG=none
TEST=chromdriver pass on multi-dll build
Review URL: http://codereview.chromium.org/3167025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3186018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The parameter describes a list of Values that act as parameters to the callback. It is always a ListValue. It should be typed as such.
BUG=none
TEST=compile; manual testing
Review URL: http://codereview.chromium.org/3146019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.
TEST=ui_tests in Release mode
BUG=49838
Review URL: http://codereview.chromium.org/2805100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser chrome. This doesn't fix problems with the NTP background image offsets (see bug 51853).
This also makes sure the OTR avatar is reversed in RTL mode, and clipped as usefully as possible when there isn't enough room for the full image.
BUG=44157
TEST=Frame, toolbar, bookmark bar, and find bar all look lined up with default and custom themes, restored and maximized, LTR and RTL, side tabs and normal tabs, and in popup and app windows
Review URL: http://codereview.chromium.org/3137019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=52750
Review URL: http://codereview.chromium.org/3171020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that the linux certs webpage is displayed in a new tab (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3116022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51786
TEST=valgrind stays green
Review URL: http://codereview.chromium.org/3183019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------
Make the saved passwords tab work.
BUG=49093
TEST=None
------------
TBR=sargrass
Review URL: http://codereview.chromium.org/3108034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We shouldn't have people in the NO group of the field trial generating
prefetching histograms. This CL removes them.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3132016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With r51258 we started requiring the TLS renegotiation extension from a
whitelist of servers that we knew supported it. When Chrome is getting MITM
attacked, this extension can be removed and this broke some debugging tools
(which intercept SSL connections) and some proxies which do the same.
This patch causes us to expect to be MITM attacked when tunneling via an HTTP
proxy and when the --allow-ssl-mitm-proxies command line flag is given.
BUG=48485
TEST=Can't really test without one of these MITM proxy machines.
http://codereview.chromium.org/3111019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jmikhail
BUG=51346
Review URL: http://codereview.chromium.org/3191010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CAPTCHA code from existing user controller and plumb into google
authenticator2.
TEST=Install ChromeOS build. Hit Captcha. Enter captcha.
BUG=50408
Review URL: http://codereview.chromium.org/3134009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests, chrome_frame_tests
BUG=52097
Review URL: http://codereview.chromium.org/3191009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If IPC send fails, further automation calls are extremely likely to fail.
Avoid wasting a lot of time on further timeouts by closing the channel
immediately on the first error.
TEST=ui_tests
BUG=51346
Review URL: http://codereview.chromium.org/3131020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52669
Review URL: http://codereview.chromium.org/3140018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3153023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
utf_string_conversions.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3148019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51084
TEST=none
Original review=http://codereview.chromium.org/3124033/show
Patch by alekseys@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Broke compile.
TBR=rkc
Review URL: http://codereview.chromium.org/3199006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51084
TEST=Run interactive_ui_tests and browser_tests.
New:
- sidebar Extension API (design doc: https://docs.google.com/a/google.com/Doc?docid=0AV4Qg3xyZ8RQZGZtbWIydDJfNWc0eHJtbmRm&hl=en);
- Sidebar panel in Chrome browser view;
Original review=http://codereview.chromium.org/2836040/show
Patch by alekseys@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa
TEST=unit_tests
BUG=52731
Review URL: http://codereview.chromium.org/3148027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in
base/ref_counted.h, not in base/scoped_ptr.h.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3132024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3149020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Backend: Various reports submitted from Chrome OS and Windows builds
sent to the feedback test server. For Chromium OS, sent reports
with current screenshot and saved screenshots; verified all reports
for data accuracy and completion.
Frontend: Tested the UI features by excersizing various options; tested
not selecting any issue, tested switching between screenshot types.
Review URL: http://codereview.chromium.org/3181027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also limit the url length when it is too long.
BUG=52624
TEST=none.
Review URL: http://codereview.chromium.org/3122026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Test=none
Bug=52624
Review URL: http://codereview.chromium.org/3169022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactors common elements (favicon source, CSS styling) from the subpages and the main page into shared locations. Also fixes a few small existing mistakes in comments and function naming.
BUG=48713
TEST=DOMUI prefs should show favicons for startup pages.
Review URL: http://codereview.chromium.org/3112017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
includes to other files
Review URL: http://codereview.chromium.org/3142019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Doc updates will follow in another CL.
BUG=48117
TEST=ExtensionsServiceTest.(UpdatePendingExternalCrx,UpdatePendingCrxThemeMismatch,ExternalPrefProvider), ExtensionManagmentTest.ExternalUrlUpdate, manual testing.
Review URL: http://codereview.chromium.org/3005057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3125025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Undo user gesture detection added to NavigationController by r18373, since
WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I
couldn't remove ViewHostMsg_DocumentLoadedInFrame/
NavigationController::DocumentLoadedInFrame since it accumulated other usages
since then.
Contributed by mihaip@chromium.org
BUG=40395
TEST=manual testing with hp.com and keyboard shortcut search experiment,
history_uitest
Review URL: http://codereview.chromium.org/3168013
TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/3104021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in linux_syscall_support.h that allows us to mark all places where we
embedd direct system calls. This allows the sandbox to rewrite them as
needed.
Also mark a few system calls as having ignored return codes. This makes
some compilers happy and prevents warning messages.
Finally, add more verbose error messages if crashdumping fails. There are
various reasons why breakpad can be prevented from doing its job. And
these error messages have proven helpful. We should leave them in the
production binary.
TEST=add --enable-seccomp-mode to command line and go to about:crash
BUG=37728
Review URL: http://codereview.chromium.org/3122028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I
couldn't remove ViewHostMsg_DocumentLoadedInFrame/
NavigationController::DocumentLoadedInFrame since it accumulated other usages
since then.
Contributed by mihaip@chromium.org
BUG=40395
TEST=manual testing with hp.com and keyboard shortcut search experiment,
history_uitest
Review URL: http://codereview.chromium.org/3168013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3130030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add RenderWidgetFullscreen(Host) subclasses, InitAsFullscreen method
to RenderWidgetHostView, and add two new ipc messages for creating
and showing full screen.
Add createFullscreenWindow to RenderView that creates RenderWidgetFullscreen
and sends message to browser which eventually creates RenderWidgetFullscreenHost.
The show method on RenderWidgetFullscreen sends message to parent
RenderViewHost in browser, which calls InitAsFullscreen on the view.
BUG=16735
TEST=RenderViewHostTest.CreateFullscreenWidget
Review URL: http://codereview.chromium.org/3055009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of wstring BookmarkModel::AddGroup() (and convert lots of uses; also
convert many uses of the wstring AddURL() as drive-by's).
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3115017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed if already running.
BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning
Review URL: http://codereview.chromium.org/3161020
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3163025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now with Fixed Unit Tests!
Run with --enable-resource-content-settings and --enable-click-to-play to enable.
TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.
The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.
Screenshot of the plugin bubble: http://imgur.com/6npqv.png
Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.
XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.
BUG=39252,38432
TEST=HostContentSettingsMapTest.*,manual
Review URL: http://codereview.chromium.org/2873104
Review URL: http://codereview.chromium.org/3124018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
too much text, and click+drag can take a while, for large amounts of text.
Bug=none
Test=Press the button
Review URL: http://codereview.chromium.org/3124029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the hood" dialog, if a corresponding policy is enabled or disabled during runtime on Windows.
BUG=52578
TEST=manual
Review URL: http://codereview.chromium.org/3129012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
already running.
BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning
Review URL: http://codereview.chromium.org/3161020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56683 0039d316-1c4b-4281-b951-d872f2087c98
|