| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=53248
TEST=none
Review URL: http://codereview.chromium.org/3126031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*
Review URL: http://codereview.chromium.org/3104032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Convert the languages parameters in bookmark_utils.* to std::string.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3169043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3137039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash while drawing the movie frames cannot handle being sized 0-by-0 and
a storm of math exception happen which prevents flash from pumping messages
BUG=52754
TEST=see bug
Reverting because Adam's fix for hulu obviates this workarround which can
have side effect elsewhere. See the bug.
Review URL: http://codereview.chromium.org/3132043
TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/3150038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out the common code so that Mac and Linux may share the new flow with Windows (e.g., import is done before the first run dialog appears).
Windows *should* be unaffected by this change. Linux has some non-user-visible changes. The user visible changes (showing the default search engine in the ballot, for example) are TODO.
BUG=49705,47651
TEST=launching chromium with --first-run works as expected, i.e. it imports stuff from your default browser (such as history); if that browser is firefox and firefox is open, the failure is silent.
Review URL: http://codereview.chromium.org/3171029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Committing for skare@google.com, original change at http://codereview.chromium.org/3074002/show .
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3189022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53354
r=mbeleshe
Review URL: http://codereview.chromium.org/3161043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
after realizing it, to get correct font info.
TEST=the button text no longer gets cut off with some fonts
BUG=52117
Review URL: http://codereview.chromium.org/3149033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests, chrome_frame_tests
BUG=52097
Review URL: http://codereview.chromium.org/3108049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
autofillable page encountered.
Reverting so we can address jhawkins concerns before relanding.
BUG=51831
TEST=In the bug.
Review URL: http://codereview.chromium.org/3149005
TBR=georgey@chromium.org, jhawkins@chromium.org
Review URL: http://codereview.chromium.org/3135050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The problem is timing related so I am unable to write a unit test which proves this fixes things. The essence of the change is to make sure we don't send messages to objects which no longer exist by clearing the delegate pointer in objects we own before we go away (where "we" is an object). The delegate pattern does not get retained, which gives certain objects to hold dangling pointers.
BUG=53205 http://crbug.com/53205
Review URL: http://codereview.chromium.org/3158031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes AutoFill heuristics to match against only form input element types that we actually fill.
BUG=47925
TEST=FormStructureTest.MatchSpecificInputTypes
Review URL: http://codereview.chromium.org/3153038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Produce gtest style output with pyauto.
This makes it easy to digest pass/fail status for individual tests ("OK" is more discoverable than '.' in the output log). And makes it easier to associate LOG messages from chrome with the individual tests triggering them.
BUG=42148
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56951
Review URL: http://codereview.chromium.org/3191014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
card overlays in response to user input.
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3199018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3159028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
per stream.
TEST=unittests
BUG=39825
Review URL: http://codereview.chromium.org/3185022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
has been reported as still happening.
BUG=47758
TEST=none
Review URL: http://codereview.chromium.org/3197020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For details, see http://codereview.chromium.org/3134032
In addition, revise SpellCheckTest.SpellCheckText to test two Hebrew words
with an ASCII double/single quotation mark in the middle.
BUG=22909, 34009
TEST=1. SpellCheckTest.SpellCheckText
2. Go to http://crbug.com/22909 and type several words mentioned in the report with the spellcheck language set to Hebrew. They shouldn't be marked as misspelled. A unittest will be added when DEPS is rolled for ICU.
3. In Hungarian chrome (on Windows, start Chrome with --lang=hu. on Linux, start Chrome with 'LANGUAGE=hu chrome'), Vietnamese is translated as 'vietnami' (without any accent) in the language menu.
TBR=hbono
Review URL: http://codereview.chromium.org/3174034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash while drawing the movie frames cannot handle being sized 0-by-0 and
a storm of math exception happen which prevents flash from pumping messages
BUG=52754
TEST=see bug
Review URL: http://codereview.chromium.org/3132043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the same page. This happens with links pointing to a location within the current page.
BUG=52943
TEST=none
Review URL: http://codereview.chromium.org/3205002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension. This means that users will need to use --enable-benchmarking
to access it. It really shouldn't be part of the exposed API.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3126029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
encountered.
BUG=51831
TEST=In the bug.
Review URL: http://codereview.chromium.org/3149005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47320
TEST=compiles
Review URL: http://codereview.chromium.org/3184021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
general AlertOverlay class.
BUG=53241
TEST=Exercice the 'Reset to Defaults' button in the dom-ui options window.
Review URL: http://codereview.chromium.org/3140027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3161036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- FormManagerTest.LabelsInferredFromParagraph
- RenderViewTest.OnHandleKeyboardEvent
TBR=dhollowa
TEST=browser_tests
BUG=52643, 52731
Review URL: http://codereview.chromium.org/3152051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename (and resort) every #include.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3173043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3203007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the new preferred size attributes for non-GtkViewsFixed widgets
won't do very much. Put the gtk_widget_size_allocation call back for
those widgets. Add in a small check into the ScreenLockerTest.TestBasic to prevent any future such regression.
BUG=chromium-os:5987
TEST=ScreenLockerTest.TestBasic
Review URL: http://codereview.chromium.org/3181039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
while playing
playlists, etc. The message is displayed when we fail to create a channel for the plugin
process.
The problem occurs because of a race condition between the plugin channel information being
deleted from the channel map and the actual channel being deleted. This race occurs if
the plugin is in the context of a sync call to the renderer which results in the plugin
instance being deleted and the new one getting created in the same context. This results
in the plugin channel information getting deleted from the map. The actual channel gets
deleted only when the plugin sync call unwinds which occurs after the browser sends in
a request to create the channel for the new plugin instance.
Fix is to create the channel name with an incrementing number in the plugin process, if
the mode is server. The channel map is still keyed off the process id and renderer id
as before.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=43595
Bug=43595
Test=Covered by new ui test SelfDeleteCreatePluginInNPNEvaluate.
The other change is a fix in the test plugin to delete a windows timer correctly and
to add support for a new plugin test case.
Review URL: http://codereview.chromium.org/3142039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tommi
Review URL: http://codereview.chromium.org/3132042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
processes. And properly mark variables as local, so that the exit code
from "identify" is correct. Otherwise, we needlessly scan for more
processes when returning from "identify".
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3173046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49254
Review URL: http://codereview.chromium.org/3143043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plumbing code for the remaining operations (Copy, Remove etc) will come later in a separate patch once this one becomes to look good.
BUG=32277
TESTS=none, will be added later
Review URL: http://codereview.chromium.org/3165040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
refactored code to get the stock preferences menu item label out of wrench_menu_model and into gtk_utils where it can be shared.
BUG=37375
TEST=none
Review URL: http://codereview.chromium.org/3175032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52517
TEST=enable compositor and resize the window; there should be no continuous redraws
Review URL: http://codereview.chromium.org/3204004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for all platforms.
BUG=52916
TEST=Compile. Page Info works as before.
Review URL: http://codereview.chromium.org/3175037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
finds all the processes that belong to a given instance of Chrome and
attempts to identify their types (e.g. browser, extension, plugin, zygote,
renderer). It also prints out information on whether a sandbox is active
and what type of sandbox has been identified.
This script is likely to only work on Linux or systems that closely mimick
Linux's /proc filesystem.
TEST=start Chrome, invoke script, verify that it shows different process types
BUG=none
Review URL: http://codereview.chromium.org/3158033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Helps prevent problems when a temporary file suddenly gets deleted by Chrome, in download tests.
Review URL: http://codereview.chromium.org/3192019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46512
TEST=manual
Review URL: http://codereview.chromium.org/3144012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: tommi@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3136014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests, chrome_frame_tests
BUG=52097
Review URL: http://codereview.chromium.org/3167038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3135046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the labels so that the long text can be seen on hover even if it still doesn't fit.
BUG=52789
TEST=open sync setup ui in a language with long words
Review URL: http://codereview.chromium.org/3197019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Convert TreeNodeWithValue's methods to string16.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3198014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
New functional tests to test pause/resume/cancel downloads and more.
Review URL: http://codereview.chromium.org/3163036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
computed display)
and document info (url, title, mimetype, doctype) to WebAccessibility.
BUG=none
TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility
Review URL: http://codereview.chromium.org/3013035
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/3132040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes painting a bit uglier, but that's better than a deadlock.
BUG=52798
TEST=see bug
Review URL: http://codereview.chromium.org/3107035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57328 0039d316-1c4b-4281-b951-d872f2087c98
|