summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-pagefinnur@google.com2008-12-045-62/+144
| | | | | | | | | | | | | | | I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames. Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden). Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it. I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious). Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test. Review URL: http://codereview.chromium.org/13130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
* really fix the ifdefpinkerton@google.com2008-12-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6367 0039d316-1c4b-4281-b951-d872f2087c98
* wrap logging with correct ifdefpinkerton@google.com2008-12-041-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6366 0039d316-1c4b-4281-b951-d872f2087c98
* Add support in spell check options sub-context menu to pop up fonts and ↵sidchat@google.com2008-12-042-3/+18
| | | | | | | | languages options menu. Review URL: http://codereview.chromium.org/12908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue in Spell Checker when certain words (such as especelly) did ↵sidchat@google.com2008-12-043-1674/+1732
| | | | | | | | | not give any suggestions. Issue=1677 Review URL: http://codereview.chromium.org/11285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6363 0039d316-1c4b-4281-b951-d872f2087c98
* add a target to run the ipc tests if and when they all pass. Fix up a ↵pinkerton@google.com2008-12-042-7/+79
| | | | | | | | signed/unsigned error in the ipc_message unit test. Review URL: http://codereview.chromium.org/12946 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6358 0039d316-1c4b-4281-b951-d872f2087c98
* adding chrome_paths.ccpinkerton@google.com2008-12-041-0/+2
| | | | | | Review URL: http://codereview.chromium.org/13128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6355 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we end the update process if we get an errorfrom the servers. ↵paulg@google.com2008-12-043-8/+18
| | | | | | | | Previously, if we got a 400 (or other)error response, we'd leave the database and transactionopen.BUG=5060 (http://crbug.com/5060) Review URL: http://codereview.chromium.org/12918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6337 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildtc@google.com2008-12-041-1/+1
| | | | | | | | | TBR=munjal Review URL: http://codereview.chromium.org/13110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6336 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium-MultiProfile-Prototypemunjal@chromium.org2008-12-0377-19/+1376
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary ======= Implement a prototype of multiple profiles in Chrome by utilizing the functionality of user-data-dir command line flag that already exists. A profile in this case is an umbrella for all user data including cookies, history, bookmarks, settings, etc. Each profile gives the user a separation of all these data elements. User Interface ============== - Wrench > "New window in profile" menu item, with sub-menu items. This new menu item has sub menu items for each existing profile, for up to 9 profiles, and one more sub menu item to launch a window in a new profile. The 9 sub-menu items also have the accelerators like CTRL + SHIFT + 1, CTRL + SHIFT + 2, etc. If there are more than 9 profiles, we will also show an extra sub-menu item, "Other...". - New Profile dialog box This dialog box is shown to the use when (s)he clicks Wrench > New window in profile > <New Profile>. It lets the user specify a profile name, and also shows a checkbox to create a desktop shortcut to launch Chrome in that profile. - Choose profile dialog box This dialog box lets the user select a profile from a drop down to open a new window in. It also has an item <New Profile> in the drop down, selecting which will show the new profile dialog box mentioned above. CTRL + M shortcut also launches this dialog box. Code Organization ================= chrome\browser\user_data_dir_profile_manager.h/.cc: This class provides an abstraction of profiles on top of the user data dir command line flag. chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc New profile dialog box code. chrome\browser\views\user_data_dir_profiles_dialog.h/.cc Choose profile dialog box code. Review URL: http://codereview.chromium.org/12895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the IsHungAppWindow DCHECK as it does not seem to be indicatingananta@chromium.org2008-12-031-1/+0
| | | | | | | | | | | | | | | | anything useful about the window at this point. It seems to fire at times even when SendMessageTimeout succeeds on the plugin window, which indicates some race condition between Windows updating its state about whether the window is hung. Fixes http://code.google.com/p/chromium/issues/detail?id=5066 Bug=5066 R=nsylvain Review URL: http://codereview.chromium.org/12920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6318 0039d316-1c4b-4281-b951-d872f2087c98
* Split the cross-platform part of skia_utils_win into skia_utils. Use this newbrettw@google.com2008-12-033-14/+6
| | | | | | | | | function when possible. Add a little documentation. This does not change the Mac build, I'll do that in a separate pass, and the function moved is never used on the mac). Review URL: http://codereview.chromium.org/12917 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6312 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx/skia_util to skia/ext/skia_util_win.brettw@google.com2008-12-0313-13/+13
| | | | | | | In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function). Review URL: http://codereview.chromium.org/13101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6306 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in window positioning that resulted in positioningsky@google.com2008-12-031-4/+8
| | | | | | | | | | | incorrectly for monitors with an origin < 0 along either axis. BUG=5059 TEST=see bug Review URL: http://codereview.chromium.org/13100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6300 0039d316-1c4b-4281-b951-d872f2087c98
* The onbeforeunload event could be sent more than once to a page.jcampan@chromium.org2008-12-033-27/+29
| | | | | | | | | | This would happen if you closed a tab more than once and if you closed the browser several times (while it is waiting for unloads to execute). BUG=5029 TEST=See bug Review URL: http://codereview.chromium.org/13078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6297 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver and image_operations from base/gfx to skia/ext. This is justbrettw@google.com2008-12-037-7/+7
| | | | | | | | like my previous change except does no namespace renaming and doesn't touch skia_utils. Review URL: http://codereview.chromium.org/13080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6290 0039d316-1c4b-4281-b951-d872f2087c98
* add a few files that now compilepinkerton@google.com2008-12-031-5/+5
| | | | | | Review URL: http://codereview.chromium.org/13062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6288 0039d316-1c4b-4281-b951-d872f2087c98
* Encapsulate https server creation a bit more in preparation for getting thedkegel@google.com2008-12-031-44/+31
| | | | | | | | cert paths from SSLTestUtil in net/base/ssl_test_util.h Review URL: http://codereview.chromium.org/13063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6287 0039d316-1c4b-4281-b951-d872f2087c98
* Copy of http://codereview.chromium.org/13003 created by ↵sgjesse@chromium.org2008-12-0315-89/+391
| | | | | | | | yury.semikhatsky@gmail.com for final commit. Review URL: http://codereview.chromium.org/13092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6286 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this change.ben@chromium.org2008-12-033-16/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6279 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old infobar code from the SCons build.sgk@google.com2008-12-032-6/+0
| | | | | | Review URL: http://codereview.chromium.org/13083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6278 0039d316-1c4b-4281-b951-d872f2087c98
* RootView should be destroyed in WM_NCDESTROY not after it.ben@chromium.org2008-12-033-11/+16
| | | | | | Review URL: http://codereview.chromium.org/12632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6277 0039d316-1c4b-4281-b951-d872f2087c98
* Tear out all the old infobar code.ben@chromium.org2008-12-0323-1231/+5
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/13077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6273 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Alternate NavURL Fetcher to use the new infobar framework.ben@chromium.org2008-12-0310-49/+275
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/13070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6268 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my skia file moves because of layout test failures.brettw@google.com2008-12-0322-57/+69
| | | | | | Review URL: http://codereview.chromium.org/12892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
* Updated the design document URLs for ResourceDispatcher and ↵scherkus@chromium.org2008-12-034-4/+4
| | | | | | | | ResourceDispatcherHost Review URL: http://codereview.chromium.org/12890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6261 0039d316-1c4b-4281-b951-d872f2087c98
* Make WordIterator and Snippet::MatchPositions use size_t instead of int for ↵pkasting@chromium.org2008-12-037-60/+59
| | | | | | | | offsets into strings. This avoids some casts. I also added a typedef for Snippet::MatchPosition which cleans up a bit of the calling code a little. Review URL: http://codereview.chromium.org/13064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6260 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 4829: No file extensions listed when saving imagesfinnur@google.com2008-12-035-43/+85
| | | | | | | | | | | | | | | | | | | We were not supplying a filter list for the Save As dialog. Now that we do, the user can select between, for example, say *.jpg and *.* as filters and we behave as follows: With a *.jpg filter active, user enters foo and we save the file as: foo.jpg With a *.jpg filter active, user enters foo. and we save the file as: foo..jpg (which is consistent with IE) With a *.jpg filter active, user enters foo.jpg, we save the file as: foo.jpg With a *.jpg filter active, user enters foo.jpeg, we save the file as: foo.jpeg (not foo.jpg or foo.jpeg.jpg) With a *.* filter active, we respect whatever user enters as extension, except if the filename contains one or more trailing dots then we strip out all those trailing dots. Also test filenames created when saving web pages, as opposed to images (should work as before). Review URL: http://codereview.chromium.org/12836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6258 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note about a test that's expected to fail if you're not running ↵pkasting@chromium.org2008-12-033-5/+12
| | | | | | | | crash_service.exe. Review URL: http://codereview.chromium.org/12882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6254 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes context menu behavior of table view. In particular when runningsky@google.com2008-12-022-18/+43
| | | | | | | | | | | | | | in an RTL locale and right clicking on the icon some times the scrollbar context menu would appear. I've fixed it by subclassing the context menu handling and getting the location from the position of the mouse. BUG=4752 TEST=see bug, but also make sure this doesn't regress 4750 Review URL: http://codereview.chromium.org/13055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6252 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.brettw@google.com2008-12-0222-69/+57
| | | | | | | | | | | This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Review URL: http://codereview.chromium.org/12842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
* add more files to mac chrome project, build a few more tests. Fix typo in ↵pinkerton@google.com2008-12-023-25/+54
| | | | | | | | scons file for darwin. Use compiler define for MSVC pragma. Review URL: http://codereview.chromium.org/13060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6244 0039d316-1c4b-4281-b951-d872f2087c98
* Change a DCHECK to CHECK to help debug a crash inwtc@google.com2008-12-021-1/+1
| | | | | | | | | | release builds. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6241 0039d316-1c4b-4281-b951-d872f2087c98
* Adding more space between dialog contents and the buttons. For XP Classic themeben@chromium.org2008-12-021-1/+1
| | | | | | | | | | | | | | there was close to no space between the tab control and the buttons. The space is aligned with default Windows look for dialogs. BUG=4402 TEST=Verify that all dialogs look good in any XP/Vista theme w.r. to space from dialog contents to buttons. Change by Sverrir Á. Berg <sverrir@google.com>, committing on his behalf. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6240 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a comment. This was brought up by Ojan in a review for my previous ↵brettw@google.com2008-12-021-2/+0
| | | | | | | | patch, but I forgot to fix it before checking in. Review URL: http://codereview.chromium.org/12877 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6239 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r6233, need to move the cert, there is a policy against dkegel@google.com2008-12-021-0/+2
| | | | | | | | net depending on chrome Review URL: http://codereview.chromium.org/13059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6237 0039d316-1c4b-4281-b951-d872f2087c98
* * Cleanup: move base/platform_test.h -> testing/jeremy@chromium.org2008-12-023-15/+2
| | | | | | | | * Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild Review URL: http://codereview.chromium.org/13052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6227 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the URL and title from the state getting functions and IPC messages.brettw@google.com2008-12-027-47/+10
| | | | | | | If the title or URL changes, we'll be updated in other ways, so this extra processing is wasted. Review URL: http://codereview.chromium.org/12859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6225 0039d316-1c4b-4281-b951-d872f2087c98
* Try to reland the ipc code to see if the testsnsylvain@chromium.org2008-12-0210-71/+317
| | | | | | | | | are going to break again. TBR:jeremy Review URL: http://codereview.chromium.org/13053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6222 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce Extension class that can serializer and deserialize from Valueaa@chromium.org2008-12-027-0/+296
| | | | | | | instances. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6211 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes and enhancementssgk@google.com2008-12-022-7/+0
| | | | | | | | | | | | | | | | | | * Configurable CHROME_BUILD_TYPE command line or external environment variable for selecting appropriate release_impl*.scons settings (_checksenabled, _coverage, _dom_stats, _official, _purify). * Configurable CHROMIUM_BUILD command line or external environment variable for selecting appropriate chromium_build*.scons settings (_google_chrome). * Configurable /INCREMENTAL linking via command line or external environment variable ($INCREMENTAL), through appropriate setting of an internal $CHROMIUM_INCREMENTAL_FLAGS construction variable. * Full link of release builds by default. * Alphabetize *.scons files in the mac_env.FilterOut() list. * Explicitly set _checksenabled.scons link flags. Review URL: http://codereview.chromium.org/13039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6210 0039d316-1c4b-4281-b951-d872f2087c98
* We have a bunch of new ui_tests failures. I wantnsylvain@chromium.org2008-12-0210-317/+71
| | | | | | | | | | to check if this change (6181) was the cause. I'm reverting. TBR:jeremy Review URL: http://codereview.chromium.org/12856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6199 0039d316-1c4b-4281-b951-d872f2087c98
* We have a bunch of new ui tests failure that startednsylvain@chromium.org2008-12-021-1/+1
| | | | | | | | | | approximatively at this revision. I'm reverting to make sure. tbr: wtc Review URL: http://codereview.chromium.org/12855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when hiding the find bar due to a NULL window_delegate_.ben@chromium.org2008-12-021-1/+3
| | | | | | Review URL: http://codereview.chromium.org/12854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6197 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SSL info bars to use the new system.ben@chromium.org2008-12-023-128/+56
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/12847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6196 0039d316-1c4b-4281-b951-d872f2087c98
* Add instrumentation to and tighten SDCH implementationjar@google.com2008-12-021-0/+8
| | | | | | | r=huanr,kmixter,openvcdiff Review URL: http://codereview.chromium.org/12699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6193 0039d316-1c4b-4281-b951-d872f2087c98
* Change a DCHECK to CHECK to help debug a crash inwtc@google.com2008-12-021-1/+1
| | | | | | | | | | release builds. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6189 0039d316-1c4b-4281-b951-d872f2087c98
* Don't close tabs on middle-click when the release happens off the tab. ↵pkasting@chromium.org2008-12-011-1/+5
| | | | | | | | Patch by Mohamed Mansour, r=ben. See http://codereview.chromium.org/12816/ . BUG=1062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6184 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ipc_tests unittest target to xcode project.jeremy@chromium.org2008-12-0110-71/+317
| | | | | | | | * Stub out ipc_channel_posix.cc to allow other code that depends on it to be compiled. * Cleanup some ipc code a bit to compile on gcc. * Remove unused IPC::Channel::ProcessPendingMessages() git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6181 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 4898: File extension wrong for saved filesfinnur@google.com2008-12-011-0/+1
| | | | | | | | | | | | When the user specifies a filename without an extension, such as "foo" instead of "foo.gif", we would append "gif" to the filename instead of ".gif" (so the user ends up with a file named "foogif"). I'm not confident this is the only thing wrong with this function. For example if the user specifies "foo." and the filter says "*.gif" shouldn't we add ".gif" to the filename instead of deleting the dot? Also, we seem to be ignoring the default_extension parameter passed in when we figure out what extension to tack on and instead get the file extension from GetFileExtensionFromPath... :s Review URL: http://codereview.chromium.org/12838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6174 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-07-05 01:31:41 +0000