| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
More comprehensive changes will be made for post 1.0.
This is good enough for 1.0.
TBR=sidchat
BUG=1723
TEST=In Accept-Language menu, Germain (Switzerland), French(Canada), etc are listed.
Review URL: http://codereview.chromium.org/9027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3956
Review URL: http://codereview.chromium.org/8987
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entry (instead of displaying the whole path). This unifies the display of titles for local and remote files.
For anyone watching, this is how tab titles will change:
'http://blah.com/index.html' will be 'index.html'
'http://blah.com/meat%20pie.pdf' will be 'meat pie.pdf'
'file://C:/blah/blue%20cheese.txt' will be 'blue cheese.txt' (previously this sometimes changed between the URL and blue%20cheese.txt depending on how the file was opened).
BUG=2529,2375
Review URL: http://codereview.chromium.org/8973
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- this one is back mergeable, I hope.
Review URL: http://codereview.chromium.org/9000
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/9002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2906
Review URL: http://codereview.chromium.org/8753
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the dragged tab container.
http://crbug.com/3939
Review URL: http://codereview.chromium.org/8800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add a unittest for label.cc
Review URL: http://codereview.chromium.org/8902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- skip or not first run dialgos
- on skip import silently search provider only
BUG=1394863
Review URL: http://codereview.chromium.org/8758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page navigations in timers and reads the history length to validate it.
When we receive a request to initiate a navigation in the browser, we send out the request to the renderer and then immediately read the history length and send it out in an update history length request. This causes the test to fail at times as it reads a stale history length.
When we receive the DidAddHistoryItem notification in the renderer, we should not update the history length for the start page navigation. This results in the test failure at times as it reads an incorrect history length.
R=jam
Review URL: http://codereview.chromium.org/8898
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was NPAPI plugin UI test failures. This occured as a sideeffect of the webkit
merge. Some functions in widget.h which were implemented by WebPluginContainer
no longer exist. We need to implement their replacements on similar lines.
Bug=3881
R=jam
Review URL: http://codereview.chromium.org/8775
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces ChromiumBridge as a means for our WebCore port to depend on the embedder indirectly. This will be extended to support the rest of our port.
WebWidgetImpl and ChromeClientImpl both needed to have their platformWindow getter implemented. This fixes a regression related to the most recent merge.
Removes the orphaned Language.cpp (see the real one in the platform/chromium directory.
Changed webkit_glue::GetMonitorInfoForWindow to webkit_glue::GetScreenInfo. This resulted in a varied amount of plumbing changes. It also pushes the platform specific bits up into the browser where they belong.
ScreenInfo is a struct that is part of the webkit/glue API.
R=dglazkov,eseidel
Review URL: http://codereview.chromium.org/8761
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view, overidding the focus set from the DialogDelegate.
We now only rely on the dialog delegate.
Also changed dialog delegate so the default button is also the focused button.
BUG=98
TEST=Open a javascript alert then confirm dialog. A button should be focused. Open all dialogs in Chrome. A button should be focused by default.
Review URL: http://codereview.chromium.org/8786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/8787
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
right-click menu, specifically on the toolbar's back/forward buttons.
Review URL: http://codereview.chromium.org/8942
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dangerous download warning cause an overlap with the label
for that download's URL.
We now use a locale-specific pixel value which changes the
height of each download's view on the download page so that
this overlap no longer happens.
BUG=3824 (http://code.google.com/p/chromium/issues/detail?id=3824)
Review URL: http://codereview.chromium.org/8933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
compare of filenames to test if a plugin is Gears.
BUG=1280317
Review URL: http://codereview.chromium.org/8784
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The link 'learn more' now points to a yet-to-be-created article in the help center. I moved it also, so that it appears to the right of the label (instead of below the label).
And finally, I added missing definitions for the Bookmark Manager, which I noticed while I was changing this.
Review URL: http://codereview.chromium.org/8777
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
destroyed. This is from the commit log of the patch checking this code in in
the old repo.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.history object. I've reverted our original changes and gone with a
different approach.
The idea is to fake the HistoryItem that FrameLoader asks for synchronously,
and give it a special URL that we can intercept later and do the back/forward
navigation.
BUG=3912
Review URL: http://codereview.chromium.org/8756
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. We can tell chrome to "always open this type of file" when
downloading. This is disabled for executable for security
reasons.
2. When downloading an executable files we download
a .download instead.
-=-=
The problem is that the "always open this type of file" is enabled
for executables during the download because we check the extension
of the file to know if it's an executable or not, and during download
we see .download, and we don't consider it an executable.
The fix is to look at the "original_name" when it's present to get
the extension of the real file, not the .download.
BUG:3814
Review URL: http://codereview.chromium.org/8918
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This issue is caused by my bonehead mistake that I forgot removing my legacy code, which raises a false event to Chrome. Sorry.
This change also fixes a crash that happens in Google Sites.
Review URL: http://codereview.chromium.org/8745
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
when you select NavSuggest suggested item before finalizing IME."To investigate this issue today, a rich-edit control of Windows XP does not finish an ongoing composition before changing its text with a SetWindowText() call. (Thanks pkasting for colleting my corrupted comments.)To solve this issue, this change manually finishes an ongoing composition before calling the function.
Review URL: http://codereview.chromium.org/8669
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
understandable stack traces. Destroy the dragged representation immediately, not after returning to the message loop.
Review URL: http://codereview.chromium.org/8926
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I used the BiDiLineIterator, which I moved out of the AutocompletePopup and into the l10n_util file. I also added a wrapper function around ubidi_getLogicalRun.
Review URL: http://codereview.chromium.org/8727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open the 'Clear browsing data' dialog, there should be a check box for from data. Open the options dialogue, 2nd tab, there should be an option for autofill.
Review URL: http://codereview.chromium.org/8740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Issue=1677
Review URL: http://codereview.chromium.org/8408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8966
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
field. I wonder why I had kept it active.
Review URL: http://codereview.chromium.org/8963
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome.exe size.
Review URL: http://codereview.chromium.org/8409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Hint, don't ever sync to this revision.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than using tacked-on functions on GraphicsContext. Clean up the associated GraphicsContext objects.
Merge SkGraphicsContext, SkPaintContext, and PlatformContextSkia into one class, PlatformContextSkia. This tries to change no code related to this, the code in PlatformContextSkia is just a concatenation of those existing files, and hopefully doesn't need much review. This file is in the wrong style and is a terrible mess, I will clean it up in successive passes so it can be reviewed reasonably.
Review URL: http://codereview.chromium.org/8754
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification. I need this for bookmarks. If a new observer is added
while the bookmark model is in the process of sending out notification
the newly added observer gets confused.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/8919
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is to allow users to download the java plugin via our plugin installer.
The plugin installer currently supports URLs which point to executable files.
However the java runtime path is timed and changes frequently. As a stop gap
fix for this, I added a facility in the plugin installer which indicates if
a URL is a display URL. If yes then we navigate to this URL in a new tab,
and allow the user to download the plugin from there.
The format of the chrome_plugins_file.xml has been changed to have each plugin
node specify a list of mime types. This reduces a great deal of duplicated
information in the plugins file.
Changed the plugin finder URL to http://dl.google.com/chrome/plugins/plugins2.xml
to ensure that older clients continue to work.
Bug=3769
R=jam
Review URL: http://codereview.chromium.org/8729
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scripts immediately, without having to restart the renderer.
Review URL: http://codereview.chromium.org/8908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Add some transition APIs.
- Start migrating some code to transition APIs.
Review URL: http://codereview.chromium.org/8825
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
text isn't truncated.
BUG=3836
Review URL: http://codereview.chromium.org/8922
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
sections and homepage links.
Review URL: http://codereview.chromium.org/8905
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a transition away from the appropriate page while that page was loading.
The issue was the LoginPrompt set up a provisional password save prior to the start of a page load, and DidNavigate is not called early enough when a user navigates, which they have an opportunity to do in the HTTP auth case (details in bug comments).
BUG=2792
Review URL: http://codereview.chromium.org/8647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the drop data so we don't have to send it over the IPC for
each drag move. However, if a page load happens during
the drop, the webview changes and we lose the cached
data.
To handle this, we keep track of which RVH we're dragging
over and if it changes, we re-send the drop data.
Review URL: http://codereview.chromium.org/8744
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmarks.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/8743
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
get the path from base::DIR_EXE.
Review URL: http://codereview.chromium.org/8750
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=3881
Review URL: http://codereview.chromium.org/8923
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8921
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7944
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes other recent additions, and doesn't fix everything,
but gets significant pieces back on track:
* New/additional library dependencies in various test executables
(too many to be worth listing).
* Portability: put library base names in $LIBS instead of explicitly
listing .lib files.
* Have interactive_ui re-use various object files from test/ui
instead of (re-)listing the .cc files.
* Add new files:
chrome\browser\bookmarks\bookmark_drag_data.cc
chrome\browser\bookmarks\bookmark_drag_utils.cc
chrome\browser\bookmarks\bookmark_table_model.cc
chrome\browser\browser_trial.cc
chrome\browser\download\download_request_manager_unittest.cc
chrome\browser\greasmonkey_master.cc
chrome\browser\spellcheck_unittest.cc
chrome\browser\views\find_bar_view.cc
chrome\browser\views\find_bar_win.cc
chrome\renderer\greasemonkey_slave.cc
* Remove old files:
chrome\browser\find_in_page_controller.cc
chrome\browser\find_in_page_view.cc
chrome\renderer\spellcheck_unittest.cc
* Remove relative reference to ../../app/google_update_settings$OBJSUFFIX.
* Get rid of by-hand /IMPLIB and /MAP flags.
* Prefix / suffix portability in the jscre library.
* Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources.
* Add $CHROME_DIR/app/resources to CPPPATH.
* Add icu38 directories to CPPPATH for building chrome/views files.
Review URL: http://codereview.chromium.org/8742
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Meiryo font.This issue is caused by a font whose text metric |tmAveCharWidth| is not precise as noted in Microsoft Knowledge Base 145994 (*1) To handle this case, this change uses the ChromeFont::horizontal_dlus_to_pixels() function instead of the ChromeFont::ave_char_width() function.(*1) http://support.microsoft.com/kb/145994BUG=2918
Review URL: http://codereview.chromium.org/8051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
introduced during NavigationController refactoring.
BUG=2616
TEST=see bug
Review URL: http://codereview.chromium.org/8865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4212 0039d316-1c4b-4281-b951-d872f2087c98
|