| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Mac part).
.xib change: Add hyperlink button with text "^IDS_PLUGIN_SELECTIVE_DISABLE" and
hooked up to -openPluginsPage: of file's owner.
BUG=736
TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/.
Review URL: http://codereview.chromium.org/1285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Gtk version of http://codereview.chromium.org/969003.
BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perlcgi/programs/form1POST.html, hit Submit, then refresh. The warning sheet should be tabmodal, not windowmodal. Opening a login form (which is also tabmodal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown.
Review URL: http://codereview.chromium.org/660434
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1247004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about changes to cookies.
This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event
BUG=38398
TEST=net_unittests
Review URL: http://codereview.chromium.org/1023004
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1256003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38548
TEST=none yet.
Review URL: http://codereview.chromium.org/1283001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Gtk version of http://codereview.chromium.org/969003.
BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown.
Review URL: http://codereview.chromium.org/660434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookies.
This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event
BUG=38398
TEST=net_unittests
Review URL: http://codereview.chromium.org/1023004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Except one, that is. We have one location we need to
take a look at (I've added a comment). This changelist
converts UI usage of DecodeImage on the UI thread to
a revamped and simplified ImageLoadingTracker class.
I plan on adding to GetFilePath a DCHECK for the File
thread but decided to do so in another changelist,
since it has a high likelyhood of flushing something
out and be backed out because of that. This started
out as issue 38521 (make infobar use cached icons)
but grew in scope to just eliminate all UI thread
access to DecodeImage and GetFilePath.
BUG=http://crbug.com/38521
TEST=None (extensions should work as before)
Review URL: http://codereview.chromium.org/1075006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because newly added Test*MenuKeyboardAccess tests fail on
some of the Windows buildbots, and possibly a XP Perf regression.
Works on Windows, and on Linux with toolkit_views.
The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.
Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.
Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.
A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.
BUG=none
TEST=New keyboard accessibility ui test.
Review URL: http://codereview.chromium.org/660323
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/1257003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=27938
TEST=Unittest in extension_service_unitttest.cc
Review URL: http://codereview.chromium.org/1095003
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Works on Windows, and on Linux with toolkit_views.
The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.
Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.
Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.
A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.
BUG=none
TEST=New keyboard accessibility ui test.
Review URL: http://codereview.chromium.org/660323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=greener tree
BUG=39158
Review URL: http://codereview.chromium.org/1266002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed duplicated windows closing from OnLoginSignInSelected().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1267002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the active window.
BUG=37832
TEST=cmd-clicking in background windows should open in bg window, foreground window bookmark loading should be unaffected.
Review URL: http://codereview.chromium.org/1202001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=maruel
TEST=none
BUG=38522
Review URL: http://codereview.chromium.org/1267003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=39156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=make tree greener
BUG=38522
Review URL: http://codereview.chromium.org/1216003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38920
TEST=ExtensionApiTest.Incognito
Review URL: http://codereview.chromium.org/1148009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do this by "remapping" about:plugins to chrome://plugins/. Also delete old
about:plugins page and associated strings.
BUG=736
TEST=Go to about:plugins; should get new plugins page (same as chrome://plugins/).
Review URL: http://codereview.chromium.org/1219005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This issue is caused by my bonehead mistake that forgot setting the parent windows of AeroPeek windows. This change just sets the BrowserFrame object (which owns AeroPeek windows) to their parent window so we can minimize AeroPeek windows when we minimize the BrowserFrame.
BUG=38597
TEST=Open two or more tabs, minimize Chrome, and verify there are not any garbage windows on Desktop.
Review URL: http://codereview.chromium.org/1120011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37852 C-u views source in password entries
TEST=See bug report.
Review URL: http://codereview.chromium.org/1113008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Tests if Browser::ToggleCompactNavigationBar() turns on/off
compact navigation bar and tool bar.
* Tests if the accelerator works.
BUG=http://crosbug.com/2028
TEST=new tests CompactNativationBarTest.TestBasic/TestAccelerator should pass.
Review URL: http://codereview.chromium.org/1200001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
aren't checked out on the bots. We need to figure out how to deal with this
since we don't want to keep expectations downstream if we can avoid it.
BUG=none
R=none
TEST=bots stay green
Review URL: http://codereview.chromium.org/1253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=bots stay green
R=eroman@chromium.org
Review URL: http://codereview.chromium.org/1214001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After a conversation with Eric, we're not worried about attacker pages loading
down the local machine or network (because such pages would themselves be
candidates for being flagged).
The concern is users with slow network connections, or random network / server
jitter.
BUG=36774
TEST=NONE
Review URL: http://codereview.chromium.org/1242001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9606
TEST=Inspect32 has accessible names for those components.
Review URL: http://codereview.chromium.org/1110013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
loading and extracting resources from the Chrome locale DLLs.
Add the Chrome Frame resource strings to the Chrome .grds so they get built directly into the Chrome locale dlls.
There is one remaining todo here, which is to load the dialog template into a grd + rc somewhere (probably in generated_resources.grd) and then get CF to load dialog templates from a different module. Will do that in another patch.
BUG=24305
TEST=Chrome Frame when loaded on machines whose locales are not US English will display strings appropriate to those locales.
Review URL: http://codereview.chromium.org/1240001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set of parens were missing, so the "not" operator only applied to the GetTabById() return value.
BUG=34778
Review URL: http://codereview.chromium.org/1238001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
causing the library to appear already loaded in a failed state.
Review URL: http://codereview.chromium.org/1251001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first two tests are from rohitbm and the rest from krisrs.
testUnicodeStrings -- test bookmarks with unicode strings
testSizes -- test bookmarks with different sized strings
testAddingBookmarksToBarAndOther - add bookmarks to diff locations
testAddingFoldersToBarAndOther -- add bookmark groups to diff locations
testAddingFoldersWithChildrenToBarAndOther -- add bookmarks and groups to
different locations
Review URL: http://codereview.chromium.org/1191002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=38610
Review URL: http://codereview.chromium.org/1247001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
last_sync_timestamp from the new_timestamp only, never from per-entry
timestamps. Use what the server sends us to know whether or not there
are more updates to fetch. Eliminate some unnecessarily complicated
logic having to do with the # of updates returned -- that's always a red
herring; with server-side filtering, it is indeed possible for 0 updates
to be returned along with a new timestamp.
BUG=37373
TEST=manual testing of 2 browser sync; unit tests.
Review URL: http://codereview.chromium.org/1161006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=736
TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions.
Review URL: http://codereview.chromium.org/1085003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BMM was originally only checking for the control key on non-mac platforms.
BUG=39085
TEST=Select some non-contiguous bookmarks and copy and paste them, without the
elements in between
Review URL: http://codereview.chromium.org/1225001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39013
TEST=pyautolib bookmark_bar.py script will now work on Linux
Review URL: http://codereview.chromium.org/1227003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Tested by loading on device and clicking fullscreen button. (needs most recent codebase)
Review URL: http://codereview.chromium.org/1034002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
access to all *Libray classes that used to be singletons. This registry adds an indirection layer that will let is replace the actual objects with mocks during test runs.
BUG=chromium-os:2026
TEST=none
Review URL: http://codereview.chromium.org/1142005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications during the port to mac & linux and making behavior more consistent.
BUG=34826
TEST=notifications on each platform.
Review URL: http://codereview.chromium.org/1055005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the translation server without the user consent).
Also added unit-tests for prefs.
BUG=38107
TEST=Visit a page that triggers the translate infobar. Translate the
page. Select "Always translate <lang1> to <lang2>".
Open a page in lang1. The page should automatically be translated
to lang2.
Open an incognito window. Navigate to a page in lang1, the page
should not automcatically be translated, an infobar should ask
if the user wants to translate the page.
Review URL: http://codereview.chromium.org/1184001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1134009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Extension disabled infobar was being shown at startup.
- Crashed extensions were persisted as unpacked extensions, regardless of how
they were installed.
BUG=30116
BUG=38856
Review URL: http://codereview.chromium.org/1157005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by sergeyu@chromium.org
BUG=28100
TEST=Ran media_unittests
Review URL: http://codereview.chromium.org/1226001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24477
TEST=manual
Review URL: http://codereview.chromium.org/1170001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_dll.gypi.
BUG=39083
TEST=Clobber build and try to open the tab-based bookmark manager. Don't get a 404.
Review URL: http://codereview.chromium.org/1222001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
type configuration. DTM::Start() has been replaced with DTM::Configure(). Note that the callback is also gone, replaced with notification service style notifications to tell listeners that configuration has started or finished.
I also added some stuff to prepare for adding the "initial download" step for new datatype into the configure process.
Review URL: http://codereview.chromium.org/1128012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Check that the app launcher is displayed correctly on ChromeOS
and Windows (when using the --app-launcher-new-tab)
Review URL: http://codereview.chromium.org/1171002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=38945
TEST=reloaded Pepper 3D plugins repeatedly
NOTE: encountered unrelated problems while testing. These changes
should be stress tested with CA plugins.
Review URL: http://codereview.chromium.org/1110011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are enabled.
Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer.
BUG=2444936
Patch contributed by ericdingle@google.com
Original review at http://codereview.chromium.org/890005
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/1205001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
--gpu-startup-dialog command line option to allow debugging of GPU
process.
BUG=none
TEST=none (tested manually in development workspace)
Review URL: http://codereview.chromium.org/1095005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/38002
TEST=as in bug
Review URL: http://codereview.chromium.org/1105010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42374 0039d316-1c4b-4281-b951-d872f2087c98
|