summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add a sleep to temporarily fix the find in page test.brettw@google.com2008-10-211-0/+5
| | | | | | Review URL: http://codereview.chromium.org/7819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3663 0039d316-1c4b-4281-b951-d872f2087c98
* Split startup-test graphs into cold and warm, since otherwise the plot axispamg@google.com2008-10-211-7/+11
| | | | | | | | | | is too large for changes in warm timings to show up well. BUG=3597 TEST=warm-test results show up better on startup-test plot Review URL: http://codereview.chromium.org/7531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3657 0039d316-1c4b-4281-b951-d872f2087c98
* Call GdiAlphaBlend directly instead of the AlphaBlend wrapper in ↵deanm@chromium.org2008-10-211-2/+0
| | | | | | | | msimg32.dll. The wrapper does a few additional santity checks, which I presume GdiAlphaBlend will have to handle anyway. This means we don't depend on msimg32.dll anymore. Review URL: http://codereview.chromium.org/7813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3656 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include path from last checkin.brettw@google.com2008-10-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3655 0039d316-1c4b-4281-b951-d872f2087c98
* Factor find in page out of WebContents and into the view, since it is almostbrettw@google.com2008-10-2125-464/+488
| | | | | | | | | | | | | | | all view specific. Rename find in page controller to be "FindBarWin", and find in page view to be "findBarView" (since this is not Windows specific, but "Views" specific). I did lots of simplification and moving around of the find in page API. I coalesced several of the show functions into one master function on the view. I removed some other sizing and window updating code from WebContents and moved it to the view. Review URL: http://codereview.chromium.org/7667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3654 0039d316-1c4b-4281-b951-d872f2087c98
* try rolling this back to see if it helpsben@chromium.org2008-10-213-86/+31
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3645 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakage from r3643.aa@chromium.org2008-10-211-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3644 0039d316-1c4b-4281-b951-d872f2087c98
* Show the path to the Greasemonkey script that caused an erroraa@chromium.org2008-10-214-26/+39
| | | | | | | | in the console. Review URL: http://codereview.chromium.org/7533 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3643 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=205, which was ↵ananta@chromium.org2008-10-207-10/+121
| | | | | | | | | | | | | an issue with a windowed flash instance not rendering content at times.The bug occurs as a result of the following:-1. The flash plugin executes a script via GetURLNotify. This script calls window.open with the target as self, which shows up as a new tab in the browser. This causes a new RenderView object to be instantiated (See RenderView::CreateWebView).2. RenderView::CreateWebView sends over the ViewHostMsg_CreateWindow IPC message to the browser. The handler in the browser sends over an ack for this message with the window handle. This is used as the parent window for any plugins instantiated in the page.3. At times, the newly created view starts receiving data which is processed before the ViewMsg_CreatingNew_ACK message is received and processed by the view. This causes the plugin to be instantiated without a parent window thus ending up as a top level window.The fix is to queue up resource messages and process them after we receive the ack for the ViewHostMsg_CreateWindow IPC. Tests :- Covered by UI tests. R=jam Review URL: http://codereview.chromium.org/7514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3631 0039d316-1c4b-4281-b951-d872f2087c98
* To go with the retardation of recently closed tabs, remove the yellow from ↵glen@google.com2008-10-201-4/+1
| | | | | | | | the style. Review URL: http://codereview.chromium.org/7624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3630 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Chromium logo so that it's not clipped and is right-aligned ↵glen@google.com2008-10-201-0/+0
| | | | | | | | | | correctly. TBR=sky Review URL: http://codereview.chromium.org/7333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3629 0039d316-1c4b-4281-b951-d872f2087c98
* Restore field trial for memory modeljar@google.com2008-10-202-6/+0
| | | | | | | | | | | | Rollback was not needed to correct distributed test regression. This reverts changes in 3608, which were done to try to repair the regression. r=huanr Review URL: http://codereview.chromium.org/7522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3627 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ctrl-k not working.pkasting@chromium.org2008-10-201-1/+1
| | | | | | | | | This was just an artifact of how I changed my mind a number of times during the AutocompleteEdit model/view split and failed to ultimately do the right thing here. BUG=2901 Review URL: http://codereview.chromium.org/7672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3621 0039d316-1c4b-4281-b951-d872f2087c98
* More Windows-is-a-crack-baby mitigation.beng@google.com2008-10-203-31/+86
| | | | | | | | | | | | | | | | | I think I've finally fixed this. Knock on wood. Turns out that these two additional places do non-client rendering: - DefWindowProc for WM_NCLBUTTONDOWN - the function EnableMenuItem (called from CustomFrameWindow::OnInitMenu) For the first case, we also need to unlock updating when we begin to receive mouse move events during modal size/move loops, otherwise the feedback won't be visually continuous. http://crbug.com/3264 Review URL: http://codereview.chromium.org/7662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3620 0039d316-1c4b-4281-b951-d872f2087c98
* recommit mainkuchhal@chromium.org2008-10-201-8/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3617 0039d316-1c4b-4281-b951-d872f2087c98
* Now omaha supports displaying custom error string through registry keys.kuchhal@chromium.org2008-10-2010-371/+481
| | | | | | Add error strings in Chrome installer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3616 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the default cursive font to 'Comic Sans MS' from 'Script' (that's not ↵jungshik@google.com2008-10-2042-84/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | available on the default Win XP/Vista installation) and the default fantasy font to 'Impact'. 'Impact' is not a 'fantasy' font, but there's no suitable font to use on the default Win XP. Fantasy is very rarely used so that this should not matter. In addition, change the serif font for Simplifed Chinese Chrome to Simsun from Simhei. The current setting is : A. serif : simhei sans-serif : simsun monospace : nsimsun What we should have if we want to keep the diestinction between serif and sans-serif in Simplified Chinese Chrome B. serif : simsun sans-serif: simhei monospace : nsimsun (Chinese has different typographic traditions from the western so that mapping is 'approximate') However, Simhei is rather ugly so that we do the following (losing the distinction between serif and sans-serif) C. serif: simsun sans-serif: simsun monospace: nsimsun So, for both serif and sans-serif, we just use Simsun. With that, even in rare occassions (for Chinese web sites) where serif is specified, we'd use Simsun rather than Simhei. BUG=2830 Review URL: http://codereview.chromium.org/7653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3610 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FieldTrial code to repair UI reliability test regressionjar@google.com2008-10-202-0/+6
| | | | | | | r=mbelshe Review URL: http://codereview.chromium.org/7520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3608 0039d316-1c4b-4281-b951-d872f2087c98
* Construct a field trial to see if HIGH or MEDIUM memory model "works better"jar@google.com2008-10-196-10/+77
| | | | | | | | | | | | | | Includes definition of a FieldTrial class to support this. I have thoughts in my head about how this will eventually extend to be controllable via UMA (as well as being able to run tests defined at compile time, as was done in this example. r=mbelshe, mmentovai Review URL: http://codereview.chromium.org/7638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3604 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 3487: We now set the bounds for the links in the About box as soon as ↵finnur@google.com2008-10-191-19/+18
| | | | | | | | we know where they should be placed, instead of waiting until the Layout call to do so. This fixes an issue of the links not appearing at all -- something, that I can't reproduce myself, but Darin could on his Vista machine (until he tried this fix). Review URL: http://codereview.chromium.org/7513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3603 0039d316-1c4b-4281-b951-d872f2087c98
* Switch various performance tests to produce output for use by the new genericpamg@google.com2008-10-186-110/+165
| | | | | | | | | | | plotting log parser. BUG=b/1221588 TEST=once scripts and data are also switched, perf tests still plot Review URL: http://codereview.chromium.org/6431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3602 0039d316-1c4b-4281-b951-d872f2087c98
* Move more platform-specific stuff from WebContents to the view.brettw@google.com2008-10-187-187/+189
| | | | | | | | | | | I refactored the way title setting is done since there were two parts that duplicated the logic and did so slightly differently. I removed some old code in RendererGone whose premise is no longer valid and had the effect of creating a bug with no benefit. I moved the sad tab view from WebContents to the view. Amusingly, the view was the only one using this, but it would go poke inside of the WebContents to get it. Review URL: http://codereview.chromium.org/7650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the test build when BUILD_PERSONALIZATION is enabled.nick@chromium.org2008-10-181-1/+2
| | | | | | | | GetProfilePersonalization returns a pointer. Review URL: http://codereview.chromium.org/7639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3583 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back CL 3578, discovered hammer.bat had not been updated yet.bradnelson@chromium.org2008-10-181-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3582 0039d316-1c4b-4281-b951-d872f2087c98
* Allow middle click on the only tab with one window open.ben@chromium.org2008-10-174-10/+53
| | | | | | | http://crbug.com/3466 Review URL: http://codereview.chromium.org/7506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3580 0039d316-1c4b-4281-b951-d872f2087c98
* Support shortcut show styles for "run maximized", "run minimized" etc.ben@chromium.org2008-10-174-3/+10
| | | | | | | http://crbug.com/3278 Review URL: http://codereview.chromium.org/7504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3579 0039d316-1c4b-4281-b951-d872f2087c98
* Applying software construction toolkit patterns in scons build.bradnelson@chromium.org2008-10-171-1/+0
| | | | | | Review URL: http://codereview.chromium.org/6569 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3578 0039d316-1c4b-4281-b951-d872f2087c98
* Changes BookmarkDragData to allow for multiple nodes. I'm going tosky@google.com2008-10-175-150/+306
| | | | | | | | | | | | | | | | | need this for the bookmark manager, which will let you drag multiple nodes around. I didn't make the bookmark bar deal with multiple nodes though (it won't allow a drop of multiple nodes). I may add support for this at some point, but not in this patch. BUG=674 TEST=covered by unit tests, but make sure the aren't problems dragging around bookmarks on the bookmark bar, especially with folders. Review URL: http://codereview.chromium.org/7498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3575 0039d316-1c4b-4281-b951-d872f2087c98
* We were still warning about a dangerous download when the user has picked ↵jcampan@chromium.org2008-10-171-2/+8
| | | | | | | | | | the option to always ask for download. BUG=3539 TEST=Select the option "always ask for download". Download an exe. You should not see a dangerous download warning. Review URL: http://codereview.chromium.org/7634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3570 0039d316-1c4b-4281-b951-d872f2087c98
* Straighten out the way the system menu works a bit. We no longer create the ↵ben@chromium.org2008-10-177-41/+32
| | | | | | | | | menu every time it is shown (or reset it). Resetting it caused some system-wide system menu items to be voted off the island (e.g. nView desktop manager, and some other third party addins). Resetting also caused some of the NC overpainting issues to be worse. This simplifies things a bit by creating the menu at frame creation time, then when the menu is run doing enabling only. Review URL: http://codereview.chromium.org/7497 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3569 0039d316-1c4b-4281-b951-d872f2087c98
* Remove throttling code from the Browser process and implement throttling in ↵erg@google.com2008-10-1713-25/+185
| | | | | | | | | | | | | the Renderer. The previous way of doing throttling was just calling CloseContents() on a window to reject it. But since the Browser is notified about a window opening asynchronously, by the time the CloseContents() sends a message back to the Renderer, a bunch more windows have been opened, leading to memory exhaustion. Instead, make all RenderViews created from a parent RenderView share a counter and start refusing to create RenderViews if too many RV have been created. Every RenderView (except for the first one) is assumed to be an unrequested popup, until notified by the Browser process by either a ViewMsg_DisassociateFromPopupCount message (this RenderView is a new top level page) or a ViewMsg_DisassociatePopup message (this RenderView is a requested popup and therefore shouldn't count against the count.) BUG=3382, 2632 Review URL: http://codereview.chromium.org/7388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem where "text/xml" responses get buffered past 512 bytes, causing ↵ericroman@google.com2008-10-171-0/+1
| | | | | | | | | | the response to be truncated. BUG=3521 Review URL: http://codereview.chromium.org/7610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3567 0039d316-1c4b-4281-b951-d872f2087c98
* Make ChromeThreadTest and TextDatabaseTest inherit from PlatformTest formark@chromium.org2008-10-173-6/+24
| | | | | | | autorelease pool management on the Mac. Review URL: http://codereview.chromium.org/7640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3563 0039d316-1c4b-4281-b951-d872f2087c98
* more bustage fixesben@chromium.org2008-10-171-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3557 0039d316-1c4b-4281-b951-d872f2087c98
* more bustage fixesben@chromium.org2008-10-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3556 0039d316-1c4b-4281-b951-d872f2087c98
* fix release bustage :-(ben@chromium.org2008-10-171-1/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3555 0039d316-1c4b-4281-b951-d872f2087c98
* attempt at fixing release bustageben@chromium.org2008-10-171-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3554 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SchedulePaint and a few other methods to use gfx types.ben@chromium.org2008-10-1724-114/+90
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3550 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some code I accidentally left in which is causing asserts and crashes.brettw@google.com2008-10-171-6/+0
| | | | | | | | | | | close_on_deactivate_ was getting set to true which was deleting the object, causing us to crash later. The code that originally set this externally is still there, so this restores the old behavior. TEST=Press tab on any page, it shouldn't assert or crash. Review URL: http://codereview.chromium.org/7631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3549 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crasher in SpellChecker Add to dictionary feature.sidchat@google.com2008-10-171-1/+2
| | | | | | | Issue=3039 Review URL: http://codereview.chromium.org/7484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3546 0039d316-1c4b-4281-b951-d872f2087c98
* testing something elseben@chromium.org2008-10-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3544 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-1725-204/+1378
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* Add processing for a master profile json file on first run. Allows:cpu@google.com2008-10-175-18/+137
| | | | | | | | | - set home page / show home button - show bookmarks bar Review URL: http://codereview.chromium.org/7369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 3470, where the download tab would show the temporary name for ↵jcampan@chromium.org2008-10-175-25/+70
| | | | | | | | | | | | dangerous downloads (see download_tab_view.cc). Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first). BUG=3470, 3471 TEST=see bugs Review URL: http://codereview.chromium.org/7395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3536 0039d316-1c4b-4281-b951-d872f2087c98
* Add some trace statements in an attempt to find the reason why a Find test ↵finnur@google.com2008-10-171-0/+23
| | | | | | | | is flaky. This will be removed once I get a run that hangs again. Review URL: http://codereview.chromium.org/7626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3534 0039d316-1c4b-4281-b951-d872f2087c98
* testing a theory...ben@chromium.org2008-10-171-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3533 0039d316-1c4b-4281-b951-d872f2087c98
* Removes expiring of recently closed tabs from new tab page. Also makessky@google.com2008-10-172-34/+5
| | | | | | | | | | | it so that if you restore a tab we remove from the tab restore service (this is what control-shift-t does too). BUG=2598 TEST=make sure closed tabs still show up on the new tab page. Review URL: http://codereview.chromium.org/4016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where a shelf or infobar would not be closed correctly when closing ↵glen@google.com2008-10-174-16/+21
| | | | | | | | | | | | | | a tab. The issue was because ShelfVisibilityChangedImpl is called twice, once with a null current_tab for the closing tab (via TabClosingAt), and once on selection of the new tab (via TabSelectedAt) - the first call nulls the shelves without doing a Layout, the nulled shelves then don't show up in the second call, so Layout is never called. http://crbug.com/2069 BUG=2069 Review URL: http://codereview.chromium.org/7155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3528 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out most view creation from WebContents. This adds a new ↵brettw@google.com2008-10-1721-205/+363
| | | | | | | | sub-delegate to RenderViewHostDelegate which is implemented by WebContentsView. I did a lot of plumbing and moving around as a result. Review URL: http://codereview.chromium.org/6608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3527 0039d316-1c4b-4281-b951-d872f2087c98
* Removes an unneeded override.sky@google.com2008-10-172-7/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3526 0039d316-1c4b-4281-b951-d872f2087c98