| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=76073
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6693021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is an extension of http://codereview.chromium.org/6280018 that provides a proxy configuration which respects command line parameters and policies
BUG=67232,70732
TEST=Start chrome, observe two PROXY_CONFIG_CHANGED events in about:net-internals (if you are on a corporate network with PAC configurations), observe that everything behaves as usual. In particular the https://www.google.com/searchdomaincheck?format=domain&type=chrome request should not fail as it uses the new system URLRequestContext.
Review URL: http://codereview.chromium.org/6292017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successfull build under MSVS2005
TBR=scottbyer
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and derive from BrowserMessageFilter for easier filtering and replying.
Review URL: http://codereview.chromium.org/6695009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
let the window be closed from the X.
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6697016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a delegate interface to decouple TabRestoreService from
Browser/BrowserList. Also clean up dependency on TabStripModel in the
process.
(on behalf of torne@google.com, http://codereview.chromium.org/6660028/)
BUG=
TEST=
Review URL: http://codereview.chromium.org/6677042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and adding others into the proper impl files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6690016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behavior. The choices are:
. immediately (current behavior and is the default).
. delayed (transitions to autocompleted after a delay).
. never (only show the suggestion, but never autocomplete it).
I'm doing this so we can collect some data to help understand which is
the less error prone of the 3. The data collection is all done on the
server side.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6685002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76073
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6683052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76073
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6681041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76073
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6685059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/tabs.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6698007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Still waiting for "R" badge resource.
BUG=chromium-os:12010
TEST=manual
Review URL: http://codereview.chromium.org/6686044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
promo shown.
BUG=76063
TEST=none
Review URL: http://codereview.chromium.org/6681036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2348
TEST=Change user picture on personal settings page and verify that the image is immediately redrawn.
R=altimofeev@chromium.org
Review URL: http://codereview.chromium.org/6693018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the fetching of data is cancelled, the helpers might not be ready yet to be reused, triggering an assertion.
BUG=62311
TEST=interactive ui tests:CollectedCookies.*
Review URL: http://codereview.chromium.org/6670033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to get rid of custom preference API functions for the proxy extension API.
BUG=73994
TEST=ProxyApiTest.*:ExtensionApiTest.*
Review URL: http://codereview.chromium.org/6683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Earlier we were waiting for background noise estimation to complete (in a few hundred milliseconds)
before displaying the bubble. Based on UX feedback I'm removing that wait now.
BUG=none
TEST=manual, check that bubble shows up instantly on clicking the mic button.
Review URL: http://codereview.chromium.org/6673043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6690017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75276
TEST=none
Review URL: http://codereview.chromium.org/6691011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just moves the initialization code of |bdict_file_path_| from SpellCheckHostImpl::SpellCheckHostImpl() (running on the UI thread) to SpellCheckHostImpl::InitializeDictionaryLocation() (running on the FILE thread) so we can initialize it without assertions.
BUG=60643
TEST=Run Chrome without crashes.
Review URL: http://codereview.chromium.org/6646042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/6626071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync and using the old default password store by default. This is temporary
until we're able to land a real fix for the deadlock.
BUG=72499
TEST=Run chrome on linux, see passwords get synced.
Review URL: http://codereview.chromium.org/6696009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13106
TEST=ran try
Review URL: http://codereview.chromium.org/6696011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
audio message filter's delegates.
This required moving the start and stop commands to the I/O thread as well
since now the routing_id is only available on the I/O thread.
BUG=75495
Review URL: http://codereview.chromium.org/6694002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We don't need the colons any more now that native options are gone. I put the group names that are a single word into ifdef titlecase blocks because they may translate into multiple words in other locales.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6696008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6698005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BaseTabStrip::StartInsertTabAnimation as its not used. Also removes
TabStrip::IsTabSelected override as its covered by BaseTabStrip
implementation.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6695005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the selection is changed using the keyboard. Also fixed radio grouping of
the password radios.
BUG=73798
TEST=none
R=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/6697009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this code is no longer used now that native options are gone
BUG=72658
TEST=compile
Review URL: http://codereview.chromium.org/6696004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Ran ClientSideDetectionHostTest with heapchecking enabled.
Review URL: http://codereview.chromium.org/6677032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this makes it look the same as all other pages (I believe the CSS predated the current look, as indicated by the deleted TODO)
BUG=none
TEST=visual
Review URL: http://codereview.chromium.org/6677026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3333
TEST=NONE
Review URL: http://codereview.chromium.org/6681026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/6698011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=touch compiles
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75237
TEST=none
Review URL: http://codereview.chromium.org/6625075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
difficult for a derived class to customize it. We need that ability for panel
windows which will derive from BrowserWindowGtk. Doing a minor refactor to get
the code out of the constructor and moving it into a virtual Init() function.
BUG=73936
TEST=none
modified: chrome/browser/ui/gtk/browser_window_factory_gtk.cc
modified: chrome/browser/ui/gtk/browser_window_gtk.cc
modified: chrome/browser/ui/gtk/browser_window_gtk.h
R=erg@chromium.org
Review URL: http://codereview.chromium.org/6682035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Revert 78062 - Migrate more of BrowserFrame's event handling down into WindowWin/WidgetWin and their delegate interfaces. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6683007 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6686059
Review URL: http://codereview.chromium.org/6677029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting since Further debugging proved that this is not relevant
at all.
Several bugs and user fourm threads like:
https://groups.google.com/group/google-chrome-frame/browse_thread/thread/9aa7c3296861a2cd?pli=1
point to Chrome startup issues with Citrix. Based on the
user feedback, it appears that browser process is hung trying
to launch renderer that comes briefly and exits. Further
investigation revealed 3 DLLs that get injected in every
process in Citrix environment.
This speculative fix adds those DLLs to the problem DLL list
for sandbox.
BUG=2423,63195,55875
TEST=run chrome or Chrome Frame via citrix published app shortcut.
Review URL: http://codereview.chromium.org/6623064
TBR=joshia@google.com
Review URL: http://codereview.chromium.org/6694006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stub out the API for setting and retrieving device policies on Chrome OS. These methods don't do anything real, they just return as though success occurred.
BUG=chromium-os:13071
TEST=unit tests
STATUS=Fixed
R=davemoore@chromium.org
Review URL: http://codereview.chromium.org/6686052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=safe_browsing_util_unittest
BUG=76013
Review URL: http://codereview.chromium.org/6679046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update some RootView event construction.
Fixup some *MouseExited/OnLeaveNotify codepaths.
Normalize event argument names.
Move View::ConvertPoint*Ancestor defs to private section.
Review URL: http://codereview.chromium.org/6685018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is minor cleanup.
TEST=sceen locker works as before
BUG=none
Review URL: http://codereview.chromium.org/6656022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of painting.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6684010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome in plugin.
TBR=nsylvain
Review URL: http://codereview.chromium.org/6695002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6683021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
would continue highlighting the tabs.
BUG=75456
TEST=see bug
Review URL: http://codereview.chromium.org/6690022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change also makes it so that a positive cache hit will immediately show
a warning page without running classification.
BUG=
TEST=Ran ClientSideDetectionServiceTest and ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6652013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enter an invalid text in page range textbox. Shift the focus out of page range textbox. An invalid warning icon is displayed on the textbox. The title text of the textbox displays an error message.
Review URL: http://codereview.chromium.org/6665010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78105 0039d316-1c4b-4281-b951-d872f2087c98
|