| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert previous traces and add one targeted test.
My traces seem to indicate that something else
than a Chrome window has focus when the test fails.
Lets figure out what that is...
BUG=62937
TEST=Tracking down problem in test
Review URL: http://codereview.chromium.org/5463001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Compiles and passes tests.
Review URL: http://codereview.chromium.org/5448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Listen for extension install events and restart the Enterprise Daemon if an extension was installed, that is from a policy and it contains the policy marker file.
BUG=chromeos:9702
TEST=manual
Review URL: http://codereview.chromium.org/5311007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Verify them at least once since startup.
BUG=chromium-os:8645
TEST=Manual
Review URL: http://codereview.chromium.org/5185001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented round coreners for the user image. Changed border size of
the login entries.
BUG=chromium-os:8917
TEST=manual
Review URL: http://codereview.chromium.org/5346006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also update chromeactions.txt to record new UMAs
BUG=58277
TEST=enable, run browser with "--vmodule=*location*=3 http://html5demos.com/geo", check "gateways": appears in the log.
Review URL: http://codereview.chromium.org/5346009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just adds value() to convert from FilePath to std::wstring. (I have verified this works good in my Windows PC.)
TBR=tommi
BUG=none
TEST=fix build in the "Google Chrome Win" bot.
Review URL: http://codereview.chromium.org/5446001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
occurred.
BUG=63649
TEST=RenderViewHostTest.RedirectLoopCookies
Review URL: http://codereview.chromium.org/5254005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just fixes my stupid typo in my previous build fix.
BUG=none
TEST=fix build in the "Google Chrome Win" bot.
Review URL: http://codereview.chromium.org/5445001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed from a call to DOMStorageContext::ClearLocalStorage
from BrowserImpl to a call to that code from the destructor
of DOMStorageContext.
BUG=64627
TEST=DOMStorageBrowserTest.ClearLocalState
Review URL: http://codereview.chromium.org/5372008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5265006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5295008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This just adds a pointer to BrowserDistribution as the second parameter for installer::GetChromeInstallPath() to fix the build breaks on the "Google Chrome Win" bot.
TBR=tommi
BUG=none
TEST=make the "Google Chrome Win" bot green.
Review URL: http://codereview.chromium.org/5442001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=No DCHECKs when printing.
Review URL: http://codereview.chromium.org/5350005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before the fix, the test crashed as the input method library
was already initialized with the non-stub implementation elsewhere.
The fix is to reset the implementation, so it'll be initialized
again.
BUG=chromium-os:6269
TEST=unit_tests; try
Review URL: http://codereview.chromium.org/5275006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gwtquake lets the renderer create > 300 threads (one per audio element?), and eventually thread creation fails. This CL makes the media code more robust against thread creation failure (currently, it just crashes the renderer).
The Real Fix probably is to have a thread pool for media stuff instead of one thread per media object. And maybe threads just leak under some circumstances. I will file a follow-up bug for that case, hopefully with a reduced test case.
BUG=53867,61293
TEST=Completing the first level in gwtquake shouldn't crash the renderer.
Review URL: http://codereview.chromium.org/5362003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For instance, the overflow ocurred with "Cancel" button in Japanese UI as
the button width was fixed. Fix this problem by making the button width
flexible.
Along the way, get rid of "position: absolute" from Save and Cancel buttons,
to make the layout more flexible.
TEST=Confirmed that the cancle button was rendered properly. See crosbug.com/8534 for screenshots.
BUG=chromium-os:8534
Review URL: http://codereview.chromium.org/5337006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8556
TEST=Login in guest mode with the language set to Japanese. Check that Japanese IME is available.
Review URL: http://codereview.chromium.org/5301008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here's what happened before the fix.
1. The user starts to convert text near the bottom of the screen, using Mozc.
2. UpdateLookupTable signal is delivered to the candidate window
3. The candidate window is shown above the pre-edit text.
4. UpdateAuxiliaryText signal is delivered to the candidate window
5. The auxiliary text like "1/10" is added to the bottom of the candidate window
6. The additional portion will cover the pre-edit text.
The fix is to move the candidate window after adding the auxiliary text at
the step 5.
Ideally, we should update the candidate window only once, rather than twice
on UpdateLookupTable and UpdateAuxiliaryText separately, but that will need
a bigger change.
BUG=chromium-os:7084
TEST=confirmed that the pre-edit text wouldn'
Review URL: http://codereview.chromium.org/5373007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64688
TEST=Manual test
Review URL: http://codereview.chromium.org/5422001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The installer now does its work based on distributions and target installation paths.
Each distribution has exactly one target installation path but each installation path can have more than one distribution.
In the absense of the --multi-install switch, the installer should continue to work as before.
The biggest difference here is that we don't rely on a single global distribution object that controls the entire installation flow and we have a few classes for the new abstractions instead of global functions.
It's far from perfect, but it's a step towards separating the core file package required for all distributions from the distributions themselves.
Additionally, there are tons of little changes here such as consistant usage of FilePath and CommandLine instead of mixing them with std::wstring.
TEST=Install, uninstall, upgrade, etc. Everything install related.
BUG=61609
Review URL: http://codereview.chromium.org/5172011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r67187 did not fix the issue.
BUG=chromium-os:9743
BUG=64261
TEST=manually
Review URL: http://codereview.chromium.org/5389003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=64874
TEST=tree goes green
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
response data to the old one.
BUG=None.
TEST=Unit-tests
Review URL: http://codereview.chromium.org/5322015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Disable failing NaClUITest.SrpcBasicTest and add back in test
expectation that was erroneously removed.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes Autofill popup menu to only show "Clear form..." menu item when form Autofill suggestions are shown.
BUG=60805
TEST=Manual, according to bug.
Review URL: http://codereview.chromium.org/5263007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also re-enable the relevant browser tests, since this error was causing the flakiness (the log could not be parsed).
BUG=64792
TEST=browser_tests,unit_tests,go to a phishing site with -v=1, no error logs show up.
Review URL: http://codereview.chromium.org/5271012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was bothering me; none of the other tooltips have
trailing periods.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5326009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Occassionally fails on linux too, for the same reason as bug 64664
BUG=64664
Review URL: http://codereview.chromium.org/5363005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also initialize cocoa explicitly; nobody happens to call |NSApplication sharedApplication| before cocoa calls are made. Also have an explicit autorelease pool, since we don't derive from PlatfromTest
BUG=64797
TEST=suppression bug_64797 goes away
Review URL: http://codereview.chromium.org/5309008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tab closing.
BUG=64849
TEST=none
Review URL: http://codereview.chromium.org/5372009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This just required fixing the remaining callers.
BUG=24672
Review URL: http://codereview.chromium.org/5356008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
create WebGL or canvas contexts but don't actually render into them, this prevents the screen from going blank.
BUG=64793
TEST=Ensure bleacherreport.com renders
Review URL: http://codereview.chromium.org/5377008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a fix for when multiple ethernet services exist (etho0, dummy0, etc).
The code loops through all available services, and if it is of TYPE_ETHERNET,
will assign it as the default service to use. If there are multiple
services of TYPE_ETHERNET, later services in the array will overwrite
earlier ones. If the last service is something without a real
connection (such as dummy0), you will not be able to access the internet.
Also, earlier services are never deleted and will be leaked.
This change will stop reassigning services once a service is created
and has a working connection. It will also delete previous connections
to fix the memory leak.
This fix was originally implemented http://codereview.chromium.org/3027015/
but was removed in http://codereview.chromium.org/4169001/
BUG=chromium-os:9766
TEST=Manual. Check to make sure connecting/disconnecting ethernet works as normal.
Review URL: http://codereview.chromium.org/5289007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59265
TEST=none
Review URL: http://codereview.chromium.org/5292005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=./out/Debug/chrome + resize browser very narrow in xmonad
Review URL: http://codereview.chromium.org/5318010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64153
TEST=manual
Review URL: http://codereview.chromium.org/5372006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cursor to the end.
BUG=63860
TEST=See bug report
Review URL: http://codereview.chromium.org/5309005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reset the source-page of the navigation if the new page is going to use a different profile than the originating page (e.g. a link on a non-OTR page opening a page in the OTR window)
BUG=63172
TEST=manual, see bug.
Review URL: http://codereview.chromium.org/5396002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For official Windows builds only, remove the flag and turn on the cloud print
proxy setup UI.
BUG=60092
TEST=On an official Windows build, cloud print gone from about:flags, present in both tabbed and untabbed options (under the hood).
Review URL: http://codereview.chromium.org/5409001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run with pepper flash, go fullscreen.
Review URL: http://codereview.chromium.org/5291012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. testBlockCookies
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5357006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/5384002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are replaced by simple XML markup).
This reflects API changes in the CL that was reviewed at
http://codereview.chromium.org/5271009.
TBR=aa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5310010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 788d69e77c290a2563604dfc04ec9f9e95b5b9a0.
TBR=jstritar@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
will be reverted immediately. I'm just landing it so that I can
pull it to m9 branch.
BUG=64737
TEST=none
Review URL: http://codereview.chromium.org/5318011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=setup_unittest.exe should now pass.
Review URL: http://codereview.chromium.org/5274003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63382
TEST=None
Review URL: http://codereview.chromium.org/5177009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67750 0039d316-1c4b-4281-b951-d872f2087c98
|