| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixed header alignment and spacing
* Fixed top nav, removed useless/dead links, added sample link instead
* Fixup requirements in samples and getting started page (beta no workie yet, mac and linux do -- at least enough to not be worth mentioning)
* Make vertical separator bar green
* Make default_icon required for page and browser actions
* Fix incorrect description of how onclick works wrt isolated worlds
* Make the page titles be <page title> - Google Chrome Extensions - Google Code
* Add a warning about NPAPI
BUG=28152,27875,28155,28182,27864,27432
Review URL: http://codereview.chromium.org/437001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28476
TEST=Install any theme (e.g., "Classic"); click "undo" in infobar; toolbar layout shouldn't change (and the toolbar's contents should be sized correctly).
Review URL: http://codereview.chromium.org/418048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bubble was appearing in its default location
when getting shown while the mouse was nearby; it
would move to the correct location on the next
motion event.
I think that there's still a flicker in the wrong
location when closing the download bar and then
triggering the bubble, but the fix is non-obvious
to me. It's possible that it's not noticeable on
anything faster than the slow DSL line that I'm
using to run Chrome remotely to test this.
BUG=28494
TEST=repeated steps from bug and checked that download bar behavior doesn't appear to have regressed either
Review URL: http://codereview.chromium.org/431007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Not exactly sure why this was compiling for some people before.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file:// URLs. It turns out teams were already depending on
this and we didn't want to break them.
Instead, group file:// access with NPAPI in the extension
install prompt.
Note: this is a pure revert of r402029 and r402069 (sorry
Finnur!) except the changes in extension_install_ui.cc,
which are new.
BUG=28456
Review URL: http://codereview.chromium.org/430003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28421
TEST=run ps auxw, see that --type is the first switch to renderer processes
Review URL: http://codereview.chromium.org/414071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 2: to be merged into 249.
BUG=28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/414076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
part 1: string fix (not to be merged to 249)
BUG=28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/431002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/420004
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/414075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/420004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=6844, 27935
Review URL: http://codereview.chromium.org/402097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin_service.cc/.h
The test automation provider registers itself as a protocol factory for http/https requests. This
is to ensure that intercepts set by the url request network tests work correctly. I was seeing these
tests fail consistently on my setup as their intercept function would never get called.
The other change is to add a simple mechanism based on a boolean flag to disable browser side plugins
like gears which also intercept network requests and expect to be called on the IO thread. The chrome
frame network tests run in a relatively simple environment where the network tests run in a separate thread
(not the IO thread) which causes a number of DCHECKS to fire in debug build test runs. The flag used to
determine whether browser plugins are loaded defaults to true.
Review URL: http://codereview.chromium.org/414017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "active window" change was done for linux in http://codereview.chromium.org/147091 and might fix other problems too. Without this, BrowserList::GetLastActive() returns NULL in Browser::Observe(), which caused the new function not to be called.
It looks something like http://imgur.com/6PHQm .
BUG=26377
TEST=
chmod -r ~/Library/Application\ Support/Chromium/Default/History*
Then start chromium (release build, so that we survive some sqlite dchecks) and make sure it displays an error message (then chmod +r again)
Review URL: http://codereview.chromium.org/418040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr
BUG=19361
TEST=ErrorPageTest
Review URL: http://codereview.chromium.org/426011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncerSession,
SyncerStatus, and ConflictResolutionView of duty.
Main impact is factors all status munging to 'StatusController', adds SyncSessionContext
to wrap various engine parts needed by different components, removes duplicated methods by a
factor of ~3 making it easier to reason about, and adds a 'Controller' to the session object to
give a way to delegate session-global (i.e affecting any session) occurrences such as throttling.
Also adds testing for 'HasMoreToSync' and other session related code.
BUG=25266
TEST=SyncSessionTest(added), StatusControllerTest(added)
various sync_unit_tests in this CL
Review URL: http://codereview.chromium.org/386030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28357
TEST=none (unless you feel like mocking /bin/ps)
Review URL: http://codereview.chromium.org/426010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this CL will be immediately reverted.)
BUG=26712
TEST=trybot
Review URL: http://codereview.chromium.org/425015
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/414069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
immediately reverted.)
BUG=26712
TEST=trybot
Review URL: http://codereview.chromium.org/425015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jianli
BUG=28445
TEST=SharedWorkerFastLayoutTest, WorkerFastLayoutTests
Review URL: http://codereview.chromium.org/429001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We had the same code in three headers, and an "if FREEBSD" in a
_linux.cc file.
Review URL: http://codereview.chromium.org/414063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
perf overview dashboard) for memory_test, but not for page_cycler.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/425008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scoped_refptr<T>
Review URL: http://codereview.chromium.org/418007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only open the Find box and not issue the search. This is because we set the prepopulate string to find_text and not find_text_ (the former is blank on F3). I have also changed the variable name to prevent this kind of confusion in the future.
BUG=28306
TEST=Automated test added.
Review URL: http://codereview.chromium.org/425003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions don't send an install error notification, so the loading bubble persists forever).
BUG=none
TEST=install a blacklisted extension
Review URL: http://codereview.chromium.org/418031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates instances of allocated-but-invalid SharedIOBuffers. Also clean up some CHECKs and TODOs associated with the bug.
The upshot is that we no longer crash in AsyncResourceHandler::OnResponseCompleted() when we can't allocate shared memory. We now crash (properly, I believe) in the renderer process if the shared memory that failed to allocate was the TransportDIB, since the renderer can't communicate with the browser without it.
BUG=16371
TEST=none
Review URL: http://codereview.chromium.org/391009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/418028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/414048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=trybots
Review URL: http://codereview.chromium.org/415006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=26610
TEST=Open a page in a teb that prints out when the window object gets focused
blured. Switch to another tab then come back to that tab. A blur and focus
events should have been fired.
Review URL: http://codereview.chromium.org/402091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28318
TEST=Bring up the Add Folder sheet by choosing Add Folder... from the contextual menu. The OK button should always be active. Click OK and a new, unnamed folder should be added.
Review URL: http://codereview.chromium.org/414055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17608
TEST=Add some bookmarks (you must use both folders and marks). Apply
a theme and make sure theme color applies bookmark button text for all
buttons (including "Other bookmarks"). Create new window and make
sure bookmark buttons still fine in new window. Quit and restart
Chrome. Make sure theme color still applied to bookmark button text
in the same way as before quitting (e.g. same color and still applies
to all). Change theme 1 more time and verify color.
Review URL: http://codereview.chromium.org/424004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=32319 with unit test fixes.
Reverting this as this caused a number of valgrind test failures.
Make the WebKitThread object start the WebKit thread on construction (not lazily).
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144
Review URL: http://codereview.chromium.org/404025
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/427001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes it so observer installed by WidgetGtk is cleaned up and not
leaked.
. Removes unnecessary static_cast<int> in view.
. Fixes some leaks in textfield and button.
. Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/420005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes the man page consistent with other outputs, like 'chrome' and 'chrome.pak', which simplifies some package building logic and keeps all file renaming in one place.
Review URL: http://codereview.chromium.org/420008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used for excluding the root node from display, rather, user is_root() for that purpose. A folder with an empty name is now shown as a blank line in the popup.
BUG=28313
TEST=Create a new folder with a blank name and add an URL to that folder. Select the new bookmark. Bring up the bubble and click either 'Edit' or 'Close'. It should not crash at this point. Also, click on the popup and a blank line should appear representing the newly created folder.
Review URL: http://codereview.chromium.org/418027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28358
TEST=On a debug build (on any platform), go to about:memory and make sure it doesn't fail a DCHECK().
Review URL: http://codereview.chromium.org/418022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
slowed down NTP on mac.
This reverts commit r32649.
Review URL: http://codereview.chromium.org/425004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27860,27861
Review URL: http://codereview.chromium.org/411008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux to poplular Linux fonts.
This CL does not change the fonts for traditional Chinese because they're the same as for English Chrome (per popular request in Mozilla bugzilla years past) and
it's not clear what to do about mscorettf (Arial, Times New Roman) we specify for most language versions of Chrome.
BUG=20171
TEST=NONE
Review URL: http://codereview.chromium.org/259060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=119
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32626
Review URL: http://codereview.chromium.org/410004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I thought the check would never fail, but I found out how to trigger it, so it turns out to be necessary after all.
TBR=derat
Review URL: http://codereview.chromium.org/421011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=28364
Review URL: http://codereview.chromium.org/418020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the HTML to the cache saved 8ms on New Tab Warm on Windows,
maybe we can shave a few more ms off by moving the CSS.
http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150
After this change, I'm going to try to do some cleanup to merge
NewTabHTMLSource into DOMUIThemeSource since these classes are both
quite small now.
BUG=26228
Review URL: http://codereview.chromium.org/413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32649 0039d316-1c4b-4281-b951-d872f2087c98
|