summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix EOL inconsistency on extension_message_service.cc.maruel@chromium.org2009-09-171-1/+1
| | | | | | | | | | | | NO CODE CHANGE. The presubmit check should have warned you. Please listen to it. This causes breakage on the try slaves because SVN is too stupid to revert a file with inconsistent EOL, go figure. TBR=mpcomplete TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26439 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new reliability test failure in ↵tyoshino@google.com2009-09-171-0/+3
| | | | | | | | | | | DeleteTask<webkit_glue::WebPluginImpl>::Run to known_crashes.txt TBR=agl BUG=22106 Review URL: http://codereview.chromium.org/215006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mouse over status bubble.darin@chromium.org2009-09-171-1/+1
| | | | | | | | | | R=dglazkov BUG=22050 TEST=none Review URL: http://codereview.chromium.org/215001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26434 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add names to some widgets for parasite's benefitevan@chromium.org2009-09-174-0/+4
| | | | | | Review URL: http://codereview.chromium.org/212002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26424 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Windows: Warn about outdated plugins."agl@chromium.org2009-09-168-302/+1
| | | | | | | This reverts commit r26409. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26420 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't put a blank line in the tooltip for nameless bookmark bar bookmarks.estade@chromium.org2009-09-161-1/+1
| | | | | | | | | | | | | Man, why is it so hard to get this right?? BUG=none TEST=look at tooltips for a bookmark that has a) no title b) no url (folder) c) both title and url Review URL: http://codereview.chromium.org/207003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26418 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the sidenav. Also remove unnecessary end-of-line white spacekathyw@google.com2009-09-1628-1236/+1283
| | | | | | | | | | from the template, so that we'll have fewer presubmit warnings. TBR=aa Review URL: http://codereview.chromium.org/214001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26417 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash issue of AutocompleteEditViewTest.suzhe@chromium.org2009-09-161-3/+22
| | | | | | | | | | | This CL fixes a crash issue of AutocompleteEditViewTest, which is due to not waiting for bookmark model and history service being fully loaded. BUG=21971 TEST=none Review URL: http://codereview.chromium.org/201135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26413 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Warn about outdated plugins.agl@chromium.org2009-09-168-1/+302
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the infrastructure for detecting out of date plugins and warning the user about them. Glen was ok with the infobar, although he notes that there will be a better 'notifications' UI for this sort of thing in the future. This UI will trigger at most once a day and only when we load the plugin information. This patch appears to duplicate some information from plugins2.xml, which is the plugins database that the default plugin uses to install missing plugins. I'm not reusing that information in this patch: * Note that the names of the plugins are different between the two. plugins2.xml uses a 'friendly' name, while this code needs to know the name that the plugin itself uses. * Also note that URLs are different. plugins2.xml wants a link to an exe for the installer, while we want a landing page. * The code for loading and parsing plugins2.xml is in the default plugin, and thus would require a lot of major refactoring to use here. Regarding the second point, above. One could imagine that we open a tab to "about:update-plugin#MAGICSTRING,application/x-shockwave". Javascript on that page notes the fragment in the URL and creates a plugin of the correct type on the page, passing MAGICSTRING to the plugin. The renderers are updated to know that all plugins on about pages should be directed to the default plugin. The default plugin notes the MAGICSTRING argument and uses a new NPAPI call to validate the string. MAGICSTRING will be a random string, created once per instance which is needed so that the default plugin can know that it's running on behalf of the browser, not some random webpage. When it validates, it doesn't wait for the user to click inside the plugin to trigger the download. It also doesn't trigger a page reload afterwards, instead draws text to the effect of "Successful install". This alternative design would remove the duplication, at the cost of a lot of work. Since it's a UI question, I asked Ben and Glen. However, they didn't get back to me so, for now at least, this simplier solution will suffice. BUG=21100 http://codereview.chromium.org/197053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26409 0039d316-1c4b-4281-b951-d872f2087c98
* Handle some startup errors encountered by ModelAssociator (such as tim@chromium.org2009-09-1611-14/+55
| | | | | | | | | | | | unable to find tagged nodes) more gracefully by triggering the unrecoverable error handler. This was in response to a suggestion from chron, as we seem to hit this case a fair bit, and crashing is a pain. More importantly it's possible users are hitting it as well and having an explicit error case / message hidden on the options dialog is better than silently failing with no inkling as to what happened. It also just seems preferable to be in the PSS error state when this happens. Review URL: http://codereview.chromium.org/201119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26407 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix Linux Views build.pkasting@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26402 0039d316-1c4b-4281-b951-d872f2087c98
* Escape ampersands in web view text selection for right click context menu so ↵estade@chromium.org2009-09-162-8/+30
| | | | | | | | | | | | that they don't show up as mnemonics. Also escape underscores in gtk menus so they don't show up as mnemonics (we use ampersands to match windows). BUG=14587 Review URL: http://codereview.chromium.org/203078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26401 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add a dialog for printing.estade@chromium.org2009-09-169-13/+260
| | | | | | | | | | | | Add an infobar directing users to tell us if they have problems with printing. Hide printing behind --enable-printing flag on linux/gtk. BUG=9847 TEST=none Review URL: http://codereview.chromium.org/200138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26400 0039d316-1c4b-4281-b951-d872f2087c98
* Gears File Drag Dropmichaeln@google.com2009-09-169-26/+36
| | | | | | | | | | | | | | | | | r24899 now keys the child security policy database based on renderer id, rather than renderer process id. Update gears drag drop to use the renderer id for the file policy access checks. This is a clone for submission of of noel's original CL http://codereview.chromium.org/195079 BUG=7995 Review URL: http://codereview.chromium.org/196145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26397 0039d316-1c4b-4281-b951-d872f2087c98
* Rename test_web_contents.* to test_tab_contents.*tony@chromium.org2009-09-167-12/+10
| | | | | | | | | Just a small cleanup. Review URL: http://codereview.chromium.org/206037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26396 0039d316-1c4b-4281-b951-d872f2087c98
* Convert InfoBubble to using BubbleBorder. This also replaces the border ↵pkasting@chromium.org2009-09-1623-446/+478
| | | | | | | | | | | | graphics with a slightly darker set from Nicholas. The downside here is that the Linux views code is definitely going to be broken by this. I'm not sure of the best design for Linux views, so I haven't implemented one. BUG=21028 TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position. Review URL: http://codereview.chromium.org/195099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26394 0039d316-1c4b-4281-b951-d872f2087c98
* Add test for history HTML escaping issue.cevans@chromium.org2009-09-161-0/+17
| | | | | | | | | BUG=17892 TEST=SessionHistoryTest.HistorySearchXSS Review URL: http://codereview.chromium.org/206040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26392 0039d316-1c4b-4281-b951-d872f2087c98
* Set OS X cache directory to ~/Library/Caches/[app name]/[profile name] mark@chromium.org2009-09-162-12/+39
| | | | | | | | | | | | | - Added implementation of GetUserCacheDirectory() for OS X. - Added FilePath::GetRelativePath(). - Implemented per-profile cache directories for OS X. Patch by Fred Akalin <akalin@gmail.com> Code review URL: http://codereview.chromium.org/174053 Review URL: http://codereview.chromium.org/204043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26387 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: memset the window command data structure. |timestamp| is aligned ↵jhawkins@chromium.org2009-09-161-2/+8
| | | | | | | | | | on a 16 byte boundary leaving 4 bytes of uninitialized data in the middle of the struct. We write this data to disk, which is a possible security risk. BUG=22031 TEST=TabRestoreUITest.RestoreToDifferentWindow Review URL: http://codereview.chromium.org/196144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26379 0039d316-1c4b-4281-b951-d872f2087c98
* First part of automated_ui_tests improvements.phajdan.jr@chromium.org2009-09-169-65/+206
| | | | | | | | | | | | - disable unreliable RestoreTab action - make more command sync, waiting for their completion TEST=none BUG=21547, 21636 Review URL: http://codereview.chromium.org/196096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26371 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/206025 for Charlie:sky@chromium.org2009-09-161-0/+5
| | | | | | | | | | | | Fix settings page transparent background issue Also comment out focus manager check due to bug: http://crbug.com/21378 TEST=none BUG=none Review URL: http://codereview.chromium.org/194128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26370 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up newer GTMthomasvl@chromium.org2009-09-164-24/+17
| | | | | | | | | | Switch a bunch of window sizing over to use the helper so it's completely in all cases. BUG=none TEST=about box, hung renderer, edit search engine, and http auto still size correctly. Review URL: http://codereview.chromium.org/201137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26369 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce severity of alert level when extension installation fails.pamg@google.com2009-09-161-1/+1
| | | | | | | | BUG=19907 TEST=as described in bug Review URL: http://codereview.chromium.org/204034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26366 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of 'Polish dragging of ToolStrips'. This CL restricts the motion of ↵sidchat@chromium.org2009-09-161-1/+23
| | | | | | | | | the ToolStrip to just horizontal motions until it is dragged far enough from the extension shelf, in which case it is torn away from it (similar to Tabs). BUG=18443 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26362 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 10860 - RTL: Hebrew file names should have forced LTRxji@chromium.org2009-09-161-11/+16
| | | | | | | | | | | | | | | | | | | directionality in download shelf. File names in download shelf are forced to be LTR in DownloadItemView and through ElideFileName(). BUG=http://crbug.com/10860 TEST=1. Open chrome with Hebrew UI. 2. Right click a link and chose Save As... (4th item from the top for non-Hebrew speakers) 3. In the save as dialog name the file קובץ.html 4. In the download shelf the filename should display as קובץ.html (not html.קובץ) Review URL: http://codereview.chromium.org/131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26359 0039d316-1c4b-4281-b951-d872f2087c98
* Build the sync unit tests:nick@chromium.org2009-09-165-34/+70
| | | | | | | | | | | | | | | | | | | - Remove old main(argc, argv) from syncable_unittest. - Since the old notifier target had only one unittest, merge it with the syncer tests. - Remove listener_unittest.cc entirely. - Don't compile natserver_main.cc, which has another main() - Use a test main from the test_support_unit library. This has the downside of pulling in a lot of deps we don't need, but it gives us a run_all_unittests.cc. - Fix a few compile errors in test code. TEST=unit tests pass BUG=none Review URL: http://codereview.chromium.org/205021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26358 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that HTML can't be executed when entered on the "Search History" or ↵mirandac@chromium.org2009-09-162-2/+2
| | | | | | | | | | | "Search downloads" pages. BUG= http://crbug.com/17892 TEST= Open history / downloads page. Search for "<h1>HI</h1>". Note that the HTML is not interpreted, but displayed as text. Review URL: http://codereview.chromium.org/201129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26357 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebViewClient, part 1.darin@chromium.org2009-09-165-268/+313
| | | | | | | | | | | | | | This change makes WebViewDelegate extend from WebViewClient as a temporary means to start having consumers implement and use WebViewClient. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/196128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26355 0039d316-1c4b-4281-b951-d872f2087c98
* Improve tab-closability of right-most tab.thakis@chromium.org2009-09-161-5/+15
| | | | | | | | | BUG=21903 TEST=Open 20 tabs. Put mouse over close button of some tab in the middle and keep clicking to close tabs. When the tab below the mouse is right-most, closing it should cause the other tabs to grow so that another close box ends up below the cursor (until the remaining tabs have reached the maximum tab width). Review URL: http://codereview.chromium.org/196137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26354 0039d316-1c4b-4281-b951-d872f2087c98
* disable extension bar for nowthakis@chromium.org2009-09-161-0/+4
| | | | | | | | | BUG=none TEST=extension bar is no longer visible Review URL: http://codereview.chromium.org/206030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26352 0039d316-1c4b-4281-b951-d872f2087c98
* Cast the TabWindowController object to the correct type before treating it asmark@chromium.org2009-09-161-3/+6
| | | | | | | a TabWindowController. Review URL: http://codereview.chromium.org/204030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26349 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize conversionsmark@chromium.org2009-09-165-10/+11
| | | | | | | | | The SDK has gotten stupider in 10.6, and has conspired with the compiler, which now thinks that when the receiver is held in a scoped_nsobject, NSColor and NSSize arguments should be converted to their CG cousins. Review URL: http://codereview.chromium.org/205016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26348 0039d316-1c4b-4281-b951-d872f2087c98
* Mac about box shouldn't be a floater.mark@chromium.org2009-09-161-6/+6
| | | | | | | | | | | | | | Nib changes: - Remove the "utility," "minimize," and "hide on deactivate" bits from the window. - Remove the "rich text" bit from the title text field. - Remove the "selectable" bit from the version text field. BUG=21918 TEST=About box should not float above other windows Review URL: http://codereview.chromium.org/206019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26346 0039d316-1c4b-4281-b951-d872f2087c98
* Add pause and resume to Linux download shelf.craig.schlenter@chromium.org2009-09-162-1/+6
| | | | | | | | BUG=16929 Review URL: http://codereview.chromium.org/203069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26344 0039d316-1c4b-4281-b951-d872f2087c98
* Edit Search Engine fix up:thomasvl@chromium.org2009-09-163-875/+510
| | | | | | | | | | | | | Fix the class name to match a rename that happened before commit. Make the label size changes force the fields over, but not string the fields (window grows). Make the url description autosize to the text it gets. Make the window track the height needed for the url description field. BUG=21893 TEST= The url description text should stay under the url box in all languages. The labels should never clip or overlap the text fields. Review URL: http://codereview.chromium.org/195096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26342 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26300 - Fix installer scripts so they don't look for pthreads.dll.nick@chromium.org2009-09-162-0/+2
| | | | | | | | | | | | | | We statically link this. TEST=none BUG=none Review URL: http://codereview.chromium.org/193120 TBR=nick@chromium.org Review URL: http://codereview.chromium.org/205020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26339 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new entry to reliability test known_crashes.txt file.tyoshino@google.com2009-09-161-0/+3
| | | | | | | | | | BUG=21978 TBR=agl TEST=none Review URL: http://codereview.chromium.org/206027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26330 0039d316-1c4b-4281-b951-d872f2087c98
* Add space between TYPE and colon in entries in known_crashes.txt file.tyoshino@google.com2009-09-161-3/+3
| | | | | | | | Looks like without this, pattern match doesn't work on reliability test. Review URL: http://codereview.chromium.org/193124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26327 0039d316-1c4b-4281-b951-d872f2087c98
* Move tests marked as crashing/hanging on Mac valgrind to mac-specific ↵dank@chromium.org2009-09-162-18/+26
| | | | | | | | | | | disable file. Add top six tests causing the most recent crashes/hangs on the mac valgrind ui bots. BUG=21949 Review URL: http://codereview.chromium.org/196134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26325 0039d316-1c4b-4281-b951-d872f2087c98
* Another try to fix a build break caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | This change just adds a namespace. I wish this fixes. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/201132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26322 0039d316-1c4b-4281-b951-d872f2087c98
* A quick build fix caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | It seems this "static_cast<GtkWidget*>(window)" has been moved from a static member "InfoBubble::Show()" to a non-static member "InfoBubble::Init()". So, we don't need this cast. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/204036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26321 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 211.0 to 212.0jon@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26320 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 21587, a regression of CL 196020.suzhe@chromium.org2009-09-163-20/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input. It's a regression of my CL: http://codereview.chromium.org/196020, which reverts the text of omnibox in OnAfterPossibleChanges(), when enter key is pressed: ... // If the change is caused by an Enter key press event, and the event was not // handled by IME, then it's an unexpected change and shall be reverted here. // {Start|Finish}UpdatingHighlightedText() are called here to prevent the // PRIMARY selection from being changed. if (enter_was_pressed_ && (char_inserted_ == '\n' || char_inserted_ == '\r')) { StartUpdatingHighlightedText(); SetTextAndSelectedRange(text_before_change_, sel_before_change_); FinishUpdatingHighlightedText(); return false; } ... Unfortunately, this piece of code causes the char_inserted_ to be set to wrong value in HandleInsertText(), if the text has only one character. See the source code of HandleInsertText(): ... // Filter out new line and tab characters. // |text| is guaranteed to be a valid UTF-8 string, so it's safe here to // filter byte by byte. // // If there was only a single character, then it might be generated by a key // event. In this case, we save the single character to help our // "key-press-event" signal handler distinguish if an Enter key event is // handled by IME or not. if (len == 1) char_inserted_ = text[0]; ... This CL uses a boolean |enter_was_inserted_| instead of char |char_inserted_| to record the enter key status, to make sure it won't be reset unexpectly. The test has been updated to cover this case. An unexpected dns lookup issue in the test which causes a failure on Windows was also fixed. BUG=21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input. TEST=Input one character in omnibox and press enter, the default link matched with the character should be opened. Review URL: http://codereview.chromium.org/200131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26315 0039d316-1c4b-4281-b951-d872f2087c98
* More miscellaneous cleanup bits to try and move info_bubble.* closer to my ↵pkasting@chromium.org2009-09-163-67/+51
| | | | | | | | | | locally rewritten versions, so that the diff will be readable. BUG=none TEST=none Review URL: http://codereview.chromium.org/196131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26312 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bare-bones extension shelf that displays extension items on OS X.thakis@chromium.org2009-09-1615-30/+858
| | | | | | | | | | | | | | | | | | | This brings our extension support to about the level it has on linux. One issue is that the toolstrips are webpages with a background image that just happens to look like the shelf they are on. But the background images are not updated on key->nonkey window changes, so the toolstrip backgrounds look slightly off in one of the two cases. If we decide to keep the shelf, we should fix this, but see the bug for erikkay's stance on this. Also, the NTP is only loaded after all toolstrips have been loaded for some reason. That's what happens on the other platforms too, I believe. The extension shelf uses the DownloadShelfView as background view for now. Screenie: http://imgur.com/wSHgU.png BUG=19073 TEST=Extensions that live in the shelf should show up. They should be clickable, resize correctly (e.g. the build status extension), and the shelf should interact in a sane way with the status bubble. Review URL: http://codereview.chromium.org/175025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26311 0039d316-1c4b-4281-b951-d872f2087c98
* Remove valgrind filters for GTK unittests as the bots now run the tests with ↵mattm@chromium.org2009-09-161-6/+0
| | | | | | | | | | xvfb. BUG=15445 Review URL: http://codereview.chromium.org/204032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26309 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: print page to file rather than using shared memory to send it to the ↵estade@chromium.org2009-09-167-139/+121
| | | | | | | | | | | | browser. BUG=9847 adapted from patch by <minyu.huang [at] gmail> Review URL: http://codereview.chromium.org/203062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26308 0039d316-1c4b-4281-b951-d872f2087c98
* Add SSL icons on Mac OS Xhawk@chromium.org2009-09-165-1/+122
| | | | | | | | BUG=14899 TEST=https sites have a lock icon in the address field, plain http sites do not Review URL: http://codereview.chromium.org/199072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26307 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Snow Leopard SDK errorsmark@chromium.org2009-09-162-2/+2
| | | | | | | error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument passing Review URL: http://codereview.chromium.org/204028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26304 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-155-15/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 07:26:38 +0000