| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
TBR:cmasone
Revert "Revert 44935 - Allow mocking of cros api without automatically deleting the mocks"
This reverts commit 6113af35343e47bb584395d387aba96b7c435277.
Review URL: http://codereview.chromium.org/1627028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1591036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when a browser action's icon changes, it caused the gtk widget
tree to be modified, which hid all tooltips. This was a problem because
several popular extensions called setIcon on a timer of a few seconds.
BUG=37489
TEST=none
Review URL: http://codereview.chromium.org/1547036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mocks
Review URL: http://codereview.chromium.org/1653011
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/1637022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1653011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41265
TEST=none
Review URL: http://codereview.chromium.org/1574037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes telephone and fax number entries in the Mac AutoFill dialog to be a single
text field for all three (1) country code, (2) area code, (3) number.
Renames address model fields city, state, country to be addressCity, addressState,
addressCountry. This was due to subtle name clash with 'state' as a selector.
Nib changes: (1) changes bindings to reflect the renaming of city, state, and country
in the model. (2) collapse telephone and fax numbers from three fields each to a single field.
BUG=41233
TEST=AutoFillAddressModelTest, AutoFillCreditCardModelTest, AutoFillAddressViewControllerTest, AutoFillCreditCardViewControllerTest
Review URL: http://codereview.chromium.org/1625020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mmoss
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1551036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=alcor
BUG=41481
TEST=none
Review URL: http://codereview.chromium.org/1629025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove "Type to search" hint
* Remove "Untrusted website" label
* Add EV cert bubble, make it function like a location icon for clicks/drags
* Modify spacing for EV/tab-to-search bubbles to keep icons and text aligned with dropdown
* Change non-EV HTTPS coloring from blue to green
Mac and Linux should compile, but only some of the above changes have been made for them. Specifically, there is no EV cert bubble, the non-EV scheme color isn't changed, and the icon/text alignment in the tab-to-search bubble hasn't been touched.
BUG=41481
TEST=paypal.com should generate a bubble around the lock and cert holder name, which responds to clicks and drags like the location icon would
Review URL: http://codereview.chromium.org/1585043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but nothing else. This is the chrome-side of webkit bug
https://bugs.webkit.org/show_bug.cgi?id=37681
BUG=37920
Review URL: http://codereview.chromium.org/1663003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
edited the obfuscated cc number.
BUG=41649
TEST=none
Review URL: http://codereview.chromium.org/1672001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also, fix download problem when downloading a file. Since we use NavigateToURL() to trigger a download, it might take a while for it to actually start downloading and doing WaitForAllDownloadsToComplete() won't work until downloads actually start. Used WaitUntil for this. (WaitUntil has been reviewed earlier in http://codereview.chromium.org/1541009).
Review URL: http://codereview.chromium.org/1575043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bkennish
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1627027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Cut down on some WARNING spam in the common case of no file.
BUG=41839
Review URL: http://codereview.chromium.org/1618031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/41842
TEST=Copy entire string from Omnibox and paste into PowerPoint2008 document.
Review URL: http://codereview.chromium.org/1671001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only a few controls actually generate accessibility events to make sure
it works, this is mostly to get the infrastructure in place.
Note that the new files are analogous to:
chrome/browser/gtk/accessibility_event_router_gtk.cc
chrome/browser/gtk/accessibility_event_router_gtk.h
chrome/browser/gtk/accessibile_widget_helper_gtk.cc
chrome/browser/gtk/accessibile_widget_helper_gtk.h
Any design changes should be made to both sets of classes.
BUG=none
TEST=Added new unit test.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44907
Review URL: http://codereview.chromium.org/1518029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41970
http://codereview.chromium.org/1591039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension api.
Only a few controls actually generate accessibility events to make sure
it works, this is mostly to get the infrastructure in place.
Note that the new files are analogous to:
chrome/browser/gtk/accessibility_event_router_gtk.cc
chrome/browser/gtk/accessibility_event_router_gtk.h
chrome/browser/gtk/accessibile_widget_helper_gtk.cc
chrome/browser/gtk/accessibile_widget_helper_gtk.h
Any design changes should be made to both sets of classes.
BUG=none
TEST=Added new unit test.
TBR=thomasvl
Review URL: http://codereview.chromium.org/1518029
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/1664004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes the chromium_zygote_t type and adds a
chromium_renderer_t type. Also, a basic policy for chromium_renderer_t
is included.
I decided not to try to have a different policy for the zygote since
it just makes things more complex for little reason.
BUG=none
TEST=none
http://codereview.chromium.org/1104002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only a few controls actually generate accessibility events to make sure
it works, this is mostly to get the infrastructure in place.
Note that the new files are analogous to:
chrome/browser/gtk/accessibility_event_router_gtk.cc
chrome/browser/gtk/accessibility_event_router_gtk.h
chrome/browser/gtk/accessibile_widget_helper_gtk.cc
chrome/browser/gtk/accessibile_widget_helper_gtk.h
Any design changes should be made to both sets of classes.
BUG=none
TEST=Added new unit test.
Review URL: http://codereview.chromium.org/1518029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mmoss
BUG=41966
TEST=none
Review URL: http://codereview.chromium.org/1613022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This issue is caused by r34322 that changes text composed by an IME. (It makes Windows reset the IME.) As a quick fix, this changes adds a new method TextField::IMEIsComposing() and call it before changing text in FindBarView::UpdateForResult().
BUG=34970
TEST=Type Ctrl+F, enable a Japanese IME, and type shift+a, return, and shift+a. Verify if the find box has two As, i.e. 'AA'.
Review URL: http://codereview.chromium.org/1630014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserTest.PageLanguageDetection.
BUG=40962
TEST=The test should not be flaky anymore.
Review URL: http://codereview.chromium.org/1642002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well.
BUG=35607
TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry)
Landing http://codereview.chromium.org/1622017/show for Satish.
Review URL: http://codereview.chromium.org/1600030
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/1599038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well.
BUG=35607
TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry)
Landing http://codereview.chromium.org/1622017/show for Satish.
Review URL: http://codereview.chromium.org/1600030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSecurityOrigin::createFromDatabaseIdentifier(), and fix all its
callers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1646013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modify the license script to have a "credits" mode, which uses
two templates derived from the existing about:credits HTML.
BUG=39240
Review URL: http://codereview.chromium.org/1520039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Chagned WidgetGtk so that any GtkFixed can be parent of WidgetGtk.
* Close button and Options menu is moved to separate TYPE_CHILD WidgetGtk
which is shown/hidden as mouse moves.
TODO: host Widget is not transparent right now. I'll address this in separate CL.
BUG=41011
TEST=none
Review URL: http://codereview.chromium.org/1654006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Start chrome with --enable-extension-apps --app-launcher-new-tab. Pressing Ctrl+T should show the NTP in the overlay.
Review URL: http://codereview.chromium.org/1660005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add images for EV bubble
* Modify images for tab-to-search to look like EV bubble
* Change lock icons
TBR=alcor
BUG=41481
TEST=none
Review URL: http://codereview.chromium.org/1652014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed from GtkEntry's to GtkTextViews.
BUG=41364
TEST=manual
Review URL: http://codereview.chromium.org/1582028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generally, we don't expect it to fail and there isn't much we
can do anyway, but it's good to at least consider each case and
do something so we can continue to receive warnings in situations
where we forgot to check the return code.
(Bonus extra bugfix: use int where we previously had bool.
I think it compiles to the same thing but the old code was
definitely wrong.)
Review URL: http://codereview.chromium.org/1564037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/41690
TEST=\
Create a bookmark with an empty title. Add to subfolder. Open it -->
see it left aligned.
Review URL: http://codereview.chromium.org/1540040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GCC doesn't mind, but clang does.
Review URL: http://codereview.chromium.org/1631025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(It confuses Clang, since NewRunnableMethod is a function.
I've filed a Clang bug, but we didn't need it in our code anyway.)
Review URL: http://codereview.chromium.org/1658009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- makes device contexts opaque to the plugin
- can get / set multiple attributes and flush with a single call (and underlying IPC message exchange)
- currently works in parallel with old API
- adapted pepper test plugin to use new API if use_new_npdevice_api=1
TEST=trybots, visual confirmation that pepper test plugin works with new API
BUG=none
Review URL: http://codereview.chromium.org/1529005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Does not work if dragging out to XP desktop. We need to return an error code
when waiting for XP Shell to start a background thread.
2) Occasional crash due to regression caused by r43726. Fix it by holding a
local reference to drag_source_.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1619023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dragging something from the download shelf.
DraggingButton.mm was setting up non-draggable buttons to be ready for drag.
DownloadShelfButtons never called endDrag.
BUG=40594
TEST=Try to drag the Other Bookmarks button. It shouldn't stay highlighted.
Review URL: http://codereview.chromium.org/1648003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Point to this from the chrome.bookmarks page.
Besides adding Bookmark Manager info, I also reorganized things a bit and added the URL for each page. Is mentioning the URLs OK? (I've found them handy, but maybe we don't want to commit to them.)
BUG=40806
TEST=none
Review URL: http://codereview.chromium.org/1633017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39819
TEST=Selecting "always translate" from the translate infobar options menu, a checkmark should appear next to it and the "never translate" options should be grayed out.
Review URL: http://codereview.chromium.org/1559036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40126
TEST=none
Review URL: http://codereview.chromium.org/1539042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40735
TEST=compile; trybots; manually opening and closing a lot of infobubbles
Review URL: http://codereview.chromium.org/1652005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38166
TEST=`google-chrome http://google.com` should raise the browser window.
Review URL: http://codereview.chromium.org/1646011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41769
TEST=Guess
Review URL: http://codereview.chromium.org/1623016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 37565
TEST= UMA calls should be recorded correctly.
Review URL: http://codereview.chromium.org/1528037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40610
TEST=manual
Review URL: http://codereview.chromium.org/1549043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flag.
BUG=39721
TEST=none
Review URL: http://codereview.chromium.org/1658007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44813 0039d316-1c4b-4281-b951-d872f2087c98
|