| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed the key-checksum field (which is unnecessary), and added the
online-only field.
BUG=chromium-os:25463
TEST=All works as before
Review URL: http://codereview.chromium.org/9691046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android we use the native download manager (and this is causing link
errors).
BUG=117407
TEST=
Review URL: http://codereview.chromium.org/9689058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
driver. This information will be added by Chrome (in different CL) just before performing error-prone printer related operations.
BUG=108194
TEST=none
Review URL: http://codereview.chromium.org/9600060
TBR=vitalybuka@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ListSingleSelectionModel behave consistently.
Also now language list has leadItem when appears first time.
BUG=chromium:117883
TEST=Test single selection lists: cookies, languages, profiles.
Review URL: https://chromiumcodereview.appspot.com/9705015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108277
TEST=OutOfProcessPPAPITest.TCPServerSocketPrivate
Review URL: http://codereview.chromium.org/9669038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move related test files.
Move WriteNode::UpdateEntryWithEncryption to nigori_util.h.
Clean up defines and dependencies. In particular, get rid of SYNC_ENGINE_VERSION_STRING and hard-code the string in the single place it's used.
Rename data_encryption.* to data_encryption_win.* and add a pragma for crypt32.lib.
Clean up exit-time constructor warnings in sync{able,er}_unittest.cc.
Remove some unused files.
BUG=117585
TEST=
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9699057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Benchmark results of copying a 1280 x 800 pixels using CopyFromCompositingSurface or CopyFromBackingSurface are as follows.
FromCompositingSurface: 40.00 ms
FromBackingStore: 2.12 ms
I'm prepareing the following CLs and these will come soon,
- Support Mac and Chrome OS (Aura)
- Reduce the number of pixels to copy from the compositing surface for performance improvement
BUG=96351
TEST=Manual
Review URL: http://codereview.chromium.org/9582003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
information will be added by Chrome (in different CL) just before performing error-prone printer related operations.
BUG=108194
TEST=none
Review URL: http://codereview.chromium.org/9600060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pages to make re-initialization work as expected. Additionally, ignore some
events that might get us into a wasteful scenario.
BUG=117671
TEST=Session restore or re-clicking same nav item loads settings correctly,
no regressions.
R=csilv,estade,mirandac,kevers
Review URL: https://chromiumcodereview.appspot.com/9693032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=estade
BUG=None?
TEST=Delete buttons in lists actually do something.
NOTRY=true
Review URL: http://codereview.chromium.org/9706052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9703013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16557
TEST=build success
Review URL: http://codereview.chromium.org/9702005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) text in bubble should be black (title can stay blue)
-> Made radio buttons and checkbox explicitly black.
2) fix alignment of radios/checkboxes (work w/ roma@)
align checkbox to left of text (“S” in “Send” in title)
-> Add local CheckboxNativeThemeBorder without left/right insets, removed padding column.
3) when you hit [Send] button ->
change button text to “Sending...” (disable Send and Cancel button)
button size should not change
-> Set Sending... text in disabled Send button during animation.
4) then “Sent!” (disabled Send and Cancel buttons) (for a few seconds)
then dismiss the bubble automatically
ideally, we would add the error message to this bubble inline instead of showing a new bubble (not gating for launch)
-> Set Sent/Error text in Send button; close after 3s (on success), add red error message on failure.
BUG=102709
TEST=Updated bubble looks as prescribed.
Review URL: https://chromiumcodereview.appspot.com/9702016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new interface is C-based so the CreateMemoryObject() callback now
takes an int rather than a bool. I have opted to wrap
content::MakeSharedMemorySegmentViaIPC() rather than change the types
in the "content" tree: arguably NaCl's use of a C interface here
should not spill over too far into Chromium's C++ code.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2651
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/9695062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoadURL and DidStartLoading.
Failing test has no DidStartLoading (in RVHImpl) in failing test, so the request must be lost somewhere. This will tell us where the request gets lost.
BUG=chromium-os:26646
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9709001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems it needed to be added to api_page_generator.js. Also, renamed
experimental.fonts.json to experimental.fontSettings.json for consistency.
BUG=114148
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9689054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
easier to sort in about:net-internals, making the world a
happier, fuzzier place.
Also slightly simplifies the functions to add NetLog entries,
and makes it impossible to create a BoundNetLog with both an
invalid source and a non-NULL NetLog.
BUG=116597
Review URL: https://chromiumcodereview.appspot.com/9585026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
due to over swigging)
Exposed GetSecurityState and GetPageType to pyAuto.
The GetSecurityState retrieves different security states for the current tab.
The GetPageType returns the type of page showing (normal, interstitial, error).
Added additional tests that uses the exposed hooks.
- testSSLCertOK
- testSSLCertIsExpiredAndCertNameMismatches
- testSSLCertAuthorityOK
TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9535022
TBR=dyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9705052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GDataOperationRegistry needs this information to provide user-friendly list of in-flight operations.
BUG=chromium-os:27371
TEST=unit_test --gtest_filter='*GData*'
Review URL: https://chromiumcodereview.appspot.com/9705048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9691033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome.
Currently InputMethodMenu continues to read/write the /home/chronos/Default/Preferences file, rather than /home/chronos/user/Preferences, even after sign in because InputMethodMenu gets a pointer to Profile by calling ProfileManager::GetDefaultProfile() *before* sign in. We have to do it after sign in since the GetDefaultProfile() function returns a different instance depending on the user is signed in or not.
This is the same fix as http://crrev.com/125787 .
BUG=118142
TEST=see the bug
Review URL: https://chromiumcodereview.appspot.com/9651023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will properly disable "Disconnect my account..." button on
ChromeOS.
cr.isChromeOs (note the last small "s", not capital "S")
returned "undefined" and thus "Disconnect..." button's
hidden attribute was always false (i.e. visible on ChromeOS).
BUG=116342
TEST=manually open chrome://settings with signed-in account and see
"Disconnect your google account" button won't appear.
Review URL: https://chromiumcodereview.appspot.com/9702051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace chrome/app/theme/mobile[_lit][_1_25x|2x].png files.
Roma made these new images after UI review (3/13/12).
I ran PNGCrush and PNGSlim (6,691 bytes -> 804 bytes).
BUG=102709
TEST=New images shown
Review URL: https://chromiumcodereview.appspot.com/9700052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added the fields for the URL, the type of the operation, and the state of
transfer (starting/in-progress/finished?). The actual data is not filled
yet (it will come soon).
BUG=chromium-os:27371
TEST=unit_tests --gtest_filter='*GData*'
Review URL: https://chromiumcodereview.appspot.com/9702057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Deleted the code that read and wrote the SpdySettings data
from preferences.
- Disabled the code that persisted the SpdySettings data.
- Disabled the unit tests that tested persisting of SpdySettings.
BUG=118148
R=willchan
TEST=browser unit tests
Review URL: https://chromiumcodereview.appspot.com/9703050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
hide the threading details from the embedder.
Review URL: https://chromiumcodereview.appspot.com/9704048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: http://codereview.chromium.org/9702030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bluetooth is to be enabled by default for R19, the UI already includes
a separate "Enable bluetooth" checkbox that is connected to the radio
power, so there is no need to leave the flag in place.
BUG=chromium-os:23022,chromium:106446
TEST=verified bluetooth now enabled by default
Change-Id: I0814b903d4764774cb63fb0b2c003ee0d5c9a49e
Review URL: http://codereview.chromium.org/9702028
TBR=keybuk@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9701056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add BluetoothDevice::Disconnect and BluetoothDevice::Forget that both
disconnect the application-level connections and low-level ACL, and in
the latter case, deletes link keys and pairing information too.
BUG=chromium-os:27765
TEST=verified on device
change-Id: I5a2613b23fac6b7c68a8fcaaf4265cccda938328
Review URL: http://codereview.chromium.org/9701007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed by WK rollout + roll
TBR=abarth
BUG=118293
Review URL: https://chromiumcodereview.appspot.com/9699061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=118070
TEST=None
Review URL: http://codereview.chromium.org/9706013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=abarth
BUG=118293
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126789
Review URL: https://chromiumcodereview.appspot.com/9703043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test exercises reading a file on a remote file point,
via RemoteFileSystemProxyInterface::CreateSnapshotFile().
BUG=chromium-os:23516
TEST=browser_tests --gtest_filter=*FileSystemExtensionApiTest.*
Review URL: https://chromiumcodereview.appspot.com/9699052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To keep the idle logout dialog with the rest of the popups on ChromeOS and following the policy of not using WebUI unless the UI is in a tab, we've moved the implementation from based on HtmlDialogUI to a views based dialog.
Reviews requested,
sky: Primary review
jhawkins: OWNER's review for removed code from ui/webui
zelidrag: OWNER's review for removed code from ui/webui/chromeos and resources/chromeos
R=zelidrag@chromium.org,jhawkins@chromium.org,sky@chromium.org
BUG=chromium-os:27545,chromium-os:27542
TEST=Tested with --enable-kiosk-mode flags.
Review URL: https://chromiumcodereview.appspot.com/9665031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114225
TEST=UI test TestHostResolverPrivate
Review URL: http://codereview.chromium.org/9455092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InputMethodManager::GetCurrentInputMethod() since it's not a simple getter.
- Do the same for previous_input_method() and current_ime_properties().
- Rename 'struct ImeProperty' to 'struct InputMethodProperty' to avoid abbreviations.
This is for crosbug.com/19655.
BUG=chromium-os:19655
TEST=try
Review URL: https://chromiumcodereview.appspot.com/9696025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, these components only registered themselves if CHROME_ETW_LOGGING was set in the environment. This is likely preventing the new log machinery in http://crrev.com/126240 from providing useful information on the main waterfall bots.
Siggi: overall
Brett: chrome/common
BUG=none
TEST=none
R=siggi@chromium.org,brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bluetooth is to be enabled by default for R19, the UI already includes
a separate "Enable bluetooth" checkbox that is connected to the radio
power, so there is no need to leave the flag in place.
BUG=chromium-os:23022,chromium:106446
TEST=verified bluetooth now enabled by default
Change-Id: I0814b903d4764774cb63fb0b2c003ee0d5c9a49e
Review URL: http://codereview.chromium.org/9702028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that gfx::Image can take a const-ref SkBitmap to copy it, the copy
no longer needs to happen at the time of Image creation.
The new constructor was added at
http://codereview.chromium.org/9455062/.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9477016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117643,117638 (#2)
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/9706036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=118231
TEST=Exercise import data dialog, make sure resizing works properly.
Review URL: https://chromiumcodereview.appspot.com/9699050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9689041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110779
TEST=Ran on perf bot.
Review URL: http://codereview.chromium.org/9699034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The display names are used for showing the file names in web pages,
and for uploading.
BUG=chromium-os:27222
TEST=manually confirm that file selection on chrome os works, the files are displayed and uploaded properly.
Review URL: https://chromiumcodereview.appspot.com/9700009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Continuation of issue 9648009.
Fixes the problem with the print dialog being in the background when launched from the command line by the cloud print print driver.
BUG=112011
TEST=No visible changes for chromium.
Review URL: http://codereview.chromium.org/9706023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crux of the problem is that buttons and text inputs are being aligned on their baseline, which I believe is correct. However they place their baseline differently relative to the top and bottom border, so the top and bottom borders wind up misaligned. To correct this, we have to add padding to the buttons and/or text inputs. The amount of padding is platform-specific.
Using vertical-align: (not-baseline) would work, but would make it look bad because the baselines would not align.
BUG=117662
TEST=visual (on win, mac, linux, chromeos)
Review URL: http://codereview.chromium.org/9689048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=115650
TEST=LauncherUpdaterTest.*, including new tests
Review URL: https://chromiumcodereview.appspot.com/9689047
TBR=davemoore@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=abarth
BUG=118293
Review URL: https://chromiumcodereview.appspot.com/9703043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114745
TEST=Theming works on 10.8.
Review URL: http://codereview.chromium.org/9700002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126787 0039d316-1c4b-4281-b951-d872f2087c98
|