| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
for specefic exceptions pages.
BUG=102892
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9147048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108724
TBR
Review URL: https://chromiumcodereview.appspot.com/9293023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=106995
TEST=
Review URL: http://codereview.chromium.org/9264055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111501
TEST=Print a doc with headers and footers enabled or disabled. Open print preview again, last setting should be remembered.
Review URL: http://codereview.chromium.org/9302014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=112024
TEST=covered by tests.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9301019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111538
TEST=Verify that favicons show up for settings, extensions.
Review URL: https://chromiumcodereview.appspot.com/9223029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary issue blocking this is was the screenshot, which would show up as a broken link if a user went to the chrome://feedback page directly.
With this change, to launch the feedback page from an extension, open it with this format,
chrome://feedback/#0?description=Text you want in the description field&categoryTag=TheCategory&customPageUrl=www.yourpageurl.com
Including the customPageUrl will supress the screenshot completely and set the page url on the displayed feedback page to the one specified.
R=zelidrag@chromium.org,xiyuan@chromium.org
BUG=chromium-os:24993
TEST=Tested opening the feedback page without going through the Report an Issue menu item with the customPageUrl parameter. Verified that the screenshot is not shown at all and the feedback is sent successfully on submit.
Review URL: http://codereview.chromium.org/9271033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23673
TEST=OncNetworkParserTest
Review URL: https://chromiumcodereview.appspot.com/9297061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new class AutocompleteFieldTrial is meant to handle one or more field trials at once. I'll add another field trial to it (that makes HistoryQuickProvider more aggressive) soon.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9113037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9301022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Waiting for idle CPU before calling pyauto.PyUITest.setUp() was problematic,
because the killing/init of Chrome occurs within pyauto.PyUITest.setUp().
BUG=chromium-os:25662
TEST=Verified CPU goes idle on Flash tests only after making this change.
Review URL: https://chromiumcodereview.appspot.com/9303017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by Ori Gershony <orig@chromium.org>.
BUG=106580
R=orig@chromium.org,estade@chromium.org
TEST=Use --enable-webstore-link to force the experiment on.
Review URL: https://chromiumcodereview.appspot.com/9303005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111475
TEST=Open proxy settings dialog on login screen with DCHECKs enabled.
Review URL: https://chromiumcodereview.appspot.com/9303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104586
TEST=See bug.
Review URL: http://codereview.chromium.org/9169040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109817
TEST=compiles
Review URL: http://codereview.chromium.org/9232070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mostly for the page action context menu, but also used elsewhere such as panels
BUG=106781
TEST=on win/chromeos, sentence case. Elsewhere, title.
Review URL: https://chromiumcodereview.appspot.com/9289037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111519
TEST=Verify 111519.
Review URL: http://codereview.chromium.org/9288077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using a software 3d rasterizer to do animation is probably slower than the regular software mode, so avoid doing that.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9289012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=110656
TEST=pyauto test: shortcuts.ShortcutsTest.testClearBrowsingDataShortcut
R=csilv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9264056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the click-to-play feature available in content settings without having to enable it in chrome://flags.
BUG=62084
TEST=none
Review URL: http://codereview.chromium.org/9293008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25635
TEST=looks 75% less crazy
Review URL: https://chromiumcodereview.appspot.com/9293019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not clear to me who needs to review the change to
third_party/leveldatabase/env_chromium.cc, or even if it's handled
through the standard CL interface for the rest of Chromium. But my
best guess was that you could either approve it or tell me who to
contact. Let me know if I need to go about this patch submission
a different way.
R=brettw@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unloads (in memory only, for now).
Add support for broadcasted events.
Add an extension.onInstalled event that is run when the event page first
starts.
BUG=81752
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9297003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's the same set of people as in chrome/browser/content_settings/OWNERS.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9301004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FlashFullscreen test. No longer mark the test as
flaky.
TEST=ui_tests
BUG=108471
Review URL: https://chromiumcodereview.appspot.com/9133024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=CWSIntentsRegistryTest.*
Review URL: http://codereview.chromium.org/9253024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I spotted another interface regression and wanted to fix it. Thanks
for reviewing.
R=johnnyg@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9104015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in 10.7.2 cause install-from-.dmg to no longer add a persistent Dock
tile. By leveraging a the same CFURL private undocumented functions that the
Dock does, Chrome can more robustly make sense of the Dock configuration and
insert itself into the plist.
BUG=111979
TEST=1. Remove Google Chrome.app from /Applications and remove its Dock tile
(if any)
2. Mount GoogleChrome.dmg
3. Launch Google Chrome.app from the .dmg
4. Click "install"
Expect the Dock to restart with a persistent tile for Chrome present
(even after quitting Chrome)
Review URL: https://chromiumcodereview.appspot.com/9264046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few more uses of the old Sleep(int ms) and PostDelayedTask()
interfaces slipped through since my last round of updates. Can you review
these?
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9104014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be removed when r119687 reaches official builds.
BUG=None
TEST=None
TBR=dennisjeffrey@chromium.org
R=dennisjeffrey@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9233037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The lock screen container needs a layout manager to respond to resolution changes caused by an external monitor being attached or detached. Marking the login screen widget as fullscreen makes it reshape to track the size change.
BUG=110942
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9121063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The calculation of the inline_autocomplete_offset_ was incorrect. Eliminated unnecessary function parameter.
BUG=110892
TEST=1) Visit an URL such as "www.amazon.com". 2) Now type 'ama' into the omnibox. 3) Verify that the presentation is "ama[zon.com]" where the bracketted section is the to-be-autocompleted portion. Also enhanced the HistoryQuickProviderTest unit tests.
Review URL: https://chromiumcodereview.appspot.com/9298017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yoz
BUG=109939
Review URL: https://chromiumcodereview.appspot.com/9233034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111752
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/9302008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: https://chromiumcodereview.appspot.com/9159038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URL than predicted.
I also took the opportunity to align the order of methods in prerender_manager.cc to that of the header (as it should be) and make a couple of methods const.
BUG=110799,111350
Review URL: http://codereview.chromium.org/9226037
TBR=dominich@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9301012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=110636
TEST=None
Review URL: http://codereview.chromium.org/9121059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the functions mapped take more than 1 argument, and all the others
are currently always undefined. This breaks locking the default search engine
select box through policy.
BUG=None
TEST=When the DefaultSearchProvider policy is set, the settings UI doesn't allow modifying the default.
Review URL: http://codereview.chromium.org/9104011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aura draws its own frame and shadow for top level windows. We will want to add support for rounded top corners for panels, but for now I think we can live with square corners.
BUG=106076
TEST=Panels on Aura should now have square corners with a standard aura window shadow behind them.
Review URL: http://codereview.chromium.org/9234046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aura has download shelf on chromeos instead of the downloads panel like the
other boards. Fix automation.
BUG=chromium-os:23648
TEST=pyauto downloads tests fixed on chromeos aura builds
Review URL: https://chromiumcodereview.appspot.com/9225017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Limiting the width of panels is affecting the behavior of some existing panels on ChromeOS device sized screens.
BUG=111121
TEST=See issue
Review URL: http://codereview.chromium.org/9288048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9223028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a policy specifies the HomepageLocation, the text field shouldn't be
editable when the user chooses the 2nd radio button.
BUG=None
TEST=Set the HomepageLocation policy to some value. The text field in the homepage UI can't be edited.
Review URL: http://codereview.chromium.org/9302005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iteration.
The pyauto performance tests that iteratively take performance measurements
now output the perf measurements on-the-fly as each measurement is taken,
thereby ensuring that the (pyauto generated) timestamps printed next to
each measured performance value is accurate in terms of when the measurement
was taken.
This CL also removes the arbitrary limit of 2 decimal places for measured
performance values.
BUG=chromium-os:25456
TEST=Ran the perf tests on my local alex device.
Review URL: https://chromiumcodereview.appspot.com/9297042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-got rid of JavaScriptDialogDelegate since the embedder really only needs to know one callback to give the results to content
-for telling it that the dialog is shown, it seemed that chrome's decision to activate the tab would be in chrome
-used WebContents as the token for resetting dialogs if their tab went away
-used currying to hide the implementation detail of reply_msg from the embedder
-made content handle NULL JS dialog creator interface instead of having a stub one in the public directory
BUG=098716
Review URL: https://chromiumcodereview.appspot.com/9159033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104981
TEST=see bug
TBR=ben
Review URL: https://chromiumcodereview.appspot.com/9296040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also took the opportunity to align the order of methods in prerender_manager.cc to that of the header (as it should be) and make a couple of methods const.
BUG=110799,111350
Review URL: http://codereview.chromium.org/9226037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:24640
TEST=Manual test.
Review URL: https://chromiumcodereview.appspot.com/9302007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UpdateTabFunction is asynchronous when updating a tab with a javascript URL. In this situation, the method was returning early before generating the callback result. This fixes the ExecuteScriptApiTest.NavigationRaceJavaScriptUrl test.
BUG=89731
TEST=ExecuteScriptApiTest.NavigationRaceJavaScriptUrl
Review URL: http://codereview.chromium.org/9225010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119690 0039d316-1c4b-4281-b951-d872f2087c98
|