| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1f7e6e059c44ad823e014534f2b3eaf5c4f5daed.
R=avi@chromium.org,ananta@chromium.org
BUG=77777
TEST=None
Review URL: http://codereview.chromium.org/6880353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6914008
TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/6914010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6914008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PhishingClassifier::TermExtractionFinished.
These can be null if the RenderView is being destroyed.
BUG=80323
TEST=none
Review URL: http://codereview.chromium.org/6902168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=tony
BUG=81297
TEST=
Review URL: http://codereview.chromium.org/6911005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/6869043/
BUG=81042
TEST=TransportSecurityStateTest.ForcePreloads
Review URL: http://codereview.chromium.org/6883294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=80233
TEST=look at NTP with new profile
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14340
TEST=updated existing ones
Review URL: http://codereview.chromium.org/6883215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderProcessHost is created and when it's launched. Also fix the same race condition in the spellcheck code.
Review URL: http://codereview.chromium.org/6907002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui/views/omnibox directory.
- Rename AutocompleteEditViewViews to OmniboxViewViews.
- Move autocomplete_edit_view_views.* to omnibox_view_views.*
BUG=80186
TEST=None
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6904130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the right thread.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6898035
TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/6907005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
removing hard-coded dir=ltr for flag title and flag dsecription.
While I'm at it, I replaced padding-(left|right) with --webkit-padding-start/endand removed unnecessary 'rtl' specific sections.
BUG=78949
TEST=Run Chrome in one of RTL languages (e.g. --lang=he on Windows or 'LANGUAGE=he chrome' on Linux) and go to 'about:flags'. Make sure that sentence-ending periods (of translated strings) are at the left-end instead of the right-end (start in RTL).
Review URL: http://codereview.chromium.org/6904028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. WebUI fonts are explicitly specified. For ko and zh-*, we want to
use locale-specific fonts instead of Droid Sans Fallback until
http://crosbug.com/14691 is fixed.
2. Add an etnry for gtkrc to name locale-specific fonts. In addition,
use the size 10 instead of the default 9 in CrOS default gtkrc file.
Size 9 is too small for these locales. Size 11 or 12 would be even
better, but our UI wouldn't work well with that size, I'm afraid.
BUG=chromium-os:708
TEST=1. Change the UI language to Korean and make sure that the font used for
Korean characters in Omnibox, Menu and WebUI are NanumGothic instead of
Droid Sans Fallback. An easy way to tell is that in the menu, the horizontal
stroke of the second character of '로그인' is sharp instead of looking as
if there were two horizontal strokes.
2. Change the UI language to ar, zh-CN, zh-TW, ar and th and make sure that
characters in the gtk-based UI are slightly larger.
Review URL: http://codereview.chromium.org/6880329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
creation page.
BUG=chromium-os:14683
TEST=Manual.
Review URL: http://codereview.chromium.org/6883281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6898035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's been failing occasionally on linux and ChromeOS. Perhaps this will fix the
flakiness, or at least narrow down which of the 3 subtests is causing problems.
BUG=80606
TEST=none
Review URL: http://codereview.chromium.org/6901153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetChannel was confused in multi-user installs. It treated them as
CHANNEL_UNKNOWN instead of their correct channels.
BUG=81218
TEST=none
Review URL: http://codereview.chromium.org/6893158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=80582
TEST=None
R=akalin@chromium.org
Review URL: http://codereview.chromium.org/6901122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
At least on 10.6. This may or may not be necessary on FutureCat; didn't check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6908001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a companion CL to http://codereview.chromium.org/6901058/
Because the trybots do not update binary files, the icons must be
committed first, then the resource reference files can be updated.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6893107
TBR=rhashimoto@chromium.org
Review URL: http://codereview.chromium.org/6914003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=78585
TEST=None
Review URL: http://codereview.chromium.org/6902152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unlock when there are no passwords to migrate into it on startup. This avoids
sometimes choosing the unencrypted store on startup if the native store was
locked, and may be related to bugs 80727, 78675, and 80738.
BUG=80727,78675,80738
TEST=starting linux chrome with locked keyring should always prompt to unlock the first time the password store is used, e.g. by sync or chrome://settings/passwords
Review URL: http://codereview.chromium.org/6902187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Valgrind unit_tests on Mac
Review URL: http://codereview.chromium.org/6901155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a companion CL to http://codereview.chromium.org/6901058/
Because the trybots do not update binary files, the icons must be
committed first, then the resource reference files can be updated.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6893107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The passphrase sync integration tests are in a state of disrepair due to
several recent changes to the sync implementation. In particular,
passphrase sync uses two similar methods called OnPassphraseRequired
and OnPassphraseFailed to differentiate between cases where a passphrase is
required for a first attempt at decryption and cases where decryption with a
cached passphrase failed and the user needs to be prompted.
This patch refactors the "for_decryption" boolean flag into an enum called
PassphraseRequiredReason, thereby eliminating the need for OnPassphraseFailed.
It also fixes the tests and updates the test framework to account for
scenarios in which a client is waiting for a passphrase that has been
set by one of its partners, and enables it to exit early when forward
progress is impossible without a call to SetPassphrase.
BUG=78840, 80180, 81018
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6902101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81219
TEST=unit_tests
Review URL: http://codereview.chromium.org/6902207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=Fixes windows build by removing a warning.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80063
TEST=
Review URL: http://codereview.chromium.org/6902157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we change the infobar to make use of this functionality it will make it
feasible for sites to make registerProtocolHandler calls on load, instead of in
response to a user action.
BUG=
TEST=Unit test provided.
Review URL: http://codereview.chromium.org/6878094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81271
R=dyu@chromium.org
TEST=
TBR=dyu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6904153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6880351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AddLibrary param got changed from FilePath::StringType to FilePath
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6880356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new function refreshData that replaces the current most visited page list with the new most visited page list, but tries to minimize turbulence, such that, for example, blacklisting a page will just replace that page without reordering everything else.
This is slightly more complicated than the old ntp's implementation, which just overrode the next setMostVisitedPages callback when a page was blacklisted. But that seems prone to race conditions, and it also doesn't work that great for non-blacklist updates.
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/6901035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This allows us to remove usage of the IOThread object, and generally makes IPC::ChannelProxy more robust for future uses.
Review URL: http://codereview.chromium.org/6901146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=80237
TEST=existing tests
Review URL: http://codereview.chromium.org/6880344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tim
Review URL: http://codereview.chromium.org/6901152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60105
TEST=just adding images, no code changed.
TBR: glen@chromium.org
Review URL: http://codereview.chromium.org/6903173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reporting glue in content.
BUG=77089,77093
Review URL: http://codereview.chromium.org/6901137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to clarify that the realm portion of the message is coming from a remote server.
BUG=79426
TEST=none
Review URL: http://codereview.chromium.org/6905140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like it broke several extensions related browser tests in the full win build starting at build #3971
BUG=70516
TBR=mpcomplete@chromium.org
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/6904169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14276
TEST=Login, examine both regular and OTR, and test with and without themes.
Review URL: http://codereview.chromium.org/6904160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80829
TEST=browser_tests --gtest_filter=*PrerenderCrx
Review URL: http://codereview.chromium.org/6904096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57849
TEST=unittests, manual testing
Review URL: http://codereview.chromium.org/6893116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's been flaky since at least r82247.
Can't mark as flaky a crashing test.
Also disable CancelAnimation since if BasicAnimation crashes, CancelAnimation will crash too.
Mac specific.
TBR=rsesek@chromium.org
BUG=81219
TEST=
Review URL: http://codereview.chromium.org/6905165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Escape punctuation characters in network name strings so they appear properly using menu2.
BUG=chromium-os:14697
TEST=Create a wi-fi network with "&" in the name. Verify that the "&" appears correctly in the network drop-down menu.
Review URL: http://codereview.chromium.org/6883289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a two-sided patch; the Chromium side is plumbing to marshall data from
the renderer to the system APIs.
Note that just hitting Cmd+Ctrl+D usually does not bring up the popup. I think
this may be an Apple bug, but I have not yet found a work-around.
BUG=17951,37715,47141
TEST=Hold Cmd+Ctrl+D on a web page and mouse around. The dictionary popup should follow the mouse and show the definition of the current word.
TEST=In a text area, the dictionary popup should work only if the text area has focus.
R=avi,suzhe,jam
Review URL: http://codereview.chromium.org/6289009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80824
TEST=none
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/6893157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Group all the overridden methods.
- Add OVERRIDE to them.
- Move the implementation out of the class declaration.
- Fix the order to match with our style.
- Add DISALLOW_COPY_AND_ASSIGN.
BUG=68682
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/6904161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was accidentally dropped in http://codereview.chromium.org/6902036
BUG=none
TEST=CrOS user policy works again
Review URL: http://codereview.chromium.org/6904163
Patch from Mattias Nissler <mnissler@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83718 0039d316-1c4b-4281-b951-d872f2087c98
|