| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=20992
TEST=Press F2 to rename folder or edit a bookmark.
Review URL: http://codereview.chromium.org/1612003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
local method. TBR=finnur
BUG= none
TEST= chrome for chromeos about box looks fine.
Review URL: http://codereview.chromium.org/1615004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/39559
BUG=http://crbug.com/40225
Review URL: http://codereview.chromium.org/1540015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Reusing the first and second bit for 41 and 42 no bueno
- Removing the condition that if the user is in some experiment it will not be drafted again
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1570011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1607004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Views.
Once we introduced the model for keeping track of the number of
visible icons, there was a race that was introduced where the
toolbar could get constructed before the model knew about any
icons, so on startup the width of the container was 0.
This CL hooks up the newly added ModelLoaded notification and
sets the width on receiving that notification, if the width
hasn't been set already.
BUG=40329
TEST=None
Review URL: http://codereview.chromium.org/1547021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
generic class, for future use in other classes.
BUG= none
TEST= chrome "about" dialog still works the same, in ltr and rtl languages.
Review URL: http://codereview.chromium.org/1508018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40370
TEST=Run epiphany and iceweasel and check that they appear in about:memory.
Review URL: http://codereview.chromium.org/1611007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1594006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also needs a webkit patch to do anything ( https://bugs.webkit.org/show_bug.cgi?id=37069 ), but can be landed independently.
BUG=11457,18992
TEST=(all require the webkit patch, so this won't work yet)
http://html5demos.com/drag and http://ljouanneau.com/lab/html5/demodragdrop.html
Dragging should show image
http://www.google.com/
Dragging google image should show image
http://www.travelvivi.com/wp-content/uploads/2009/09/Eiffel_Tower.jpg
Dragging image should work, drag image should be smaller than image itself
Random website
Mark some text, drag it. Should show drag cursor and no image
Review URL: http://codereview.chromium.org/1539018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables credit card filling when "Name on Card" field is present. This adds
to existing method of clicking on card number to fill.
BUG=38320
TEST=CreditCardFieldTest, FormStructureTest, manual testing with cc.html (attached).
Review URL: http://codereview.chromium.org/1518017
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/1605011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Valgrind issues failures addressed, trying to land this again.
Move fetching of fullfledged auth cookies to a time when we have the user's real profile available. Also, enable the use of a localaccount on Chrome OS.
Initial CL: http://codereview.chromium.org/1515003
Revert CL: http://codereview.chromium.org/1517015
Review URL: http://codereview.chromium.org/1567020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking,
so we can't use RunAllPending().
* Convert gtk keycode to Win when checking accelerator.
BUG=39736
TEST=none (interactive_ui_tests should pass once enabled
it'll be enabled by http://codereview.chromium.org/1576008
Review URL: http://codereview.chromium.org/1545011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables credit card filling when "Name on Card" field is present. This adds
to existing method of clicking on card number to fill.
BUG=38320
TEST=CreditCardFieldTest, FormStructureTest, manual testing with cc.html (attached).
Review URL: http://codereview.chromium.org/1518017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1520016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9601
TEST=Inspect32 through the fields.
Review URL: http://codereview.chromium.org/1591012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.
Review URL: http://codereview.chromium.org/1591009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1048002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes:
FindBarController now sets the prepopulate text during Show for the Find dialog, to fix regression 40121. It also checks not just the current find string (find_text()) but the previous one also (previous_find_text()) in MaybeSetPrepopulateText() because the current find string is blanked out when closing the Find window. And TabContents now makes sure previous_find_text() is never overwritten with an empty find_text value (to prevent the last search from being cleared if you open Find, close it without searching and open it again).
This changelist also adds automated tests for the codepaths above, which results in adding a GetFindText method to the FindBarTesting interface, to allow the tests to check what string is being shown to the user when the Find box opens.
BUG=40121
TEST=FindInPageControllerTest.Prepopulate* (three tests)
Review URL: http://codereview.chromium.org/1560012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG: 34209
TEST: behavior should be the same as if you had set the --enable-sync-preferences and --enable-sync-autofill flags.
Review URL: http://codereview.chromium.org/1551014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed two static SkBitmap objects.
- default_favicion does not seem to be in use. Removed along with InitClass.
- Moved to local static and moved to heap. SkBitmap destructor was failing on
exit (in pthread_mutex_lock)
* Set VIEW_ID_TAB_CONTAINER_FOCUS_VIEW to the tab container (this ID is required in the test)
* Use FocusManager and call TabContentsDelegate::TakeFocus
in TabContentsViewGtk::TakeFocus.
BUG=39736
TEST=none (interactive_ui_tests needs more patch to run)
Review URL: http://codereview.chromium.org/1594003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2349
TEST=manually checked the appearance
Review URL: http://codereview.chromium.org/1572021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is just code cleanup.
BUG=crosbug.com/2356.
TEST=manually confirmed the ime stuff works with chrome
Review URL: http://codereview.chromium.org/1570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reliably reproduce (before this patch), run browser_tests
--gtest_filter=ExtensionApiTest.ShowPageActionPopup and then move the
mouse pointer outside of the browser window.
BUG=none
TEST=fixes ExtensionApiTest.ShowPageActionPopup
Review URL: http://codereview.chromium.org/1555006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Change controls size in "Action" column from 'small' to 'regular'.
BUG=39818
TBR=trungl
Review URL: http://codereview.chromium.org/1609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
Content settings window: Enable & hook up "exceptions" button.
The dialog is not "live" (i.e. if it's open while settings are deleted through the bubble, the window is only updated after closing & reopening it). It's not possible to do any editing in the window, only deleting. This matches windows/linux.
http://imgur.com/q7qMK
BUG=39818
TEST=Go to a few geolocation pages, click allow/deny. Then go to content settings->locations->exceptions, the visited pages should be listed.
Review URL: http://codereview.chromium.org/1566015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:2036
TEST=Run test LoginManagerViewTest.AuthentionFailed
Review URL: http://codereview.chromium.org/1594016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(2nd try).
Original review: http://codereview.chromium.org/1576010
BUG=crosbug.com/488
TEST=manual
TBR=satorux
Review URL: http://codereview.chromium.org/1606010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Because my AeroPeek code caused lots of usability problems, this change disables the AeroPeek code by default and add an "--enable-aero-peek-tabs" option, which enables this code, until we find solutions that avoid flooding users with tab thumbnails.
BUG=37957
TEST=Open two tabs, and verify we can see only one thumbnail on Windows 7.
Review URL: http://codereview.chromium.org/1571008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new readyState CLOSING.
Fix close() to match the API spec.
OnError reports WebSocket error, and OnSocketError reports socket level error
OnClose reports was_clean.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1587008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(2nd try; see r43475 and r43481).
Modified chrome/browser/chromeos/cros/cros_in_process_browser_test.cc not to break browser_tests. Other files are not modified since the previous CL (r43475).
BUG=crosbug.com/488
TEST=none
Review URL: http://codereview.chromium.org/1599017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1606009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the disabled test by setting the accessible name after we set the tooltip.
BUG=40391
TEST=The following test passes browser_tests.exe --gtest_filter=BrowserViewsAccessibilityTest.TestStarButtonAccObj
Review URL: http://codereview.chromium.org/1530020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=40343
TEST=None
Review URL: http://codereview.chromium.org/1619001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40391
TEST=none
TBR=pkastking@chromium.org, mhm@chromium.org
Review URL: http://codereview.chromium.org/1569020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
String conversion fix due to r43584.
TBR=pkasting
TEST=none
Review URL: http://codereview.chromium.org/1528017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The refactoring in r43558 caused SetAccessibleName and GetAccessibleName to be none virtual causing couple of components not having accessible names since they depend on overriding it. The following change sets the accessible name directly since view now stores it.
BUG=40343
TEST=With AccExplorer32 check if accessible names have been resolved.
Review URL: http://codereview.chromium.org/1616004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adds a new animation when inserting a tab. I've changed the code to
make it clear when an index is in terms of the model, and when it is
in terms of tab_data_. I may replace using an index for tab data with
an actual int wrapper class to avoid mistakes, but I'll do that
separately.
BUG=27783
TEST=thorougly test all animations in the tab strip, as well as
dragging tabs in an out.
Review URL: http://codereview.chromium.org/1553008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=29633
TBR=jrg@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two xibs in this change.
ExtensionInstallPrompt.xib: This handles the more common case of installing an extension with one or more permission warnings. There is an NSBox with room for the warnings which are separated by \n\n.
ExtensionInstallPromptNoWarnings.xib: It is also possible to install an extension with zero permission warnings. This is currently rare, but we hope to make it more common in the coming quarters. In this case, there is no NSBox and the layout is slightly different.
BUG=29633
Review URL: http://codereview.chromium.org/1540013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the process of trying to do this, I discovered some unnecessary
config.h includes as well as some remaining WebCore function calls.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1521010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
notifications and storage permissions as "access to your
browsing history".
Review URL: http://codereview.chromium.org/1526007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to fix the perf regression: remove the code that calls LabelForElement.
TBR=dhollowa
BUG=40306
TEST=none
Review URL: http://codereview.chromium.org/1597005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40234
TEST=In the bug.
Review URL: http://codereview.chromium.org/1549018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on the label
BUG=38284,38263
TEST=in the bugs
Review URL: http://codereview.chromium.org/1607005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calls LabelForElement.
Repair tree bustage across mac and linux.
TBR=dhollowa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1520015
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/1604010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1520015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40204
TEST=manual
Review URL: http://codereview.chromium.org/1601006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27570
TEST=Star should be moved to right hand end of location bar, reload to left endcap.
Review URL: http://codereview.chromium.org/1561009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43562 0039d316-1c4b-4281-b951-d872f2087c98
|