summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add a check to test an assumption about view NULLness.ben@chromium.org2011-05-031-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6902210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83974 0039d316-1c4b-4281-b951-d872f2087c98
* Rename suid python binary used for enabling testing interface on chromeosnirnimesh@chromium.org2011-05-032-4/+3
| | | | | | | | | | | s/python/suid-python/ so that we don't end unintentionally using suid python. BUG= TEST= Review URL: http://codereview.chromium.org/6910031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83973 0039d316-1c4b-4281-b951-d872f2087c98
* Use single command line flag for all pure Views situations,saintlou@chromium.org2011-05-033-1/+11
| | | | | | | | | | | rather than enabling case by case BUG=none TEST=none Review URL: http://codereview.chromium.org/6911018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83972 0039d316-1c4b-4281-b951-d872f2087c98
* Rename View::GetCursor and simplify arguments.msw@chromium.org2011-05-038-25/+17
| | | | | | | | | | | | | | | | Simplify RootView::UpdateCursor with MouseEvent ctor support. Restore pre-r83123 WigetWin::SetCursor(NULL) behavior. Cleanup (function ordering, OVERRIDEs, unnecessary "views::"). This originates from changes and comments of Patch Set 3 at: http://codereview.chromium.org/6893096/ BUG=72040 TEST=Mouse cursors. Review URL: http://codereview.chromium.org/6910032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83970 0039d316-1c4b-4281-b951-d872f2087c98
* Add tracking for scorer creation failures.noelutz@google.com2011-05-031-2/+32
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6910008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83969 0039d316-1c4b-4281-b951-d872f2087c98
* File Manager: Add production artrginda@chromium.org2011-05-0317-33/+69
| | | | | | | | | BUG=chromium-os:14844 TEST=manual testing in chromeos-chrome on linux Review URL: http://codereview.chromium.org/6912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83967 0039d316-1c4b-4281-b951-d872f2087c98
* Move favicon from TabContents to TabContentsWrapper.avi@chromium.org2011-05-0325-61/+400
| | | | | | | | | BUG=71097 TEST=no visible change Review URL: http://codereview.chromium.org/6909027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83966 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling pyauto notification test.sunandt@google.com2011-05-031-0/+1
| | | | | | | | BUG=80510 TEST=notifications.NotificationsTest.testKillNotificationProcess Review URL: http://codereview.chromium.org/6909036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83965 0039d316-1c4b-4281-b951-d872f2087c98
* Print Preview: Fixing print header overflow issues.dpapad@chromium.org2011-05-031-6/+2
| | | | | | | | | | | | | | | When the "Print Preview" header is long (happens in many languages) it is wrapped on the next line without hiding any of the print options anymore (since it no longer absolutely positioned). BUG=NONE TEST=launch using LANGUAGE=el_GR ./out/Release/chrome --enable-print-preview, no printing options should be hidden by the header. Review URL: http://codereview.chromium.org/6912033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83963 0039d316-1c4b-4281-b951-d872f2087c98
* PreviewableContentsController::hidePreview works with prerender on OSX.cbentzel@chromium.org2011-05-032-5/+6
| | | | | | | | | | BUG=81268 TEST=go to prerender page with UseTabContents set to true, make sure debug build does not crash when swapping in prerendered page. Review URL: http://codereview.chromium.org/6909029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83953 0039d316-1c4b-4281-b951-d872f2087c98
* Add HostObserverInterface and decouple HeartbeatSender and ChromotingHost.sergeyu@chromium.org2011-05-031-0/+11
| | | | | | | | | BUG=None TEST=Everything still works. Review URL: http://codereview.chromium.org/6911024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83951 0039d316-1c4b-4281-b951-d872f2087c98
* Safebrowsing download UMA results shouldn't be set when safebrowsing is ↵mattm@chromium.org2011-05-032-12/+21
| | | | | | | | | | | disabled. BUG=80620 TEST=see bug Review URL: http://codereview.chromium.org/6901145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83950 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling pyauto tests for DevTools.sunandt@google.com2011-05-031-0/+2
| | | | | | | | BUG=81440 TEST=enterprise.EnterpriseTest.testDisableDevTools, shortcuts.ShortcutsTest.testDeveloperToolsShortcut, shortcuts.ShortcutsTest.testJavaScriptConsoleShortcut Review URL: http://codereview.chromium.org/6912035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83949 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate wstring from base/utf_offset_string_conversions.h, ↵pkasting@chromium.org2011-05-036-26/+12
| | | | | | | | | | net/base/escape.h, and net/base/net_util.h, and reduce the API surfaces in various places slightly where possible. BUG=23581 TEST=none Review URL: http://codereview.chromium.org/6898026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83948 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the security infobar for --enable-nacl, which is in about:flagsdmichael@chromium.org2011-05-031-3/+0
| | | | | | | | | BUG=77590 TEST=start chrome with '--enable-nacl', or turn it on in about:flags and restart. Confirm that _no_ infobar appears saying 'You are using an unsupported command-line flag: --enable-nacl. Stability and security will suffer.'. Review URL: http://codereview.chromium.org/6913029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83945 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a bunch of browser tests as flaky on Mac.jam@chromium.org2011-05-033-1/+28
| | | | | | | | BUG=81451 TBR=mark Review URL: http://codereview.chromium.org/6907024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83944 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling pyauto tests that use flash.sunandt@google.com2011-05-031-0/+10
| | | | | | | | BUG=81396 TEST=NONE Review URL: http://codereview.chromium.org/6911032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83941 0039d316-1c4b-4281-b951-d872f2087c98
* Modify screen reader detection to use the AXEnhancedUserInterface attribute ↵dtseng@chromium.org2011-05-034-18/+26
| | | | | | | | | | set on AXApplication when VoiceOver's turned on. This gives us the ability to turn on ax even after a render widget host has started. BUG=none TEST=manually with VoiceOver. Launch Chrome, VoiceOver, windows, tabs (permuted order) and verify that ax is on. This sometimes required navigation to a different page or efreshing the current page. Review URL: http://codereview.chromium.org/6909013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83940 0039d316-1c4b-4281-b951-d872f2087c98
* Automation hook FillAutofillProfile now waits for the web data service to be ↵dennisjeffrey@chromium.org2011-05-033-18/+151
| | | | | | | | | | | | | | | | | | updated. The FillAutofillProfile automation hook sets autofill profiles and credit cards in the web data service. Previously, the hook did not wait for the web data service to be updated before returning, even though updating to the web data service is asynchronous. This is now fixed. This change improves -- but does not yet completely solve -- pyauto autofill flakiness. BUG=80336 TEST=None Review URL: http://codereview.chromium.org/6880281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83937 0039d316-1c4b-4281-b951-d872f2087c98
* Have the phishing classifier guard against extra PageCaptured calls.bryner@chromium.org2011-05-032-18/+100
| | | | | | | | | | | Currently, the classifier assumes that any PageCaptured call will be preceded by a DidCommitProvisionalLoad. This seems to not always be the case, and is causing occasional crashes. Cancel classification in this situation so that we don't swap out the page text from under the term feature extractor. BUG=80325 TEST=PhishingClassifierDelegateTest.DuplicatePageCapture Review URL: http://codereview.chromium.org/6902171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83936 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to extension webRequest API.mpcomplete@chromium.org2011-05-037-73/+231
| | | | | | | | | | | | | | | - onBeforeSendHeaders respects extraInfoSpec. - request headers are now an array of {name, value} objects instead of a flat string. - onBeforeRequest is sent after redirects now. This allows extensions to intercept redirects and cancel/redirect them elsewhere. BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6912008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83925 0039d316-1c4b-4281-b951-d872f2087c98
* Add method IsPassphraseRequiredForDecryption to ProfileSyncServicersimha@chromium.org2011-05-035-34/+31
| | | | | | | | | | | | | | | | | | ProfileSyncService needs to know in multiple places whether a passphrase is required for decryption. Right now, the logic involves checking passphrase_required_reason_ against a couple of states. This patch refactors this logic into the methods: IsPassphraseRequired IsPassphraseRequiredForDecryption BUG=81313, 81341, 81018 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6910012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83923 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83730: Revert 83687 - Remove ExtensionMsg_UpdatePageActions.mpcomplete@chromium.org2011-05-036-62/+13
| | | | | | | | | | | | Trying again. The previous checkin broke browser tests, but I could not reproduce either on the trybot or locally. BUG=70516 TEST=no Review URL: http://codereview.chromium.org/6907007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83920 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Hook up Create New Profile menu itemsail@chromium.org2011-05-031-3/+11
| | | | | | | | | | | | This change hooks up the Create New Profile menu item to the backend action. BUG=None TEST=Ran and verified that the menu item works correctly. Review URL: http://codereview.chromium.org/6909008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83919 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang buildjam@chromium.org2011-05-032-5/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83918 0039d316-1c4b-4281-b951-d872f2087c98
* Added some more OWNERS in places where we don't have any.estade@chromium.org2011-05-033-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6911015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83914 0039d316-1c4b-4281-b951-d872f2087c98
* Add v8 as a dependency for unit_testsvangelis@chromium.org2011-05-031-0/+1
| | | | | | | | | | | BUG=Compile fails on Windows shared lib builder. TEST=Compile succeeds on Windows shared lib builder. Original CL by asanka. http://codereview.chromium.org/6911029 Review URL: http://codereview.chromium.org/6911029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83913 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/3451017/sky@chromium.org2011-05-0336-73/+73
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6910024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83912 0039d316-1c4b-4281-b951-d872f2087c98
* Start moving content_settings code out of content code.jam@chromium.org2011-05-0312-86/+252
| | | | | | | BUG=76793 Review URL: http://codereview.chromium.org/6913013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83910 0039d316-1c4b-4281-b951-d872f2087c98
* Print Preview: Removing double column format in left pane header.dpapad@chromium.org2011-05-034-21/+16
| | | | | | | | | | | | | | | | | Removing unnecessary "To be printed" label and moving the print/ cancel buttons in the center. Also in this CL: 1) Restricting the width of the printer drop-down list. It was overflowing the available space when a printer with a long named existed (e.g. "Microsoft XPS Document Writer"). 2) Making print/cancel button size equal. 3) Removing localized string that is not used anymore. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6883292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83909 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Wire up ui::MenuModel::MenuWillShow for MenuController.rsesek@chromium.org2011-05-034-11/+83
| | | | | | | | | | BUG=80879 TEST=Wrench and back/forward menus work as before. Review URL: http://codereview.chromium.org/6909028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83907 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS file for content/browser/webuiestade@chromium.org2011-05-031-0/+1
| | | | | | | | | | | also add myself to OWNERS for chrome/browser/ui/webui BUG=none TEST=none Review URL: http://codereview.chromium.org/6883305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83906 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error handling in proxy settings apibattre@chromium.org2011-05-037-47/+112
| | | | | | | | | | | Introduce a bad_message parameter in order to simulate EXTENSION_FUNCTION_VALIDATE. This allows the Proxy Settings API to terminate extensions that circumvent the input parameter validation performed by the generic extension api. BUG=none TEST=none Review URL: http://codereview.chromium.org/6902039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83901 0039d316-1c4b-4281-b951-d872f2087c98
* Reference large infobar icons.rhashimoto@chromium.org2011-05-031-17/+17
| | | | | | | | | | | This CL is identical to http://codereview.chromium.org/6893107/. The original commit was reverted because of a DEPS issue in a different tree which has since been resolved. BUG=none TEST=none Review URL: http://codereview.chromium.org/6889020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83899 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome.test.checkDeepEqbattre@chromium.org2011-05-031-0/+6
| | | | | | | | | | | Fix a call like the following: checkDeepEq([{abc: 'def'}], []) BUG=none TEST=none Review URL: http://codereview.chromium.org/6912022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83898 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the prerender memory browser test for tab contents and some general cleanuptburkard@chromium.org2011-05-032-12/+13
| | | | | | | R=mmenke Review URL: http://codereview.chromium.org/6907022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83894 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TwoClientLivePasswordsSyncTest.SetPassphraseTwice as flaky.jam@chromium.org2011-05-031-1/+2
| | | | | | | BUG=81341 Review URL: http://codereview.chromium.org/6911028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83891 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Expand panels before focusing them.derat@chromium.org2011-05-031-8/+14
| | | | | | | | | | | | | | | | | r81859 made Chrome first ask the window manager to focus a panel after its titlebar was clicked and then ask the WM to expand the panel. The window manager would expand the panel in response to the focus request and then ignore the expansion request; as a result, it wouldn't show the little "collapse anchor" button underneath the mouse pointer. This change makes us expand the panel first and then focus it. BUG=chromium-os:14735 TEST=manual: checked that the anchor is shown after expanding a panel, and that collapsing a panel still works as expected (and dismisses its urgent state if present) Review URL: http://codereview.chromium.org/6910014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83890 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel prerenders that spawn post requests.dominich@chromium.org2011-05-0311-23/+476
| | | | | | | | | | BUG=77177 TEST=PrerenderBrowserTest.PrerenderXhr* Review URL: http://codereview.chromium.org/6901128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83889 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line option to set the minimum loggingmmenke@chromium.org2011-05-038-26/+57
| | | | | | | | | | | level used by the NetLog. BUG=80851 TEST=none Review URL: http://codereview.chromium.org/6893131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83888 0039d316-1c4b-4281-b951-d872f2087c98
* Improve DnD effects on ntp4estade@chromium.org2011-05-034-15/+145
| | | | | | | | | | | dragging from one row to another should cause an effect where tiles, instead of jumping between rows, slide off the side and reappear/slide into the correct place. BUG=none TEST=manual Review URL: http://codereview.chromium.org/6902186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83887 0039d316-1c4b-4281-b951-d872f2087c98
* Enable (optional) blocking of webrequests in case a PAC script cannot be ↵battre@chromium.org2011-05-0323-31/+176
| | | | | | | | | | | | | fetched or is invalid. The optional blocking is currently only exposed to the Proxy Settings API, not to command-line parameters or policies. BUG=79344 TEST=Install the sample proxy extension and enter a non-existing url and a URL that does not point to a valid JavaScript file. In either case, the request should fail. Review URL: http://codereview.chromium.org/6871019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83882 0039d316-1c4b-4281-b951-d872f2087c98
* Add a method for PAC script errors to the network delegate.jochen@chromium.org2011-05-034-1/+8
| | | | | | | | | | | Also add a wrapper class to avoid passing around raw NULL pointers, and a bridge so I can invoke the method from other than the IO thread BUG=48930 TEST=net unittests Review URL: http://codereview.chromium.org/6822026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83881 0039d316-1c4b-4281-b951-d872f2087c98
* Adopt InterstitialPage to RenderViewHost message changes which were ↵markusheintz@chromium.org2011-05-0311-29/+120
| | | | | | | | | | | | introduced by http://codereview.chromium.org/6883177. This makes the buttons on interstitial pages work again. Committed by sfeuz Review URL: http://codereview.chromium.org/6904159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83880 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure right badge shows up on the Wrench menu for Linux and Mac.finnur@chromium.org2011-05-037-54/+56
| | | | | | | | | | Also make sure the icon shows up on Linux and Mac (we were accidentally returning false from GetIconForCommandId, which works on Windows because we were not checking the return value). BUG=80647 TEST=Same as in http://codereview.chromium.org/6840038/, but for Linux and Mac. Review URL: http://codereview.chromium.org/6904129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83879 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Handle terminated extensions in extension/app sync codeakalin@chromium.org2011-05-032-8/+12
| | | | | | | | | | | | Also cleaned up some dead code and obsolete comments. BUG=80726 TEST= Review URL: http://codereview.chromium.org/6909001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83877 0039d316-1c4b-4281-b951-d872f2087c98
* Fix inverted sign in pref checkpfeldman@chromium.org2011-05-031-1/+1
| | | | | | | | | BUG=dev tools should be enabled by default TEST=manual Review URL: http://codereview.chromium.org/6911013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83875 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 754.0 to 755.0chrome-release@google.com2011-05-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83872 0039d316-1c4b-4281-b951-d872f2087c98
* [Extensions] Add unit tests for terminated extensionsakalin@chromium.org2011-05-033-113/+158
| | | | | | | | | | | | | | | | | | Change enabled -> terminated state transition to be atomic. Added unit tests for various functions' behavior with terminated extensions. Fix incorrect use of extension_id parameter in UninstallExtension (by renaming the parameter to extension_id_unsafe and the copy to extension_id). Cleaned up unit tests a bit. BUG=80756,80752 TEST= Review URL: http://codereview.chromium.org/6889015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83868 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Add network menu item text for Mobile Data top-up URL.nkostylev@chromium.org2011-05-031-3/+3
| | | | | | | | | | | Remove unused carrier deal notification text. BUG=chromium-os:14575 TEST=None. Review URL: http://codereview.chromium.org/6905129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83865 0039d316-1c4b-4281-b951-d872f2087c98