| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression.
Revert "Moved SigninManager out of browser/sync, and start changing the code so signin"
This reverts commit 897f42f222022acb470de4e8cd369862139583f2.
Revert "Make SigninManager a ProfileKeyedService."
This reverts commit b29413fd67465671335091b2b7e3bb7ed2f62e0f.
BUG=108017
TEST=watch perf bots, see if perf regression disappears
TBR=jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9251031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The windows AppId associates the taskbar shortcut for the app with
the running app window. Once properly set the taskbar shortcut is
highlighted when the app is running.
BUG=110422
TEST=Manual testing on Windows
Review URL: http://codereview.chromium.org/9120026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r118171. There's an issue in the destruction
order of ash::VideoDetector vs. ash::Shell.
BUG=110114
TEST=built it
TBR=apatrick
Review URL: https://chromiumcodereview.appspot.com/9232037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now only consider a tab syncable if it has at least one valid entry, where
valid is true iff the url is valid and the scheme is neither chrome or file.
This avoids syncing tabs with nothing but chrome:// or file:// navigations.
BUG=109301
TEST=unit_tests
Review URL: http://codereview.chromium.org/9114015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110091
TEST=Navigate to chrome://network-action-predictor. Notice that checking the 'filter' checkbox causes the table to be redrawn with only entries where Confidence is > 0
Review URL: http://codereview.chromium.org/9186055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23751
TEST=make sure $LOGIN_ID or $LOGIN_EMAIL are substituted with actual values in EAP.Identity and VPN user fields.
Review URL: http://codereview.chromium.org/9188055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=shess@chromium.org
BUG=None
TEST=.../history tests
Review URL: http://codereview.chromium.org/9071014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
From the logs, you can see it's crashing after returning from
ExtensionUnpacker::Run(), which means it's probably crashing in a destructor.
BUG=108724
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9252025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108570
TEST=See reduced test case in bug.
Review URL: http://codereview.chromium.org/9252019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107265
TEST=
Review URL: http://codereview.chromium.org/8918018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=110463
TBR=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9253023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserList::GetLastActive can return NULL. Add code to terminate calls early in case of a NULL.
BUG=110585
TEST=No visible changes.
Review URL: http://codereview.chromium.org/9252018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug is that popup windows are getting opened maximized on linux/gtk because of this call here: http://www.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/gtk/browser_window_gtk.cc&l=1705
It seemed more robust to fix the behavior in Browser::GetSavedWindowShowState().
BUG=106967
TEST=See issue. Also test that maximized state for main browser window is remembered correctly, and --start-maximized works.
Review URL: http://codereview.chromium.org/9211020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The same change was made to the startup tests because they are too slow
in debug.
Review URL: http://codereview.chromium.org/9252020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the gpu process to ignore all knowledge of renderers. It simplifies
some of the gpu <-> browser and gpu <-> renderer IPC, but mostly paves the way
for non-renderer clients.
Surfaces are kept in a global GpuSurfaceTracker which is just a thread-safe map.
BUG=99516
TEST=covered by existing tests. Run chrome, open poster circle (or other accelerated content page).
Review URL: http://codereview.chromium.org/9194005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds an ash::VideoDetector class that watches for layer
updates and attempts to detect the playback of video. A
Chrome OS-specific observer updates a _CHROME_VIDEO_TIME
property on the X root window, which is used by the power
manager to defer screen dimming or other power management
features. This matches the implementation currently in use
on Chrome OS, with Chrome taking the X window manager's role
for detecting video and setting the property.
BUG=110114
TEST=added; also manually checked that the property is updated
Review URL: http://codereview.chromium.org/9249004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you try to load a .swf file immediately after firing up the browser, it
ends up getting getting downloaded, instead of being displayed through the
flash player, which indicates that the plugin isn't registered yet.
Force the plugin to get registered before running tests involving flash.
This should fix the flakiness on win pyauto bots for the following tests:
flash.FlashTest.testFlashLoadsAfterKill
infobars.InfobarTest.testPluginCrashInfobar
flash.FlashTest.testCanLoadFlash
BUG=94123
TEST=green pyauto win bots
R=dennisjeffrey@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9254010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In aura/chromeos, popups are shown in panels. We don't want to show the wrench
menu in this case.
BUG=109189
TEST=Open a small popup in aura/chromeos. Ensure no wrench menu.
Review URL: http://codereview.chromium.org/9211019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r118166 simplified pixel tests, so we need to update the local ref images.
(This only affects gpu waterfall.)
BUG=
TEST=gpu_tests
TBR=kbr
Review URL: https://chromiumcodereview.appspot.com/9254012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of compositing over some text, we simply composit over a black div.
Also, instead of drawing a teapot through WebGL, we draw a green triangle.
(This only affects gpu waterfall. The tests will fail in the first a few runs until we update the ref image revision.)
Checking pixel values (besides comparing with ref images) will be implemented in a seperate CL.
BUG=
TEST=gpu_tests
R=kbr
Review URL: https://chromiumcodereview.appspot.com/9259002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
toast. Initialization when chrome early exits is a bit hairy right now, and a lot of code runs which shouldn't. A bunch of those depend on IOThreat being initialized, so continue to intialize it even if PreCreateThreadsImpl early returns.
TEST=--try-chrome-again=10001 doesn't crash. Finnur is adding a test.
Review URL: https://chromiumcodereview.appspot.com/9249020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9252010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They don't need to be typedefed in C++.
BUG=80197
R=akalin@chromium.org
Review URL: http://codereview.chromium.org/8960009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=109883
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9221005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110241
TEST=added a small extension to test roundtrip.
Review URL: http://codereview.chromium.org/9174019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
asserts.
BUG=110629
TBR=apatrick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9252023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/9188023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23674
TEST=verify per bug rpt.
Review URL: http://codereview.chromium.org/9188065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables file browser tests on chromeos. The test api has been fixed.
BUG=24257
TBR=dgozman@chromium.org
R=dgozman@chromium.org
TEST=
Review URL: https://chromiumcodereview.appspot.com/9243027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ash::internal::DialogFrameView
This code is only compiled into Aura and only used if the "Google-style
dialogs" flag is specified (--aura-google-dialog-frames).
Remaining issues:
* Constrained windows are still broken -- see issue 109138.
* Title and body text should be #222, not black. This CL only affects the
title, and currently leaves it at black to match the body text.
* The shadow and border stroke are not up to spec. Fixing this would require
adding new image assets or rewriting the drawing code entirely.
* Some dialogs look pretty bad, such as the certificate viewer (which has
a tab bar with the wrong look).
* The close button placement on medium- and small-sized dialogs may be wrong;
there are no examples in the spec.
* There are sizing/positioning issues with various dialogs (for example, in
Javascript popups the title bar is not always long enough to hold the title).
BUG=none
TEST=none
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/9187061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rename TestTabContentsView to TestWebContentsView.
Add content namespace to both.
TBR=owners (trivial updates)
BUG=98716
Review URL: http://codereview.chromium.org/9241011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9148072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes, tabs/tasks are frequently updated and a lot of update messages come in a short time. In such case, the list
trys to update UI again and again, the UI stops and does not accept any input for a while.
To avoid it, this cl delays the update of the list and combine updates if they come within a second.
BUG=110424
TEST=manual
Review URL: http://codereview.chromium.org/9221009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts http://crrev.com/117681 and http://crrev.com/104931 and instead uses new 10.7 notifications to change the shortcuts on Close Tab and Close Window items, so that cmd-W does a "Close Window" when the dictionary is open.
The above is also how Safari appears to solve this issue, as can be seen by going to the File menu when the dictionary popover is up.
BUG=104931, 110306, 109061
TEST=1. Open a tab and double 3-finger tap on a word to bring up the
dictionary popup. Hit cmd-W. The popup should close but the tab
should stay open. Hit cmd-W again. The tab should close.
2. Try cmd-shift-W with > 1 tab open. The window should close.
3. Open a window that doesn't have tabs (e.g. Chrome -> About
Chrome). File -> Close Tab should be disabled.
Review URL: http://codereview.chromium.org/9230011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing googleurl unit tests continue to pass
Review URL: https://chromiumcodereview.appspot.com/9104001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9252015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is being removed in favor of class ChromeEndureGmailTest
in file perf_endure.py.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9251003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110453
TEST=Log in with new account on device with a camera. Click on camera icon when selecting avatar and observe that camera dialog shows up and can be used.
Review URL: http://codereview.chromium.org/9243012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. App list and browser shortcut buttons can be moved around.
. Clicking the tabbed button cycles windows (creating a new one if
there isn't one).
BUG=110094
TEST=see bug
R=ben@chromium.org,jamescook@chromium.org
Review URL: http://codereview.chromium.org/9231030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=109216
TEST=Verify 'Manage connections' button works properly on ChromeOS.
Review URL: https://chromiumcodereview.appspot.com/9242033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests are gone, so no need to have them in the disabled list.
BUG= 108379
TEST= nacl_integration
R=noelallen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9107020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The test is very much like the WebGLTeapot test, only we draw a simple semi-transparent red rectangle over some text.
BUG=
TEST=GpuPixelBrowserTest.Canvas2DRedBox on GPU waterfall
R=vangelis,jbates
Review URL: https://chromiumcodereview.appspot.com/9212023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a bug where the NTP collision code would skip over the element that came after a collision. This would result in incorrect behavior if the collision was followed by another collision, as the code will miss that first element.
BUG=61447
TEST=unit_test:ExtensionSortingFixNTPCollisions*
Review URL: http://codereview.chromium.org/9225007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use a single view for the status area now. In compact
mode, the window underneath it can vary (login screen, lock
screen, regular or incognito browser window, etc.). This
change makes us update the text style used for the status
area accordingly.
BUG=107389
TEST=manual testing in compact mode; also added a browser test
Review URL: https://chromiumcodereview.appspot.com/9197018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110443
TEST=see bug for manual test
Review URL: http://codereview.chromium.org/9244011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110359
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9215008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
other testing. Committing this fix quickly, but will rework if marja says so.
BUG=chromium-os:25066
TEST=Manual, pending coming up with something that can test accurately
TBR= marja
Review URL: https://chromiumcodereview.appspot.com/9249007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The ScopedSettings destructor should only remove the temporary observers from the animator, not the sequences. Added an ImplicitAnimationObserver for use with ScopedSettings to provide a simple way to get notified when implicit animations complete.
BUG=None
TEST=compositor_unittests
Review URL: https://chromiumcodereview.appspot.com/9112034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See comment on BrowsingInstance class that explains it should only be
visible to SiteInstance. By restoring this design, we also eliminate
one Chrome->Content dependency.
TBR=ben@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9221017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Necessary for working with PP_NetAddress_Private structure in NaCl module (for instance, for changing port after TCP connection).
BUG=108265
TEST=UI test NetAddressPrivateUntrusted
Review URL: https://chromiumcodereview.appspot.com/9007009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118089 0039d316-1c4b-4281-b951-d872f2087c98
|