summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Share the code that builds the page menu in a common model, make Mac and Win ↵pinkerton@chromium.org2009-12-0914-842/+780
| | | | | | | | | | use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code. BUG=22646 TEST=page menu should work as before Review URL: http://codereview.chromium.org/465130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34179 0039d316-1c4b-4281-b951-d872f2087c98
* Change most callers of NativeScrollbar size functions to use a dedicated ↵pkasting@chromium.org2009-12-093-19/+10
| | | | | | | | | | function that matches WebKit instead, since the callers really care about content area scrollbars. BUG=none TEST=none Review URL: http://codereview.chromium.org/463061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34177 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access, 2nd attempt.oshima@chromium.org2009-12-091-8/+9
| | | | | | | | | | | | | | * ExternalMetrics class requires scoped_refptr. original CL : http://codereview.chromium.org/470006 BUG=None TEST=Run unit_test with valgrind. patch from issue 470006 Review URL: http://codereview.chromium.org/465140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34176 0039d316-1c4b-4281-b951-d872f2087c98
* Define X509Certificate::intermediate_ca_certs_ as a std::vector ofwtc@chromium.org2009-12-091-7/+6
| | | | | | | | | | | | | | | | OSCertHandle so that we can also use it on Windows. Remove the unused SSLClientSocketMac::intermediate_certs_ member. R=hawk BUG=28744 TEST=Can visit good HTTPS sites with no certificate errors. Clicking the "Certificate information" button in the page security information window should show a complete certificate chain (as opposed to just the server certificate). Review URL: http://codereview.chromium.org/452042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34175 0039d316-1c4b-4281-b951-d872f2087c98
* Fix delete day so that font is correct and it can be reached through tab.mirandac@chromium.org2009-12-091-1/+2
| | | | | | | | | | Landing for eisinger. BUG= 21459 TEST= On history page, font for delete day msg is correct, and you can tab to it. Review URL: http://codereview.chromium.org/473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34168 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34161 - Enable Pepper support by default, including building the test ↵sehr@google.com2009-12-095-26/+13
| | | | | | | | | | | | | | | | | | | | plugin. This is needed because the NaCl plugin code that runs in the renderer needs to use Pepper APIs all the time, and NaCl support has been enabled by default for several months now. To cause an untrusted Pepper plugin to run in the renderer one needs to specify the internalpepper flag. I have also removed the enable_pepper flag from gyp. As the build of the GPU process was tied to this flag, I have renamed the flag to enable_gpu. TEST=none BUG=none Review URL: http://codereview.chromium.org/464074 TBR=sehr@google.com Review URL: http://codereview.chromium.org/475004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34162 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Pepper support by default, including building the test plugin.sehr@google.com2009-12-095-13/+26
| | | | | | | | | | | | | | | This is needed because the NaCl plugin code that runs in the renderer needs to use Pepper APIs all the time, and NaCl support has been enabled by default for several months now. To cause an untrusted Pepper plugin to run in the renderer one needs to specify the --internal-pepper flag. I have also removed the enable_pepper flag from gyp. As the build of the GPU process was tied to this flag, I have renamed the flag to enable_gpu. TEST=none BUG=none Review URL: http://codereview.chromium.org/464074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34161 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium: support custom WebCore context menu items in Chromium port ↵pfeldman@chromium.org2009-12-099-7/+78
| | | | | | | | (downstream). Review URL: http://codereview.chromium.org/465123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34154 0039d316-1c4b-4281-b951-d872f2087c98
* No op change (gonna be in here later today) to force builds after master ↵thomasvl@chromium.org2009-12-091-0/+1
| | | | | | | | | | restart. BUG=none TEST=none Review URL: http://codereview.chromium.org/473001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34153 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 267.0 to 268.0chrome-bot@google.com2009-12-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34151 0039d316-1c4b-4281-b951-d872f2087c98
* views: libbrowser depends on libviews.thestig@chromium.org2009-12-091-0/+1
| | | | | | | | | BUG=none TEST=views valgrind bots successfully builds. TBR=oshima Review URL: http://codereview.chromium.org/472001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34146 - A place to store the pid>mach_port_t mapping.thakis@chromium.org2009-12-0913-361/+9
| | | | | | | | | | | | | | | | Not yet for review. Landing to measure perf impact, will revert immediately. BUG=13156 TEST=unittests Review URL: http://codereview.chromium.org/460126 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/466088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34147 0039d316-1c4b-4281-b951-d872f2087c98
* A place to store the pid->mach_port_t mapping.thakis@chromium.org2009-12-0913-9/+361
| | | | | | | | | | | | | Not yet for review. Landing to measure perf impact, will revert immediately. BUG=13156 TEST=unittests Review URL: http://codereview.chromium.org/460126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34146 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my r4300 and re-fixes Issue 3156 and 13500.hbono@chromium.org2009-12-092-23/+16
| | | | | | | | | | | | | | | | | | My r4300, which is a fix Issue 3156, has been causing regressions (Issue 9596, Issue 13500, Issue 29290, etc.) Every time when this change caused regressions, we added more code to Chromium and made Chromium code more complicated. So, I think it is better to revert this change once and find another solution for Issue 3156 rather than to add another workaround for Issue 29290. To look into Issue 3156 more deeply, it is caused by a recursive message-handler call. When SetWindowText() is called while an IME is composing text, the IME calls SendMessage() to send a WM_IME_COMPOSITION message. When we receive this WM_IME_COMPOSITION message, it updates the omnibox and calls SetWindowText()... This recursive call caused not only Issue 3156 but also caused some other IME issues, such as Issue 13500. BUG=3156,13500,29290 TEST=On XP, open a new tab, set the IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate and show the popup URL without a crash. TEST=Open Gmail, compose a new e-mail (without using a tear-off window), set the IME to Hiragana, type 'c' in its message body, and wait for the draft auto-saving. The browser should show the 'c' character. Review URL: http://codereview.chromium.org/467015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34145 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bugs with panels. We weren't setting the type at the right timesky@chromium.org2009-12-092-2/+4
| | | | | | | | | | | | and needed to set a size_request so that the title gets the right size. BUG=none TEST=none Review URL: http://codereview.chromium.org/466081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34141 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug so that if we restore popups (as we do on chrome os) wesky@chromium.org2009-12-091-2/+2
| | | | | | | | | | | restore them to the correct size. BUG=none TEST=none Review URL: http://codereview.chromium.org/471002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34140 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue where clicking on a <SELECT> dropdown in an extension popup ↵andybons@chromium.org2009-12-097-6/+110
| | | | | | | | | | | | | window would hard crash the browser. I'm hoping that this will open up discussions for refactoring work amongst ExtensionHost and TabContentsView, since so much code is shared between the two and both need sufficient Mac love. BUG=29353 TEST=load a browser action with a popup that contains a SELECT element. click on the element and observe that it acts normally (no crashing). Review URL: http://codereview.chromium.org/465108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34136 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34134 - Viewsbased login window for Chrome OS. Doesn't yet actually ↵jrg@chromium.org2009-12-0915-387/+16
| | | | | | | | | | | do anything Review URL: http://codereview.chromium.org/449023 TBR=cmasone@google.com Review URL: http://codereview.chromium.org/467060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34135 0039d316-1c4b-4281-b951-d872f2087c98
* Views-based login window for Chrome OS. Doesn't yet actually do anythingcmasone@google.com2009-12-0915-16/+387
| | | | | | Review URL: http://codereview.chromium.org/449023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34134 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup; remove deprecate file_util function and some obsolete TODOs.estade@chromium.org2009-12-094-18/+7
| | | | | | Review URL: http://codereview.chromium.org/467030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34133 0039d316-1c4b-4281-b951-d872f2087c98
* Remove check for usage stats in the toast experimentcpu@chromium.org2009-12-091-4/+0
| | | | | | | | | | | | BUG=none TEST= same as before but you know don't need to opt-in for sending crash reports or usage stats TBR=rahulk Review URL: http://codereview.chromium.org/464078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34130 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DCHECK because it's invalid in single process mode.mpcomplete@chromium.org2009-12-091-1/+0
| | | | | | Review URL: http://codereview.chromium.org/460151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34123 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where content scripts would get run twice in some cases.mpcomplete@chromium.org2009-12-091-2/+7
| | | | | | | | BUG=29644 Review URL: http://codereview.chromium.org/466079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34122 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34110 - Fix leak of ShutdownDetector. Broke Mac startup_test.willchan@chromium.org2009-12-091-48/+30
| | | | | | | | | | | | For some reason I thought that nonjoinable threads would always delete their delegates. I was wrong. BUG=http://crbug.com/29675 Review URL: http://codereview.chromium.org/460144 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/460154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34121 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add UMA calls for drag-and-drop of URLs on tab strip.viettrungluu@chromium.org2009-12-091-0/+2
| | | | | | | | | | | (Chrome/Win already has these, and we use the same names.) BUG=29799 TEST=none Review URL: http://codereview.chromium.org/465139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34120 0039d316-1c4b-4281-b951-d872f2087c98
* Have the utility process run out of process on Linux again bytony@chromium.org2009-12-094-27/+4
| | | | | | | | | | | | using the /proc/self/exe trick we use for plugins. Since we don't need any resources from .pak files, this should be safe. BUG=22703 TEST=Install a theme, verify that it worked properly. Review URL: http://codereview.chromium.org/464073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34117 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34099 - fix for memory leak and illegal access. (found in valgrind test)asargent@chromium.org2009-12-092-12/+8
| | | | | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/466083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34114 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NewTabUIStartupTest.ComplexThemeCold.erg@google.com2009-12-091-0/+35
| | | | | | | | | | | | | All data in recent history for this test is invalid as it isn't loading the NTP image. Not sure how long this has been broken. BUG=NONE TEST=The performance of this test on the buildbot gets slower to include all the time we weren't counting. (I am assuming around 300ms?) Review URL: http://codereview.chromium.org/460150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34113 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for reliability bot failure in WebCore::ImageEventSender.asargent@chromium.org2009-12-091-0/+2
| | | | | | | | | BUG=29759 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34112 0039d316-1c4b-4281-b951-d872f2087c98
* Make "delete history for day" message have the correct font on Mac.mirandac@chromium.org2009-12-091-1/+1
| | | | | | | | | | | Committing for feldstein. BUG= 21459 TEST= History tab on mac should show correct font in "delete day" message. Review URL: http://codereview.chromium.org/460148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of ShutdownDetector.willchan@chromium.org2009-12-091-30/+48
| | | | | | | | | For some reason I thought that non-joinable threads would always delete their delegates. I was wrong. BUG=http://crbug.com/29675 Review URL: http://codereview.chromium.org/460144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34110 0039d316-1c4b-4281-b951-d872f2087c98
* Revert this, it didn't compile on linux_views (argh)pkasting@chromium.org2009-12-081-2/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34109 0039d316-1c4b-4281-b951-d872f2087c98
* Try re-enabling the resize corner on Windows to see if it still causes perf ↵pkasting@chromium.org2009-12-081-5/+2
| | | | | | | | | | regressions. BUG=458 TEST=The bottom right corner of the window whould have a resize corner. Review URL: http://codereview.chromium.org/465133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34108 0039d316-1c4b-4281-b951-d872f2087c98
* removing the file that was accidentally added to cl.oshima@chromium.org2009-12-081-2/+0
| | | | | | | | | | BUG=None TEST=None TBR=rvargas Review URL: http://codereview.chromium.org/466078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34102 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access. (found in valgrind test)oshima@chromium.org2009-12-083-8/+14
| | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34099 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for 2 reliability failures.asargent@chromium.org2009-12-081-0/+5
| | | | | | | | BUG=29758 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34097 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable tab switching test.chase@chromium.org2009-12-081-1/+1
| | | | | | | | | | | | | | After some debugging on the interactive perf system, it appears the screen was locked (or at least locked up). Current theory is this is why OnPaint wasn't being called and the histogram wasn't being populated. BUG=28968 TEST=tab switching test runs on slaves Review URL: http://codereview.chromium.org/463053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34093 0039d316-1c4b-4281-b951-d872f2087c98
* Minor copyedit of new Xyz channel wording.kathyw@google.com2009-12-084-20/+26
| | | | | | | | | | TBR=aa BUG=none TEST=none Review URL: http://codereview.chromium.org/466074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34089 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'minus' graphic to the local error page if you expand thetony@chromium.org2009-12-082-32/+56
| | | | | | | | | | | | | | "more details" link. Also add a slide transition for showing/hiding the details. BUG=28923 TEST=Turn off error pages in Options, navigate to http://dev.chromium.org:8024/ and play with the "More information on this error" link. Review URL: http://codereview.chromium.org/463045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34083 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Sleep around printing page cycler results."chase@chromium.org2009-12-081-4/+0
| | | | | | | | | | | | | Originally committed in r32954. The underlying problem was fixed in r33704 and r33736. BUG=28764 TEST=morejs page cycler continues to get results for reference build Review URL: http://codereview.chromium.org/460124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34082 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix theme loading bubble position.derat@chromium.org2009-12-081-0/+4
| | | | | | | | | BUG=29539 TEST=tried it Review URL: http://codereview.chromium.org/464058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34077 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications should resize themselves to the content within min-max bounds, ↵johnnyg@chromium.org2009-12-0811-92/+218
| | | | | | | | | | | | | rather than being all the same size. CL hooks into RenderView callbacks to detect the size of the content, and contains some refactoring so that conceptually balloon size = content size + frame, rather than content size = balloon size - frame as it has been. BUG=26691 TEST=included Review URL: http://codereview.chromium.org/460131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34076 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] bring more extension tests online in browser_teststhomasvl@chromium.org2009-12-081-8/+1
| | | | | | | | | | | | | | | | - extension_bookmarks_apitest.cc passes - extension_history_apitest.cc passes - extension_javascript_url_apitest.cc passes - extension_messages_apitest.cc passes - extension_override_apitest.cc passes - extension_toolstrip_apitest.cc passes - isolated_world_apitest.cc passes BUG=none TEST=none Review URL: http://codereview.chromium.org/465125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34075 0039d316-1c4b-4281-b951-d872f2087c98
* Add Cocoa window interposing for plugin processstuartmorgan@chromium.org2009-12-0812-159/+326
| | | | | | | | | | | | | | Adds support for noticing window show/hide done via Cocoa APIs. Also adds interposing on a couple more Carbon calls that I came across while debugging. Refactors to make things a bit less messy: - Moves responsibility for re-activating the browser when the last plugin window closes into the browser, to simplify that logic. - Moves utility method for activating the plugin process into the plugin, rather than the interpose library, so the Cocoa code can use it too. - Add a data-holder and a couple of wrapper methods to reduce code duplication in the window show/hide handling. BUG=28009, 29321 TEST=Plugin-opened windows (Gmail attachments, full-screen Flash, etc.) should work as expected again. Review URL: http://codereview.chromium.org/465111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34074 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Don't show all of the print dialog's children, including widgets ↵thestig@chromium.org2009-12-081-1/+1
| | | | | | | | | | normally not displayed. BUG=26872 TEST=Default print dialog should not have the conflict warning. Review URL: http://codereview.chromium.org/460138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34072 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Eliminte locking from PrefetchObserver and DnsMaster in favor of ↵eroman@chromium.org2009-12-086-231/+250
| | | | | | | | | | | | | | | | | making these classes non-threadsafe. Conceptually, PrefetchObserver and DnsMaster live on the IO thread, and their methods can only be called from the IO thread. In the cases where calls do need to be made from the UI thread, we post a task to be run on the IO loop and return without blocking. The only time where we block is during shutdown, when we must wait on the IO thread to get us the startup list and referral list. BUG=25335 Review URL: http://codereview.chromium.org/300032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34066 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] A chunk of browser_tests for extensions:thomasvl@chromium.org2009-12-084-11/+15
| | | | | | | | | | | | | | | | - Bring up extension_apitest on mac - stub browser_action_apitest but get it compiling - stubs_apitest passes - compile cross_origin_xhr_apitest, but we don't pass it. - content_script_all_frames_apitest passes - execute_script_apitest passes BUG=none TEST=waterfall stays green Review URL: http://codereview.chromium.org/465121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34065 0039d316-1c4b-4281-b951-d872f2087c98
* Update docs to recomment beta channel instead of dev whereaa@chromium.org2009-12-084-9/+33
| | | | | | | | appropriate. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34064 0039d316-1c4b-4281-b951-d872f2087c98
* Update the 128x128 icon to have transparent corners. Thefinnur@chromium.org2009-12-081-1/+1
| | | | | | | | | | | | 64x64 already is correct. BUG=None TEST=The RSS extension should not have white corners on the gallery or in the install dialog. Review URL: http://codereview.chromium.org/465115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34061 0039d316-1c4b-4281-b951-d872f2087c98
* Reformat the homepage, add video playlist.kathyw@google.com2009-12-088-121/+180
| | | | | | | | | | TBR=aa TEST=none BUG=none Review URL: http://codereview.chromium.org/460140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34060 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 11:14:10 +0000