summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-0671-95/+95
| | | | | | | | | | | | | 2/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6805012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80647 0039d316-1c4b-4281-b951-d872f2087c98
* Modify GetNTPInfo automation hook to return additional info about apps.dennisjeffrey@google.com2011-04-063-41/+86
| | | | | | | | | | | | | The following additional information is returned: (1) Whether the app is a component extension. (2) Whether the app is disabled. BUG=None TEST=None Review URL: http://codereview.chromium.org/6689019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80644 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling three flaky tests. Opened bugs# 70659, 74843anantha@chromium.org2011-04-061-0/+4
| | | | | | Review URL: http://codereview.chromium.org/6803014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80643 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently trim learned referrer databasejar@chromium.org2011-04-068-100/+227
| | | | | | | | | | | | | | | | | | | | Data learned during navigation, about subresources, was only being trimmed (pruned?) at shutdown. This CL regularly calls for reductions in contents. Without this, long lived clients can accumulate large lists. We also form two preconnections to a site if we have no prior info about its sub-resources. This accelerates learned activity. This CL also sets the initial estimate of number of connections needed to 2, so that we are more aggressive in our learning curves about sub-resources. R=mbelshe BUG=75200 Review URL: http://codereview.chromium.org/6628063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80637 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser version control in gpu blacklist entry. This allows us to push ↵zmo@google.com2011-04-062-3/+13
| | | | | | | | | | out an entry for a specific version of chrome. BUG=78064 TEST=unittest Review URL: http://codereview.chromium.org/6693080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80636 0039d316-1c4b-4281-b951-d872f2087c98
* Read and Write SSL3, TLS1 and Cert revocation SSL preferencesrtenneti@chromium.org2011-04-067-134/+22
| | | | | | | | | | | from local_state on Windows and Mac. BUG=76551 TEST=testing SSL preferences with options UI R=wtc Review URL: http://codereview.chromium.org/6693077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80635 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CRLF from devtools_netlog_observer.ccvsevik@chromium.org2011-04-061-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6800015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80634 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-0672-100/+100
| | | | | | | | | | | | | 1/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6689029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80630 - Mark the following as disabled under ↵mmenke@chromium.org2011-04-061-125/+0
| | | | | | | | | Windows:ExtensionCrashRecoveryTest.BasicExtensionCrashRecoveryTest.CloseAndReloadExtensionCrashRecoveryTest.ReloadIndependentlyChangeTabsExtensionCrashRecoveryTest.ReloadIndependentlyNavigatePageExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBarsExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBarsSameBrowserExtensionCrashRecoveryTest.TwoExtensionsCrashFirstExtensionCrashRecoveryTest.TwoExtensionsCrashSecondExtensionCrashRecoveryTest.TwoExtensionsCrashBothAtOnceExtensionCrashRecoveryTest.TwoExtensionsOneByOneExtensionCrashRecoveryTest.TwoExtensionsIgnoreFirstExtensionCrashRecoveryTest.TwoExtensionsReloadIndependentlyExtensionCrashRecoveryTest.CrashAndUninstallTBR=mmenkeBUG=78598TEST=noneReview URL: http://codereview.chromium.org/6804012 TBR=mmenke@chromium.org Review URL: http://codereview.chromium.org/6804013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80631 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the following as disabled under Windows:mmenke@chromium.org2011-04-061-0/+125
| | | | | | | | | | | | | | | | | | | | | | | ExtensionCrashRecoveryTest.Basic ExtensionCrashRecoveryTest.CloseAndReload ExtensionCrashRecoveryTest.ReloadIndependentlyChangeTabs ExtensionCrashRecoveryTest.ReloadIndependentlyNavigatePage ExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBars ExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBarsSameBrowser ExtensionCrashRecoveryTest.TwoExtensionsCrashFirst ExtensionCrashRecoveryTest.TwoExtensionsCrashSecond ExtensionCrashRecoveryTest.TwoExtensionsCrashBothAtOnce ExtensionCrashRecoveryTest.TwoExtensionsOneByOne ExtensionCrashRecoveryTest.TwoExtensionsIgnoreFirst ExtensionCrashRecoveryTest.TwoExtensionsReloadIndependently ExtensionCrashRecoveryTest.CrashAndUninstall TBR=mmenke BUG=78598 TEST=none Review URL: http://codereview.chromium.org/6804012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80630 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the following as failing under Windows:mmenke@chromium.org2011-04-062-0/+16
| | | | | | | | | | | | | | | | | | | DesktopNotificationsTest.TestShow DesktopNotificationsTest.TestClose DesktopNotificationsTest.TestCancel DesktopNotificationsTest.TestPositioning DesktopNotificationsTest.TestVariableSize DesktopNotificationsTest.TestQueueing DesktopNotificationsTest.TestUserInputEscaping Also Mark TaskManagerBrowserTest.NoticeNotificationChanges as disabled under windows. TBR=mmenke BUG=78597 TEST=none Review URL: http://codereview.chromium.org/6802009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80629 0039d316-1c4b-4281-b951-d872f2087c98
* Drop RDH from ProfileImportProcessHost.willchan@chromium.org2011-04-064-15/+9
| | | | | | | | | | | | | | | If a RDH is passed to the parent class, it will create a ResourceMessageFilter to handle resource loads. ProfileImportProcessHost shouldn't need to load resources. It's just importing the profile. This is part of the effort to pass a per-profile content::ResourceContext object to all message filters that need it. We need to avoid creating message filters unless we need them. We don't need a ResourceMessageFilter here. BUG=78596 TEST=none Review URL: http://codereview.chromium.org/6805006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80627 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extension automation support that was used only by CEEE.joi@chromium.org2011-04-0620-1002/+26
| | | | | | | | | BUG=none TEST=all automated tests pass Review URL: http://codereview.chromium.org/6756044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80626 0039d316-1c4b-4281-b951-d872f2087c98
* Last of the app icons.avi@chromium.org2011-04-068-8/+23
| | | | | | | | | | | Move the non-extension app icon code to extension_tab_helper, merge with extension app code. BUG=71097 TEST=no visible change Review URL: http://codereview.chromium.org/6792059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80622 0039d316-1c4b-4281-b951-d872f2087c98
* Update notification iconsdpolukhin@chromium.org2011-04-065-2/+3
| | | | | | | | | BUG=chromium-os:9164 TEST=Manual Review URL: http://codereview.chromium.org/6806008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80620 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80539 - Refactor ExtensionService/ExtensionServiceInterface to be ↵cmp@chromium.org2011-04-0625-237/+195
| | | | | | | | | more testableIn particular:- Add various status accessors to ExtensionServiceInterface (e.g., IsExtensionEnabled())- Convert IsIncognitoEnabled() to take an ID instead of an Extension*.- Add CheckForUpdates() to ExtensionServiceInterface.- Remove various unneeded accessors from ExtensionServiceInterface.Rewrite some sync utility functions to take advantage of the newinterface (although it will be rewritten more in a future CL).BUG=77995TEST=Review URL: http://codereview.chromium.org/6720042 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6804010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80613 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Detect browser crashes on shutdown in UI tests. phajdan.jr@chromium.org2011-04-069-116/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously the automation framework could miss a browser crash during shutdown on POSIX (on Windows there is crash_service.exe that should catch all crashes). This change makes the automation framework avoid losing information about the browser process' exit status (CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout (which on POSIX never reported the process has been signaled). Finally, it makes the automation framework use WaitForExitCodeWithTimeout instead of WaitForSingleProcess. This way we can get the exit status information in an accurate and cross-platform way. To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them. I've tested this change locally on Mac with a UI test that SIGKILLs the browser. Before this change the test passed (it shouldn't), and after this change the test failed with an information that the browser has not exited cleanly. BUG=56644 Review URL: http://codereview.chromium.org/6689014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80608 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a simple Extension App Omnibox provider. finnur@chromium.org2011-04-067-7/+275
| | | | | | | | BUG=52444 TEST=Install an App from the gallery, then type a substring from its name (or it's launch url) and see it appear as a suggestion in the Omnibox. Review URL: http://codereview.chromium.org/6758031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80605 0039d316-1c4b-4281-b951-d872f2087c98
* Set the linux speech bubble to be the same size in warm up and recording modes.satish@chromium.org2011-04-061-7/+32
| | | | | | | | | | | This is already the case in mac and windows, this CL fixes the linux version to match them. BUG=none TEST=manual, click on the speech button and verify that the bubble stays same size between warm up and recording states. Review URL: http://codereview.chromium.org/6800011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80603 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build.willchan@chromium.org2011-04-062-6/+9
| | | | | | | | | | | Broken by crrev.com/80540 BUG=none TEST=none Review URL: http://codereview.chromium.org/6806005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80601 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reload the history page if something got deleted.jochen@chromium.org2011-04-066-70/+4
| | | | | | | | | | | Only reload it if the user requested the deletion through the history page itself. BUG=49475 TEST=none Review URL: http://codereview.chromium.org/6691055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80600 0039d316-1c4b-4281-b951-d872f2087c98
* Add accelerator for triggering enrollment from login prompt.mnissler@chromium.org2011-04-0611-21/+68
| | | | | | | | | | | | It's still only enabled for non-official builds, since the connection to GAIA and policy infrastructure is still missing. BUG=chromium-os:13277 TEST=manual Review URL: http://codereview.chromium.org/6689010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80599 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up enrollment login with GAIA auth.mnissler@chromium.org2011-04-065-10/+174
| | | | | | | | | | | | With this, the enrollment UI is now functional up to the point of actually passing the auth credentials on to the policy subsystem. BUG=chromium-os:13277 TEST=manual Review URL: http://codereview.chromium.org/6759055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80598 0039d316-1c4b-4281-b951-d872f2087c98
* Implement login and confirmation UI for enterprise enrollment screenmnissler@chromium.org2011-04-0619-104/+801
| | | | | | | | | | | | This adds a WebUI-based flow to the enterprise enrollment screen that first prompts for credentials and then shows a confirmation screen. BUG=chromium-os:13277 TEST=manual Review URL: http://codereview.chromium.org/6778014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80597 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spinner & warm up animation frames into file-scoped globals instead ↵satish@chromium.org2011-04-061-72/+94
| | | | | | | | | | | | | of instance variables. Also corrected naming of the other file-scoped globals in that vicinity. BUG=none TEST=none, no change in functionality. Review URL: http://codereview.chromium.org/6794058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80596 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 728.0 to 729.0chrome-release@google.com2011-04-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80593 0039d316-1c4b-4281-b951-d872f2087c98
* Show EULA in initial locale instead of current localedpolukhin@chromium.org2011-04-065-2/+106
| | | | | | | | | BUG=chromium-os:13838 TEST=manual Review URL: http://codereview.chromium.org/6793039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80589 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at moving system access code from libcros to Chrome.satorux@chromium.org2011-04-067-8/+380
| | | | | | | | | | | | | | | | | | | | | system_access* are mostly identical copies of chromeos_system*, except: - strdup/free is used instead of NewStringCopy/delete, as NewStringCopy doesn't exist in Chrome tree. - functions reside in chromeos::system_access namespace to avoid conflicts with the existing functions in libcros. In the follow-up patch, we'll remove cros/system_library, as the libcros layer should be unnecessary after the migration. We'll also remove chromeos_system* from libcros in separate patches. BUG=chromium-os:13351 TEST=confirmed timezone switching worked. also added --vmodule=system_library=1 to /sbin/session_manager_setup.sh to observe that the machine info was obtained properly in /var/log/chrome/chrome* (there wasn't an handy way to test the machine info code). Review URL: http://codereview.chromium.org/6760024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80588 0039d316-1c4b-4281-b951-d872f2087c98
* Disable registration of Breakpad's signal handler for Native Clientmseaborn@chromium.org2011-04-061-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | This partially undoes r71459. This fixes a security vulnerability that occurs when the NaCl revision is updated to r4598 or later. That revision changes NaCl's sel_main_chrome.c so that it no longer registers a signal handler, but instead leaves Breakpad's signal handler (registered by Chrome) in place. The vulnerability would allow NaCl untrusted code to escape NaCl's inner sandbox on x86-32 Linux. This is because although NaCl's signal handler knows how to safely handle faults from NaCl x86-32 sandboxed code, Breakpad's signal handler does not. Breakpad's signal handler does not restore %gs. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1607 TEST=assertion to be added on the NaCl side (http://codereview.chromium.org/6798008/) Review URL: http://codereview.chromium.org/6677168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80581 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up Autofill CreditCard logicisherman@chromium.org2011-04-068-143/+111
| | | | | | | | | | | | | | | * When determining possible field types (for upload to the server), match against stored data, not just against the Luhn checksum * When displaying the obfuscated credit card number, display exactly the right number of obfuscating '*'s. * When importing credit card data, only save the card if the detected card type is one we recognize. * Prune some unhelpful member variables * Prune some unhelpful methods from the header BUG=77822 TEST=unit_tests --gtest_filter=CreditCardTest.* Review URL: http://codereview.chromium.org/6690038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80580 0039d316-1c4b-4281-b951-d872f2087c98
* Switch fonts when Chrome OS locale changes.falken@chromium.org2011-04-066-10/+54
| | | | | | | | | | | | | | | | | | | This patch is just a start. When locale changes through the login screen UI, the fonts in ResourceBundle and PlatformFontGtk are updated, and the password fields and username labels are redrawn with the correct font. In the future, all widgets in the login screen would be redrawn with the correct font. When the locale changes upon login, the fonts are updated, though not all widgets are redrawn correctly yet. BUG=chromium-os:13450 TEST=manually Review URL: http://codereview.chromium.org/6788004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80579 0039d316-1c4b-4281-b951-d872f2087c98
* Only consider numbers between 12 and 19 digits long to potentially be credit ↵isherman@chromium.org2011-04-063-18/+57
| | | | | | | | | | | card numbers. BUG=64433 TEST=unit_tests --gtest_filter=CreditCardTest.* Review URL: http://codereview.chromium.org/6758027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80577 0039d316-1c4b-4281-b951-d872f2087c98
* Build break fix for WK change https://bugs.webkit.org/show_bug.cgi?id=57566zelidrag@chromium.org2011-04-061-0/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6799005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80576 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in SearchProvider. The crash occurred because thesky@chromium.org2011-04-063-6/+20
| | | | | | | | | | | | | SearchProvider could end up recursively invoking the AutocompleteClassifier, leading to weird bugs. BUG=78342 TEST=see bug R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6792064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80575 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80567 - P2P Transport implementation.TEST=Unittests.BUG=NoneReview ↵sergeyu@chromium.org2011-04-061-2/+0
| | | | | | | | | URL: http://codereview.chromium.org/6791023 TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/6799003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80571 0039d316-1c4b-4281-b951-d872f2087c98
* P2P Transport implementation.sergeyu@chromium.org2011-04-061-0/+2
| | | | | | | | | TEST=Unittests. BUG=None Review URL: http://codereview.chromium.org/6791023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80567 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't route mouse events to the render view host if window is not ↵asvitkine@chromium.org2011-04-062-16/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | frontmost. This change makes Mac Chrome match the behaviour of other browsers on the Mac (tested Firefox and Safari) as well as other Mac applications such as iTunes. Additionally, this fixes a number of bugs, including: - Mouse cursor changing when hovering over web content in background windows yet clicks in this case would be eaten to bring the window to the front. - Mouse cursor NOT changing when hovering web content in background windows when Chrome is not the active application - resulting in inconsistent behaviour. - http://crbug.com/77928 - resulting in wrong cursor persisting after moving out of the web content area of a background window. Also, change related unit tests to make the test window the keyWindow so that the tests continue to pass. BUG=77928 TEST=Open two windows, A and B. Open a webpage in A, then make B the foreground window. Now, hover the cursor over web content in A. The cursor should not change and mouse-over actions should not occur. R=mark@chromium.org Review URL: http://codereview.chromium.org/6720023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80563 0039d316-1c4b-4281-b951-d872f2087c98
* Allow pyauto HTTP file server to serve files from an arbitrary directoryrsimha@chromium.org2011-04-061-3/+8
| | | | | | | | | | | | | | | | | | | | | | | The PyAuto HTTP file server is hard coded to serve its files from the relative path "chrome/test/data". This has worked for tests within the chromium project because they all store their data in that directory. Now that Chromium Native Client had a dependency on PyAuto and uses its HTTP server to serve files for its tests, the hard-coded relative path will need to be replaced by the path to the NaCl staging directory, which varies across platforms. This patch adds a new parameter called "--http-data-dir" to pyauto.py, so that the HTTP server path can be overridden. The default remains "chrome/test/data", so Chromium tests that use the HTTP server do not need any modifications. BUG=77356 TEST=Run any pyauto functional test that uses the HTTP server Review URL: http://codereview.chromium.org/6732051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80559 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Rename ShowExtensionInstallDialog2 to ShowExtensionInstallDialog.tfarina@chromium.org2011-04-0611-165/+175
| | | | | | | | | | | BUG=66730 TEST=None R=aa@chromium.org Review URL: http://codereview.chromium.org/6720048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80556 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram added: GPU.GPUProcessLaunchCausescheib@chromium.org2011-04-067-20/+39
| | | | | | | | | | | | | - This will help distinguish why the GPU process was started. Also, corrected code in "about:" page parsing to not spawn the GPU process unless a GPU related page is being requested. BUG=78361 TEST=about:histograms includes GPU.GPUProcessLaunchCause after GPU use (e.g. about:gpu). Review URL: http://codereview.chromium.org/6794002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80555 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionApiTest.Infobars on Mac, as it is flaky.twiz@chromium.org2011-04-051-1/+2
| | | | | | | | BUG=60990 TEST=ExtensionApiTest.Infobars Review URL: http://codereview.chromium.org/6798005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80553 0039d316-1c4b-4281-b951-d872f2087c98
* Move UserScriptSlave and UserScriptIdleScheduler to the extensions subdirectory.jam@chromium.org2011-04-058-17/+17
| | | | | | Review URL: http://codereview.chromium.org/6677177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80551 0039d316-1c4b-4281-b951-d872f2087c98
* Use https for all the help center URLs. It's actively supported. And it lookscevans@chromium.org2011-04-051-13/+13
| | | | | | | | a little more professional to land on https when "learning more" about e.g. our privacy stance, or the password manager. Review URL: http://codereview.chromium.org/6735068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80550 0039d316-1c4b-4281-b951-d872f2087c98
* This test is failing on Win xp and vista. Disabling temporarily and ↵anantha@chromium.org2011-04-051-0/+2
| | | | | | | | investigating crbug.com/78519 Review URL: http://codereview.chromium.org/6793056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80549 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable passing test SettingsWebUITest.SetBooleanPrefTriggers.dtseng@chromium.org2011-04-051-7/+1
| | | | | | | | | BUG=77764 TEST=repeated runs on try bots. Passing for the past two days on Win, Mac, and Linux. TBR=jam Review URL: http://codereview.chromium.org/6735073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80544 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Clang style errors.asargent@chromium.org2011-04-052-0/+7
| | | | | | | | | | BUG=none TEST=none TBR=erg@chromium.org Review URL: http://codereview.chromium.org/6793053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80542 0039d316-1c4b-4281-b951-d872f2087c98
* Make BookmarkModelVerifier wait for favicon load during GetFaviconrsimha@chromium.org2011-04-054-28/+76
| | | | | | | | | | | | | | | | | | The test case for bookmark favicon sync was failing in its verification step because GetFavicon sometimes returned a blank favicon for a URL. This was because GetFavicon can be asynchronous if the favicon of a bookmark node is not already loaded. This patch modifies BookmarkModelVerifier::FaviconsMatch and wraps BookmarkModel::GetFavicon with an additional wait on favicon load, but only if a favicon was set for that particular URL. BUG=69694 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6760033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80540 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor ExtensionService/ExtensionServiceInterface to be more testableakalin@chromium.org2011-04-0525-195/+237
| | | | | | | | | | | | | | | | | | | In particular: - Add various status accessors to ExtensionServiceInterface (e.g., IsExtensionEnabled()) - Convert IsIncognitoEnabled() to take an ID instead of an Extension*. - Add CheckForUpdates() to ExtensionServiceInterface. - Remove various unneeded accessors from ExtensionServiceInterface. Rewrite some sync utility functions to take advantage of the new interface (although it will be rewritten more in a future CL). BUG=77995 TEST= Review URL: http://codereview.chromium.org/6720042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80539 0039d316-1c4b-4281-b951-d872f2087c98
* Adds two Python/PyAuto functions, GetProxySettings() and SetProxySetting(), ↵dtu@chromium.org2011-04-0510-93/+260
| | | | | | | | | | | | | | | that allow tests to read and manipulate Chrome OS proxy settings. Fixes issue with proxy settings where they reset when changing only the port of a proxy without changing the URL. This happens when using the automation hooks because they create a new ProxyCrosSettingsProvider with each invocation. This is done by removing the caching behavior of ProxyCrosSettingsProvider. Modifies the type of the "Port" textboxes in the Proxy Settings UI to Integer so that ProxyCrosSettingsProvider uses a consistent type for both Get() and Set(). BUG=chromium-os:13650,chromium-os:12727 TEST=Manual. Test included for GetProxySettings() that will run in the Autotest lab. stanleyw will add additional tests that use SetProxySetting(). Review URL: http://codereview.chromium.org/6737035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80537 0039d316-1c4b-4281-b951-d872f2087c98
* Add a webstore install method that lets us prompt the user before downloading.asargent@chromium.org2011-04-0515-19/+572
| | | | | | | | | | | | | | | | | | | A while back we decided to minimize friction by showing extension/app permissions inline in the webstore, and let installs done via the private webstore API skip the regular extension installation confirmation that happens after downloading and unpacking the .crx file. We've reconsidered this and are now adding a new private install method that lets us go back to having the client display the confirmation dialog, but do it before downloading the .crx file. The webstore just needs to pass the manifest and icon, and then after downloading the .crx we make sure the unpacked extension's manifest matches what we had prompted with. BUG=75821 TEST=(Existing tests should pass; new functionality requires chrome web store server side changes to test) Review URL: http://codereview.chromium.org/6794010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80536 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-15 15:42:03 +0000