| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31077
Review URL: http://codereview.chromium.org/351004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add plumbing to allow multiple Sandbox profiles on OS X.
* Separate sandbox_init_wrapper into platform specific files.
* Sandbox Worker process & add plumbing to Sandbox utility process when we bring that up.
* Remove mention of stale bugs in utility process on Mac.
BUG=23582
TEST=Worker process should work.
Review URL: http://codereview.chromium.org/341033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20969
TEST=none
Review URL: http://codereview.chromium.org/348056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=|'localStorage' in window| should only be true iff --enable-local-storage is specified
Review URL: http://codereview.chromium.org/335034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hack for making them work in test shell and single process mode.
This replaces http://codereview.chromium.org/335034/show
TEST=none
BUG=24581
Review URL: http://codereview.chromium.org/363014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 31077.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Review URL: http://codereview.chromium.org/351004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so that when unattended, typically the first run dialog is not shown
(when using automation proxy) and the user does not get a chance to consent
to sending stats. This gives an opportunity to force enable breakpad.
BUG=24960,25271
TEST=Breakpad should be initialized if --enable-crash-reporter flag has been specified
Review URL: http://codereview.chromium.org/282011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
compile-time differences between Chrome Frame and Chrome.
Review URL: http://codereview.chromium.org/361023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrote unit tests for the entire class and fixed some other bugs that cropped up.
BUG=25075
TEST=unit_tests, also closing tabs/browser shouldn't try to use dead IO loop
Review URL: http://codereview.chromium.org/363007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
database. This allows us to modify Browser::Type without invalidating databases from older versions.
http://crbug.com/26500
TEST=see bug
Review URL: http://codereview.chromium.org/361016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26756
Review URL: http://codereview.chromium.org/361024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Less file IO on the UI thread
Review URL: http://codereview.chromium.org/354013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
almost identical app menu.
This CL will toggle app menu depending on the status of toolbar.
- This is only for toolkit views build as gtk version does not toggle toolbar.
- The menu contnets are not fully sync'ed. We need some refactoring, when
we fully migrate to views.
Review URL: http://codereview.chromium.org/366010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24701
TEST=ran chrome and looked at the strings
Review URL: http://codereview.chromium.org/366016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22962
TEST=Install an extension. Install dialog warning should not include any warnings about autoupdating.
Review URL: http://codereview.chromium.org/362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=7228-7241
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also correct some long line violations.
Review URL: http://codereview.chromium.org/355034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bookmarks bar during an animation. What we want is the "extra"
height provided by the bookmarks bar. Since we always show at
least 4px, we don't count that as extra height.
Review URL: http://codereview.chromium.org/366019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26509
TEST=none
Review URL: http://codereview.chromium.org/340072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
keep alignment correct in both cases. Also strip out newlines from bookmark titles.
[Patch by feldstein.]
BUG=26353
TEST=Add and remove titles from bookmarks in the bookmark bar and verify that they look correct, and icons are centered when there is no text.
Review URL: http://codereview.chromium.org/353024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26614
Review URL: http://codereview.chromium.org/360035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on shutdown when extensions were running.
BUG=15708
BUG=26652
Review URL: http://codereview.chromium.org/355032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 20036
TEST= install glossy blue theme. See curved corner (overlay) in upper left hand corner.
Note that it does not appear in the incognito version of the theme (now it appears in the jarringly wrong color).
Review URL: http://codereview.chromium.org/361018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declaration order.
This is strictly a no-op refactor, it does not change any code (just re-orders it within the file).
This addresses a TODO to tidy the code.
TBR=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/360030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 26704
TEST= change themes. browser does not crash.
Review URL: http://codereview.chromium.org/366015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=amit
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TCV's size allocate message. This avoids a spurious size-allocate
being sent to the renderers when creating a new tab. The extra
size-allocate is called by the build-in GtkFixed's size allocate
method.
Another way to think of this is that we only size our RWH directly
and decouple it's sizing from the GTK+ widget's sizing.
BUG=26495
Review URL: http://codereview.chromium.org/363012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 26689
TEST= none
Review URL: http://codereview.chromium.org/362012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw
BUG=None
TEST=This is fixing a test.
Review URL: http://codereview.chromium.org/367006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also grasp at straws trying to fix a crash bug.
BUG=21201
Review URL: http://codereview.chromium.org/345058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
causing a unit test to crash last time.
Refactor security-icon code to a more general form, also more consistent with
the Windows implementation, in preparation for implementing page actions.
Review URL: http://codereview.chromium.org/264037
BUG=14899, 22922, 12281
TEST=unit tests included
Review URL: http://codereview.chromium.org/348069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ones more prominently.
Also added an unused string for 'getting more extensions',
so we can translate.
Converted 'Developer Tools' references to 'Developer Mode',
to avoid confusion with Chrome's developer tools.
TEST=Load extension b_foo through --load-extension.
Open chrome://extensions/ and notice extension b_foo is
on top, even though another extension a_foo normally would
appear at the top due to alphabetical sorting. Then disable
an extension and notice it should turn all gray. Enable,
and it should no longer be gray.
BUG=http://crbug.com/26699, http://crbug.com/25850
Review URL: http://codereview.chromium.org/365008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Baselines match between labels and top control for:
- default browser (basics)
- browsing data (personal stuff)
- themes (personal stuff)
- The list for startup urls and the textbox for homepage are both indented to the start of the text on the radio they go with.
- The gap above the list for startup urls and the textbox for homepage and their radio buttons is the same.
BUG=26703
TEST=Baseline match, gap between radio and field/list is the same, field/list are left aligned
Review URL: http://codereview.chromium.org/362011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unavailable.
BUG=23258
TEST=We get approximate memory usage in about:memory for sandboxed renderers.
Review URL: http://codereview.chromium.org/365007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
volumes.
BUG=26660
TEST=no visible difference. Make sure volume still works. Code size should go down marginally.
Review URL: http://codereview.chromium.org/357004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Yet I cannot delete AutomationProxyForExternalTab because it is used by extension_uitest.cc.
Enable some tests meanwhile - now they should be stable enough.
BUG=18797,24664
TEST=ui_tests ok
Review URL: http://codereview.chromium.org/339009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line.
Also,
* At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it).
* The installer now propagates the presence of --verbose-logging to uninstalls.
* The chrome_launcher now allows the --chrome-frame switch through to chrome.
* The installer now accepts a --chrome-frame switch.
* Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer.
BUG=26012, 26603
TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly.
Review URL: http://codereview.chromium.org/345021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20793
TBR=dglazkov
Review URL: http://codereview.chromium.org/361013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It wasn't wired up to any errors yet, it wasn't hidden by default, it created an unnecessary horizontal space, and it would DCHECK (or worse) when that space was clicked.
BUG=26595
TEST=Displayed the bookmarks bar, verified that the gap to the left of "Other Bookmarks" went away and that it was no longer clickable.
R=estade
Review URL: http://codereview.chromium.org/360024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This allows DCHECKs that the code is running on the correct thread to succeed.
BUG=26714
Review URL: http://codereview.chromium.org/363010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26265,26268
Review URL: http://codereview.chromium.org/360023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tear down a toast.
BUG=26360
TEST=cancel a notification
Review URL: http://codereview.chromium.org/363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r30843.
This broke the findbar/download shelf animation optimization. I
originally was doing this as part of fixing issue 26495, but I
found a different way.
TBR=estade
Review URL: http://codereview.chromium.org/366009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes sure Linux packages are rebuilt if any of the packaging scripts or
config files change.
Review URL: http://codereview.chromium.org/360017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31001 0039d316-1c4b-4281-b951-d872f2087c98
|