| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9301027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=106580
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9302023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9303023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RestartBrowser() calls pkill and pgrep on 'chrome'. These calls are not working correctly, because that regex includes the 'chromedriver' process.
BUG=chromium-os:19556
TEST=Run the PyAuto test: python pyauto_webdriver.py
Review URL: http://codereview.chromium.org/9104025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Precisely, keep track of the time that the user first began modifying
text in the omnibox. When the UMA finally selects an omnibox suggestion
and this selection is logged (for opted-in / UMA users), record in this
log entry the elapsed time since the user began modifying the omnibox.
This will be useful to measure changes to the omnibox. In general,
omnibox changes should result in less time spent typing in the omnibox /
reviewing proferred suggestions.
This code works as you'd expect with two caveats:
* If the current tab/window loses focus at some point (e.g., the user types,
switches tabs, switches back, and types more), the elapsed time only starts from
the beginning of the second series of modifications. Nuance to this
rule: if a user types in the omnibox, clicks somewhere on the page in a
way that doesn't navigate to a new page (but this click will have the effect
of closing the omnibox dropdown), then returns to the omnibox and types
more, the elapsed time counts from the beginning of the first modification.
(Basically, this type of action, where the current tab still remains
in focus even if the omnibox itself has gone in and out of focus, calculates
elapsed time in a way that makes sense.)
* If a user enters text in the omnibox, switches tabs/windows, and then
returns to this tab and presses enter without typing more, thereby
navigating to the inline suggestion that was originally offered, no
omnibox transition event is currently logged. This changelist does not
alter this policy. The omnibox event is only logged if the omnibox
suggestion dropdown is open with the transition happens. In this case,
when the user leaves the tab, the dropdown closes. When the user returns,
the dropdown doesn't re-open unless the user types something new.
I believe this changelist is fine/useful as-is. I don't like the first
caveat mentioned above but I'm inclined to submit this as-is and fix
that special case in a later changelist (if I decided it's worth bothering).
I prevent not to postpone this changelist on this subtlety.
Regarding the second caveat, that's orthogonal to this changelist and
should be fixed in a different change (if indeed we desire to fix it--I'll
have to look at everyone who is observing omnibox transition events).
I will submit this changelist only *after* the server processing UMA
uploads is running code that can handle the XML format with this new
attribute.
Chrome privacy folks have okayed this change.
Tested by hand (on linux). I looked at normal use and tested in particular:
* Startup. The initial blank window with an empty omnibox doesn't start the
timing until the user types something into the box.
* Highlight all in omnibox. Then type. The timer starts only when you
begin typing, not at the highlight stage.
* Start typing. Press escape (which reverts omnibox to the current
page's URL), then type more. The timer starts when the second series of
typing begins.
* Type in omnibox. Click on a link on the page (this causes a page
transition and the omnibox to display the new page's URL). Modify the
omnibox. The timer starts when the second series of typing begins; the
first modification does not count.
* Alt-enter (to open an omnibox suggestion in a new foreground tab) gets
emitted as normal, with appropriate timing.
* If you go back to the tab that you used to open the background tab, its
omnibox shows the current page's URL. If you start typing here, the
starting time is from this second set of typing, not the first use in this
tab that ended with opening a suggestion in a new tab.
* Open a new tab. The timer only starts when you start typing in the
omnibox, not when the tab gets opened.
* Middle-click (to open an omnibox suggestion in a new background tab) gets
emitted as normal, with appropriate timing.
* After you middle-click a result, the omnibox dropdown stays open on the
current tab. If you select something new here, the timing is from the
beginning of when you originally started typing. That is, both the
results opened from this list of suggestions have the same start time.
* After you middle-click a result, you type more (and thus get new
suggestions), the timing still starts from the time you originally
began modifying the omnibox (i.e., before you opened a new tab in the
background).
I saw some behavior we may want to change later. These are described
in the caveats section above.
* Highlight all and press delete. Then type. The timer starts when you
press delete, not at the first real character you type.
* Type in the omnibox. Switch tabs/windows/whatever. Return and type
more. The timing starts from this second batch of typing. I'd think it
should start from the first.
* If you middle-click a result, then switch windows (i.e., this window
or this tab loses focus), the omnibox disappears. If you return to the
omnibox and hit return to select whatever inline autocompletion is
already in the omnibox, no notify event is emitted.
* Likewise, if you type in the omnibox, switch windows or tabs, then
return and hit return (the omnibox is closed but populated with
original inline suggestion), no notify event is emitted.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9241020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProcessSingleton::WndProc was being invoked with |this| == NULL
and somehow base::win::WrappedWindowProc<> eats the exceptions
causing the critical return from WM_CREATE to not be zero and thus
window creation fails.
Other Minor fixes, inspiration from Joi's change 9121046
BUG=111361
TEST=crashes should dissapear, see bug.
Review URL: http://codereview.chromium.org/9298043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a new version of the sync promo that is displayed inside a blocking dialog window.
If a new browser window is spawned from inside the sync promo then we close the dialog box and foucs on the new window. Any remaining first run tabs are added as inactive tabs to the new browser window.
Screenshots: http://imgur.com/iBspQ
BUG=107219
TEST=
Review URL: https://chromiumcodereview.appspot.com/9225053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let UserImageScreen know UserImageScreenHandler is destroyed.
BUG=111940
TEST=Verify crash in issue 111940 no longer happens.
Review URL: http://codereview.chromium.org/9159046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were two problems:
1. The return value of UnusedLegalNameForNewDropFile() wasn't being checked for nil.
2. UnusedLegalNameForNewDropFile() failing due to FileAlreadyExists() incorrectly handling titles with ?'s in them. PathWithBaseURLAndName() was truncating the name at the ? sign.
BUG=111821
TEST=See bug.
Review URL: http://codereview.chromium.org/9159041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
active one.
BUG=102541,110655
TEST=Open two windows and have one foreground. Move the mouse to the one that is
not and perform a two-finger swipe. The background window navigates, not
the foreground one.
Review URL: https://chromiumcodereview.appspot.com/9303016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for specefic exceptions pages.
BUG=102892
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9147048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108724
TBR
Review URL: https://chromiumcodereview.appspot.com/9293023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=106995
TEST=
Review URL: http://codereview.chromium.org/9264055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111501
TEST=Print a doc with headers and footers enabled or disabled. Open print preview again, last setting should be remembered.
Review URL: http://codereview.chromium.org/9302014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=112024
TEST=covered by tests.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9301019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111538
TEST=Verify that favicons show up for settings, extensions.
Review URL: https://chromiumcodereview.appspot.com/9223029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary issue blocking this is was the screenshot, which would show up as a broken link if a user went to the chrome://feedback page directly.
With this change, to launch the feedback page from an extension, open it with this format,
chrome://feedback/#0?description=Text you want in the description field&categoryTag=TheCategory&customPageUrl=www.yourpageurl.com
Including the customPageUrl will supress the screenshot completely and set the page url on the displayed feedback page to the one specified.
R=zelidrag@chromium.org,xiyuan@chromium.org
BUG=chromium-os:24993
TEST=Tested opening the feedback page without going through the Report an Issue menu item with the customPageUrl parameter. Verified that the screenshot is not shown at all and the feedback is sent successfully on submit.
Review URL: http://codereview.chromium.org/9271033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23673
TEST=OncNetworkParserTest
Review URL: https://chromiumcodereview.appspot.com/9297061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new class AutocompleteFieldTrial is meant to handle one or more field trials at once. I'll add another field trial to it (that makes HistoryQuickProvider more aggressive) soon.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9113037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9301022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Waiting for idle CPU before calling pyauto.PyUITest.setUp() was problematic,
because the killing/init of Chrome occurs within pyauto.PyUITest.setUp().
BUG=chromium-os:25662
TEST=Verified CPU goes idle on Flash tests only after making this change.
Review URL: https://chromiumcodereview.appspot.com/9303017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by Ori Gershony <orig@chromium.org>.
BUG=106580
R=orig@chromium.org,estade@chromium.org
TEST=Use --enable-webstore-link to force the experiment on.
Review URL: https://chromiumcodereview.appspot.com/9303005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111475
TEST=Open proxy settings dialog on login screen with DCHECKs enabled.
Review URL: https://chromiumcodereview.appspot.com/9303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104586
TEST=See bug.
Review URL: http://codereview.chromium.org/9169040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109817
TEST=compiles
Review URL: http://codereview.chromium.org/9232070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mostly for the page action context menu, but also used elsewhere such as panels
BUG=106781
TEST=on win/chromeos, sentence case. Elsewhere, title.
Review URL: https://chromiumcodereview.appspot.com/9289037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111519
TEST=Verify 111519.
Review URL: http://codereview.chromium.org/9288077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using a software 3d rasterizer to do animation is probably slower than the regular software mode, so avoid doing that.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9289012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=110656
TEST=pyauto test: shortcuts.ShortcutsTest.testClearBrowsingDataShortcut
R=csilv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9264056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the click-to-play feature available in content settings without having to enable it in chrome://flags.
BUG=62084
TEST=none
Review URL: http://codereview.chromium.org/9293008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25635
TEST=looks 75% less crazy
Review URL: https://chromiumcodereview.appspot.com/9293019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not clear to me who needs to review the change to
third_party/leveldatabase/env_chromium.cc, or even if it's handled
through the standard CL interface for the rest of Chromium. But my
best guess was that you could either approve it or tell me who to
contact. Let me know if I need to go about this patch submission
a different way.
R=brettw@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unloads (in memory only, for now).
Add support for broadcasted events.
Add an extension.onInstalled event that is run when the event page first
starts.
BUG=81752
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9297003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's the same set of people as in chrome/browser/content_settings/OWNERS.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9301004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FlashFullscreen test. No longer mark the test as
flaky.
TEST=ui_tests
BUG=108471
Review URL: https://chromiumcodereview.appspot.com/9133024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=CWSIntentsRegistryTest.*
Review URL: http://codereview.chromium.org/9253024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I spotted another interface regression and wanted to fix it. Thanks
for reviewing.
R=johnnyg@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9104015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in 10.7.2 cause install-from-.dmg to no longer add a persistent Dock
tile. By leveraging a the same CFURL private undocumented functions that the
Dock does, Chrome can more robustly make sense of the Dock configuration and
insert itself into the plist.
BUG=111979
TEST=1. Remove Google Chrome.app from /Applications and remove its Dock tile
(if any)
2. Mount GoogleChrome.dmg
3. Launch Google Chrome.app from the .dmg
4. Click "install"
Expect the Dock to restart with a persistent tile for Chrome present
(even after quitting Chrome)
Review URL: https://chromiumcodereview.appspot.com/9264046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few more uses of the old Sleep(int ms) and PostDelayedTask()
interfaces slipped through since my last round of updates. Can you review
these?
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9104014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be removed when r119687 reaches official builds.
BUG=None
TEST=None
TBR=dennisjeffrey@chromium.org
R=dennisjeffrey@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9233037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The lock screen container needs a layout manager to respond to resolution changes caused by an external monitor being attached or detached. Marking the login screen widget as fullscreen makes it reshape to track the size change.
BUG=110942
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9121063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The calculation of the inline_autocomplete_offset_ was incorrect. Eliminated unnecessary function parameter.
BUG=110892
TEST=1) Visit an URL such as "www.amazon.com". 2) Now type 'ama' into the omnibox. 3) Verify that the presentation is "ama[zon.com]" where the bracketted section is the to-be-autocompleted portion. Also enhanced the HistoryQuickProviderTest unit tests.
Review URL: https://chromiumcodereview.appspot.com/9298017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yoz
BUG=109939
Review URL: https://chromiumcodereview.appspot.com/9233034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111752
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/9302008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: https://chromiumcodereview.appspot.com/9159038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URL than predicted.
I also took the opportunity to align the order of methods in prerender_manager.cc to that of the header (as it should be) and make a couple of methods const.
BUG=110799,111350
Review URL: http://codereview.chromium.org/9226037
TBR=dominich@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9301012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=110636
TEST=None
Review URL: http://codereview.chromium.org/9121059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the functions mapped take more than 1 argument, and all the others
are currently always undefined. This breaks locking the default search engine
select box through policy.
BUG=None
TEST=When the DefaultSearchProvider policy is set, the settings UI doesn't allow modifying the default.
Review URL: http://codereview.chromium.org/9104011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aura draws its own frame and shadow for top level windows. We will want to add support for rounded top corners for panels, but for now I think we can live with square corners.
BUG=106076
TEST=Panels on Aura should now have square corners with a standard aura window shadow behind them.
Review URL: http://codereview.chromium.org/9234046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119715 0039d316-1c4b-4281-b951-d872f2087c98
|