summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Some crashes reported from the field seems to indicate that whenjcampan@chromium.org2008-11-253-3/+20
| | | | | | | | | | | | | | | | | storing/restoring the focused view on a tab, the focus manager or focused view is garbage. I have not been able to repro any of these crashers and was not able to discover much from the mini-dumps. This is a simple work-around that just prevents the storing/restoring of focus when closing a tab, to avoid the cases reported in the crasher. Note this is the equivalent of CL 12622 (which is on the release branck), which was reviewed by Ben. BUG=4633 Review URL: http://codereview.chromium.org/12652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6000 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in WebContents::ShowWidget. I suspect this issky@google.com2008-11-255-0/+34
| | | | | | | | | | | | | happening because the RenderWidgetHost is getting destroyed between the time it is created but before it it shown (perhaps the renderer went away). BUG=4629 TEST=none Review URL: http://codereview.chromium.org/12439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5998 0039d316-1c4b-4281-b951-d872f2087c98
* Changes table_view to get position for context menu from the currentsky@google.com2008-11-253-2/+22
| | | | | | | | | | | | | | position of the mose. I've no idea why, but it seems when RTL the position passed to OnContextMenu is wrong in weird inconsistent ways. I thought it was interted, but that isn't always the case. I'm also changing the anchor position to top_right when RTL. BUG=4750 TEST=see bug Review URL: http://codereview.chromium.org/12447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5996 0039d316-1c4b-4281-b951-d872f2087c98
* The first run sentinel does not get created for system installcpu@google.com2008-11-251-2/+11
| | | | | | | | | | | | - Vista case mostly if user has UAC enabled - The sentinel path is not writeable if you are not elevated so first run keeps happening every time. BUG=1503885 Review URL: http://codereview.chromium.org/12650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5994 0039d316-1c4b-4281-b951-d872f2087c98
* Changelist for erg's readability review.erg@google.com2008-11-253-114/+180
| | | | | | | | | | | | | | | | I am submitting BlockedPopupContainer for my C++ windows readability review. It's original code reviews are: http://codereview.chromium.org/8782 http://codereview.chromium.org/9373 http://codereview.chromium.org/10606 In addition to the above reviews, the test cases have been (re)written in: http://codereview.chromium.org/10206 http://codereview.chromium.org/9709 http://codereview.chromium.org/10282 Review URL: http://codereview.chromium.org/10618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5992 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/12434jcampan@chromium.org2008-11-251-2/+27
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5990 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for 1498134, possible crash when cancelling a url request. Thesky@google.com2008-11-252-2/+29
| | | | | | | | | | | | | | crash happened because OnReadCompleted would invoke CompleteRead which might invoke CancelRequest and delete the request. If this happened when control returned back to OnReadCompleted the request was deleted, yet ResourceDispatcherHost assumed it wasn't. BUG=1498134 TEST=none Review URL: http://codereview.chromium.org/12602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5989 0039d316-1c4b-4281-b951-d872f2087c98
* Set the delegate on incoming TabContents in ↵erg@google.com2008-11-251-3/+5
| | | | | | | | BlockedPopupContainer::ReplaceContents. Review URL: http://codereview.chromium.org/12646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5988 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the encoding menu for javascript and css files. jungshik@google.com2008-11-251-1/+4
| | | | | | | | | | BUG=3565 TEST=Open a JS or CSS file by clicking a link to it in view-source and see if the encoding menu is enabled. Review URL: http://codereview.chromium.org/12619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5982 0039d316-1c4b-4281-b951-d872f2087c98
* * Delete Desktop and Quick Lauch shortcuts in user level install case also.kuchhal@chromium.org2008-11-251-4/+3
| | | | | | | | BUG=4651 Review URL: http://codereview.chromium.org/12417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5976 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5971.maruel@chromium.org2008-11-256-142/+2
| | | | | | Review URL: http://codereview.chromium.org/12637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5974 0039d316-1c4b-4281-b951-d872f2087c98
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-256-2/+142
| | | | | | | | Add more DCHECKs. Same as r5607 except that Thread.StopSoon is fixed. Review URL: http://codereview.chromium.org/11534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5971 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash with plugin installer infobar due to the infobardelegate not being ↵ben@chromium.org2008-11-258-18/+30
| | | | | | | | | | removed from the containing TabContents. http://crbug.com/4620 Review URL: http://codereview.chromium.org/12624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5957 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the WebRequest API to consistently use std::string instead ofdarin@chromium.org2008-11-251-4/+4
| | | | | | | | | | | | | | | | | | | std::wstring for HTTP header fields The HTTP specification guarantees that all fields in the header will be ASCII and thus fit fine in a std::string. The GetHttpHeaders/SetHttpHeaders interfaces use std::string values for HTTP headers. This patch fixes GetHttpMethod(), SetHttpMethod(), GetHttpHeaderValue() and SetHttpHeaderValue() and callers to use std::string as well. Patch by James Robinson <jamesr@google.com> R=darin Review URL: http://codereview.chromium.org/12412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5955 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 5929 (r5882) with crash fix and also this change:ben@chromium.org2008-11-2518-273/+338
| | | | | | | | | | | http://codereview.chromium.org/11392/show which fixes the remainder of the UI test issues apparently. http://crbug.com/4620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5954 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of ISO-8859-9 in the character encoding menu because it's now ↵jungshik@google.com2008-11-254-13/+9
| | | | | | | | | | | | treated as an alias to its superset, windows-1254. BUG=4746 TEST=visit http://www.sabah.com.tr (ISO-8859-9 page) and make sure that 'Turkish' is checked in the encoding menu Review URL: http://codereview.chromium.org/11811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5948 0039d316-1c4b-4281-b951-d872f2087c98
* Find now uses WebKit's TextMatch highlighting for Find-in-page.finnur@google.com2008-11-241-10/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to discard a bunch of code and plumbing related to maintaining and passing around the tickmark vector. WebKit now owns the drawing of the highlights for inactive matches and we use the selection controller to draw the active highlight. I also simplified the code by eliminating the separate FindNext function, which has been merged into Find. This change also requires minor changes to WebKit upstream (sold seperately, void where prohibited). It simply consists of adding one empty virtual paint function to ScrollbarThemeComposite.h (paintTickmarks) and in ScrollbarThemeComposite::paint call paintTickmarks(). This fixes/makes obsolete a slew of bugs: BUG=1326399, 1241554,1143991, 1070190, 1023019, 984786, 893737, 868599 ... and a couple of external ones as well. Full list: 1326399 Find highlighting disappears on ThinkPad x60s 1241554 Find doesn't highlight word inside blinky tag 1143991 Have find-in-page code use skia and have inspected node highlighting set the right xfermode 1070190 Find should begin searching from caret/selection 1023019 Find not highlighting correctly 984786 Find highlight drawing code causes ClearType text to look bad 893737 Find in page should search textareas 868599 Find in page tick marks incorrectly appear on nested scrollbars 298 Find-In-page should highlight elided entries 4389 Find-in-box is not highlighting all the instances of the search word 3908 Find in page highlighting and tickmarks are broken Review URL: http://codereview.chromium.org/11364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5946 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some net/ code. Change a number of wstrings to FilePaths.estade@chromium.org2008-11-243-4/+5
| | | | | | Review URL: http://codereview.chromium.org/12409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5944 0039d316-1c4b-4281-b951-d872f2087c98
* Add a NULL channel check in CreateNPVariantParam as it can be called withananta@chromium.org2008-11-241-9/+15
| | | | | | | | | | | | | a NULL channel during renderer plugin shutdown. Fixes bug http://code.google.com/p/chromium/issues/detail?id=4740 R=jam Bug=4740 Review URL: http://codereview.chromium.org/12609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5943 0039d316-1c4b-4281-b951-d872f2087c98
* Don't save state when the page ID doesn't change.brettw@google.com2008-11-241-2/+9
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=4684 Review URL: http://codereview.chromium.org/12613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5942 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a potential memory leak with a message creation.klink@chromium.org2008-11-241-4/+3
| | | | | | Review URL: http://codereview.chromium.org/11579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5939 0039d316-1c4b-4281-b951-d872f2087c98
* Add class to encapsulate a CF Mach Message Source and handle it's liftime.jeremy@chromium.org2008-11-243-0/+131
| | | | | | | | | This class handles adding a listener on Mach port to the current CFRunloop and calling a delegate when a message is received on that port. Review URL: http://codereview.chromium.org/11331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5936 0039d316-1c4b-4281-b951-d872f2087c98
* Update scons for the unforking of the inspector resource files.ojan@google.com2008-11-241-1/+1
| | | | | | | | I didn't actually build this and see if it works, but I'll at least make sure it passes the trybots. Review URL: http://codereview.chromium.org/11378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5934 0039d316-1c4b-4281-b951-d872f2087c98
* rollbackben@chromium.org2008-11-248-97/+90
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5933 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r5882 with a crash fix.ben@chromium.org2008-11-248-90/+97
| | | | | | | http://codereview.chromium.org/11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5929 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reenter Webkit, while it waits for outgoing sync calls to complete. Thisananta@chromium.org2008-11-241-0/+4
| | | | | | | | | | | | | | fixes bug http://code.google.com/p/chromium/issues/detail?id=4582, which is a crash in the renderer process, which occurs when the renderer receives a sync message requesting accessibility information from the browser, while it waits for the PluginDestroyed sync call to unwind. The ViewMsg_GetAccessibilityInfo has a timeout associated with it, which indicates that it is ok for the call to fail. We now turn off the unblock flag on the sync message which will ensure that it does not reenter Webkit in this scenario. R=jcampan Bug=4582 Review URL: http://codereview.chromium.org/12402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5927 0039d316-1c4b-4281-b951-d872f2087c98
* * Add net_unittests and unit_tests sources that size comparisonssgk@google.com2008-11-241-1/+5
| | | | | | | | | | | | | | | revealed slipped by getting added to the SCons build: net\base\x509_certificate_unittest.cc chrome\browser\greasemonky_master_unittest.cc chrome\browser\greasemonky_slave_unittest.cc chrome\browser\template_url_prepopulate_data_unittest.cc chrome\renderer\render_widget_unittest.cc * Sort file lists. * Move net\*_unittest.cc files that don't have "win" in the base name to the to_be_ported_files lists for Linux and Mac. Review URL: http://codereview.chromium.org/11587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5925 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5882. It broke LoginPromptTest.TestBasicAuth and .TestTwoAuths.maruel@chromium.org2008-11-248-91/+83
| | | | | | Review URL: http://codereview.chromium.org/11399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5922 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base versions of the graphics headers, which previously just ↵brettw@google.com2008-11-2210-11/+11
| | | | | | | | forwarded to the skia ones. Review URL: http://codereview.chromium.org/11588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
* Add new infobar files to SCons build.sgk@google.com2008-11-222-0/+3
| | | | | | Review URL: http://codereview.chromium.org/11380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5892 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix 2.evanm@google.com2008-11-221-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5886 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evanm@google.com2008-11-221-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5885 0039d316-1c4b-4281-b951-d872f2087c98
* container_win.cc => widget_win.cc in the SCons build.sgk@google.com2008-11-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5884 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix system level check. We should check for mode conflict when we are ↵kuchhal@chromium.org2008-11-221-15/+15
| | | | | | | | | | doing an install and not for uninstall. BUG=4651 Review URL: http://codereview.chromium.org/11365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5883 0039d316-1c4b-4281-b951-d872f2087c98
* This change makes the following infobars use the new system:ben@chromium.org2008-11-228-83/+91
| | | | | | | | - save password Review URL: http://codereview.chromium.org/11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5882 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r5252 temporarily to see if it is related to thewtc@google.com2008-11-221-10/+1
| | | | | | | | | | crash in ResourceDispatcherHost::OnReadCompleted. R=eroman BUG=b/1498134 Review URL: http://codereview.chromium.org/11584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5881 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-2211-73/+69
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
* * Add support for verbose-logging option in master preferences file.kuchhal@chromium.org2008-11-224-2/+19
| | | | | | | | BUG=1497924 Review URL: http://codereview.chromium.org/11369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5879 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia extensions from the port to skia/ext for Windows only. Fixed thebrettw@google.com2008-11-211-1/+0
| | | | | | | | include guards of the moved files, but nothing else. Review URL: http://codereview.chromium.org/11568 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5861 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2008-11-211-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5858 0039d316-1c4b-4281-b951-d872f2087c98
* Beginnings of a new InfoBar system.ben@chromium.org2008-11-2115-25/+989
| | | | | | | | | | This implements AlertInfoBar and InfoBarContainer. It also makes the crashed plugin/js oom infobars use this new system. Design Doc: http://dev.chromium.org/developers/design-documents/info-barshttp://crbug.com/4620 Review URL: http://codereview.chromium.org/11318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5856 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at this fix. I hit after my patch. The problem appears to besky@google.com2008-11-212-6/+8
| | | | | | | | | | | | | | that it is possible for browser list to return a browser with no window/tabs. This is possible depending upon timing of these. I'm moving the checks into the session service. BUG=4666 TEST=no direct way to test this as its rather random. But make sure you don't encounter any problems with session restore. Review URL: http://codereview.chromium.org/11362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5855 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few leaks in SafeBrowsing. These have been around since the ↵erikkay@google.com2008-11-214-8/+76
| | | | | | | | beginning, but have been hit by a particular pattern that's being sent down by the SB servers recently.BUG=http://code.google.com/p/chromium/issues/detail?id=4522 Review URL: http://codereview.chromium.org/11336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5854 0039d316-1c4b-4281-b951-d872f2087c98
* Base class for setup's html dialogscpu@google.com2008-11-213-13/+291
| | | | | | | | | | | | | | - Couple of things unimplemented to keep the review at a reasonable size - Will be used for a derived EULADialog class - Will be used for the inactive user toast annoy-a-tron - Will be used to warn user of products that conflict with chrome BUG=1468838 BUG=1484308 Review URL: http://codereview.chromium.org/11552 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5853 0039d316-1c4b-4281-b951-d872f2087c98
* Add a manifest to chrome.exe because we need thatnsylvain@chromium.org2008-11-213-1/+17
| | | | | | | | | | to pass the OEM Ready tests. bug:1496104 Review URL: http://codereview.chromium.org/11330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5851 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback "Remove use of wide characters in stats table identifiers."evanm@google.com2008-11-215-29/+29
| | | | | | | This reverts commit r5847. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5850 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Container->Widgetben@chromium.org2008-11-21107-701/+663
| | | | | | | | | R=erg review url = http://codereview.chromium.org/11348/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/common to Linux.evanm@google.com2008-11-216-36/+25
| | | | | | | | | | BUG=3649 Review URL: http://codereview.chromium.org/10255 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5848 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-215-29/+29
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where NTP metrics for restored tabs weren't getting recorded ↵glen@chromium.org2008-11-212-4/+1
| | | | | | | | | | correctly. BUG=4668 Review URL: http://codereview.chromium.org/11356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5846 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 21:15:58 +0000