| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL includes:
1. Implementation of ui_test_utils_mac.mm
2. Fix for ui_controls_mac.mm
3. Port browser_keyevents_browsertest.cc to Mac and add some new tests for Mac.
4. Partially port browser_focus_uitest.cc to Mac, now can be compiled and run
on Mac but some tests fail.
5. Add two functions into ui_test_utils.h: HideNativeWindow() and
ShowAndFocusNativeWindow(). The latter one shows a window and grabs the input
focus, which is useful for tests depending on fake keyboard/mouse events.
Because browser_keyevents_browsertests.cc and browser_focus_uitest.cc
belong to interactive_ui_tests, which is not available on Mac (see
http://crbug.com/21276), in order to test them on Mac, you may want to
move them into browser_tests locally. But it won't work on build and try
bots, because these tests must be run with screen unlocked.
This CL depends on CL: http://codereview.chromium.org/2973004
and http://codereview.chromium.org/2805075
BUG=22515 Keyboard handling needs unit tests
BUG=48671 interactive_ui_test: BrowserKeyEventsTest.NormalKeyEvents is flaky
BUG=48936 Browser window is opened inactivated when running an InProcessBrowserTest.
TEST=none
Review URL: http://codereview.chromium.org/2986004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47883
TEST=manual (turning network connection off and on)
Review URL: http://codereview.chromium.org/2809056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Add menu item with shortcut cmd-f10 for now, connect it to -commandDispatch:. Connect app controller's new outlet to the new menu item.
BUG=50307
TEST=No changes by default. If --enable-expose-for-tabs is passed, a new menu item should be visible below "prev tab" in the window menu. It should be active for normal browser windows and fullscreen windows, but not if there are no browser windows around or if the current window is a popup window or a non-browser window (e.g. prefs). Clicking the menu item doesn't do anything yet. cmd-f10 should trigger the menu item, but it shouldn't if the cmdline flag isn't passed.
TEST2=Go to a page that is busy spinning some javascript (e.g. "javascript:while(1);"), give it focus, hit cmd-f10. Menu should blink immediately.
Review URL: http://codereview.chromium.org/3020035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
experiment (then set to [4, 6, 8, 16] connections -- see http://codereview.chromium.org/2658006). Overall, 16 connections did not compare favorably to either 6 or 8 connections. At this point we'd like to modify and narrow down our range to span 5 to 9 connections.
r=jar
BUG=44491
Review URL: http://codereview.chromium.org/3077001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The fact that we have this weird vestigal "Default" directory
is really confusing. :(
Review URL: http://codereview.chromium.org/3014028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
alphabetization. Note that the F1 key is the "Back" key on Chrome OS,
and F2 is "Forwards".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2878059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing the most simple eliding, which is to truncate and replace with
ellipses on a character basis. I put this in the code rather than the
.xib because this seems like it should be a hard-wired Omnibox
behavior.
BUG=50253
TEST=Put in a very long URL and check that it elides as the window gets too small for it to fit. You can easily craft long URLs by adding # and filling with whatever you desire after that.
Review URL: http://codereview.chromium.org/3010031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands.
BUG=None.
TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled.
Review URL: http://codereview.chromium.org/3026025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20504
TEST=greener valgrind
TBR=evan@chromium.org,mark@chromium.org
Review URL: http://codereview.chromium.org/3020036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
download directory.
BUG=4994
TEST=none
Review URL: http://codereview.chromium.org/3043024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A field of the ViewHostMsg_Resource_Request structure was uninitialized.
Also, includes a fix for an ASSERT_EQ that listed the expected value second
instead of first.
R=oshima
BUG=50002
TEST=none
Review URL: http://codereview.chromium.org/3052014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fails on all platforms, not just Mac.
BUG=48148
Review URL: http://codereview.chromium.org/3036022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
update. The strings being removed are all unused and were not added recently.
BUG=none
TEST=Ideally, this will not cause test failures on Windows. This change is
actually the TEST= of a build tool upgrade.
Review URL: http://codereview.chromium.org/3064011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=try
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make the code more object-oriented, make the object expose less accessors
- make some parts of code look more obvious, use existing helpers
- make the public interfaces slightly better (less ctor parameters)
- make some names slightly better
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3029025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49091
TEST='Manage' button in DOMUI Basics prefs should bring up an empty sub-page.
Review URL: http://codereview.chromium.org/2806081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR: arv
BUG=49328
TEST=no bookmark bar promo on first run to empty profile. or ever.
Review URL: http://codereview.chromium.org/3053015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=29675
TEST=none
TBR=evan@chromium.org,willchan@chromium.org
Review URL: http://codereview.chromium.org/2884041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative/defensive fix for bug 49274.
BUG=49274
TEST=manual (checked that this didn't break normal behavior)
Review URL: http://codereview.chromium.org/3054018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50307
TEST=none
Review URL: http://codereview.chromium.org/3020034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
insertions and deletions.
BUG=none
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/3039029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3026016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--host-rules seems like a reasonable enough substitute for these two command line flags, and removing them will simplifies the fairly complicated URL rewrite logic in HttpNetworkTransaction.
BUG=None
TEST=built and ran net_unittests
Review URL: http://codereview.chromium.org/3041019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, increase login timeout.
BUG=None
TEST=unit tests
Review URL: http://codereview.chromium.org/3061019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch is 99% the same as spotrh's version (thanks spot!) except
for the use of gfx::kNullPluginWindow in this version.
BUG=49533
Review URL: http://codereview.chromium.org/3014034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
encoding menu on those pages.
BUG=48157
TEST=On the NTP, Wrench menu --> Tools --> Encoding is disabled. On normal web pages, it isn't.
Review URL: http://codereview.chromium.org/3027023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add "MainMessageLoopStart()" and related platform methods to handle tasks
directly tied to the start of the main message loop.
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/2931007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
closes.
Review URL: http://codereview.chromium.org/3043020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL http://codereview.chromium.org/3026006
Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.
BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.
Review URL: http://codereview.chromium.org/3064002
TBR= nkostylev@chromium.org
Review URL: http://codereview.chromium.org/2878056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port magic from GTMFadeTruncatingTextFieldCell to Chrome's GradientButtonCell, used by buttons in the bookmark bar. Any button that inherits from this class will now get overflowing titles truncated with a nice gradient (same as tab titles), rather than the default ellipsis.
Using GTMFadeTruncatingTextFieldCell in this case wasn't feasible because bookmark buttons are subclasses of NSButtonCell and already use a bunch of specialized behavior provided by it.
BUG=45104
TEST=Add a bookmark to the bookmark bar and increase the length of it's title. Once you get past a certain length, rather than truncate the title should fade out nicely. Exactly in the same way long tab titles do. Bookmark buttons with titles that aren't truncated should look exactly the same. Also test with Dolce & Gabbana theme which has inverted contrast.
Review URL: http://codereview.chromium.org/2806066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Tests that use a regular PrefService are green.
Review URL: http://codereview.chromium.org/3046023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add test register form page.
Added extra debug logging.
Full cycle:
1. Register screen navigates to chrome://register (host page).
2. host page requests DOMUI for register form URL: getRegistrationUrl msg on DOM load event.
3. Once URL is received it is loaded in an iframe.
4. When register form is loaded it sends get_user_info msg via postMessage to host page.
5. host page requests DOMUI for system/user info: getUserInfo msg.
6. Once info is received host page sends that to an iframe with set_user_info msg.
7. Register form notifies host page on registration success/skip status with complete_registration msg.
8. Based on registration result host page navigates to cros://register/[success|skipped] so that Out of box wizard is notified.
BUG= http://crosbug.com/4813
TEST=manual
Review URL: http://codereview.chromium.org/3058006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
swap Alt/Ctrl keys and Search/Ctrl keys.
BUG=chromium-os:2636
TEST=manually on eeepc
Review URL: http://codereview.chromium.org/3038025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several integration tests use the wrong method to wait for sync to complete, as a result of which they fail during verification.
Also making the condition for the detection of sync completion more robust.
BUG=50114
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3037019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=confirmed that the layout names added in generated_resource.grd appear in the languages and input dialog. also confirmed that error messages are gone from logs.
BUG=chromium-os:3440
Review URL: http://codereview.chromium.org/3063007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser connected to the renderer. This basically
meant that if the browser process exited then other popups could not query cookies from the host.
Part of the fix for http://b/issue?id=2277519
Bug=2277519
Review URL: http://codereview.chromium.org/3066004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move utility functions into a header file (currently chewing and pinyin
are the customers).
TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4808
Review URL: http://codereview.chromium.org/3015028
Patch from Takayoshi Kochi <kochi@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2636
TEST=manually on eeepc, ran the browser_tests
Review URL: http://codereview.chromium.org/2806077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use EncoderZlib / DecoderZlib as default encoder and decoder.
BUG=50246
Review URL: http://codereview.chromium.org/3034035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not be misleading (e.g. "depressed" where it should be "disabled"). Better indenting. Inline a function that has only one caller for simplicity.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3029032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless).
BUG=50107
TEST=Throbber responds to theme changes
Review URL: http://codereview.chromium.org/3064006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Nicer indenting.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, the language name and the input method list were
hard-coded in the HTML file. With this change, these values will be
displayed based on the underlying data from C++ world.
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3008016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change.
Make naming for theme and locale changes consistent and clear.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/2878055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add boilerplate line for experimental api pages
BUG=48582
TEST=NONE
Review URL: http://codereview.chromium.org/2881038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are out-of-date -- the normal images no longer have white backgrounds, and we don't need an extra "transparent" set.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3075001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50107
TEST=Resize gripper nest to browser actions container should no longer appear
Review URL: http://codereview.chromium.org/3052011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/3028018 on behalf of zbehan@.
third_party: add a stub cros directory and cros_api.gyp for libcros to satisfy gyp depdendencies
cros: fix more of the third_party includes, forbid similar includes for future
BUG=none
TEST=make sure both chrome and chromeos builds are happy.
TBR=zelidrag
Review URL: http://codereview.chromium.org/3035021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53729 0039d316-1c4b-4281-b951-d872f2087c98
|