summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Merge in part of the last perf change. Move when we initializetony@chromium.org2009-11-242-20/+24
| | | | | | | | | | | | | | | the CSS/HTML for the NTP. This should allow the history query to happen sooner. Move the first_view logic out of NewTabHTMLSource. It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated. Also make sure we only hang on to the original profile. I think the incognito profile can be deleted out from under us when the last incognito window is closed. Review URL: http://codereview.chromium.org/434038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32965 0039d316-1c4b-4281-b951-d872f2087c98
* Partially reverting 32942apatrick@google.com2009-11-241-5/+0
| | | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32964 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the nonclientframeview for popups on views/gtk drawsky@chromium.org2009-11-241-1/+50
| | | | | | | | | | | | nothing. This is needed as we want the window manager rendering the decorations. BUG=none TEST=none Review URL: http://codereview.chromium.org/436026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32963 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a doc link.kathyw@google.com2009-11-242-2/+2
| | | | | | | | | | BUG=28529 TEST=none TBR=aa Review URL: http://codereview.chromium.org/435025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32961 0039d316-1c4b-4281-b951-d872f2087c98
* Sleep briefly before/after printing page cycler results.chase@chromium.org2009-11-241-0/+4
| | | | | | | | | | | | | | | Speculative fix to address bad perf results for reference build. An error message that's being printed at the same time as the test results is believed to be causing the graphing code to incorrectly read those results. BUG=none TEST=sane linux morejs reference graph result Review URL: http://codereview.chromium.org/437024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32954 0039d316-1c4b-4281-b951-d872f2087c98
* Branched gpu process and command buffer code into Chrome tree. Fixed up ↵apatrick@google.com2009-11-241-0/+5
| | | | | | | | | | | paths and other minor changes to make it work in the Chrome tree. Will remove copy from O3D tree shortly. Only works in Windows currently. TEST=none BUG=none Review URL: http://codereview.chromium.org/436017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32952 0039d316-1c4b-4281-b951-d872f2087c98
* Update Signal Thread to use ref counting and locks to ensure thread safety.zork@chromium.org2009-11-242-2/+3
| | | | | | Review URL: http://codereview.chromium.org/418042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32948 0039d316-1c4b-4281-b951-d872f2087c98
* Document the maximum # of characters for the name andkathyw@google.com2009-11-242-2/+6
| | | | | | | | | | | description fields. BUG=28664 TEST=none TBR=nickbaum Review URL: http://codereview.chromium.org/436027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32946 0039d316-1c4b-4281-b951-d872f2087c98
* Disables default browser check and exit menu for toolkit_views onsky@chromium.org2009-11-244-3/+17
| | | | | | | | | | | chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/431029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32942 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Switch "Save" and "Discard" buttons on dangerous download warning.thakis@chromium.org2009-11-241-533/+43
| | | | | | | | | | | | | "Ok" buttons are always on the right on OS X. Nib change: I only switched the two buttons. BUG=28638 TEST=Download a dmg, confirm "Save" botton is on the right. Review URL: http://codereview.chromium.org/438019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32939 0039d316-1c4b-4281-b951-d872f2087c98
* Sets widget created by info bubbles to a custom type so that theysky@chromium.org2009-11-242-0/+14
| | | | | | | | | | | don't get a drop shadow and centered on screen. BUG=none TEST=none Review URL: http://codereview.chromium.org/431021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32936 0039d316-1c4b-4281-b951-d872f2087c98
* Switch theme loading to use its own string.avi@google.com2009-11-244-6/+8
| | | | | | | | | BUG=http://crbug.com/24177 TEST=no visible change Review URL: http://codereview.chromium.org/361006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32934 0039d316-1c4b-4281-b951-d872f2087c98
* Update pages that reference the gallery to link to the gallery.kathyw@google.com2009-11-2410-14/+38
| | | | | | | | | | | Also a few wording changes. TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/437027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32931 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: improve hover/clicked state appearance of bookmark bar buttons.viettrungluu@chromium.org2009-11-241-33/+56
| | | | | | | | | | | | | I more or less implemented things as per discussion with Cole and Glen. (This does not re-create the appearance on Win Chrome, which is not exactly right either.) BUG=28477 TEST=Load various themes (in particular, "Karim Rashid") and make sure bookmark bar buttons look good and legible in hover and pressed states. Review URL: http://codereview.chromium.org/440001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32930 0039d316-1c4b-4281-b951-d872f2087c98
* Reduced the size of images in the debugging tutorial so they'llkathyw@google.com2009-11-2416-32/+34
| | | | | | | | | | | | load faster, and not take so much space visually. TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/434037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32929 0039d316-1c4b-4281-b951-d872f2087c98
* disable extension toolstrips by default, addingerikkay@chromium.org2009-11-245-5/+17
| | | | | | | | | | | --enable-extension-toolstrips BUG=24475 TEST=Extension*Toolstrip* Review URL: http://codereview.chromium.org/434026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to prevent selecting a popup menu item from crashing when the item is ↵avi@google.com2009-11-241-2/+5
| | | | | | | | | | | auto-opened. BUG=http://crbug.com/28215 TEST=as in bug Review URL: http://codereview.chromium.org/431019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32925 0039d316-1c4b-4281-b951-d872f2087c98
* One of the views was extending off the side of the window, simple fix while ↵thomasvl@chromium.org2009-11-241-2/+9
| | | | | | | | | | I sort out better sizing with some of the other changes needed. TEST=see bug BUG=28410 Review URL: http://codereview.chromium.org/437037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32922 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce DLOG in websocket codeukai@chromium.org2009-11-242-31/+1
| | | | | | | | | BUG=28657 TEST=none Review URL: http://codereview.chromium.org/440005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32919 0039d316-1c4b-4281-b951-d872f2087c98
* Move base64 from 'net/base' into 'base'.hayato@chromium.org2009-11-2412-25/+23
| | | | | | | | | BUG=13572 TEST=none Review URL: http://codereview.chromium.org/399068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Restore omnibox text selection on tab switch.derat@chromium.org2009-11-242-12/+5
| | | | | | | | | | | | | | | | | Tested by: - highlighting omnibox text - switching to a different tab - highlighting some other text - switching back to the first tab - confirming that the omnibox highlighting was restored but PRIMARY didn't get updated when switching back BUG=20674 TEST=see above Review URL: http://codereview.chromium.org/440003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32914 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 256.0 to 257.0chrome-bot@google.com2009-11-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32908 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move the NTP HTML generation to early so we can avoid an extra"tony@chromium.org2009-11-243-23/+20
| | | | | | | | | | | | | It caused New Tab Warm on Windows to regress to the speed before adding the cache on Windows. This reverts commit r32899. TBR=arv Review URL: http://codereview.chromium.org/431024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32906 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Create app modal dialogs in a different way to work around a KDE 3 ↵thestig@chromium.org2009-11-2411-7/+33
| | | | | | | | | | window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows. BUG=28230 TEST=see bug Review URL: http://codereview.chromium.org/425016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32905 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a TODO in post_commit_command.cc. Clarify what's going on.nick@chromium.org2009-11-241-3/+4
| | | | | | Review URL: http://codereview.chromium.org/431023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32904 0039d316-1c4b-4281-b951-d872f2087c98
* Move the NTP HTML generation to early so we can avoid an extratony@chromium.org2009-11-243-20/+23
| | | | | | | | | | | | | trip to the UI thread later. Not sure if this will make a difference. Move the NTP and CSS handler init to after adding the MostVistedHandler. This should allow an earlier db fetch for the cases when the HTML/CSS are not in the cache (e.g., browser startup). Review URL: http://codereview.chromium.org/439013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes extension packing codepath that was hitting a race condition DCHECK ↵andybons@chromium.org2009-11-243-0/+8
| | | | | | | | | | described in http://crbug.com/27944. BUG=28530 TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash. Review URL: http://codereview.chromium.org/436008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32898 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame's host network stack implementation for IE full tab mode ↵ananta@chromium.org2009-11-241-14/+6
| | | | | | | | | | | | | | | | | | | | | | | | implicitly follows redirects. When Chrome receives a notification about a redirect it also attempts to follow the redirect request. While this works in most cases, some sites actually returned an error for the second request initiated by Chrome. Fix is to abort the request in urlmon, when we receive a notification about a redirect. I also fixed the IsRedirectResponse function in the UrlRequestAutomationJob class to only treat 301, 302, 303 and 307 as redirect codes on the same lines as the default http job. Test=covered by existing network tests. I also verified that http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL. Fixes http://code.google.com/p/chromium/issues/detail?id=28296 Bug=28296 Review URL: http://codereview.chromium.org/402107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32896 0039d316-1c4b-4281-b951-d872f2087c98
* Final part of PathString cleanup.munjal@chromium.org2009-11-2423-392/+295
| | | | | | | | | BUG=26342 TEST+exist Review URL: http://codereview.chromium.org/429003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32894 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show --help on ChromeOS.thestig@chromium.org2009-11-241-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/437030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32893 0039d316-1c4b-4281-b951-d872f2087c98
* Added main menu item for Sync in OS X. (Right below "Preferences..."). Made ↵akalin@chromium.org2009-11-2413-152/+340
| | | | | | | | | | | | | it work without a browser window being present. Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}. BUG=27995 TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in. Review URL: http://codereview.chromium.org/423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when an extension popup shows a JS alert. Showing the alert takes...rafaelw@chromium.org2009-11-245-39/+76
| | | | | | | | | | | | | | | | Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show. Disable showing JS alerts from popups, because doing so makes the popup disappear immediately, which has all sorts of unfortunate side effects for the poor orphaned alert (see bug for details). BUG=27758 TEST=create extension with popup, put link with |onclick="alert('test');"| in it; install extension, open popup, and click link; see no crash (nor popup) Review URL: http://codereview.chromium.org/435010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
* page info dialog polish:estade@chromium.org2009-11-233-9/+8
| | | | | | | | | | | | | | GTK: - set default size of contents, rather than window as a whole---this gets line wrapping right. All: - change title string to Title Case instead of Sentence case - fix Connection text for mixed/unsafe content BUG=28507 Review URL: http://codereview.chromium.org/437026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32887 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ResourceBundle::LoadImageResourceBytes since it appears totony@chromium.org2009-11-237-8/+8
| | | | | | | | | be identical to LoadDataResourceBytes. Migrate callers to LoadDataResourceBytes. Review URL: http://codereview.chromium.org/437019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
* Moved common OpenSyncMyBookmarksDialog() code into SyncStatusUIHelper.akalin@chromium.org2009-11-235-29/+32
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32880 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux packaging options more granular.mmoss@chromium.org2009-11-232-102/+279
| | | | | | | | | This allows us to not waste time building packages/channels we don't care about. Also added option to build new 'trunk' channel packages, which are a special configuration for developer testing. Review URL: http://codereview.chromium.org/418021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32879 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the ExtensionApiTest.ExecuteScript test as flaky as it failed for no ↵ananta@chromium.org2009-11-231-1/+3
| | | | | | | | | | | | | | | | apparent reason on the vista dbg builder. Issue http://code.google.com/p/chromium/issues/detail?id=28630 has been logged to track this. TBR=aa Bug=28630 Review URL: http://codereview.chromium.org/432010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32866 0039d316-1c4b-4281-b951-d872f2087c98
* Disable these only on linuxtim@chromium.org2009-11-231-4/+15
| | | | | | | | | TBR=levin BUG=28445 Review URL: http://codereview.chromium.org/437021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32865 0039d316-1c4b-4281-b951-d872f2087c98
* Disable more tests causing crashes and failures on LinuxTest(dbg) and ↵tim@chromium.org2009-11-231-3/+8
| | | | | | | | | | | valgrind (respectively). TBR=levin BUG=28445 Review URL: http://codereview.chromium.org/438007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32862 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new icon.aa@chromium.org2009-11-231-0/+0
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix environment variables not being used after switching to ↵jam@chromium.org2009-11-233-7/+8
| | | | | | | | | | ChildProcessLauncher. BUG=28602 TEST=verified flash works on Mac Review URL: http://codereview.chromium.org/439005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32854 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension updates use omaha id when talking to omaha.asargent@chromium.org2009-11-233-1/+145
| | | | | | | | | | BUG=b/2168147 TEST=Extensions auto-updates should still work. Review URL: http://codereview.chromium.org/403026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32853 0039d316-1c4b-4281-b951-d872f2087c98
* Removed browser owned by HtmlDialogWindowController. This fixes the crashakalin@chromium.org2009-11-232-28/+48
| | | | | | | | | | | | | | | | | | described in issue 28329. Use a non-incognito profile for HTML dialogs and any links launched from them. This diverges from the behavior on Windows, but according to beng this is okay. Made it so that HTML dialog boxes don't keep history. BUG=28329 TEST=made sure there is no crash when closing the browser with the sync setup wizard open Review URL: http://codereview.chromium.org/416004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32851 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all ErrorPage tests as FLAKY.phajdan.jr@chromium.org2009-11-231-75/+21
| | | | | | | | | | | | | | | It's a race condition which used to manifest more frequently on XP, but in fact it exists on all platforms. People started adding even more #ifdefs and things when tests failed on Linux too, so let's just say they're all flaky. :-( TEST=none BUG=22877 Review URL: http://codereview.chromium.org/437016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32849 0039d316-1c4b-4281-b951-d872f2087c98
* The appcache system uses two threads, an IO thread and a DB thread.michaeln@google.com2009-11-234-16/+58
| | | | | | | | | | | | | | | It does not create these threads, the embedder is responsible for providing them to the appcache library by implementing the class declared in appcache_thread.h. Also in this CL are two implementations, one for Chrome and another for test_shell. TEST=none BUG=none Review URL: http://codereview.chromium.org/409005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32846 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted cleanup.estade@chromium.org2009-11-2315-61/+34
| | | | | | | | process: grep for TODO(port), find cruft, clean it up Review URL: http://codereview.chromium.org/427004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
* Add platform abstraction for simple error box, and use it in a couple ↵estade@chromium.org2009-11-2311-57/+46
| | | | | | | | | | | | extensions-related places. Also add a virtual destructor in some unrelated infobar. BUG=27691 Review URL: http://codereview.chromium.org/427002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32840 0039d316-1c4b-4281-b951-d872f2087c98
* Add a label member to the FormField class. This member will hold the value ↵jhawkins@chromium.org2009-11-232-14/+36
| | | | | | | | | | of the field's label once we parse this value from the DOM. BUG=none TEST=none Review URL: http://codereview.chromium.org/418032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32834 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug when accessing g_browser_process->broker_services() at shutdown.jam@chromium.org2009-11-236-22/+38
| | | | | | | BUG=28501 Review URL: http://codereview.chromium.org/435001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32832 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing GCC 4.4 build fix (landing a patch for hbono)ian@chromium.org2009-11-231-1/+1
| | | | | | | | | | | | | | This patch was written by hbono, landing for him as he can't land this until tomorrow, and it's a patch to fix a build. Reviewed at http://codereview.chromium.org/414025 BUG=none TEST=GCC 4.4 compiles Review URL: http://codereview.chromium.org/436003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32829 0039d316-1c4b-4281-b951-d872f2087c98