| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
kimworking@gmail.com, r=me; see http://codereview.chromium.org/28302 .
BUG=7690
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes build break by including FFmpeg dependency for media project in chrome.sln.
This is a second attempt at committing the following changelists:
http://codereview.chromium.org/39295
http://codereview.chromium.org/28165
TBR=darin
Review URL: http://codereview.chromium.org/42029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is very similar to r10845, but also includes a regression fix for issue 8410, where locking and unlocking the screen would cause mispositioning of child content.
BUG=20,8410
Review URL: http://codereview.chromium.org/42027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix >80 cols lines.
Review URL: http://codereview.chromium.org/42013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename FocusLocation to SetFocus (and don't make it select all).
This matches the Windows style more closely.
- Implement SetUserText (basically copied from Windows w/ a TODO).
- Switch to the gtk_accel APIs instead of using the widget ones.
- Hookup FocusSearch (and its ctrl-k accelerator).
- Hookup AcceptInput (the go button now works!).
- Fix lack of space before {
- Rename edit_view_ to location_entry_ to match the Windows LocationBarView.
- Don't plumb FocusLocationBar through BrowserWindow -> BrowserToolbar.
Review URL: http://codereview.chromium.org/43025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add Linux-specific files:
* third_party/xdg_user_dirs/xdg_user_dir_lookup.cc
* browser/gtk/download_item_gtk.{cc,h}
* browser/gtk/download_shelf_gtk.{cc,h}
* browser/tab_contents/render_view_context_menu_gtk.{cc,h}
* Don't exclude too many browser/download/* files on Linux.
* Remove browser/download/save_page_model.{cc,h}.
* Exclude Windows-specific browser/download/download_{exe,util}.cc.
* Make test/unit/run_all_unittests.cc part of the test_support library.
* Remove duplicate test/ui_test_utils.{cc,h} (moved to test_support).
* Exclude test/automation/window_proxy.{cc,h} on non-Windows systems,
but only exclude the rest of test/automation/*.{cc,h} on Mac.
* Remove left-over test/automation/window_proxy exclusion from the
'ui_tests' target (they're now in the 'test_support' target).
Review URL: http://codereview.chromium.org/40328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
want to see how useful this is before I expand it to other logging
areas (like timers).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/41022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/38009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix files with lines > 80 cols. Part 2.
Review URL: http://codereview.chromium.org/40226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
All files should now end in only a single newline.
Review URL: http://codereview.chromium.org/42010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is a new file committed in r11323, adding a proper copyright header.
Review URL: http://codereview.chromium.org/43013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This implements some beginning functionality of "omnibox". It uses GtkTextView for a rich text edit for the location bar. Color emphasis, inline autocomplete, and the results popup work. You can select one of the omnibox results using the keyboard. Mouse selection doesn't work. The results popup code will have to be scraped and reimplemented with cairo / pango.
BUG=8236
Review URL: http://codereview.chromium.org/40013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=8546
Review URL: http://codereview.chromium.org/43010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Console Debugger when user clicks Debug JavaScript. This is a temporary solution and we will get rid of this flag as well as of debugger console when developer tools implement all their functionality.
Review URL: http://codereview.chromium.org/39259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
That flag has been replaced in functionality by --renderer-cmd-prefix.
Review URL: http://codereview.chromium.org/41021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
delegate to avoid
crashing because of not cleaning up.
http://crbug.com/8573
Review URL: http://codereview.chromium.org/40326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Got app and unit_tests linking with gyp under windows.
Still missing pieces (things don't run).
Review URL: http://codereview.chromium.org/39319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
now.
Remove some stupid code in the Tab's mouse pressed handler that was duplicating the nc-hittest handler. o_O.
http://crbug.com/8519
Review URL: http://codereview.chromium.org/41018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashes. This is the code to set and maintain the URL, but we're not
using it anywhere yet.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/39202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Misc cleanup:
- remove duplicate comments on Extension accessors
- remove useless function in ExtensionsService
Review URL: http://codereview.chromium.org/39285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8321
TEST=Open the option panel, under minor tweaks, the autofill text next to the check-box should say "Save text from forms to make them easier to fill out"
Review URL: http://codereview.chromium.org/41016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Somehow it was not compiling in non-debug anymore because of a this being used in the initializer without the right warning removed macro.
BUG=None
TEST=Visit a bad HTTPS page, make sure interstitial still shows and works properly.
Review URL: http://codereview.chromium.org/41015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changed, so that spellcheck language falls back to default.
Issue=7811
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/41002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
restore the maximized state. The problem was we were using a boolean
when we really needed three values: use the default, explicitly
maximized or explicitly normal.
I'm also removing a bogus DLOG in info_bubble.
BUG=7930
TEST=see bug
Review URL: http://codereview.chromium.org/40306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Small fix to get them to display (need to include webkit strings in our
language pak files).
Review URL: http://codereview.chromium.org/39296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that created it, but if a tab contained a download shelf and was
dragged to a new window the ResizeCorner would be referencing the
wrong BrowserView. I've changed the code to look up the ancestor
BrowserView as necessary.
BUG=8477
TEST=see bug
Review URL: http://codereview.chromium.org/41010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
drag then release was broken. It appears that TPM_RIGHTBUTTON
disallows this behavior.
BUG=8560
TEST=see bug
Review URL: http://codereview.chromium.org/41006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a PasswordManagerTableModelObserver to listen for row count change events.
PasswordManagerView and PasswordManagerExceptionsView are listening to the
event.
Move the |instance_| variable from static global to the respective class to
avoid future misuse of the variable.
Review URL: http://codereview.chromium.org/39313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting build bustage
Review URL: http://codereview.chromium.org/40315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Navigate to bad https URL, make sure interstitial page still shows up and works as expected.
Review URL: http://codereview.chromium.org/40311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageEvent object to the onmessage handler.
Also adding support for origin and target parameters. The origin parameter is
implicit but target can be specified when calling postMessage. If no target
is specified we default to "*".
At the moment I'm only allowing target == "*" messages to pass through since
I haven't implemented support for matching more complicated patterns :)
Review URL: http://codereview.chromium.org/40128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Far from complete but sending early to sync with others.
Review URL: http://codereview.chromium.org/40258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Exclude .m and .mm files on non-Mac platforms.
* browser/autocomplete/edit_drop_target.{cc,h} are gone.
* browser/gtk/browser_toolbar_view_gtk.{cc,h}
=> browser/gtk/browser_toolbar_gtk.{cc,h}
* Target 'browser' needs net_resources.h to build on Linux.
* Exclude to-be-ported browser/debugger files on Linux.
* Comment out url_request_mock_http_job.cc in test_support.
(It really belongs there, but it's currently used by
production code in automation_provider.cc, so leave
it there for now, with appropriate comments.)
Review URL: http://codereview.chromium.org/39350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
domain security policy enforcement.
This copy of DOM checker was fetched from:
http://lcamtuf.coredump.cx/dom_checker/
Some values in dom_config.js have been changed. There have been no other
modifications.
In order to automate this test, there will need to be a few more small changes.
To more easily see what changes have been made for Chromium, I'm first checking
in a clean copy.
BUG=6274
Review URL: http://codereview.chromium.org/40234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
here is we fail to create the file, and so current_session_file_.get()
is NULL and we crash. current_session_file_.get() is NULL if
OpenAndWriteHeader returns NULL (which is does if the full header
isn't written correctly.
Here's how I'm changing the code:
. The file is now truncated instead of closed/reopened. Hopefully this avoids the possibility of a scanner locking the file and the delete failing.
. Added a unit test for coverage of truncation.
. The file is opened in exclusive access. There is no reason why a scanner should open this file.
. Added null checks.
BUG=8476
TEST=none
Review URL: http://codereview.chromium.org/39275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
automation calls.
BUG=5671
Review URL: http://codereview.chromium.org/40301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the following methods to WebKitClient:
decrementStatsTable
incrementStatsTable
traceEventBegin
traceEventEnd
The implementation of initV8CounterFunction is now a no-op. V8Proxy.cpp no
longer calls it, and I moved the corresponding work out of WebKit. The
embedder now calls the appropriate V8 API before initializing WebKit.
Includes some cleanup to WebString and WebCString. I decided that I prefer
"data" over "characters" since the latter may be confusing in some cases. For
example, the elements of a WebString or WebCString may not be individual
characters but may be part of a character. "data" is also consistent with
basic_string<T> and so should be plenty familiar.
There is wanton disregard for the Chrome+JSC build in this CL, but that's
OK. We have already crossed that bridge.
R=dglazkov
Review URL: http://codereview.chromium.org/39288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Packages are manually generated now (run ./build.sh after a successful static build), but will be integrated into the main build system soon.
Review URL: http://codereview.chromium.org/39088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- used string16 instead of wstring where needed
- replaced GetTickCount calls with portable functions from base/time.h
- misc GCC cleanups
- enabled following unit tests on Linux:
browser/autocomplete/history_contents_provider_unittest.cc
browser/autocomplete/history_url_provider_unittest.cc
browser/autocomplete/keyword_provider_unittest.cc
browser/bookmarks/bookmark_html_writer_unittest.cc
Review URL: http://codereview.chromium.org/39335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=wtc,darin,huanr
Review URL: http://codereview.chromium.org/40138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test simulates following scenario: user opens a local html page with Chrome when a browser instance is already running. The new Chrome process should notify the existing process about new page and exit. Bug 7900 broke this behavior causing the new process to crash.
I verified that the ui_tests infrastructure would catch this crash and cause the test to fail.
BUG=7900, 8056
Review URL: http://codereview.chromium.org/39257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11247 0039d316-1c4b-4281-b951-d872f2087c98
|