summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Remove our only use of dynamic_cast, which is not needed.deanm@chromium.org2009-04-081-1/+1
| | | | | | | | | | | We don't want to ever use RTTI. This was casting a WebContents to a TabContents, which is a simple and safe upcase, since WebContents derives from TabContents. It should have just been a static_cast. Review URL: http://codereview.chromium.org/62147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13350 0039d316-1c4b-4281-b951-d872f2087c98
* Added restore and add tab to the system menu so that these operationsidanan@chromium.org2009-04-082-3/+15
| | | | | | | | | | can be done from there. BUG=2144 Review URL: http://codereview.chromium.org/62113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13348 0039d316-1c4b-4281-b951-d872f2087c98
* 1. All debugger messages are dispatched in a static method on the IO thread. ↵yurys@google.com2009-04-083-6/+24
| | | | | | | | | | | All responses from the v8 go to another static method where we should find out which devtool agent delegate should be used for sending the response. We use call_id to match request with the delegate its response should be sent to. We don't pass the delegate directly as it's designed to be accessed on the render thread only. To match debug command response with its request the request sequence number is replaced with a number that is unique across the renderer(note that requests from different clients may have equal ids so we cannot rely on them). This happens before the command gets to the v8. When the command response is ready the original request_seq is restored. Before that the request_seq field is used to find out which devtools agent delegate should be used for sending the response. 2. For the debugger events we derive target agent from the current v8 execution context. If there is no agent attached to the RenderView owning that context 'continue' command is sent to the v8 automatically and the message is ignored. Review URL: http://codereview.chromium.org/62106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13347 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor tab model observer for cocoa into a separate class so it can be ↵pinkerton@chromium.org2009-04-087-106/+214
| | | | | | | | re-used. Mark tab as visible when switching to it so tabs loaded in the background work. Review URL: http://codereview.chromium.org/63087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13346 0039d316-1c4b-4281-b951-d872f2087c98
* Basic underpinnings of the gyp equivalent of the Linux SHARED=1 build:sgk@google.com2009-04-083-11/+11
| | | | | | | | | parameterize the 'type' setting of the various library targets, with a default of 'static_library'. (Hat tip to Craig Schlenter.) Review URL: http://codereview.chromium.org/62127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13345 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 12739, 12740, and 12741 because we're going to fix Issue 7448 purely ↵abarth@chromium.org2009-04-0811-39/+2
| | | | | | in WebKit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13343 0039d316-1c4b-4281-b951-d872f2087c98
* Move location bar bridge out of tab_contents_controller.shess@chromium.org2009-04-086-75/+149
| | | | | | | | | | [So that I don't keep getting conflicts as I work to finish the omnibox change http://codereview.chromium.org/50074 ] Review URL: http://codereview.chromium.org/63096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13342 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid Google Chrome/Chromium default browser conflict by renaming ↵kuchhal@chromium.org2009-04-082-41/+32
| | | | | | | | | | | Capabilities key. BUG=9697 Review URL: http://codereview.chromium.org/62100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13341 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for omnibox crash.estade@chromium.org2009-04-083-4/+60
| | | | | | | | BUG=9760 Review URL: http://codereview.chromium.org/63095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13340 0039d316-1c4b-4281-b951-d872f2087c98
* DNS prefetch experiment extension: Consider different connection count limitsjar@chromium.org2009-04-081-5/+19
| | | | | | | | | | | | This CL both enables selection of a run-time selected limit on the number of connections to a single host, and varies that limit to see how it relates to DNS prefetch latency in connections. r=wtc Review URL: http://codereview.chromium.org/62083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13339 0039d316-1c4b-4281-b951-d872f2087c98
* Stuff needed for alert info bars.estade@chromium.org2009-04-081-16/+4
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/63111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13336 0039d316-1c4b-4281-b951-d872f2087c98
* linux: don't crash on alert infobars.evan@chromium.org2009-04-081-6/+1
| | | | | | | | | | estade didn't sufficiently test his change. Luckily, the fix is trivial. TBR=estade Review URL: http://codereview.chromium.org/62138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13334 0039d316-1c4b-4281-b951-d872f2087c98
* posix: implement AutomationWindowTracker.evan@chromium.org2009-04-084-23/+37
| | | | | | Review URL: http://codereview.chromium.org/62135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13331 0039d316-1c4b-4281-b951-d872f2087c98
* More info bar implementation.estade@chromium.org2009-04-082-16/+101
| | | | | | Review URL: http://codereview.chromium.org/62136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13329 0039d316-1c4b-4281-b951-d872f2087c98
* Support the new popup and new window dispositions in the external tab ↵ananta@chromium.org2009-04-084-2/+34
| | | | | | | | | | | | | | | | container. Disabled the TRACK_HWND_DESTRUCTION macro in render_widget_host_view_win.cc as it fires consistently for the external tab container probably due to multiple WM_DESTROY messages received for the container, when the parent window is destroyed. Fixes bug http://b/issue?id=1747547 Bug=1747547 Review URL: http://codereview.chromium.org/63074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13326 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on tab closure. We now use our own model data and check that ↵jhawkins@chromium.org2009-04-081-4/+5
| | | | | | | | | the hovering index is not out of bounds. BUG=9803 Review URL: http://codereview.chromium.org/62133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13325 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplement the bookmark bar to use a GtkToolbar.erg@google.com2009-04-082-29/+294
| | | | | | | | | | Add all bookmark buttons to a GtkToolbar. All bookmark buttons are draggable, though we don't accept drops yet since I still need to figure out how to communicate with the model. Review URL: http://codereview.chromium.org/63099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13322 0039d316-1c4b-4281-b951-d872f2087c98
* hclam: picked you for this review based on the revision log of ↵aa@chromium.org2009-04-083-6/+32
| | | | | | | | | | | | | | ChromeURLRequestContext, but feel free to redirect if there is someone better. Fix leak of media_request_context_. This is kind of a nasty fix though. I think that ChromeURLRequestContext needs to be refactored more, but not sure exactly how right now. If you don't like this fix, I won't feel bad nuking it and letting someone working on this area handle it. Review URL: http://codereview.chromium.org/63073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13320 0039d316-1c4b-4281-b951-d872f2087c98
* Skia: remove fHeight (retry)agl@chromium.org2009-04-081-1/+1
| | | | | | | | | | | | Skia was previously calculating the leading value incorrectly, leading us to add fHeight to get the height of a line of text. Now that Skia is calculating fLeading correctly, we can remove fHeight. http://codereview.chromium.org/62123 https://bugs.webkit.org/show_bug.cgi?id=25083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13316 0039d316-1c4b-4281-b951-d872f2087c98
* posix: move lack of printing into a bug.evan@chromium.org2009-04-081-18/+18
| | | | | | Review URL: http://codereview.chromium.org/63103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13314 0039d316-1c4b-4281-b951-d872f2087c98
* Greatly reduce the race window in ProcessSingletoncpu@google.com2009-04-081-8/+14
| | | | | | | | | | | - fix only for windows - Anantha has a good test to be commited RSN BUG=9593 Review URL: http://codereview.chromium.org/57082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13313 0039d316-1c4b-4281-b951-d872f2087c98
* Skeleton setup for new Automated UI test framework.huanr@chromium.org2009-04-088-72/+221
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add automated_ui_test_base.{cc,h} that defines an AutomatedUITestBase class. This class can be used for both UI test suites and automated UI test running on ChromeBot. - Add automated_ui_test_test and include it in UI test suite so we can individually test all commands provided in AutomatedUITestBase. - Change AutomatedUITest to be a subclass of AutomatedUITestBase. Move RunCommandAsync(), RunCommand(), and NewTab() from AutomatedUITest to AutomatedUITestBase. The plan is moving all individual UI command functions (after they are converted to sync mode) to AutomatedUITestBase so they can be shared by UI test suites and automated UI test. - In automation_provider.cc, add a mapping mechanism from command to notification type. This will make it easy to add more command types. Review URL: http://codereview.chromium.org/56190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13312 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused database code.paulg@google.com2009-04-082-33/+0
| | | | | | | | | The new storage system doesn't check URLs on the DB thread any longer, so this code is never called. Review URL: http://codereview.chromium.org/62110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13311 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the findbar crash.tc@google.com2009-04-078-42/+40
| | | | | | | | | | | | | | | | FindBarController is no longer owned by the BrowserWindow, it is owned by Browser. So we can remove the FindBarController code in BrowserWindowGtk. Also, go ahead and implement BrowserWindow::CreateFindBar (which creates the gtk widget and adds it to the gtk widget hierarchy) and enable the code on linux. Since the widgets are created and added to the hierarchy later, we attach the signals after the widgets have been "realized". Review URL: http://codereview.chromium.org/62126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13310 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebDragData in WebView and WebViewDelegate.darin@chromium.org2009-04-076-38/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | I also cleaned up some of the WebView and WebViewDelegate methods to pass WebPoint instead of pairs of ints or gfx::Point. With this change, I am keeping webkit/glue/webdropdata.{h,cc}, which is what Chrome uses to pass around the equivalent data. Now, it is possible to construct a WebDropData from a WebKit::WebDragData and to also get a WebKit::WebDragData from a WebDropData. Hence, the conversion between WebDropData and ChromiumDataObject (see clipboard_conversion.{h,cc}) is now removed in favor of conversion between WebDropData and WebKit::WebDragData. Conversion between WebKit::WebDragData and WebCore::ChromiumDataObject is very cheap (just reference counting). Finally, this change also brings in WebData, which is now used by the return value of WebKitClient::loadResource. As a companion to that change, I also changed webkit_glue::GetDataResource to return StringPiece instead of std::string. That also saves on an unnecessary buffer copy. R=dglazkov Review URL: http://codereview.chromium.org/63084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13305 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing v8 settings to fix startup_tests regression.bradnelson@google.com2009-04-071-1983/+1983
| | | | | | Review URL: http://codereview.chromium.org/62121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13304 0039d316-1c4b-4281-b951-d872f2087c98
* linux: pass a bunch more ui tests.evan@chromium.org2009-04-0710-52/+60
| | | | | | | | Mostly random portability fixes: use portable functions, use FilePath, etc. Review URL: http://codereview.chromium.org/62117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13302 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Skia: remove fHeight"agl@chromium.org2009-04-071-1/+1
| | | | | | | | This reverts r13300 and r13299. Something clearly went wrong with the layout tests that I didn't notice. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13301 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build fix.agl@chromium.org2009-04-071-1/+1
| | | | | | | (Was building test_shell, not chrome and forgot about chrome_font.cc) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13300 0039d316-1c4b-4281-b951-d872f2087c98
* Move loadtimes extension out of the extensions directory.davemoore@chromium.org2009-04-075-12/+12
| | | | | | | | | This directory is only for extensions in service of the chrome extensions system, not all chrome related V8 extensions Review URL: http://codereview.chromium.org/63066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some threading issues and some refactoring in AudioRendererHosthclam@chromium.org2009-04-075-232/+437
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. AudioRendererHost should not wait on IO thread. Calling AudioOutputStream::Start requests some audio packets by calling IPCAudioSource::OnMoreData, resulting in a deadlock. I implemented a prefetching logic to solve this problem, source has to know how many internal buffers the implementation of AudioOutputStream is using and prepare the same amount of packets before calling AudioOutputStream::Start. 2. When IPCAudioSource::OnMoreData is waiting for packet to arrive, calling AudioOutputStream::Stop will result in a deadlock since it expects OnMoreData to return. Should wake up all waiting threads before calling AudioOutputStream::Stop. 3. Did some refactoring and move the message handlers completely into AudioRendererHost, it was clumsy to call to AudioRendererHost from ResourceMessageFilter. Also moved all logics of using shared memory for packet passing, prefetching to IPCAudioSource. AudioRendererHost is now merely a container that manages and delegates calls to IPCAudioSource. This refactoring is helpful because the next step is to implement standalone IPC channel for audio. Review URL: http://codereview.chromium.org/57023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13288 0039d316-1c4b-4281-b951-d872f2087c98
* Disable user metrics reporting for chromium builds.rvargas@google.com2009-04-071-2/+9
| | | | | | Review URL: http://codereview.chromium.org/62071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13286 0039d316-1c4b-4281-b951-d872f2087c98
* Cloned from 62030arv@chromium.org2009-04-075-19/+63
| | | | | | | | | | | | | | | Add a "Clear All" link to the downloads page. Fixes jankiness of the blue bar in the download page as it loads. Improve rendering time of the downloads page by chunking the number of download items to do before scheduling the timeout. BUG=9033 Review URL: http://codereview.chromium.org/62115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13285 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land popup routing fix for browser.ben@chromium.org2009-04-0715-75/+162
| | | | | | | | | | Just the bugfix + test now. Test is disabled pending a working framework. http://crbug.com/8472 Review URL: http://codereview.chromium.org/59007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13282 0039d316-1c4b-4281-b951-d872f2087c98
* Use one worker process per domain until we hit the maximum count of 10, then ↵jam@chromium.org2009-04-075-17/+95
| | | | | | | | | | reuse processes. Also add a test mode --webworker-process-per-core to create a worker process per worker until we hit the number of cores, then reuse. Review URL: http://codereview.chromium.org/61001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13279 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash seen when trying to paste on linux.tc@google.com2009-04-071-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/63069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13278 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.tc@google.com2009-04-0725-501/+576
| | | | | | | | | | | | JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class. This change converts it into an MVC so we can port to linux/mac. AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view. The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text. I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text. Review URL: http://codereview.chromium.org/63033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13276 0039d316-1c4b-4281-b951-d872f2087c98
* posix: the code path on either side of this ifdef is identical.evan@chromium.org2009-04-071-10/+0
| | | | | | | | Looks like someone cleaned up the code but missed this part. Review URL: http://codereview.chromium.org/63072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13275 0039d316-1c4b-4281-b951-d872f2087c98
* posix: convert a NOTIMPLEMENTED into a bug.evan@chromium.org2009-04-071-2/+3
| | | | | | Review URL: http://codereview.chromium.org/63077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13274 0039d316-1c4b-4281-b951-d872f2087c98
* Disables the download item on the download-shelf when the file is opened.jcampan@chromium.org2009-04-078-14/+84
| | | | | | | | | | | This is to mitigate against multiple clicks when a file takes some time to show anything to the user when opened (typically a setup.exe). By changing the title and disabling the button, we indicate to the user that an action was taken. BUG=7264 TEST=Download a file (image for example). In the download shelf, press the download item. The download item text should change to "Opening..." and it should be disabled (not responsive to clicks/drag and drops). Review URL: http://codereview.chromium.org/58014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13273 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/63070senorblanco@chromium.org2009-04-071-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13266 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes of base/string_piece.hthestig@chromium.org2009-04-073-6/+9
| | | | | | Review URL: http://codereview.chromium.org/62016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13265 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "Save page as..." functionality. Fix by Roland Steiner.avi@google.com2009-04-071-1/+5
| | | | | | | http://codereview.chromium.org/63045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13260 0039d316-1c4b-4281-b951-d872f2087c98
* Info.plist key SVNRevision is now, really, the SVNRevision.jrg@chromium.org2009-04-071-6/+1
| | | | | | | | Use CFBundleVersion for the Keystone version (e.g. 172.2.0.0). Review URL: http://codereview.chromium.org/63027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13259 0039d316-1c4b-4281-b951-d872f2087c98
* Adds new messages and widens some existing messages between the renderer and ↵michaeln@google.com2009-04-0723-7/+462
| | | | | | | | browser processes to support an implementation of the HTML5AppCache spec with most of the logic running in the browser process. The gist of most of the changes are to indicate which frame each resource request is coming from, and to indicate which appcache each response was retrieved from (if any).See https://docs.google.com/a/google.com/Doc?docid=agv6ghfsqr_15f749cgt3&hl=en Review URL: http://codereview.chromium.org/9712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13258 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out a test that I accidentally uncommented in my previous CL.brettw@chromium.org2009-04-071-3/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13257 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify the documentation for loading_only on TabRenderer::UpdateData.brettw@chromium.org2009-04-072-3/+16
| | | | | | Review URL: http://codereview.chromium.org/63029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13256 0039d316-1c4b-4281-b951-d872f2087c98
* Make the RenderViewHostFactory a global. This prevents us from having to passbrettw@chromium.org2009-04-0732-125/+165
| | | | | | | | | a factory pointer around all the time. Removing TestTabContents will require making the Browser object keep track of the Factory pointer as well, so I think the global is the best approach and cleans some things up. Review URL: http://codereview.chromium.org/62044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13255 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem with DrawRectInt at the edges of a ChromeCanvas.deanm@chromium.org2009-04-071-9/+10
| | | | | | | | | | | | | | | It seems there used to be an old bug in Skia, and we explicitly set a stroke width of 1 instead of 0 to work around it. Internally in Skia this goes down a more complex path, creating a path from the rect, and then filling the path. This was causing problems at the edges of the canvas, for example if you were to DrawRectInt(0, 0, width - 1, height - 1). Switch some SkRects to SkIRects. Internally Skia will still convert them to scalars, but it makes our code a bit cleaner. Review URL: http://codereview.chromium.org/62099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13254 0039d316-1c4b-4281-b951-d872f2087c98
* Updated the AutomationMsg_TabReposition IPC to be able to set the parent of ↵ananta@chromium.org2009-04-074-1/+34
| | | | | | | | | | a window. Bug=1751431 Review URL: http://codereview.chromium.org/62042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13253 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 14:13:50 +0000