| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
for tab-specific browser action buttons.
o If a tooltip is not present on a browser action button, clear the tooltip of the button.
BUG=28719
TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab.
Review URL: http://codereview.chromium.org/434047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
up to the desktop notification service.
BUG=27249
TEST=none
Review URL: http://codereview.chromium.org/432005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the same constant for both Linux and Windows.
BUG=28660
TEST=load extensions, compare spacing
Review URL: http://codereview.chromium.org/440002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28209
TEST=Enable sync and sign in. The "Sync my Bookmarks" label should now read "Bookmarks Synced..."
Review URL: http://codereview.chromium.org/431032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24475
TEST=startup_tests.exe --gtest_filter=*Toolstrip*
Review URL: http://codereview.chromium.org/431037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test only works if the source of scripts are found in a specific
order. This cannot be ensured since the source is found by traversing
the heap. The scripts tab is only visible after processing the
debugger test page, so only check for visibility in that case.
Enable test on Linux again where it passes after this change.
TEST=none
BUG=26540
Review URL: http://codereview.chromium.org/434044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=arv
Review URL: http://codereview.chromium.org/431038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the CSS/HTML for the NTP. This should allow the history query
to happen sooner.
Move the first_view logic out of NewTabHTMLSource. It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated.
Also make sure we only hang on to the original profile. I think
the incognito profile can be deleted out from under us when the
last incognito window is closed.
Review URL: http://codereview.chromium.org/434038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
nothing. This is needed as we want the window manager rendering the
decorations.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/436026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=28529
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/435025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative fix to address bad perf results for
reference build. An error message that's being printed
at the same time as the test results is believed to
be causing the graphing code to incorrectly read those
results.
BUG=none
TEST=sane linux morejs reference graph result
Review URL: http://codereview.chromium.org/437024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
paths and other minor changes to make it work in the Chrome tree. Will remove copy from O3D tree shortly. Only works in Windows currently.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/436017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/418042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
description fields.
BUG=28664
TEST=none
TBR=nickbaum
Review URL: http://codereview.chromium.org/436027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/431029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Ok" buttons are always on the right on OS X.
Nib change: I only switched the two buttons.
BUG=28638
TEST=Download a dmg, confirm "Save" botton is on the right.
Review URL: http://codereview.chromium.org/438019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't get a drop shadow and centered on screen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/431021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/24177
TEST=no visible change
Review URL: http://codereview.chromium.org/361006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also a few wording changes.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/437027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I more or less implemented things as per discussion with Cole and Glen. (This
does not re-create the appearance on Win Chrome, which is not exactly right
either.)
BUG=28477
TEST=Load various themes (in particular, "Karim Rashid") and make sure bookmark bar buttons look good and legible in hover and pressed states.
Review URL: http://codereview.chromium.org/440001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
load faster, and not take so much space visually.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/434037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-extension-toolstrips
BUG=24475
TEST=Extension*Toolstrip*
Review URL: http://codereview.chromium.org/434026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
auto-opened.
BUG=http://crbug.com/28215
TEST=as in bug
Review URL: http://codereview.chromium.org/431019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I sort out better sizing with some of the other changes needed.
TEST=see bug
BUG=28410
Review URL: http://codereview.chromium.org/437037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28657
TEST=none
Review URL: http://codereview.chromium.org/440005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13572
TEST=none
Review URL: http://codereview.chromium.org/399068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested by:
- highlighting omnibox text
- switching to a different tab
- highlighting some other text
- switching back to the first tab
- confirming that the omnibox highlighting was restored
but PRIMARY didn't get updated when switching back
BUG=20674
TEST=see above
Review URL: http://codereview.chromium.org/440003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused New Tab Warm on Windows to regress to the speed before adding
the cache on Windows.
This reverts commit r32899.
TBR=arv
Review URL: http://codereview.chromium.org/431024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows.
BUG=28230
TEST=see bug
Review URL: http://codereview.chromium.org/425016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/431023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trip to the UI thread later. Not sure if this will make a
difference.
Move the NTP and CSS handler init to after adding the MostVistedHandler.
This should allow an earlier db fetch for the cases when the HTML/CSS
are not in the cache (e.g., browser startup).
Review URL: http://codereview.chromium.org/439013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
described in http://crbug.com/27944.
BUG=28530
TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash.
Review URL: http://codereview.chromium.org/436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implicitly follows redirects.
When Chrome receives a notification about a redirect it also attempts to follow the redirect request. While
this works in most cases, some sites actually returned an error for the second request initiated by Chrome.
Fix is to abort the request in urlmon, when we receive a notification about a redirect. I also fixed the
IsRedirectResponse function in the UrlRequestAutomationJob class to only treat 301, 302, 303 and 307 as
redirect codes on the same lines as the default http job.
Test=covered by existing network tests.
I also verified that http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL.
Fixes http://code.google.com/p/chromium/issues/detail?id=28296
Bug=28296
Review URL: http://codereview.chromium.org/402107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26342
TEST+exist
Review URL: http://codereview.chromium.org/429003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/437030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it work without a browser window being present.
Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}.
BUG=27995
TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in.
Review URL: http://codereview.chromium.org/423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show.
Disable showing JS alerts from popups, because doing so makes the popup
disappear immediately, which has all sorts of unfortunate side effects for the
poor orphaned alert (see bug for details).
BUG=27758
TEST=create extension with popup, put link with |onclick="alert('test');"| in
it; install extension, open popup, and click link; see no crash (nor popup)
Review URL: http://codereview.chromium.org/435010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK:
- set default size of contents, rather than window as a whole---this gets line wrapping right.
All:
- change title string to Title Case instead of Sentence case
- fix Connection text for mixed/unsafe content
BUG=28507
Review URL: http://codereview.chromium.org/437026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be identical to LoadDataResourceBytes. Migrate callers to
LoadDataResourceBytes.
Review URL: http://codereview.chromium.org/437019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/414064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This allows us to not waste time building packages/channels we don't care about. Also added option to build new 'trunk' channel packages, which are a special configuration for developer testing.
Review URL: http://codereview.chromium.org/418021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
apparent reason
on the vista dbg builder.
Issue http://code.google.com/p/chromium/issues/detail?id=28630 has been logged to track this.
TBR=aa
Bug=28630
Review URL: http://codereview.chromium.org/432010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=28445
Review URL: http://codereview.chromium.org/437021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind (respectively).
TBR=levin
BUG=28445
Review URL: http://codereview.chromium.org/438007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChildProcessLauncher.
BUG=28602
TEST=verified flash works on Mac
Review URL: http://codereview.chromium.org/439005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=b/2168147
TEST=Extensions auto-updates should still work.
Review URL: http://codereview.chromium.org/403026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
described in issue 28329.
Use a non-incognito profile for HTML dialogs and any links launched
from them. This diverges from the behavior on Windows, but according
to beng this is okay.
Made it so that HTML dialog boxes don't keep history.
BUG=28329
TEST=made sure there is no crash when closing the browser with the sync
setup wizard open
Review URL: http://codereview.chromium.org/416004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32851 0039d316-1c4b-4281-b951-d872f2087c98
|