| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/266016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/267024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when sad tab is showing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the alert icon from the download item dangerous download xib.
- Remove the download fav icon from the download shelf xib.
- Update the download shelf to fetch the image from the pak.
- Update the download item to fetch the alert image from the pak.
- Update the bookmark bar to fetch the folder icon from the xib and cache it.
- Remove the three images from the bundles.
BUG=20230
TEST=all three still show their images
Review URL: http://codereview.chromium.org/260012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
version of r20787.
BUG=http://crbug.com/18719
TEST=download a theme, make sure that it doesn't stay in the download shelf.
Review URL: http://codereview.chromium.org/268008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=amit
http://codereview.chromium.org/255087
Adding a unique runtime Id to Profile objects, that can be used as the key
of the ProfileSiteInstanceMap type. This is used to make sure that Profile
objects can correctly share site information when one profile is derived
from another.
BUG=0
TEST=See unit tests
Review URL: http://codereview.chromium.org/261012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/268015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch by Joel Stanley <joel@jms.id.au>
Review URL: http://codereview.chromium.org/261021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/261022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tooltips longer than 1024 chars get truncated. However, to determine if the
tooltip changed, the un-truncated new text was compared to the truncated old
text. Thus, for long tooltips, the tooltip text was considered to be constantly
changing, causing the tooltip to be destroyed and re-created constantly.
Patch by Simon Radford
R=beng,darin
BUG=4754
TEST=Go to (for example) http://people.mozilla.org/~rdoherty/tooltips.html and
check that the long tooltips do not flash on Windows (I used Vista).
Review URL: http://codereview.chromium.org/265003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
be flaky.
BUG=none
TEST=none
TBR=jam
Review URL: http://codereview.chromium.org/261020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/18854
TEST=Titles on mouse-over in Expose. No extra title in titlebar.
Review URL: http://codereview.chromium.org/259023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
isolated world. Chromium side of change.
Review URL: http://codereview.chromium.org/262002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=6427
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Have the system_metrics generated code depend on 'protobuf_lite'.
Review URL: http://codereview.chromium.org/242117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
observe changes.
- implemented power menu button showing remaining battery info.
- implemented clock menu button showing detailed clock info.
- also implemented monitoring of network status change.
- don't show highlighted state for these menu buttons
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/251099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062
The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots.
HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.
Additionally, support is added for packaging extensions via ---pack-extension on linux and mac
BUG=20668, 20669
TBR=aa,wtc
Review URL: http://codereview.chromium.org/265032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24217
TEST=screenshotted before and after.
Review URL: http://codereview.chromium.org/261018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=rebuild gyp files, open chrome.sln. Observer chrome_frame project.
Review URL: http://codereview.chromium.org/271014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UpdatePopupAppearance() never removes child views (the popup quickly grows to its child limit and then stays there forever; we only show some of the children at a time though).
BUG=20511
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/262018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
necessary. Remove unnecessary V8::IsDead() check (IdleNotification() already checks IsRunning(), which is mutually exclusive with IsDead()).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in unit_tests.
Review URL: http://codereview.chromium.org/271017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r28350 aka http://codereview.chromium.org/259023
Passed the trybots because of DCHECK which wasn't there for build
bots.
TBR=zork
Review URL: http://codereview.chromium.org/271015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19895
TEST=AuthWatcherTest
Review URL: http://codereview.chromium.org/246098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/18854
TEST=Titles on mouse-over in Expose. No extra title in titlebar.
Review URL: http://codereview.chromium.org/259023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/218014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
matches its result count (views).
BUG=20511
TEST=none
Review URL: http://codereview.chromium.org/271013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we reassign them. The particular scenario that can lead to this is
when migrating bookmarks out of the db we never reset the ids of the
newly created nodes, so that we wrote all to the file with ids of
0. I'm not patching that code so that I have coverage of the unit
test, and we'll handle fix up during reading anyway.
BUG=24060
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/268001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=aa
Review URL: http://codereview.chromium.org/270017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=5709,5708,5706,5705,5704,5703,5702,5701,5700
BUG=none
TEST=ran the tests
Review URL: http://codereview.chromium.org/256067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of +[NSBundle bundleWithIdentifier:] or +[NSBundle bundleForClass:].
BUG=24118 14610
TEST=Mac startup time should improve
Review URL: http://codereview.chromium.org/268011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use SOCK_SEQPACKET rather than SOCK_DGRAM to prevent the renderer from
sending datagrams to other sockets on the system. The sandbox may prevent the
renderer from calling socket() to create new sockets, but it'll still inherit
some sockets. With PF_UNIX+SOCK_DGRAM, it can call sendmsg to send a datagram
to any (abstract) socket on the same system. With SOCK_SEQPACKET, this is
prevented.
http://codereview.chromium.org/267011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Physical memory isn't a concept on Linux. We have private pages and
proportional set size.
This patch matches the task manager up with about:memory. 'Private
memory' gets you the number of private pages and 'Shared memory' is
the PSS (except on systems with old kernels that don't have PSS, where
it'll be zero).
http://codereview.chromium.org/242096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
falls back to extension subtree.
We look for ext_root/foo/bar.js under ext_root/_locales/fr/foo/bar.js if current locale is fr. If there is no fr specific resource we load ext_root/foo/bar.js instead.
Lots of small refactoring to replace FilePath with ExtensionResource.
BUG=12131
TEST=See unittest for sample tree.
Review URL: http://codereview.chromium.org/256022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
were fixed by
revision 27811.
BUG=22775
Review URL: http://codereview.chromium.org/271007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1."
This reverts commit c18585b4bd75664122be8af6ff1170cc5c6efc66.
TBR=tc
Review URL: http://codereview.chromium.org/270015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rename the button to BrowserActionButton.
This should make adding animation to the badge easier.
Review URL: http://codereview.chromium.org/268002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062
Attempting to land this patch earlier resulted in compile failures on linux valgrind and linux perf that I was unable to reproduce.
I am splitting this into two pieces. This piece adds extension packing support via --pack-extension for mac & linux.
BUG=20668,20669
Review URL: http://codereview.chromium.org/266007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I don't see the crashes anymore.
BUG=21520
TEST=none
Review URL: http://codereview.chromium.org/264004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without this, the benchmark just doesn't run.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
done so that we can show the menu quickly. This is a hack. If the menu
remains html we'll pull the html into Chrome and won't need this. This
is just for a better prototype experience.
BUG=24147
TEST=make sure the main menu still works.
Review URL: http://codereview.chromium.org/271004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
consistently on Win.
TBR=zork
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/262015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we don't get a new tab load (see valleys here:
http://build.chromium.org/buildbot/perf/xp-release-single-core/new-tab-ui-cold/report.html?history=300
). Paper over these errors.
TBR=evanm
Review URL: http://codereview.chromium.org/264003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts,
"Change detectLanguage() API to now return the top three languages as well their percentages. Added suitable unit testing to test that top three languages are returned as expected."
TBR=zork
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24122
TEST=none
Review URL: http://codereview.chromium.org/269008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some string cleanup in google_chrome_strings.grd.
Some of these strings use "Chrome" instead of "Google Chrome", but to avoid copyright/trademark issues they should use "Google Chrome".
BUG=21866
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reports failure. This meant we were never preloading data.
TEST=covered by perf tests
http://crbug.com/23854
Review URL: http://codereview.chromium.org/265018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28301 0039d316-1c4b-4281-b951-d872f2087c98
|