| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=114148
TEST=none
Review URL: http://codereview.chromium.org/9784014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new preference.
BUG=101877
TEST=PrefProvider*,HostContentSettingsMap*
Review URL: https://chromiumcodereview.appspot.com/9826020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements rules removal for the WebRequestRulesRegistry and also adds some testing functionality to ensure that we are not leaking any memory.
BUG=112155
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9844028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements the beginning of the RulesRegistry for the Declarative Web Request API; it allows registering rules and checking whether their conditions are fulfilled.
BUG=112155
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9820003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
language/network in OOBE
BUG=chromium-os:25498
TEST=On OOBE, select language by mouse or keyboard (open the list by pressing enter, select with arrow keys, commit the selection with enter).
Review URL: http://codereview.chromium.org/9864056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9925001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9750012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
extension docs.
Review URL: https://chromiumcodereview.appspot.com/9924003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add hl=<UI Language> query param instead.
BUG=118960
TEST=browsertest --gtest_filter=TranslateManagerTest.*
Review URL: http://codereview.chromium.org/9791078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119595
TEST=yes
Review URL: http://codereview.chromium.org/9905002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
created by window.open.
We want attempts to create those windows to succeed, but the window.open call
should still return null. This is accomplished by opening the background contents
in another process, in the same manner as r125180.
BUG=120446
R=creis@chromium.org
Review URL: http://codereview.chromium.org/9837074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disposition to inline
In the new UX flow, we will use the inline WebIntent tab modal dialog for user consent instead of the Info Bar.
Also get rid of the actual extension code since it's been moved to
chromeos assets repository.
BUG=chromium-os:28353, chromium-os:27854, chromium-os:28484
TEST=make sure extension loads and handles intents correctly.
Review URL: http://codereview.chromium.org/9865016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16557
TEST=build success
Review URL: http://codereview.chromium.org/9791045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120598
TEST=Verify fix for issue 120598.
Review URL: https://chromiumcodereview.appspot.com/9802043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116170
TEST=none
Review URL: http://codereview.chromium.org/9901002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9866051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Can browse chromeos://cryptohome
Review URL: https://chromiumcodereview.appspot.com/9891001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120714
TEST=Do an official build with dchecks enabled. Observe no dcheck 20s after startup.
Review URL: http://codereview.chromium.org/9877017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
factory method to creating an anonymous ChromeV8Extension.
BUG=104100
TEST=existing browser tests
Review URL: http://codereview.chromium.org/9791015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(i.e. apps pages that only have a [+])
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/9791046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was broken due to changes to the Windows 8 APIs around default
handlers. Chrome checks if it is the default handler for the protocol
before launching any external program. Prior to this change the check
on Windows 8 would always return success. This change makes it return
UNKOWN instead.
BUG=116452
TEST=Tested external handlers work on Win 7 and Win 8. Checked register
protocol handler still works on Win 8.
Review URL: http://codereview.chromium.org/9863026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process.
VerifyPermissions was replaced with something simpler in http://codereview.chromium.org/9867003/, and another simple browser test in chrome/browser/extensions/crx_installer_browsertest.cc.
We weren't copying --enable-platform-apps to the utility process that unzipped CRX files, so it wasn't able to load platform app CRXes.
BUG=120075, also in-person reported during hackathon
TEST=added (and refactored others)
Review URL: https://chromiumcodereview.appspot.com/9839106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Bring back ChromeAppListItem base class so that we can have different
types items in app list;
- Add 128x128 product icon to theme_resources;
- Add a ChromeAppItem that uses the product icon and short product name as
title. On activation, it does the same thing as the launcher button;
- Make ChromeAppItem always the first in the list;
BUG=120572
TEST=Verify fix for issue 120572
Review URL: https://chromiumcodereview.appspot.com/9802034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds keyboard support to the new browser autofill.
BUG=51644
TEST=When using the new autofill, keyboard presses should work as they do in the old autofill
Review URL: http://codereview.chromium.org/9432029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nix old AboutFlags_disable-chrome-to-mobile UMA bin.
Add new AboutFlags_enable-chrome-to-mobile UMA bin.
BUG=102709
TEST=Chrome To Mobile is disabled by default; chrome://flags shows enable option.
Review URL: https://chromiumcodereview.appspot.com/9844011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Per r14902, that's how background pages were initially specified in the manifest.
R=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/9873042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9909006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I just realized some test filenames have options in front of them. Need to rid of the options, otherwise we get invalid files.
BUG=
TEST=see a few more tests
R=kbr
Review URL: https://chromiumcodereview.appspot.com/9906004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
including log dumps, when Chrome's DNS resolver is enabled.
BUG=117258
Review URL: http://codereview.chromium.org/9854026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9902001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test started to crash and, as a result of fixing the crash, the
geolocation infobar code was refactored and improved in
http://codereview.chromium.org/9491009 . Hopefully as a result, this
test also no longer be flaky.
BUG=70588
TEST=GeolocationBrowserTest.TabDestroyed
Review URL: http://codereview.chromium.org/9874016
TBR=jknotten@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9800002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=120155
TEST=javascript dialogs work on the Mac
Review URL: http://codereview.chromium.org/9836127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
running on ports 53, 80, 587, 6121, 8080.
Increase the percentage of users who are participating the
experiment in Dev (to 10%) and Beta (to 5%) channels.
Created sub functions for unit testing of various failures
in VerifyBytes routine.
BUG=115849
R=jar
TEST=unit tests for network.
Review URL: http://codereview.chromium.org/9460054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
posix. TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9887006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PostTaskAndReply will leak if the reply task is not run.
The fix is to ensure that reply tasks are run before
ending a test.
Here's what was happening before the fix:
1) post tasks to FILE thread with PostTaskAndReply
2) in TearDown(), ShutdownOnUIThread() is called, this will block until all tasks posted to FILE thread are run
3) and the test ends.
4) wait! what happened to reply tasks? they weren't run.
5) PostTaskAndReply implementation deletes an object when the reply task is run, so that object was leaked
BUG=120353,120726
TEST=locally run valgrind and confirm the leak is gone with the fix.
Review URL: https://chromiumcodereview.appspot.com/9897001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=120719
TEST=doesn't crash on site in bug
Review URL: http://codereview.chromium.org/9844036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- testInfoBarDisappearByNavigatingPage was failing every other run due to the chrome://history page
not displaying. Changed to chrome://version for robustness.
- testSavedPasswordInTabsAndWindows was failing since the test expected Incognito mode to display the
login into creds. This is not the bahvior while in Incognito mode. Removed the checks and added a
new test specifically for Inconito mode.
BUG=119602
TEST=Tested on win qa-bots.
Review URL: https://chromiumcodereview.appspot.com/9837121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110794
TEST=Built and ran with official Chrome
Review URL: https://chromiumcodereview.appspot.com/9869001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
public-facing API stuff.
BUG=no
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9877018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=119389
Review URL: https://chromiumcodereview.appspot.com/9873015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is turned on.
This will improve feedback for a couple of toolbar controls that check
this state, and also start collecting UMA statistics on accessibility usage
in Chrome OS.
BUG=99504
TEST=none
Review URL: http://codereview.chromium.org/8537024
TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the platform independent PlatformCanvas was used on Aura
(http://crrev.com/128354), the reference count issue has not happened any longer.
On the contrary, copying the bitmap retured by PlatformCanvas causes assertion
error in debug build.
BUG=chromium-os:28418
TEST=Manually tested crash does not happen and thumbnail is properly generated
Review URL: http://codereview.chromium.org/9853025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Reland of https://chromiumcodereview.appspot.com/9861029 with fixes tests.)
BUG=111878
TEST=Go to "chrome:settings", tab opened should be "chrome://chrome/settings/".
Review URL: https://chromiumcodereview.appspot.com/9866060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=120770
TEST=disabled
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9886002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like the changes made in r124187 accidentally broke the search
UI on the chrome://sync page. This commit updates some includes to
un-break search functionality.
BUG=120334
TEST=Load search tab on chrome://sync, verify that search returns results.
Review URL: http://codereview.chromium.org/9864019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
protector.ProtectorPreferencesTest.testPreferencesBackupInvalidRestoreLastSession on mac.
BUG=120317
TEST=none
Review URL: http://codereview.chromium.org/9874026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android there's no Browser/BrowserList as tab management happens in
the Java-layer. This Registry provides a similar mechanism as
BrowserList to give sync code visibility into the running windows and
tabs.
BUG=117407
Review URL: http://codereview.chromium.org/9866023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
themselves up after a timeout.
BUG=81758
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9791011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120762
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9885001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129494 0039d316-1c4b-4281-b951-d872f2087c98
|