| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/647064
BUG=35963
TEST=WorkerTest.StressJSExecution
Review URL: http://codereview.chromium.org/661139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=johnnyg@chromium.org
BUG=none
TEST=mac debug build should cycle green
Review URL: http://codereview.chromium.org/660192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33306
TEST=modified and added new test (TestSticky) to DesktopNotificationsTest
Review URL: http://codereview.chromium.org/661155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces VideoLayer, which is similar to BackingStore except handles YUV surfaces and conversion to RGB.
BUG=33329
TEST=N/A
Review URL: http://codereview.chromium.org/597066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a pinned tab.
BUG=33123
TEST=see bug
Review URL: http://codereview.chromium.org/661128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tabs.
- problem happened because infobars are destructed when switching between tabs, only the delegates persist. without the infobar to receive the PAGE_TRANSLATED notification to update the translate state, the infobar gets stuck at translating state when user switches back to the associated tab.
- fix was to update the state in the infobar delegate on receiving PAGE_TRANSLATE notification so that when a new translate infobar is created, its visual display will reflect the updated after-translate state.
BUG=36895
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/660187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
add openMAX test and FFMPEG test to arhicved list to be used in chrome OS build process.
Review URL: http://codereview.chromium.org/661185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36874
Review URL: http://codereview.chromium.org/661186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://docs.google.com/View?id=dd4ngnpz_0dpsb8n96 for API proposal.
BUG=0
TEST=See unit tests as part of this CL
Review URL: http://codereview.chromium.org/657037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Visit a page in a language other than the Chrome's language.
A translate infobar should be shown.
In the options/Under the Hood tab, unselect "Offer to translate
pages that aren't in a language I read". Navigate again to a
page in a non Chrome-UI language. No translate infobar should be
shown.
Review URL: http://codereview.chromium.org/661095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
better label what process it is.
BUG=none
TEST=Don't see "Helper" in actvitiy monitor.
Review URL: http://codereview.chromium.org/660140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently, we can sometimes have a null RenderView here. This must
corresponse to a frame/document that has already been detached from
the page.
R=jorlow
BUG=36831
TEST=none
Review URL: http://codereview.chromium.org/661169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We still have ~150 callers to AppendToPath in our code, but most of
them are in the installer and I'm reluctant to fiddle with that code
without having an easy way to test it.
BUG=24672
Review URL: http://codereview.chromium.org/654013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bolt the geolocation dispatcher host up to the location arbitrator
Introduces a new method for fetching a singleton default location arbitrator with minimal fuss.
Fix bug in the geolocation dispatcher where bridge id & route id were swapped on send.
BUG=http://crbug.com/11246
TEST=run browser with --enable-geolocaiton & Open http://maps.google.co.uk/maps/m
Review URL: http://codereview.chromium.org/658005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(It lacked a space after the process type.)
Review URL: http://codereview.chromium.org/661180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default user profile and starting login wizard after necessary
initialization happens. Also renamed first-login-screen-name switch to
just login-screen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- rename NewPolicyPolicy to NewPollingPolicy
- log content of json request string, rather than its address
BUG=none
TEST=run browser, looked at logging output
Review URL: http://codereview.chromium.org/661091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewed at http://codereview.chromium.org/651081.
TBR=ericbidelman
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the client has an IPv6 address on an interface
It is indeed causing a perf regression in startup on Linux...
I'll need to rearchitect to do the probes asynchronously, and get
off the startup-critical-path.
This currently only works on Posix, not windows.
Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).
The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection. If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.
BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660073
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/661164
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has an IPv6 address on an interface
This is a second attempt to land a reviewed change. It was reverted because
the tree got very red (for other reasons), and it was plausible that this
change was causing startup latency in Mac and Linux (causing both perf bots
to go red). If this landing turns those perf-bots red (tonight) I'll need
to revert. (... and I'll need to rearchitect to do the probes
asynchronously, and get off the startup-critical-path.
This currently only works on Posix, not windows.
Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).
The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection. If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.
BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660073
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/661164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG:36871
Review URL: http://codereview.chromium.org/660162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
led me to believe each component of the version string could be a
32-bit integer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that the bots have something to point at.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/660155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change includes: desktop shortcut, quick launch short cut,
short cut name in start menu, add/remove program name.
BUG=35574
TEST=Run "setup --chrome-sxs" and Chrome is installed with different short cut.
Review URL: http://codereview.chromium.org/661051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36661 Ctrl-1 gets queued while Ctrl-tab doesn't
TEST=See bug report.
Review URL: http://codereview.chromium.org/660069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/660063 ), r=me.
BUG=22853
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36687
TEST=about:tcmalloc, etc, works when tcmalloc is enabled on Linux.
Review URL: http://codereview.chromium.org/660118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
channel getting destroyed
and it being referenced in the background thread.
Fix is to use the underlying IPC::Channel pointer passed to the message filter when the
filter gets Added to send and receive messages. This ensures that the SyncChannel is not used across
threads.
Review URL: http://codereview.chromium.org/661109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change to AutoFillDialog.xib was window anchoring flags to better position dialog in different window sizes on first run.
> 1.) The initial position of the dialog is half off-screen on my 15'' MBP. It should probably be
> more on the left.
>
Done. Auto centering now.
> 2.) Furthermore, the dialog should autosave its position. See e.g.
> keyword_editor_cocoa_controller.mm on how to do this (the |if (g_browser_process...)| block in
> |initWithProfile| – it takes only a couple lines).
>
Done.
> 3.) When clicking "Add an address", I find it weird that the new address starts in the collapsed
> state. That makes it hard to see how to delete it again, and chances are that when I'm adding a
> new address I want to edit it immediately.
>
Done.
BUG=36441
TEST=see manual repro steps above.
Review URL: http://codereview.chromium.org/660130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
default one.
ExternalTabContainer tests create the host window and the automationproxy in the main thread, that will cause deadlock (especially when host window is visible).
Added test for openening popup windows.
TEST=ui_tests
Review URL: http://codereview.chromium.org/661028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
syncer util a while ago.
Review URL: http://codereview.chromium.org/661123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the local version, as it may not have been set yet. I messed this up as part of my multi-pass syncer command change yesterday.
BUG=36822
Review URL: http://codereview.chromium.org/661133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
64-bit loader code and fix some build issues.
Review URL: http://codereview.chromium.org/651065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-experimental-extension-apis . The UI needs work. Tab and window
events are hooked up so that they work with incognito tabs/windows when
enabled.
BUG=32365
BUG=36292
Review URL: http://codereview.chromium.org/657041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
translate infobar was expected to always be instantiated with BeforeTranslate state, but if connection is slow and infobar remains at Translating state when user switches to another tab then switches back to the "Translating" tab, all controls need to be created.
BUG=36812
TEST=On a slow connection, open a page that shows translate infobar, click to translate; while it's still translating, switch to another tab then switch back to the translating tab, it shouldn't crash.
Review URL: http://codereview.chromium.org/661103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
preference.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/661113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed in http://codereview.chromium.org/427009/diff/4020/11020 , when the offset was applied relative to the icon instead of the view, but the number wasn't updated.
BUG=31956
TEST=Go to https://addons.mozilla.org/en-US/firefox/addon/5890 , look at omnibox. Nothing should look bad.
Review URL: http://codereview.chromium.org/661116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
was accidentally left out of my last commit.
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
already toggles between pause and resume)
also, share more code between windows and linux. DownloadShelfContextMenu{Win,Linux} don't need to both implement menus::SimpleMenuModel::Delegate.
BUG=24759
TEST=download item context menu still works.
Review URL: http://codereview.chromium.org/652200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
drawn as they should be.
BUG=http://crbug.com/35554 ; http://crbug.com/26983
TEST=no visible change in normal mode; themed incognito windows should look almost correct (missing theme header)
Review URL: http://codereview.chromium.org/661097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ready yet).
Review URL: http://codereview.chromium.org/660099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ContentBlockedBubbleGtk looks at tab_contents->blocked_popup_container(), and
all I can think of is that people are clicking on the icon after
DidNavigateMainFramePostCommit() occurred.
BUG=35909
TEST=none
Review URL: http://codereview.chromium.org/660098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(chrome_nacl_win64.dll -> nacl64.dll, nacl.exe -> nacl64.exe). The motivation for the change:
1. Make the name shorter (look better when installed on users machines)
2. Allow differentiation between 64-bit and 32-bit binaries if we decide to switch to a similar design for 32-bits too.
Review URL: http://codereview.chromium.org/650195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- CustomDrawButton
- ToolbarStarToggle
- GoButton
BUG=36760
TEST=manual
Review URL: http://codereview.chromium.org/661063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Korean, Adobe shortcut URL does not work. Until it's fixed, use the full url.
BUG=36072
TEST=Run Chrome in Korean or Swedish and follow the steps in the bug report.
TBR=oritm
Review URL: http://codereview.chromium.org/661100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL requires a patch to webkit to compile. That patch is tracked here:
https://bugs.webkit.org/show_bug.cgi?id=35257
This CL makes a change on Mac and Linux. Windows will follow in a sepperate change.
BUG=30247
TEST=Manual testing using the test case attached to the bug and the sample extensions.
Review URL: http://codereview.chromium.org/657012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40036 0039d316-1c4b-4281-b951-d872f2087c98
|