| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
doesn't seem to support all the IPC messages.
BUG=28028
TBR=chase
Review URL: http://codereview.chromium.org/437072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
using RunCommand (sync).
Review URL: http://codereview.chromium.org/436031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
address.
Review URL: http://codereview.chromium.org/435026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28028
Review URL: http://codereview.chromium.org/436040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27543
TEST=Manually tested
Review URL: http://codereview.chromium.org/437033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs.
* Use these APIs with all key iterator usage.
* SetXXX() calls cannot fail, so change them from bool to void.
* Change GetSize() to size() since it's cheap, and add empty().
Other:
* Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop).
* Shorten a few bits of code.
BUG=567
TEST=none
Review URL: http://codereview.chromium.org/441008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doing so, make it use the font-family and font-size (84% by default) set in locale_settings for the current UI language. The body font size used to be 87%. To make up for the difference between two, the font sizes given in percentage are adjusted (increased) accordingly in the rest of the file.
BUG=28202
TEST=1. Run Chrome with '--lang=he' or '--lang=ar' on Windows (or 'LANGUAGE=he chrome' / 'LANGUAGE=ar chrome' on Linux) and go to 'chrome://extensions'. Strings are not yet translated, but the overall UI should be RTL.
2. Run Chrome in en-US (or your favorite LTR language) and go to 'chrome://extensions'. It should look the same as before.
Review URL: http://codereview.chromium.org/434024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quirks are enabled by default.
R=darin
BUG=19586
TEST=wikileaks.org should now have its sidebar in the proper place.
Review URL: http://codereview.chromium.org/442010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jparent
TEST=bots green
Review URL: http://codereview.chromium.org/444002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a flaky failure in Linux startup tests that
started appearing after r33063 landed. Try backing
out r33063 to see if this CL is the cause.
BUG=24144
TEST=linux startup tests pass
TBR=jorlow
Review URL: http://codereview.chromium.org/441020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preferences yet, but at least adds support for looking in the right place.
R=cpu,kuchhal
TEST=unit test included
BUG=19374
Review URL: http://codereview.chromium.org/405003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Draw a "ugly black bar" (where "black" is actually a theme colour) to indicate
where a bookmark button that's being dragged will end up if dropped. This is a
stopgap measure for the beta. Later, we will make the buttons move around
instead (even if implementable in the time remaining, such animations would be a
crash risk).
BUG=17608
TEST=Drag bookmark bar buttons around. Make sure that the bar indicating where a button will be dropped is visible enough and accurate. Repeat with various themes.
Review URL: http://codereview.chromium.org/437051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
never-ending CPU spike upon expanding a story.
BUG=28428
TEST=Install the extension, expand a story, notice lack of CPU spike.
Review URL: http://codereview.chromium.org/437060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27657
TEST=Typing "google" in the search field pulls up origins containing "google" in their name
Review URL: http://codereview.chromium.org/435024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestHTTPSErrorWithNoNavEntry: fails differently on 32 and 64 bits due to timing issue. (We thought it's deterinistic, but this is apparently not)
FindDisappearOnNavigate: due to asynchronous-ness on x11.
BUG=28629,28098
TEST=build and run browser_tests in 64bit.
Review URL: http://codereview.chromium.org/438010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The drag would be cancelled after pressing Esc, but moving the mouse again would
cause the bookmark bar button to see a drag again and start a new drag. This
patch makes the button wait for the next mouse down.
BUG=28502
TEST=Drag bookmark bar button and keep mouse button; press Esc (and see cancellation animation); move mouse again and make sure a new drag doesn't start.
Review URL: http://codereview.chromium.org/437055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to control the log level and log feature flags from outside the process, and all log messages can be transported into ETW trace sessions.As is this provides an event trace provider class thatmanages the log level on control callbacks and shunts the formatted log messages to ETW when warranted.The provider observes one feature flag, which when turned on causes it to capture and log a stack trace at the log site, which can be helpful when diagnosing errors from logs.This CL also initializes ETW logging for chrome.dll, but only if the environment variable "CHROME_ETW_LOGGING" is set. The ETW machinery may create a thread in every process registering a trace provider, and the environment variable makes this overhead optional.
TEST=Unittests in this change
BUG=none
Review URL: http://codereview.chromium.org/413006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start the WebKit thread when we initialize the resource dispatcher host.
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TBR=darin
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144,28364
Review URL: http://codereview.chromium.org/432007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI thread.
BUG=27834
TEST=none
Review URL: http://codereview.chromium.org/440012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/437049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23850
TEST=Go to a login page (i.e. gmail), log in with several different user accounts.
Observe that the last used account is now the one that is used for the initial page autofill.
Patch by zelidrag@chromium.org
Original Review: http://codereview.chromium.org/437032
Review URL: http://codereview.chromium.org/434070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina (thiago.farina@gmail.com)
BUG=26443
TEST=None
Review URL: http://codereview.chromium.org/414072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27333
TEST=UserScriptTest and check the issue does not happen against userscipt encoded in UTF-8 with BOM..
Review URL: http://codereview.chromium.org/420001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28746
TEST=Ctrl+C = clean shutdown.
Review URL: http://codereview.chromium.org/432019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(sync_ui_util), per style guide.
Changed static functions into anonymous-namespace functions.
Renamed files/namespaces from sync_status_ui_helper to sync_ui_util.
Moved sync_ui_util_mac.mm functions into sync_ui_util namespace.
Updated all callers.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/414065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.
Review URL: http://codereview.chromium.org/412008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetCurrentRenderView() can actually return NULL, which means
that GetExtensionIdForCurrentContext() can also return empty
string. Hillarity ensues.
BUG=28487
Review URL: http://codereview.chromium.org/441005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=UserScriptMasterTest
Review URL: http://codereview.chromium.org/434034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(One edited file: template/api_template.html.
Every other change is an automatically generated file.)
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/434058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is almost a full revert of r31526, except that the two DCHECK(url_request_context_getter_) which I promoted to CHECK()s remain as CHECK()s (since they will be useful to catch similar problems in the future, and are cheap).
BUG=27074
Review URL: http://codereview.chromium.org/434050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
via redirect) in a web page displayed by Chrome Frame. The request should be handled by the host browser.BUG=23561
Review URL: http://codereview.chromium.org/385108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change also reworks the tcmalloc dependency to be added only to chrome and test_shell, instead of base. This is necessary since otherwise tcmalloc will be double initialized (by both the main executable and dlopen'd shared objects like the npapitestplugin.so).
Add valgrind suppressions. This are invalid reads on static initialization in the VDSOSupport module. I haven't investigated it yet, but I suspect they're benign.
BUG=http://crbug.com/28149, http://crbug.com/28385
Review URL: http://codereview.chromium.org/399081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
file with the necessary include rules.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This goes along with webkit bug: https://bugs.webkit.org/show_bug.cgi?id=31841
BUG=17466
Review URL: http://codereview.chromium.org/431031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25028
TEST=Drag the window from both incognito view and regular window bar while it's in foreground and background
Review URL: http://codereview.chromium.org/434030
Patch from feldstein.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28577
TEST= Trigger notification (remove a thumbnail) with themed browser, note that text and link in notification (and in extension/bookmark sync promo) are legible and retain original colors.
Review URL: http://codereview.chromium.org/437045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(In particular, clip them to their rounded rectangle.)
BUG=28593
TEST=Drag bookmark bar buttons with a wide variety of themes; make sure edges/corners are correctly clipped from drag images.
Review URL: http://codereview.chromium.org/435028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't remove the underlying support from
UserScriptMaster; that is a riskier change.
BUG=27520
Review URL: http://codereview.chromium.org/418043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allowing unwanted popups from a notification with script that sets window.location=foo.
Instead override some RVHDelegate::View methods to allow popups to be blocked, and new-tab links to open in new tabs; now regular links will navigate the toast. The view methods are implemented using the standard helper.
BUG=28015
TEST=none
Review URL: http://codereview.chromium.org/434041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux Release builds on my machine, all the chrome://theme/ image
requests block for 300-400ms during browser startup (it's faster
after startup). Something is blocking the UI thread so move
image requests that aren't themed off the UI thread. This is
safe to do because ResourceBundle is thread safe.
I still see chrome://theme/theme_ntp_attribution and
chrome://theme/theme_ntp_background blocking so I will look
into those next (I think with the default theme, they shouldn't
be loaded at all).
Review URL: http://codereview.chromium.org/440009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a section that points to the various doc URLs (e.g. trunk) and explains
each one.
The only files I edited are static/docs.html and template/api_template.html.
(The remaining files just reflect the template changes.)
BUG=none
TEST=none
TBR=nickbaum
Review URL: http://codereview.chromium.org/431035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flicker is caused by setting window title icon while a loading
animation is in progress. Fix the problem by skipping window icon update
when loading animation is running.
BUG=15782
TEST=Verify no flicker while web app loads per Ben's comments.
Review URL: http://codereview.chromium.org/436028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for tab-specific browser action buttons.
o If a tooltip is not present on a browser action button, clear the tooltip of the button.
BUG=28719
TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab.
Review URL: http://codereview.chromium.org/434047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
up to the desktop notification service.
BUG=27249
TEST=none
Review URL: http://codereview.chromium.org/432005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the same constant for both Linux and Windows.
BUG=28660
TEST=load extensions, compare spacing
Review URL: http://codereview.chromium.org/440002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28209
TEST=Enable sync and sign in. The "Sync my Bookmarks" label should now read "Bookmarks Synced..."
Review URL: http://codereview.chromium.org/431032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24475
TEST=startup_tests.exe --gtest_filter=*Toolstrip*
Review URL: http://codereview.chromium.org/431037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test only works if the source of scripts are found in a specific
order. This cannot be ensured since the source is found by traversing
the heap. The scripts tab is only visible after processing the
debugger test page, so only check for visibility in that case.
Enable test on Linux again where it passes after this change.
TEST=none
BUG=26540
Review URL: http://codereview.chromium.org/434044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=arv
Review URL: http://codereview.chromium.org/431038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the CSS/HTML for the NTP. This should allow the history query
to happen sooner.
Move the first_view logic out of NewTabHTMLSource. It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated.
Also make sure we only hang on to the original profile. I think
the incognito profile can be deleted out from under us when the
last incognito window is closed.
Review URL: http://codereview.chromium.org/434038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32965 0039d316-1c4b-4281-b951-d872f2087c98
|