| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001
for details
BUG=
Review URL: https://codereview.chromium.org/1059333004
Cr-Commit-Position: refs/heads/master@{#327270}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need a +4GB base so the loader will randomize above 4GB.
BUG=361670
R=robertshield@chromium.org,jam@chromium.org
NOTRY=TRUE
Review URL: https://codereview.chromium.org/233413008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add functionality to ServiceResolverThunk to copy a thunk without patching.
2. Move chrome_elf thunk-handling code to a common location.
3. Use a thunk instead of a f'n ptr for redirects.
BUG=334379
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255151
Review URL: https://codereview.chromium.org/183833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the exported functions iterator in PEImage instead of writing our
own.
BUG=
Review URL: https://codereview.chromium.org/192933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Crashy on today's canary)
> Make chrome_elf use thunks instead of function pointers.
>
> 1. Add functionality to ServiceResolverThunk to copy a thunk without patching.
> 2. Move chrome_elf thunk-handling code to a common location.
> 3. Use a thunk instead of a f'n ptr for redirects.
>
> BUG=334379
>
> Review URL: https://codereview.chromium.org/183833004
TBR=caitkp@chromium.org
Review URL: https://codereview.chromium.org/189803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=349926
TEST=NONE
Review URL: https://codereview.chromium.org/183973039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add functionality to ServiceResolverThunk to copy a thunk without patching.
2. Move chrome_elf thunk-handling code to a common location.
3. Use a thunk instead of a f'n ptr for redirects.
BUG=334379
Review URL: https://codereview.chromium.org/183833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=345287
Review URL: https://codereview.chromium.org/174013007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will cover most of the CreateFile calls and save us from death by
circular gyp dependencies.
Review URL: https://codereview.chromium.org/183773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensure that the dll code is referenced, instead of the target
making its own copy.
TBR=sky@chromium.org
BUG=329023
Review URL: https://codereview.chromium.org/181373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Manual: Start chrome.exe, wait ~60s and check chrome://histograms, the Stability.FileAtPath metric should have run (at least) once, and the resulting value should be 6, assuming the check succeeded.
Review URL: https://codereview.chromium.org/169093007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/154653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=343792
OK, it's been almost a week now, with regular pings to OWNERs, so I guess it's OK to TBR... It's only Gyp/script changes anyway... Feel free to uncheck the CQ box if you disagree...
TBR=beng@chromium.org, darin@chromium.org
Review URL: https://codereview.chromium.org/165893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=334379
Review URL: https://codereview.chromium.org/154463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=334379
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246313
Review URL: https://codereview.chromium.org/138593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This caused reading profile error on Windows8 platform.
> Use an alternate mechanism for CreateFile calls in Chrome
>
> BUG=334379
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464
>
> Review URL: https://codereview.chromium.org/138593004
TBR=caitkp@chromium.org
Review URL: https://codereview.chromium.org/144333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=334379
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464
Review URL: https://codereview.chromium.org/138593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fix a missing dependency on chrome_elf_unittests, it should have a dependency on chrome_elf.dll and chrome.exe if you want to be able to do:
- ninja -C out\Release chrome_elf_unittests
- out\Release\chrome_elf_unittests.exe
on a fresh checkout...
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/132823006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeCreateFileTest.CheckWriteAndReadParams crashes on Vista
> Use an alternate mechanism for CreateFile calls in Chrome
>
> BUG=334379
>
> Review URL: https://codereview.chromium.org/138593004
TBR=caitkp@chromium.org
Review URL: https://codereview.chromium.org/140783009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=334379
Review URL: https://codereview.chromium.org/138593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some msvc libs (DEBUG builds)
2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245197
Review URL: https://codereview.chromium.org/109483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
import of chrome.exe (https://codereview.chromium.org/109483003/)
Reason for revert:
Tests failing on Win x64 bots.
Original issue's description:
> 1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
> 2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245197
TBR=robertshield@chromium.org,siggi@chromium.org,csharp@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/132613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some msvc libs (DEBUG builds)
2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048
Review URL: https://codereview.chromium.org/109483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also increase the states stored in the register to prevent
the setup code from running multiple times per version if
it fails to start one time.
Also, this uses RegQueryValueEx and RegSetValueEx
instead of RegSetKeyValue and RegGetValue since
they aren't available on XP.
TBR=sky@chromium.org
BUG=329023
Review URL: https://codereview.chromium.org/133923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Use a Finch Experiment to control the Browser Blacklist
>
> Also increase the states stored in the register to prevent
> the setup code from running multiple times per version if
> it fails to start one time.
>
> BUG=329023
>
> Review URL: https://codereview.chromium.org/120963002
TBR=csharp@chromium.org
Review URL: https://codereview.chromium.org/132043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also increase the states stored in the register to prevent
the setup code from running multiple times per version if
it fails to start one time.
BUG=329023
Review URL: https://codereview.chromium.org/120963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Breaking WIN tests on waterfall
TBR=robertshield@chromium.org,siggi@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/114333008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make sure chrome_elf.dll imports nothing besides kernel32 and some
msvc libs (DEBUG builds)
2. make sure chrome_elf.dll is always the first entry in chrome.exe's
import table.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
Review URL: https://codereview.chromium.org/109483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It fails on Win 7 Tests x64 (2) bot.
> Add tests to make sure ChromeELF.dll imports are correct:
>
> 1. Make sure chrome_elf.dll imports nothing besides kernel32 and some
> msvc libs (DEBUG builds)
> 2. make sure chrome_elf.dll is always the first entry in chrome.exe's
> import table.
>
> Review URL: https://codereview.chromium.org/109483003
TBR=caitkp@chromium.org
Review URL: https://codereview.chromium.org/123583004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make sure chrome_elf.dll imports nothing besides kernel32 and some
msvc libs (DEBUG builds)
2. make sure chrome_elf.dll is always the first entry in chrome.exe's
import table.
Review URL: https://codereview.chromium.org/109483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It broke on the main waterfall after going through the CQ. Two changes:
* No-op the loading test on 64-bit.
* Remove the 'IgnoreAllDefaultLibraries' directive. This seems to exclude
the CRT on some builders.
Original CL description:
Chrome browser process DLL blacklist.
This patch allows for blocking of module loading in the browser process.
It does not actually prevent any modules from loading.
Original Review URL: https://codereview.chromium.org/107663008
BUG=329023
TEST=chrome_elf_unittests.exe
TBR=cpu
Review URL: https://codereview.chromium.org/118343004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is breaking the Win builders (and the blacklist_test
is failing on 64 bits).
> Chrome browser process DLL blacklist.
>
> This patch allows for blocking of module loading in the browser process.
> It does not actually prevent any modules from loading.
>
> BUG=329023
> TEST=chrome_elf_unittests
>
> Review URL: https://codereview.chromium.org/107663008
TBR=robertshield@chromium.org
Review URL: https://codereview.chromium.org/107443008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch allows for blocking of module loading in the browser process.
It does not actually prevent any modules from loading.
BUG=329023
TEST=chrome_elf_unittests
Review URL: https://codereview.chromium.org/107663008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238539
Review URL: https://codereview.chromium.org/85403005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Breaks Chromium x64
TBR=robertshield@chromium.org,caitkp@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/105573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/85403005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should stop the address conflicts suspected of causing the perf regression.
TEST= working set size returns to normal
BUG=318691
Review URL: https://codereview.chromium.org/77673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Set a base address for chrome_elf to avoid base address collisions with chrome_dll.
>
> NOTRY=true
> BUG=318691
>
> Review URL: https://codereview.chromium.org/75483002
TBR=caitkp@chromium.org
Review URL: https://codereview.chromium.org/75683005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_dll.
NOTRY=true
BUG=318691
Review URL: https://codereview.chromium.org/75483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
chrome_elf.dll is shipped in Chrome's version directory to
ease updates, and is loaded early in chrome.exe's lifetime
by making it a private assembly in a subfolder of
chrome.exe's folder (see
http://msdn.microsoft.com/library/aa374224.aspx).
BUG= http://crosbug.com/p/23889
Review URL: https://codereview.chromium.org/53793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234795 0039d316-1c4b-4281-b951-d872f2087c98
|