| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/951463003
Cr-Commit-Position: refs/heads/master@{#320086}
|
|
|
|
|
|
|
|
| |
BUG=345874
Review URL: https://codereview.chromium.org/974903002
Cr-Commit-Position: refs/heads/master@{#318897}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Application of https://codereview.chromium.org/962003002/.
TBR=keybuk@chromium.org
R=brettw@chromium.org
BUG=456014
Review URL: https://codereview.chromium.org/960413003
Cr-Commit-Position: refs/heads/master@{#318574}
|
|
|
|
|
|
|
|
|
|
|
| |
Testing shows that this change is correct, but there was no evidence supporting the other change. Will manually run the x64 dbg test try bot for this change.
TBR=thakis@chromium.org,jvoung@chromium.org
BUG=458690,460563
Review URL: https://codereview.chromium.org/942003008
Cr-Commit-Position: refs/heads/master@{#318160}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes process_version template. In GYP this is used in two ways and the GN version only supported one of these. This change also deletes an unnecessary fork of the template file, and fixes the dependencies for the extra files (previously they were just passed with "-f" and not added to the inputs of the target.
Adds a cdm_adapter template which basically matches the GYP version. Uses this for the media clearkey adapter and the widevine one in the official build.
Fixes for the crypto targets when compiling with the official build's checked-in sysroots.
Review URL: https://codereview.chromium.org/949233003
Cr-Commit-Position: refs/heads/master@{#318083}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:40001 of https://codereview.chromium.org/921353002/)
Reason for revert:
Speculative revert after discussion on IRC, this seems pretty unlikely but may have caused the failures at:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35506
Original issue's description:
> sandbox: Fix some nt_internals.h function prototypes for Win64
>
> NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes.
>
> NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes.
>
> DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change.
>
> R=robertshield@chromium.org,rvargas@chromium.org
> BUG=458690
>
> Committed: https://crrev.com/4ede4e174a51d08262edfb2e2c05845504bd9b1a
> Cr-Commit-Position: refs/heads/master@{#317177}
TBR=jschuh@chromium.org,robertshield@chromium.org,thakis@chromium.org,wfh@chromium.org,rvargas@chromium.org,rnk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458690
Review URL: https://codereview.chromium.org/943043002
Cr-Commit-Position: refs/heads/master@{#317409}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu
as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate.
R=brettw@chromium.org
TBR=ddorwin@chromium.org
EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
BUG=344767
Review URL: https://codereview.chromium.org/913373002
Cr-Commit-Position: refs/heads/master@{#317223}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes.
NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes.
DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change.
R=robertshield@chromium.org,rvargas@chromium.org
BUG=458690
Review URL: https://codereview.chromium.org/921353002
Cr-Commit-Position: refs/heads/master@{#317177}
|
|
|
|
|
|
|
|
| |
BUG=454018
Review URL: https://codereview.chromium.org/891813003
Cr-Commit-Position: refs/heads/master@{#314213}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoids ninja expecting an import .lib to be generated so that it doesn't
continually rebuild because the import lib is "missing".
To be landed after gyp roll at https://codereview.chromium.org/890043003/ lands.
R=robertshield@chromium.org
BUG=342974,451499
Review URL: https://codereview.chromium.org/886123002
Cr-Commit-Position: refs/heads/master@{#314008}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/832583007
Cr-Commit-Position: refs/heads/master@{#312814}
|
|
|
|
|
|
|
|
|
|
| |
These dlls have been causing stability issues.
BUG=
Review URL: https://codereview.chromium.org/852843002
Cr-Commit-Position: refs/heads/master@{#312392}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/837033002
Cr-Commit-Position: refs/heads/master@{#311053}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This driver has persistent issues, we previously blacklisted it for
http://crbug.com/378465 but came up with a workaround and thus it
was allowed again. Now we're getting renderer hangs because it
blocks a sync ipc from completing on the audio thread.
Given the multiple issues and high install base, I think we should
permanently blacklist this dll from loading.
BUG=422522
TEST=none
Review URL: https://codereview.chromium.org/838683002
Cr-Commit-Position: refs/heads/master@{#310556}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the top crashes for Chrome 38 and 39 is a crash due
to some issue in YCWebCameraSource.ax, which is a component
of CyberLink Youcam software. Let's blacklist it for now,
to stop Chrome from crashing repeatedly.
BUG=424159
Review URL: https://codereview.chromium.org/831223003
Cr-Commit-Position: refs/heads/master@{#310284}
|
|
|
|
|
|
|
|
| |
BUG=429173
Review URL: https://codereview.chromium.org/698533002
Cr-Commit-Position: refs/heads/master@{#302274}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=427616
/analyze pointed out that the loop range-check used the comma operator
when && was probably intended. The bug was harmless, but confusing, so
I fixed it.
/analyze also pointed out that the code was checking data read by a
function and then checking whether the read succeeded. Reversing the
order of the checks has no effect except to get rid of the undefined
behavior.
Review URL: https://codereview.chromium.org/678193003
Cr-Commit-Position: refs/heads/master@{#301691}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/654753008
Cr-Commit-Position: refs/heads/master@{#300823}
|
|
|
|
|
|
|
|
|
|
|
| |
This step is a complete search for OVERRIDE to
replace it with its lowercase versions.
BUG=417463
Review URL: https://codereview.chromium.org/644783004
Cr-Commit-Position: refs/heads/master@{#299241}
|
|
|
|
|
|
|
|
|
|
|
| |
Quick Report reports they have fixed the issue and the dll now works
correctly with chromium.
BUG=382561
Review URL: https://codereview.chromium.org/617453002
Cr-Commit-Position: refs/heads/master@{#297178}
|
|
|
|
|
|
|
|
|
| |
BUG=416722
R=gab@chromium.org, robertshield@chromium.org
Review URL: https://codereview.chromium.org/603803002
Cr-Commit-Position: refs/heads/master@{#296819}
|
|
|
|
|
|
|
|
|
|
| |
This param has been unused since http://crrev.com/234367 and makes the method confusing.
BUG=314800
Review URL: https://codereview.chromium.org/575253002
Cr-Commit-Position: refs/heads/master@{#295400}
|
|
|
|
|
|
|
|
|
|
| |
and components/
Also fix the formatting of chrome_elf/OWNERS
Review URL: https://codereview.chromium.org/546733002
Cr-Commit-Position: refs/heads/master@{#294245}
|
|
|
|
|
|
|
|
|
|
|
| |
cespy.dll is a LSP and preventing it from loading in Chrome prevents
users from accessing the internet.
BUG=399968
Review URL: https://codereview.chromium.org/545003006
Cr-Commit-Position: refs/heads/master@{#293812}
|
|
|
|
|
|
|
|
|
|
|
| |
I think the older order could result in incorrect behavior if Chrome
crashed during startup. This might help with the bug as well.
BUG=406475
Review URL: https://codereview.chromium.org/500563002
Cr-Commit-Position: refs/heads/master@{#291679}
|
|
|
|
|
|
|
|
|
| |
BUG=394532
TEST=unit_tests
Review URL: https://codereview.chromium.org/444543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=399744
Review URL: https://codereview.chromium.org/440663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=370153
Review URL: https://codereview.chromium.org/434143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=397137,396244
TEST=chrome_elf_unittests
NOTRY=true
Review URL: https://codereview.chromium.org/418033004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
minisp.dll (seems to be malware)
cespy.dll (CovenantEyes)
cplushook.dll (seems to be malware)
BUG=
Review URL: https://codereview.chromium.org/354063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added a unit test to environment_data_collection_win_unittest.cc
Edited chrome_elf_init_win.cc and blacklist.cc so that the registry is
only cleared immediately before being repopulated (and safe browsing is not left
with an empty registry to read from).
BUG=
Review URL: https://codereview.chromium.org/346763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/353873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/357733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/349693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/343613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/332193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added UMA recording of the blacklist disabled and retry succeeded events.
Deprecating the blacklist start up events 'BLACKLIST_THUNK_SETUP_FAILED' and
'BLACKLIST_INTERCEPTION_FAILED' as we are switching over to a more coarse
grained recording of the set up status (this information can be gathered from
crash reporting now anyways).
BUG=
Review URL: https://codereview.chromium.org/311893005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/325323003/)
Reason for revert:
No crashes have been found after 37.0.2046.2 and Canary on Windows is now on 37.0.2051.2, hence it looks good. Not sure if was the blacklisting or the "calling CoInitializeEx twice" patch which did the trick here.
I would like to revert the blacklisting patch to see if we can cope with the CoInitializeEx patch only. It would be great if we could avoid adding another DLL to the blacklist.
Original issue's description:
> Blacklists virtualCamera.ax.
>
> Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator.
>
> BUG=383715, 378465
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276946
TBR=tommi@chromium.org,robertshield@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383715, 378465
Review URL: https://codereview.chromium.org/335073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This comment roughly explains when the blacklist should be used, as well
as linking to the blacklist policy.
R=robertshield@chromium.org
BUG=
Review URL: https://codereview.chromium.org/334913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator.
BUG=383715, 378465
Review URL: https://codereview.chromium.org/325323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These DLLs were causing major instabilities on Stable Channel.
BUG=379218
NOTRY=true
Review URL: https://codereview.chromium.org/320653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The finch blacklist is collected from finch in chrome_elf_init_win.cc,
stored in a registry, and added to the blacklist in blacklist.cc.
BUG=
Review URL: https://codereview.chromium.org/300933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/298893004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: https://codereview.chromium.org/292123011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=362783
Review URL: https://codereview.chromium.org/292933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need a +4GB base so the loader will randomize above 4GB.
BUG=361670
R=robertshield@chromium.org,jam@chromium.org
NOTRY=TRUE
Review URL: https://codereview.chromium.org/233413008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We've seen different failure related to the fact that we use the same flag without providing the same API and functionality.
BUG=
TBR=jamesr
Review URL: https://codereview.chromium.org/212643015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=353978
Review URL: https://codereview.chromium.org/208273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/206223006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add functionality to ServiceResolverThunk to copy a thunk without patching.
2. Move chrome_elf thunk-handling code to a common location.
3. Use a thunk instead of a f'n ptr for redirects.
BUG=334379
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255151
Review URL: https://codereview.chromium.org/183833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257749 0039d316-1c4b-4281-b951-d872f2087c98
|