summaryrefslogtreecommitdiffstats
path: root/chrome_frame/test
Commit message (Collapse)AuthorAgeFilesLines
* Some more chrome frame test pure virtual function call crash fixes. There is ↵ananta@chromium.org2010-04-263-2/+15
| | | | | | | | | | | | | | | | | | another crash which occurs when the remote COM apartment running in Ie shuts down and tries to free references to the web browser event sink. We unsubscribe from the event sink in the destructor of the ComStackObjectWithUninitialize object. The call to DispEventUnadvise fails every time. Unsubscribing and call CoDisconnectObject to release the server side stub references in the OnQuit notification fixes the crash. To aid debugging this issue in the future we now override the purecall handler in chrome frame tests. Bug=41980 TBR=amit Review URL: http://codereview.chromium.org/1695015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45569 0039d316-1c4b-4281-b951-d872f2087c98
* More chrome frame test crash fixes. At times we fail to create the HTTP ↵ananta@chromium.org2010-04-241-2/+7
| | | | | | | | | | | | | server and end up crashing while dereferencing a NULL server pointer. Added expectations and checks to handle this gracefully. Bug=41980 TBR=amit Review URL: http://codereview.chromium.org/1706011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45526 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the flakiness with the ChromeFrame FullTabModeIE_KeyboardTest ↵ananta@chromium.org2010-04-233-6/+11
| | | | | | | | | | and the FullTabModeIE_WindowOpenInChrome test. We need to set focus to the Chrome renderer window. Review URL: http://codereview.chromium.org/1736014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45515 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing fixes for chrome frame test pure virtual function call crashes. ↵ananta@chromium.org2010-04-231-4/+8
| | | | | | | | | | | | | | | One of these fixes is in the ChromeFrame ActiveX where we were invoking the onload/onmessage handlers on a NULL interface pointer. The other fix is in the chrome frame test code where we need to protect against reentrancy while in the context of an outgoing COM interface call. Fixes http://code.google.com/p/chromium/issues/detail?id=41980 Bug=41980 Review URL: http://codereview.chromium.org/1691012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45481 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing attempt to fix chrome frame tests crashes. Moving the ↵ananta@chromium.org2010-04-231-4/+4
| | | | | | | | | | | | ComObjectstackEx instances which handle new IE windows to before the message loop to ensure that they remain valid when the message loop is destroyed. Bug=41980 Review URL: http://codereview.chromium.org/1761005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45387 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt to fix the pure virtual function call crash in chrome frame ↵ananta@chromium.org2010-04-221-25/+25
| | | | | | | | | | | | | | | | | tests. This crash happens because the timed message loop object attempts to destroy pending tasks, which point to a deleted CComObjectStackEx instance in its destructor. Fix is to ensure that the CComObjectStackEx instance which holds chrome frame mocks outlives the message loop. Fixes http://code.google.com/p/chromium/issues/detail?id=41980 Bug=41980 TBR=stoyan Review URL: http://codereview.chromium.org/1772001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45342 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Factor out reading and writing of preferences into |PrefStore|."bauerb@chromium.org2010-04-221-1/+2
| | | | | | | | | | | | | | | | | | | The CL now applies after r45225 (Throw out preferences files that are corrupt rather than keeping them in read-only mode), which means that the changes in that commit moved to JsonPrefStore. I updated JsonPrefStoreTest.InvalidFile to test the new behavior. *** In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1717007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45309 0039d316-1c4b-4281-b951-d872f2087c98
* The HttpNegotiateTest.ReportProgress test fails on IE6 as we fail to ↵ananta@chromium.org2010-04-223-5/+39
| | | | | | | | | | retrieve the IBrowserService interface. Disabling this test for IE6 for now. Review URL: http://codereview.chromium.org/1731003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45277 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to fix the pure virtual function call crash in chrome frame test ↵ananta@chromium.org2010-04-211-3/+16
| | | | | | | | | | | | | | | | runs. It appears to be caused by a race condition during disconnecting from chrome frame and receiving a callback from IE (Chrome Frame). Added checks to detect and work around this issue. Should fix http://code.google.com/p/chromium/issues/detail?id=41980 Bug=41980 Review URL: http://codereview.chromium.org/1703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45233 0039d316-1c4b-4281-b951-d872f2087c98
* Only switch to cf for text/html. With opt-in URLs we could mark a URL to be ↵tommi@chromium.org2010-04-214-28/+189
| | | | | | | | | | | loaded in CF regardless of the target mime type. If CF turns around and wants to download the target, we would hit an infinite loop. TEST=Verify that issue 40046 is resolved. OptIn urls should work with the moniker patch and downloads should not cause an infinite loop. BUG=40046 Review URL: http://codereview.chromium.org/1715004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45226 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45168 - Reland r45028: Factor out reading and writing of preferences ↵erikkay@chromium.org2010-04-211-2/+1
| | | | | | | | | | | | | | | | | | into |PrefStore|. In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1687001 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/1688004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45200 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45028: Factor out reading and writing of preferences into |PrefStore|.bauerb@chromium.org2010-04-211-1/+2
| | | | | | | | | | | | | In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1687001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45168 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame with the moniker patch enabled we should not process optin ↵ananta@chromium.org2010-04-202-11/+0
| | | | | | | | | | | | urls in the BHO. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42155 Bug=42155 Review URL: http://codereview.chromium.org/1706003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45117 0039d316-1c4b-4281-b951-d872f2087c98
* Handle cookie requests in BackgroundThread.stoyan@chromium.org2010-04-201-1/+1
| | | | | | | | | Enable the unload event test. BUG=40814 TEST=unload event test Review URL: http://codereview.chromium.org/1629027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45042 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45028 - Factor out reading and writing of preferences into |PrefStore|.thomasvl@chromium.org2010-04-201-2/+1
| | | | | | | | | | | | | | | | In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1523023 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/1682001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45038 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out reading and writing of preferences into |PrefStore|.bauerb@chromium.org2010-04-201-1/+2
| | | | | | | | | | | | | In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1523023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45028 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the ChromeFrame IMoniker patch by default now.ananta@chromium.org2010-04-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1650015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44991 0039d316-1c4b-4281-b951-d872f2087c98
* Make X-Frame-Options detection in Chrome Frame non-case-sensitive, as it ↵robertshield@chromium.org2010-04-201-0/+7
| | | | | | | | | | | should be. BUG=42019 TEST=X-FRAME-OPTIONS et al start to work. Review URL: http://codereview.chromium.org/1539045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44988 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44898 - Disable two test cases in the BeginningTransaction test until ↵tommi@chromium.org2010-04-191-13/+9
| | | | | | | | | | | | | | | I fix them. TEST=none BUG=none TBR=amit Review URL: http://codereview.chromium.org/1633020 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/1648017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44920 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two test cases in the BeginningTransaction test until I fix them.tommi@chromium.org2010-04-181-9/+13
| | | | | | | | | | TEST=none BUG=none TBR=amit Review URL: http://codereview.chromium.org/1633020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44898 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the following net tests for ChromeFrame as they rely on ↵ananta@chromium.org2010-04-161-0/+5
| | | | | | | | | | | | | | | functionality provided by Chrome's network stack like the ability to override a proxy for a URL request, etc. 1. URLRequestTestHTTP.ProxyTunnelRedirectTest 2.URLRequestTestHTTP.UnexpectedServerAuthTest. TBR=amit Review URL: http://codereview.chromium.org/1667003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44828 0039d316-1c4b-4281-b951-d872f2087c98
* Fix expectations for MonikerPatchTest unit testsamit@chromium.org2010-04-161-2/+2
| | | | | | | | | | | | | | | | The contract of the cache stream is changed to return S_FALSE if the data is completely read and this was the last data notification. Adjusted unit test expectations accordingly BUG=none TEST=Tests from MonikerPatchTest TBR=ananta Review URL: http://codereview.chromium.org/1523027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44747 0039d316-1c4b-4281-b951-d872f2087c98
* With the ChromeFrame moniker patch on, the data cache maintained to indicate ↵ananta@chromium.org2010-04-161-2/+2
| | | | | | | | | | | | | | | whether we should switch to Chrome, was not being drained correctly to the delegate, resulting in the delegate continuing to wait for more data when there was none. This caused sites like go/wave to not redirect correctly to CF. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41365 Bug=41365 Review URL: http://codereview.chromium.org/1637017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44735 0039d316-1c4b-4281-b951-d872f2087c98
* With the ChromeFrame IMoniker patch in the referrer would not propagate ↵ananta@chromium.org2010-04-161-2/+1
| | | | | | | | | | | | | | | | | | | | correctly to Chrome when we switch from IE to CF. In ChromeFrame the referrer is set in the navigation manager which receives this in the IHttpNegotiate::BeginningTransaction patch. When we switch from IE to cF via the moniker patch we receive two calls to BeginningTransaction, the first one with the referrer and the other one without the referrer for the same URL causing the referrer to be overwritten. Fix is to handle this case. The referrer is cleared in our BeforeNavigate notification. I also moved some functions to chrome frame utils as part of this CL. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41680 Bug=41680 Review URL: http://codereview.chromium.org/1653006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44733 0039d316-1c4b-4281-b951-d872f2087c98
* Change tests expectation to suit the new codeamit@chromium.org2010-04-161-15/+11
| | | | | | | | | | | BUG=NONE TEST=NavigationToRestrictedSite TBR=ananta Review URL: http://codereview.chromium.org/1629022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44731 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a failing test temporarilyamit@chromium.org2010-04-151-1/+2
| | | | | | | | | | | BUG=41680 TEST=referrer test TBR=ananta Review URL: http://codereview.chromium.org/1631020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44713 0039d316-1c4b-4281-b951-d872f2087c98
* The timeout for the ChromeFrame FullTabModeIE_KeyboardTest was incorrectly ↵ananta@chromium.org2010-04-151-1/+1
| | | | | | | | | | | | set to 0x9999 in a recent CL. Correcting this to get the IE8 builder green. TBR=amit Review URL: http://codereview.chromium.org/1545039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44651 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit of the ill-fated r44474, this time with new compiling goodness.robertshield@chromium.org2010-04-147-0/+203
| | | | | | | | | | | | Add multi-version delegation to Chrome Frame such that CF will scan for older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running. BUG=40117 TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening. TBR=tommi Review URL: http://codereview.chromium.org/1585037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44522 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the expectations for the ChromeFrame FullTabModeIE_BackForwardAnchor ↵ananta@chromium.org2010-04-143-9/+33
| | | | | | | | | | test to get it to work on IE6. It appears that on IE6 we don't receive the BeforeNavigate notifications for the anchor URLs. Review URL: http://codereview.chromium.org/1568032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44495 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44473 (build breakage on bots) - Add multiversion delegation to ↵robertshield@chromium.org2010-04-147-203/+0
| | | | | | | | | | | | | | | Chrome Frame such that CF will scan for older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running. BUG=40117 TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening. Review URL: http://codereview.chromium.org/1562018 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/1604035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44474 0039d316-1c4b-4281-b951-d872f2087c98
* Add multi-version delegation to Chrome Frame such that CF will scan for ↵robertshield@chromium.org2010-04-147-0/+203
| | | | | | | | | | | | older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running. BUG=40117 TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening. Review URL: http://codereview.chromium.org/1562018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44473 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FileVersionInfo into an interface with platform implementations.tony@chromium.org2010-04-141-1/+4
| | | | | | | | | | | | | This allows us to move the chrome specific version informaton used by Linux into src/chrome. Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome. In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell. Review URL: http://codereview.chromium.org/1560027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame FullTabModeIE_AnchorUrlNavigateTest test only works if the ↵ananta@chromium.org2010-04-141-0/+3
| | | | | | | | | | IMoniker patch is enabled. TBR=amit Review URL: http://codereview.chromium.org/1575039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44432 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for remaining major issues with moniker patchamit@chromium.org2010-04-142-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes things so that they now work 'naturally', i.e switch to chrome frame looks just like switching to pdf. The same bind context and underlying network transaction objects are used and requests aren't sent multiple times. Finally the TestPostReissue test is happy! This patch fixes two issues with earlier scheme: Issue 1: data can be read only once from a given bind context. Mshtml looks at the mime type in the FORMATETC but never issues a read. So when it switches, the new active document can read from start. Since we are reading the data for switching, when we actually switch, we have to transfer over the data read so far to our UrlmonUrlRequest. Issue 2: The very first UrlmomUrlRequest has to start binding right away, in the context of BindToStorage or network transcations associated with the bind context are gone (due to OnStopBinding for BindToObject). TEST=covered by existing tests BUG=33332 Review URL: http://codereview.chromium.org/1508033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44427 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame SaveAs test which always failed on the chrome frame ↵ananta@chromium.org2010-04-131-0/+3
| | | | | | | | | | | | | | | builder. This test creates a temporary file name and feeds the path to the SaveAs dialog put up by Chrome. If the file already existed the test fails. The other problem was that Chrome appends the .htm extension to the path passed in which caused the subsequent GetFileAttributes expectation to fail. Fix is to replace the .tmp extension in the temporary file name with .htm and to delete the file initially before starting the test. This test is still marked as flaky as it expects programmatic keyboard input. Review URL: http://codereview.chromium.org/1613015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44411 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the expectations for the ChromeFrame NavigateOk test so that it passes ↵ananta@chromium.org2010-04-131-1/+1
| | | | | | | | | | | | on IE8. It appears that the OnUpdateTargetUrl notification is not received at times on IE8. TBR=amit Review URL: http://codereview.chromium.org/1612015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44399 0039d316-1c4b-4281-b951-d872f2087c98
* Preparation CL for executing READ and COOKIE network requests from the ↵stoyan@chromium.org2010-04-131-0/+2
| | | | | | | | background thread. Review URL: http://codereview.chromium.org/1520033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44369 0039d316-1c4b-4281-b951-d872f2087c98
* IE would not switch into ChromeFrame if the url being navigated to had an ↵ananta@chromium.org2010-04-131-1/+35
| | | | | | | | | | | | | | | | | | | | anchor. The IsTopLevelUrl function exposed by the navigation manager would compare the URL received in the BHO which has the anchor and the URL received from the anchor which does not have the anchor. As a result we would not wrap the bind status callback which caused this issue. The IsTopLevelUrl function now compares the URLs after stripping the anchor portion in the URL. Should fix bug http://code.google.com/p/chromium/issues/detail?id=38265. This only works if the moniker patch is enabled. Bug=38265 Test=Covered by unit test. Review URL: http://codereview.chromium.org/1559027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44309 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome_launcher to the list of processes terminated at the beginning and ↵ananta@chromium.org2010-04-123-0/+3
| | | | | | | | | | | | end of chrome frame test runs. This is to get around extract build failures on the IE6 builder as chrome launcher does not shutdown at times. TBR=amit Review URL: http://codereview.chromium.org/1646001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44248 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build by commenting the tests in UrlmonMonikerTest.amit@chromium.org2010-04-091-1/+2
| | | | | | | | | | | I have to rewrite those tests anyway. TBR=ananta Review URL: http://codereview.chromium.org/1626008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44042 0039d316-1c4b-4281-b951-d872f2087c98
* Switch renderer in Moniker patchamit@chromium.org2010-04-094-301/+358
| | | | | | | | | | Step one of the changes. Inspect data and cause a switch in the moniker patch. Review URL: http://codereview.chromium.org/1589013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44038 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame tests should use IWebBrowser::Quit to quit IE. This ensures ↵ananta@chromium.org2010-04-081-5/+1
| | | | | | | | | | that the OnQuit notification is received correctly on IE6. Review URL: http://codereview.chromium.org/1574020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44015 0039d316-1c4b-4281-b951-d872f2087c98
* Fix horrible bug in Cache.stoyan@chromium.org2010-04-081-0/+72
| | | | | | | Unittest added. Review URL: http://codereview.chromium.org/1611012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44011 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to get the ChromeFrame IE6 builder on FYI green. I had to tweak the ↵ananta@chromium.org2010-04-083-22/+101
| | | | | | | | | | | | | | | | | | | | | | test expectations a bit because the OnQuit notification does not seem to show up on IE6 for some reason. We can debug that later. The sideeffect of this would be that the relevant tests which rely on the OnQuit notification would run for the duration of the loop. We also needed to check in the ConnectToChromeFrame helper if we are already connected. This is for the AttachExternalTab case where we could receive the NavigateComplete event twice. While debugging this on my local IE6 VM I found that the calls to register/unregister chrome frame would take for ever on the VM. This was because the ExceptionHandler would try to setup and unwind. This only works correctly for official builds. To workaround this we launch the crash server for the duration of the test and run the chrome frame tests under headless mode. The FullTabModeIE_BackForwardAnchor test still fails on IE6. This is marked as FLAKY anyway. I will send out a separate CL addressing this issue. Review URL: http://codereview.chromium.org/1564018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43975 0039d316-1c4b-4281-b951-d872f2087c98
* Mark FullTabModeIE_UnloadEventTest as flaky, while investigating the reason ↵stoyan@chromium.org2010-04-081-1/+1
| | | | | | | | | (perhaps caused by http://src.chromium.org/viewvc/chrome?view=rev&revision=43953) TBR=amit Review URL: http://codereview.chromium.org/1525019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43963 0039d316-1c4b-4281-b951-d872f2087c98
* Move Urlmon network requests to UI thread, thus allowing reusing the bind ↵stoyan@chromium.org2010-04-082-19/+26
| | | | | | | | | | | | | context (and already fetched data) via INET_E_TERMINATED_BIND error code. Make caching of data more sensible, so the UI does not freeze (the reason why url request have been moved to a background thread). Always return INET_E_TERMINATED_BIND on OnDataAvailable when BSCF_LASTDATANOTIFICATION flag is detected, so if a subsequent DownloadToHost request comes from Chrome, bind context and already fetched data can be reused. BUG=36694 Review URL: http://codereview.chromium.org/1523014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43953 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame net tests would not work on IE6 and IE7. This is because the ↵ananta@chromium.org2010-04-074-16/+29
| | | | | | | | | | | | | | | profile path used varies across these browsers. This changed in the recent fixes for privacy where on IE6 and IE7 the profile is in temporary internet files. The ChromeFrame net tests assumed the profile would always be in the default path which caused the tests to not work. Added a helper function in chrome_Frame_test_utils.cc/.h to retrieve the correct profile path based on IE version and use this. This should get the net tests up and running on the FYI IE6 builder. Review URL: http://codereview.chromium.org/1553015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43856 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the FullTabModeIE_TestPostReissue ChromeFrame test as this test ↵ananta@chromium.org2010-04-072-8/+7
| | | | | | | | | | | | | | | only runs if the moniker patch is enabled. The moniker patch is turned off by setting its default value to PATCH_METHOD_IBROWSER. The NavigationToRestrictedSite test is also dependent on the moniker patch for some reason. Added code to turn this test off if this patch is disabled. The FullTabModeIE_ReferrerTest test was incorrectly being turned off if the moniker patch was disabled. This test does not rely on the moniker patch. Review URL: http://codereview.chromium.org/1520021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43806 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the bug number for the disabled chrome frame tests.ananta@chromium.org2010-04-062-2/+2
| | | | | | | | TBR=amit Review URL: http://codereview.chromium.org/1562012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43682 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the NavigationToRestrictedSite ChromeFrame test as it relies for ↵ananta@chromium.org2010-04-051-1/+2
| | | | | | | | | | | some reason on the moniker patch to be around. Bug=40266 TBR=amit Review URL: http://codereview.chromium.org/1568014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43661 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 23:52:11 +0000