| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
For this patch, I skipped over any instance where it wasn't a nearly trivial
change.
Review URL: http://codereview.chromium.org/3069014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
maintained GURL members holding the url and
referrer. We can stuff this information into the ChromeFrameLaunchParams member maintained by the client. This
reduces the complexity in the code related to detecting whether we can navigate up front or after chrome initialization.
The ChromeFrame ActiveX now launches the automation server in its implementation of IPersistPropertyBag::Load. This avoids
race conditions between launching the automation server and navigating to it via put_src.
Review URL: http://codereview.chromium.org/3038038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to net/test/test_server.h
No code changes, just a move.
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/3034038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookies in the outgoing HTTP requests.
To achieve this we no longer issue navigations with the gcf:attach* prefix. We now issue a navigation to the current
page URL with the attach external tab suffix, which indicates that the page is forced into ChromeFrame without making
an actual HTTP request. This ensures that the new IE8 process has access to all HTTP cookies.
We need to patch IInternetProtocol::LockRequest and UnlockRequest to not call the underlying implementations for our
dummy request as this crashes in IE8 in the prebinding code path.
Fixes bug http://b/issue?id=2277519
Added tests for the CanNavigateFullTabMode helper function.
Bug=2277519
Review URL: http://codereview.chromium.org/3051018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3068004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reloads the current page via the gcf: protocol to load
it in chrome. The page when loaded in Chrome validates whether the cookies were set. This does not work correctly on IE8 in Vista
and windows 7 as the cookie stores are partitioned.
Fix is redirect the page to a target page which validates the cookies.
Review URL: http://codereview.chromium.org/3053018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- simplify the public interface
- remove unneeded methods
- make it easier to understand
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/2881028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3029019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
headers to be terminated by
a single \r\n combination as wininet adds the terminating \r\n at the end while sending the headers out.
TBR=stoyan
Review URL: http://codereview.chromium.org/2888019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2825053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests issued by chrome.
--host-resolver-parallelism=XXX
This is a useful debugging tool, since for some users too many parallel DNS requests results in spurious DNS failures from their resolver.
BUG=44489
Review URL: http://codereview.chromium.org/3019007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=should be no functional change except if there are buggy BHOs that we know of loaded in IE.
BUG=44463
Review URL: http://codereview.chromium.org/2906011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occur if the page had an unload handler.
We execute unload handlers in the WM_DESTROY message in the external tab and spin a nested loop waiting for the
unload handlers to finish. This causes a deadlock at times if a windows message is dispatched to IE which is blocked
in DestroyWindow.
The fix is to remove the nested loop mess from the external tab and instead send over a special automation message
to Chrome in which context we execute the unload handlers. The message contains the notification window and the
actual window message to be posted back when the unload handlers finish executing.
The active document/activex spin a GetMessage loop waiting for this message to arrive. To ensure that we don't wait
indefinitely we have a 1 second timer and exit the loop if this timer is received.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=49132
Bug=49132
Test=Covered by existing unload event test.
Review URL: http://codereview.chromium.org/3014001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hang occurs because of a race condition
in registering the http/https protocol factories. The net tests registers a protocol factory and the Chrome
AutomationResourceMessageFilter also registers factories. If the net tests ends up being first in the chain then
the requests are incorrectly dropped.
Fix is to register the net tests protocol factory before instantiating the AutomationResourceMessageFilter.
TBR=stoyan
Review URL: http://codereview.chromium.org/2959013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2934005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
seems to be a race condition causing
the tests to hang on startup on the builder. It appears that on chrome frame net tests startup we process an initial
HTTP head request in the test automation provider factory and end up sending this as the response to IE instead of
the expected dummy chrome frame page. This causes the tests to hang.
Fix is to also check for a valid tab handle in the test automation provider factory instead of just asserting for
the same.
TBR=amit
Review URL: http://codereview.chromium.org/2951015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
history if the back and the current page both
were rendered in ChromeFrame. This was because the back operation would incorrectly navigate twice. Once via IE history
navigation and the other navigation would originate within the renderer and would execute as a new navigation in IE.
Fix is to not report backforward navigations as top level navigations to the external host.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=44403
Bug=44403
Test=Covered by ChromeFrame test
Review URL: http://codereview.chromium.org/2982003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sink tests. Have the test mock contain, not inherit the IE event sink. Use the new test server to verify the right requests are being sent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2822016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefs, to manage preferences set by extensions.
Update various callers of the PrefValueStore constructor accordingly.
The initial user will be the proxy extension API.
BUG=266
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/2823037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stoyan
Bug=48175
Review URL: http://codereview.chromium.org/2886019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Upstreamed support for partial results from devtools' version
- Made DidRead receive data and length (in order to support websockets data)
- Fixed all the clients.
Added net/server with http socket implementation that supports websockets. Will remove net/tools fetch client and server later.
Review URL: http://codereview.chromium.org/2868036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead. XP ignores pages read as data
while mapping image sections. This shows a reasonable improvement in cold startup performance on XP.
This change only comes into effect for headless mode which enables us to try out the effect on the perf bots
and for chrome frame processes.
Code mostly written by Amit.
Added a chrome frame perf tests which measures LoadLibrary in cold mode with pre-reading.
Bug=45510
Review URL: http://codereview.chromium.org/2805064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable chrome to display all cookies used/blocked on the current site to the user instead of just the information that something was blocked. The cookies are collected in data structures suitable for displaying them using the cookies tree model.
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2370001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=48175
Review URL: http://codereview.chromium.org/2810045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to not terminate at times leading to
extract build failures.
TBR=amit
Bug=47596
Review URL: http://codereview.chromium.org/2838036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address bar to initiate navigation.
These tests fail at times on the builders because of an incorrect URL actually being sent in to Chrome.
Fix is to increase the delay between selecting the address bar via Alt+D and sending the url.
TBR=amit
Review URL: http://codereview.chromium.org/2827036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that the dll unloads correctly
after every test.
Review URL: http://codereview.chromium.org/2813039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to enabling them dynamically - only when the application really needs
them.
I am working on some test cases for this, and will add them. But wanted
to send out the concept for review.
In this implementation, I modify the message loop to detect when the
application has requested high resolution timers. Note that there are
multiple MessageLoops active in a single process. After a period of
time, we simply shut it off again. We could have set a timer or
kept a count of active timers, or any number of more complex algorithms.
But I think this algorithm is very simple and good enough. If an
application continues needing high resolution timers for more than 1s,
we'll turn the high-resolution timers back on again.
One last change - since we've implemented the clamp at 4ms, there isn't
a lot of point to our use of 1ms for timeBeginPeriod. I've modified
that to 2 (which is half of 4ms, our target minimal interval).
BUG=46531
TEST=MessageLoop.HighResolutionTimers
Review URL: http://codereview.chromium.org/2822035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crash for subsequent test runs.
Bug=47812
TBR=amit
Review URL: http://codereview.chromium.org/2845030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test fails because of a crash while running
one of the chrome frame creation tests. This test causes a crash on the builder and it appears to occur because of multiple
chrome frame dlls being loaded in the process. One from the regular release\servers folder and the other one from the
reference build.
Attempted fix is to add a sleep after the call to CoFreeUnusedLibraries to allow the currently loaded chrome frame binary
to unload.
TBR=amit
Review URL: http://codereview.chromium.org/2840024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
times does not unload the chrome frame dll. Removing
the corresponding expectation that validates whether the dll has been unloaded.
TBR=amit
Review URL: http://codereview.chromium.org/2847033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use a process-wide object (singleton pattern)
* Create/destroy this object on the main thread, make it outlive all consumers
* Make observer-related functions threadsafe
As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around).
BUG=none
TEST=Unittests; network changes still trigger notifications
Review URL: http://codereview.chromium.org/2802015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
mode and also start crash_service.exe, which
would serve as the crash handler for the duration of the test runs. This ensures that the tests don't hang for 60 seconds
while unloading the chrome frame dll which waits for the exception handler code to uninitialize which blocks on machines
which don't have the official crash server running.
Review URL: http://codereview.chromium.org/2810024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DocumentComplete event at times is fired twice by all
IE versions for new windows. Updated the expectations to account for this.
TBR=stoyan
Review URL: http://codereview.chromium.org/2802017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
additional DocumentComplete event fired
on IE8 as well on the same lines as IE7. This event fires twice randomly. Modified the expectations to handle this.
TBR=stoyan
Review URL: http://codereview.chromium.org/2799026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pass. On IE7 the DocumentComplete
event is fired twice at times for popup windows. We need to add expectations for those.
TBR=stoyan
Review URL: http://codereview.chromium.org/2809031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
onload notification, which is blocked on
IE7/8 by the popup blocker thus causing this test to consistently fail. Fix is to open the popup in the ondblclick
notification and to fire dummy mouse down events to the IE window to trigger this event.
TBR=amit
Review URL: http://codereview.chromium.org/2866013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
target blank which target a different origin
should initiate the navigation in the host browser. We achieve this by performing an origin check on the opener frame
and the URL being opened. If the origins don't match we allow the host browser to handle this navigation.
There is still one issue here as a popup window creation request is still initiated and sent out to the host browser
which initiates a dummy attach external tab navigation. Subsequently while applying policy the OpenURL IPC is sent out
to the host browser which initiates the navigation to the expected URL. This causes a dummy attach external tab entry
to be created in the host browser's history which would have to be deleted.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=46667
Bug=46667
Test=Covered by new chrome frame unit test.
Review URL: http://codereview.chromium.org/2855017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NavigationToRestrictedSite test. It appears
that on IE7 we don't receive the NavigateComplete notification. The protocol patch is now active on the IE7 builder
TBR=stoyan
Review URL: http://codereview.chromium.org/2835010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1: Convert RegisterStringPref.
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/2809022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame internet protocol
patch. Basically the change is to add an additional BeforeNavigate2 expectation for the error page.
Review URL: http://codereview.chromium.org/2842012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
suggested dimensions and would end up
opening a default top level browser window in IE.
ChromeFrame does receive the dimensions from the external tab container when it is notified about a popup being
opened.
Fix is to honor these dimensions by passing them off in the specially crafted url containing other arguments.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=42250
This fix is currently implemented for IE full tab mode only.
Bug=42250
Test=Covered by augmenting the existing window open test to also validate the window size. Added a new unit test
to test the ParseAttachExternalTabUrl helper function.
Review URL: http://codereview.chromium.org/2867007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RunnableMethods easier.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2830006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if_modified_since, etc to pass through the host network
stack. Filtering out these issues causes POST requests issued by buzz to fail.
Fixes bug http://b/issue?id=2321282
Bug=2321282
Test=Covered by ChromeFrame unit test.
Review URL: http://codereview.chromium.org/2846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needs some plumbing in the external tab
container to populate the navigation history for the tab contents when it is created.
Bug=46615
TBR=amit
Review URL: http://codereview.chromium.org/2813009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
net::HttpNetworkDelegate is an interface for providing hooks into http network activity. ChromeNetworkDelgate implements this interface in chrome/ code. In the future, it might also implement other interfaces. My only current intended consumer for this would be extensions. There's no actual behavior change, this is all just plumbing for now.
BUG=29314
Review URL: http://codereview.chromium.org/2749015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Allows binding on 0.0.0.0 to allow connections from a VM (for example).
Simple GMock class and Actions.
Review URL: http://codereview.chromium.org/2620006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=chrome frame tests
Review URL: http://codereview.chromium.org/2620001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49265 0039d316-1c4b-4281-b951-d872f2087c98
|